From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1A085E77188 for ; Mon, 6 Jan 2025 13:35:14 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 773CD6B0089; Mon, 6 Jan 2025 08:35:13 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 723C16B008A; Mon, 6 Jan 2025 08:35:13 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 5C45C6B008C; Mon, 6 Jan 2025 08:35:13 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 3CC256B0089 for ; Mon, 6 Jan 2025 08:35:13 -0500 (EST) Received: from smtpin07.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id E8775B0936 for ; Mon, 6 Jan 2025 13:35:12 +0000 (UTC) X-FDA: 82977123264.07.F9BC23B Received: from mail-pl1-f180.google.com (mail-pl1-f180.google.com [209.85.214.180]) by imf07.hostedemail.com (Postfix) with ESMTP id 1C46A4000D for ; Mon, 6 Jan 2025 13:35:09 +0000 (UTC) Authentication-Results: imf07.hostedemail.com; dkim=pass header.d=bytedance.com header.s=google header.b=NOaIqKsg; spf=pass (imf07.hostedemail.com: domain of zhengqi.arch@bytedance.com designates 209.85.214.180 as permitted sender) smtp.mailfrom=zhengqi.arch@bytedance.com; dmarc=pass (policy=quarantine) header.from=bytedance.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1736170511; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=dSl9CiTNSQwE0RKlCdBtogvBaV/TE9/iFGVUzDM7I3Y=; b=CPI9vdNqVoRdOWIE9aV+J3UWgXHzT3ysCzSex0hJDOc7o9OjEDJ5/zPXK/X3Vj24ZAapV8 6esxzoA4uW8JqKhqFAwwEXoTu6Ky62c79tlPj9sYRy5hNg9DZ13vthM0+FNFIsSGTazNRN 7P1iAE2beaY14mQWVawYe+ykHkg+XOE= ARC-Authentication-Results: i=1; imf07.hostedemail.com; dkim=pass header.d=bytedance.com header.s=google header.b=NOaIqKsg; spf=pass (imf07.hostedemail.com: domain of zhengqi.arch@bytedance.com designates 209.85.214.180 as permitted sender) smtp.mailfrom=zhengqi.arch@bytedance.com; dmarc=pass (policy=quarantine) header.from=bytedance.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1736170511; a=rsa-sha256; cv=none; b=XyJE/SUOLardUh8v8gz2w2a5mjYU/gjVoECLXoiWDV9Epch8KgKuWmbDIBx0Ag9qOfLRnj XPLnFH8LM3ftvcyyjSqIfKc8LLfMmF2qp5iJzAvawfdNwD0eN5iZAmhHHPZR8DqZdyPJQD yDj954GyGS78aaRdIdqgbg8prCyh+IM= Received: by mail-pl1-f180.google.com with SMTP id d9443c01a7336-21670dce0a7so23051425ad.1 for ; Mon, 06 Jan 2025 05:35:09 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bytedance.com; s=google; t=1736170508; x=1736775308; darn=kvack.org; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=dSl9CiTNSQwE0RKlCdBtogvBaV/TE9/iFGVUzDM7I3Y=; b=NOaIqKsgNaKylsQON7o5HoUHZ34kFrgs8v+oA27PZLp/PR+G3OPN6Fcv9J8qTjqih8 CNR5Faxh9iTce9QO9Wp+fWzXZSLsqR8qhYlozSg+XAz9AfCN9KAXuGGcDSPdxaC4vjws 3Ra24kEXwFik19Wc3XT5O+ddPVG+yuuSCFRa43h0hrfqIBd2Rr2Y+JbTI/+YC5HnbD54 AYcbU+inSUMaFzfr0wQ906FpyRQku9+LpMx8dIIjGzigNxgNPYc5pm+A5zqWFT+RjQRH pgIBveGWReSRtGewNhuGe6E8gkccD+26qIya2R+yKM0kGYcrvUK3/rPGaqQL6N7CA2B3 LDEQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1736170508; x=1736775308; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=dSl9CiTNSQwE0RKlCdBtogvBaV/TE9/iFGVUzDM7I3Y=; b=Ee2jc+zmRGcK8LyV7oF5O9E9fUC5PSB9MVarKuH8o+KYF+oM/pQiSVaGEeiNFKr+wa aIwS3xY73DEYZwA7SsfWLkysGwAgPrXeQQXUwwlnzZvCDImScWASt1mC4Rt3JuxxaGfn Ha0bFLtBvQeRHcd+BqljlYQCqQjBHrV3PjbufCi68A7+ZnjSu1e78X0xO2VUxnX+R8KJ KaWPXbrlSCkbkhgZuhwvSP7UUj6jcJ3SkV7rRPe5k862McQdMvhp4yidJVGPiRf+m7Ia Ph9U4b3JF9c8Tob00d9BQWZt4+ioRICg/8u3eAgPAZr4y3/oMSzuQGdBrcE+NSx673Wp rmdA== X-Forwarded-Encrypted: i=1; AJvYcCXD6wKHQ8kNMM1wiMOoIq5GFTNY/HiizZnX9JO0bOef7vWd3V/zOBEtBXPFHycK34H5Mqwd3uNHHw==@kvack.org X-Gm-Message-State: AOJu0Yw8B9mNpzh0bH0xi6r7rtDJ8u+qLvJZX3Bb7iSMCKUn8zqpttw+ 4EmGbNPXBHt9mIe0PiP6yl0UCvo+Aibk9NXq7hA1nxTU3AvHvTRyMDqTcTomMwk= X-Gm-Gg: ASbGncuST/9QNFaiw9pirjJYMZow7j8XYk/ay6hqw2DCZ1hjmW/LwFyK9GUyMWTGGXX UN7FEQYnuiYrby6Z2WZABF4DQjnS2PKp9qG03iKt2qI/Jo0Zncvpt1u5l2nwmMAK07TmfnBJNa0 qMic+NsZc9kdf9Bo3xBq3qXMDmRSz1aR8YaRCkt+JjJo+k797gEyl2y+XR85HNa7zghXANkqEJI lcQp2UgmO07oFddgwLZpC5gKs9PmiX1nvTGm2QcuQc7QGda4p1PXinjUz5/Mkow1ChxIQG79WPy bb8XVL9RcK/n3Sv2VcpE3NO9S4tJQO6XT2FrCAtKiFVGEaA81xsY X-Google-Smtp-Source: AGHT+IFuxfmftFbdw6fO4bIMnZYJ/q+si7Sq93AxF4PGQarIeYtLJTB7gRBGy3tWc8bUzZwj1LueBQ== X-Received: by 2002:a17:902:e844:b0:216:3083:d03d with SMTP id d9443c01a7336-219e6f13c50mr852868805ad.44.1736170508636; Mon, 06 Jan 2025 05:35:08 -0800 (PST) Received: from ?IPV6:2409:8a28:f44:d64:296c:a8f3:f81e:f88b? ([2409:8a28:f44:d64:296c:a8f3:f81e:f88b]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-219dc9cdf02sm292469725ad.151.2025.01.06.05.34.58 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 06 Jan 2025 05:35:08 -0800 (PST) Message-ID: <57ea8193-2fd9-41a9-85b4-7af924f900f4@bytedance.com> Date: Mon, 6 Jan 2025 21:34:55 +0800 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v4 12/15] s390: pgtable: also move pagetable_dtor() of PxD to __tlb_remove_table() Content-Language: en-US To: Alexander Gordeev Cc: peterz@infradead.org, kevin.brodsky@arm.com, palmer@dabbelt.com, tglx@linutronix.de, david@redhat.com, jannh@google.com, hughd@google.com, yuzhao@google.com, willy@infradead.org, muchun.song@linux.dev, vbabka@kernel.org, lorenzo.stoakes@oracle.com, akpm@linux-foundation.org, rientjes@google.com, vishal.moola@gmail.com, arnd@arndb.de, will@kernel.org, aneesh.kumar@kernel.org, npiggin@gmail.com, dave.hansen@linux.intel.com, rppt@kernel.org, ryan.roberts@arm.com, linux-mm@kvack.org, linux-arm-kernel@lists.infradead.org, linuxppc-dev@lists.ozlabs.org, linux-riscv@lists.infradead.org, linux-s390@vger.kernel.org, sparclinux@vger.kernel.org, linux-kernel@vger.kernel.org, x86@kernel.org, linux-arch@vger.kernel.org, linux-csky@vger.kernel.org, linux-hexagon@vger.kernel.org, loongarch@lists.linux.dev, linux-m68k@lists.linux-m68k.org, linux-mips@vger.kernel.org, linux-openrisc@vger.kernel.org, linux-sh@vger.kernel.org, linux-um@lists.infradead.org References: <2d16f0fe-9c7f-4229-b7b5-ffa3ab1b1143@bytedance.com> From: Qi Zheng In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam05 X-Stat-Signature: nmagyr9gitra1shg8b3wosk3dnf5cpo4 X-Rspamd-Queue-Id: 1C46A4000D X-Rspam-User: X-HE-Tag: 1736170509-894524 X-HE-Meta: U2FsdGVkX1/nIAgLnbwsJWJD4kEcBue7DWe3R5jNSeKfVf/R7v5n8VWKdhc1FaQIYk9KorIxyZW3iv619ta/7lGavjvylJ08UXz7rQtYry0xhWFztDlNqbemEX4Ll8Sd1DcbUBSkc90zVJuNR1nOxljPn5qu59wQ0cweannWTb0tCRtWEaGEtFBc4OK1byp6Q70WjnUn06yP5+3XcAhSFebNbOw8Yo0xEzivx8CRY8rlW7cYXcaextuUynfd6tvJmD5/1ekjrJyx8fEwRBtnFZbREXy0Xq4Sx3lhsMuOzChysy7YTWpmO2ngPPM9+WXetPYv9cZamQFJIVmx90z39UCShG6zx1k5qwUcEu2ylTsjvhA3zCq4vlUKAOPOgkKmjkJrtH78j5hivzckhFzz0pZWdFiUgNxpqrqlemA6ibrnWhZRR5z0oCnuuhHq61DuAJQni0yD/rabs1kLsNR5p9Oiz4OeScndn87IWeIKDFEwyWHDU0r3yrURL/afngqXw5fVgACkWXL7aCAloK5CxIHRArlSDHiTND5MPKAmzWfKcZhYDi31KbTnovvaWOl/qBbLVvWJwdZb8U+FQqqmonMfOzHR50yxMwg02dvfwbOUp4UGI5vOl5BCGBKr5bs7VAc1keBA1O+7nHR5FwfNVA7Nqm7P0wtqXx1dZkgKuxgTwRdWnt/Tpdq4Cokf8HZcTgfhcjQHHcKqJuBuKF1aTbCZfr1IO2hqHLyRDnhLrxIhF5ISZIbodyZrpRfoSW+EmFQEb2ZPQDkn7nLpfdGUxOFCJuMnFT/tfvySrrzwRPmFnLRRYJS6ly2YUDS02JJ7ozx6W/Exo6UFht2qO5BBB1pcYvQ9iAe0eTqJfn4TfIUEgGQexCgbf8syiDfu0eshNqP48Bieg9k81Ndtvf2h+QY1CrGHSGO7GbgJtvV9nPgRB8chZw44cLDni9/koMoQPeSPzddaLfZYeMlfNh3 Qx8snHLW fMmj2JeTr6++P0tq/ZywISKyEhhP0N0JQutlToR40YkDtWAJg3NlOoQs60nE1AO/8HPFc/6Ej5coZEumtiH4dB+LL4KfArnTwga7s9ivVKGlS/XdN/nTHa1bm9takEMcePMNl58qVtBM+5phJVQoIsSvzcLxutgOc+I+xI/oN/EWvGFPV4mwfvNG56IjISKtgvozkVIn59iegZ1ZS+iZJKx/B8WXXGKNpCTriGBp83Y4s/VJLQnrX2SR6ei8fIg178AxtLadyGCeejpaq3vlUzL9aX1xyMMTPWf3XRvnvDpRCs6ioJHO2GxivmpUAYCESrfwKatNYrj6yCH6DnM/fvlz2ZZiy+hJNS3yT7FxQvP+tkqU6pHjEwanfc9cVwwh0l4tbHiIUGkdWZJi7yxl1WTrEh0j0Ypq27KmeF6b+N8jK88ZJ1YEQqeoqijiaHrzoE5kbA6ssuUVZgchO2skmhYdO+e68VVumMxTnrPUW8nect6PeL8c9FR6eBQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 2025/1/6 20:44, Alexander Gordeev wrote: > On Mon, Jan 06, 2025 at 07:02:17PM +0800, Qi Zheng wrote: >>> On Mon, Dec 30, 2024 at 05:07:47PM +0800, Qi Zheng wrote: >>>> To unify the PxD and PTE TLB free path, also move the pagetable_dtor() of >>>> PMD|PUD|P4D to __tlb_remove_table(). >>> >>> The above and Subject are still incorrect: pagetable_dtor() is >>> called from pagetable_dtor_free(), not from __tlb_remove_table(). >> >> Hmm, __tlb_remove_table() calls pagetable_dtor_free(), so moving to >> pagetable_dtor_free() means moving to __tlb_remove_table(). Right? > > Right. But you Subject and description claim "... also move the > pagetable_dtor()" not to pagetable_dtor_free() - which is another > function. OK, will change the subject and description to: s390: pgtable: also move pagetable_dtor() of PxD to pagetable_dtor_free() To unify the PxD and PTE TLB free path, also move the pagetable_dtor() of PMD|PUD|P4D to pagetable_dtor_free(). But pagetable_dtor_free() is newly introduced in this patch, should it be changed to 'move ... to pagetable_pte_dtor_free()'? But this seems strange. :( > >> And the main purpose of this patch is also to move pagetable_dtor() >> to __tlb_remove_table(). So I think this description makes sense? > > The patch makes sense, but the description it is incorrect ;) > > Thanks! Thanks!