From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id E7222C25B76 for ; Sat, 1 Jun 2024 20:58:43 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 8032D6B0089; Sat, 1 Jun 2024 16:58:43 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 7B3986B00A2; Sat, 1 Jun 2024 16:58:43 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 62CBF6B00A3; Sat, 1 Jun 2024 16:58:43 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 414796B0089 for ; Sat, 1 Jun 2024 16:58:43 -0400 (EDT) Received: from smtpin02.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 05CD91A09BE for ; Sat, 1 Jun 2024 20:58:43 +0000 (UTC) X-FDA: 82183533726.02.D0DA1AC Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.223.131]) by imf16.hostedemail.com (Postfix) with ESMTP id A9A7B180002 for ; Sat, 1 Jun 2024 20:58:40 +0000 (UTC) Authentication-Results: imf16.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=N8Ka+e5Y; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=uAvjNoRZ; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=N8Ka+e5Y; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=uAvjNoRZ; dmarc=none; spf=pass (imf16.hostedemail.com: domain of vbabka@suse.cz designates 195.135.223.131 as permitted sender) smtp.mailfrom=vbabka@suse.cz ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1717275521; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=f08YTq5NqPwUS8/f2MmUhAERP5xzqBaHcJBchZ/cHuA=; b=WwLKdc0k6CulIF/mFsb6DGSWtmo+dzFyI3Y/Cv83XRsK8fFu2jfNRWNiaXTp8BPPZMMLpk 6Q7A0WpU+qXK/brMQ4SpNv37qtZ9MM33JMbuyR21FU7f2aTkWINTAqrTdQj/nBDm7ZaDsX wH/rtCNTJBoXk/Orc5nSp6gKckvvtwg= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1717275521; a=rsa-sha256; cv=none; b=uZbtAULsBEpYB4/oVH30Q76cWOv4RBitvVzW7LIdMUPByQh2cFKW0oPQHn+tq/BSuxT6VO XCuwSu1IGFaW6FAgc0jeSPjHGBVALzY/ss8i1uARxF9CMTWJJMM6FVBrFgfPGHjt0F9aRZ mCiAaIv8GR9zXRfLifz2neGqPZPmSpU= ARC-Authentication-Results: i=1; imf16.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=N8Ka+e5Y; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=uAvjNoRZ; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=N8Ka+e5Y; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=uAvjNoRZ; dmarc=none; spf=pass (imf16.hostedemail.com: domain of vbabka@suse.cz designates 195.135.223.131 as permitted sender) smtp.mailfrom=vbabka@suse.cz Received: from imap1.dmz-prg2.suse.org (unknown [10.150.64.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 498C31FEEA; Sat, 1 Jun 2024 20:58:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1717275519; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=f08YTq5NqPwUS8/f2MmUhAERP5xzqBaHcJBchZ/cHuA=; b=N8Ka+e5YnuuS9Ip6MRUPX+bWCR0D9dKqEhySmDxAQysYgDh6twyQAYCA9odXbQLaDeb+e0 PHz0RhQrlorkOQM9oE0Z3h1IEmQlI3pS62Xc6rcSlIRpHm086aeGs7V8P22yBicReZLqro inF3hcgD+XK9a/eggIAwuqtCarxzPsM= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1717275519; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=f08YTq5NqPwUS8/f2MmUhAERP5xzqBaHcJBchZ/cHuA=; b=uAvjNoRZxb3TK29bt+WhUn3WbACAEcxvCLCzvPu/sj3RFx3puEk2RDzMKsRPbe7A3C0K8H AyFL9/V8MDtfSvCQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1717275519; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=f08YTq5NqPwUS8/f2MmUhAERP5xzqBaHcJBchZ/cHuA=; b=N8Ka+e5YnuuS9Ip6MRUPX+bWCR0D9dKqEhySmDxAQysYgDh6twyQAYCA9odXbQLaDeb+e0 PHz0RhQrlorkOQM9oE0Z3h1IEmQlI3pS62Xc6rcSlIRpHm086aeGs7V8P22yBicReZLqro inF3hcgD+XK9a/eggIAwuqtCarxzPsM= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1717275519; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=f08YTq5NqPwUS8/f2MmUhAERP5xzqBaHcJBchZ/cHuA=; b=uAvjNoRZxb3TK29bt+WhUn3WbACAEcxvCLCzvPu/sj3RFx3puEk2RDzMKsRPbe7A3C0K8H AyFL9/V8MDtfSvCQ== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 2CE70137C3; Sat, 1 Jun 2024 20:58:39 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id zumdCn+LW2YgUAAAD6G6ig (envelope-from ); Sat, 01 Jun 2024 20:58:39 +0000 Message-ID: <57c8c75d-c080-42e0-824e-a8cd84c33fb2@suse.cz> Date: Sat, 1 Jun 2024 22:58:38 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 1/1] mm: fix xyz_noprof functions calling profiled functions Content-Language: en-US To: Suren Baghdasaryan , akpm@linux-foundation.org Cc: kent.overstreet@linux.dev, pasha.tatashin@soleen.com, keescook@chromium.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org References: <20240531205350.3973009-1-surenb@google.com> From: Vlastimil Babka Autocrypt: addr=vbabka@suse.cz; keydata= xsFNBFZdmxYBEADsw/SiUSjB0dM+vSh95UkgcHjzEVBlby/Fg+g42O7LAEkCYXi/vvq31JTB KxRWDHX0R2tgpFDXHnzZcQywawu8eSq0LxzxFNYMvtB7sV1pxYwej2qx9B75qW2plBs+7+YB 87tMFA+u+L4Z5xAzIimfLD5EKC56kJ1CsXlM8S/LHcmdD9Ctkn3trYDNnat0eoAcfPIP2OZ+ 9oe9IF/R28zmh0ifLXyJQQz5ofdj4bPf8ecEW0rhcqHfTD8k4yK0xxt3xW+6Exqp9n9bydiy tcSAw/TahjW6yrA+6JhSBv1v2tIm+itQc073zjSX8OFL51qQVzRFr7H2UQG33lw2QrvHRXqD Ot7ViKam7v0Ho9wEWiQOOZlHItOOXFphWb2yq3nzrKe45oWoSgkxKb97MVsQ+q2SYjJRBBH4 8qKhphADYxkIP6yut/eaj9ImvRUZZRi0DTc8xfnvHGTjKbJzC2xpFcY0DQbZzuwsIZ8OPJCc LM4S7mT25NE5kUTG/TKQCk922vRdGVMoLA7dIQrgXnRXtyT61sg8PG4wcfOnuWf8577aXP1x 6mzw3/jh3F+oSBHb/GcLC7mvWreJifUL2gEdssGfXhGWBo6zLS3qhgtwjay0Jl+kza1lo+Cv BB2T79D4WGdDuVa4eOrQ02TxqGN7G0Biz5ZLRSFzQSQwLn8fbwARAQABzSBWbGFzdGltaWwg QmFia2EgPHZiYWJrYUBzdXNlLmN6PsLBlAQTAQoAPgIbAwULCQgHAwUVCgkICwUWAgMBAAIe AQIXgBYhBKlA1DSZLC6OmRA9UCJPp+fMgqZkBQJkBREIBQkRadznAAoJECJPp+fMgqZkNxIQ ALZRqwdUGzqL2aeSavbum/VF/+td+nZfuH0xeWiO2w8mG0+nPd5j9ujYeHcUP1edE7uQrjOC Gs9sm8+W1xYnbClMJTsXiAV88D2btFUdU1mCXURAL9wWZ8Jsmz5ZH2V6AUszvNezsS/VIT87 AmTtj31TLDGwdxaZTSYLwAOOOtyqafOEq+gJB30RxTRE3h3G1zpO7OM9K6ysLdAlwAGYWgJJ V4JqGsQ/lyEtxxFpUCjb5Pztp7cQxhlkil0oBYHkudiG8j1U3DG8iC6rnB4yJaLphKx57NuQ PIY0Bccg+r9gIQ4XeSK2PQhdXdy3UWBr913ZQ9AI2usid3s5vabo4iBvpJNFLgUmxFnr73SJ KsRh/2OBsg1XXF/wRQGBO9vRuJUAbnaIVcmGOUogdBVS9Sun/Sy4GNA++KtFZK95U7J417/J Hub2xV6Ehc7UGW6fIvIQmzJ3zaTEfuriU1P8ayfddrAgZb25JnOW7L1zdYL8rXiezOyYZ8Fm ZyXjzWdO0RpxcUEp6GsJr11Bc4F3aae9OZtwtLL/jxc7y6pUugB00PodgnQ6CMcfR/HjXlae h2VS3zl9+tQWHu6s1R58t5BuMS2FNA58wU/IazImc/ZQA+slDBfhRDGYlExjg19UXWe/gMcl De3P1kxYPgZdGE2eZpRLIbt+rYnqQKy8UxlszsBNBFsZNTUBCACfQfpSsWJZyi+SHoRdVyX5 J6rI7okc4+b571a7RXD5UhS9dlVRVVAtrU9ANSLqPTQKGVxHrqD39XSw8hxK61pw8p90pg4G /N3iuWEvyt+t0SxDDkClnGsDyRhlUyEWYFEoBrrCizbmahOUwqkJbNMfzj5Y7n7OIJOxNRkB IBOjPdF26dMP69BwePQao1M8Acrrex9sAHYjQGyVmReRjVEtv9iG4DoTsnIR3amKVk6si4Ea X/mrapJqSCcBUVYUFH8M7bsm4CSxier5ofy8jTEa/CfvkqpKThTMCQPNZKY7hke5qEq1CBk2 wxhX48ZrJEFf1v3NuV3OimgsF2odzieNABEBAAHCwXwEGAEKACYCGwwWIQSpQNQ0mSwujpkQ PVAiT6fnzIKmZAUCZAUSmwUJDK5EZgAKCRAiT6fnzIKmZOJGEACOKABgo9wJXsbWhGWYO7mD 8R8mUyJHqbvaz+yTLnvRwfe/VwafFfDMx5GYVYzMY9TWpA8psFTKTUIIQmx2scYsRBUwm5VI EurRWKqENcDRjyo+ol59j0FViYysjQQeobXBDDE31t5SBg++veI6tXfpco/UiKEsDswL1WAr tEAZaruo7254TyH+gydURl2wJuzo/aZ7Y7PpqaODbYv727Dvm5eX64HCyyAH0s6sOCyGF5/p eIhrOn24oBf67KtdAN3H9JoFNUVTYJc1VJU3R1JtVdgwEdr+NEciEfYl0O19VpLE/PZxP4wX PWnhf5WjdoNI1Xec+RcJ5p/pSel0jnvBX8L2cmniYnmI883NhtGZsEWj++wyKiS4NranDFlA HdDM3b4lUth1pTtABKQ1YuTvehj7EfoWD3bv9kuGZGPrAeFNiHPdOT7DaXKeHpW9homgtBxj 8aX/UkSvEGJKUEbFL9cVa5tzyialGkSiZJNkWgeHe+jEcfRT6pJZOJidSCdzvJpbdJmm+eED w9XOLH1IIWh7RURU7G1iOfEfmImFeC3cbbS73LQEFGe1urxvIH5K/7vX+FkNcr9ujwWuPE9b 1C2o4i/yZPLXIVy387EjA6GZMqvQUFuSTs/GeBcv0NjIQi8867H3uLjz+mQy63fAitsDwLmR EP+ylKVEKb0Q2A== In-Reply-To: <20240531205350.3973009-1-surenb@google.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Stat-Signature: eui8eajixz4aunknsb3go1gkkrzqcueg X-Rspamd-Queue-Id: A9A7B180002 X-Rspam-User: X-Rspamd-Server: rspam01 X-HE-Tag: 1717275520-413352 X-HE-Meta: U2FsdGVkX1/IGibdb6g+emVuggZHC0zvx4CgOT0ZP12A7OOKV4idaUX409WtOtz7WLB8vcUBjsVWNKHVKBOuIjm+yw8ezy3683JJYatSsyc4mAZ0DyDNOyhQtRL93jajMMo2Iju2SpUUAXYD8bRdFXpmFrRDE5eLKExtCB9R8yDz1DXjUQ2CRxodw3gkPaZyK2Z8k0QEHd3SxI2my27cX4xOWdaAwQBPmW69sy4fToMDtOgFbrLDlqYb3Lk5gTKqiyqF39GO1h26AFCmBBq1UrfkN1sLuoxEacF9eVoN3XA25ECXa94OIFob9488tfWhIZQNc0aG30ZBalHYz8gI3dw2UFgNxP2UMW8R4rH+Ih00pYTk8jXHbj42FWwnHNqaRgvO5B0nSLycEutLIJ9611TCaWvTLDt8HbteTq05PATRaggMWBgxpBUGAZR/ippfNINjp1jYg9IC8zP2B0hABGdQutVw/gY4HHSzggTinBM8Gq347cGOj1jAb6r3RKUH5EV92McmSLzwpTobLy6V5Wh7gh4g8JycVvLYh5pesHTd6h/iN7miHXSMgDIjLkOYPvoWVRKxwIXyljbAVJ/w35HaSzBlaKaBFhk8r7SDp5LoNwNl6ODrryQwh93Exk6BwRdVg/bvnnAfZYaS8LdqejqXJFaVXyeQCxg/PxcLizHuSg2kQN4YN+0AHBFO4EGC9AxBaFDFQNzsFrxib9PMNSdbFbAUsrLE/1HWZ/41wCJDyxV8iSrZIjTvVEzVIQjG4VXa5gZl7tnW0V7r1qxsvHAZl/qFU+WQVZZ0gZSpyufABszvbgvqf8klqZsPlQA4YxxzrYNOhe5jGBXRBwr0YTkWItVGFwaAVvAm2mDilGt48yM19MUtoKi4NP4AD13IIcb9JDp0H+WOlmjnF3/ya7TgcnPytbcdOSGDqzAaJd18hzkOYmJEO82e6ogvMx0jvDeGKOv7iOnTaFPHVzX lebb8xXo shy3KZle//Pmo5EHtA8rJGL85YgoDsdUf2C0A+G8SFJvPL86pwqeqyKbV9zRX0vtGTS7jssXro5+ZhSeKr/e3NEaytNnXYpqAT6HVegEn3b/T2UddklLrskNkQnLu80GXPvXxkR0lGRBdsXJigH3fA5NHvvISMxx2R9zryMG2/F020dhXocAp9bpsWvaqtYloP9niReuXy2d4YqqK47tvGTnd+M2kQqdsr0ZJY5nRBhCzJq1ydkNoMcE4E5+Fpaalv8g0sWtgeiwYpl+n8I68EG0jlaTOChFMJacEqk5LXONWH3K5eeakNRhJLJw7xDL+/vfUGG2U9F3mDu4= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 5/31/24 10:53 PM, Suren Baghdasaryan wrote: > Grepping /proc/allocinfo for "noprof" reveals several xyz_noprof functions, > which means internally they are calling profiled functions. This should > never happen as such calls move allocation charge from a higher level > location where it should be accounted for into these lower level helpers. > Fix this by replacing profiled function calls with noprof ones. > > Fixes: b951aaff5035 ("mm: enable page allocation tagging") > Fixes: e26d8769da6d ("mempool: hook up to memory allocation profiling") > Fixes: 88ae5fb755b0 ("mm: vmalloc: enable memory allocation profiling") > Signed-off-by: Suren Baghdasaryan > Cc: Kent Overstreet Acked-by: Vlastimil Babka > --- > mm/filemap.c | 2 +- > mm/mempool.c | 2 +- > mm/util.c | 10 +++++----- > 3 files changed, 7 insertions(+), 7 deletions(-) > > diff --git a/mm/filemap.c b/mm/filemap.c > index 9fe5c02ae92e..37061aafd191 100644 > --- a/mm/filemap.c > +++ b/mm/filemap.c > @@ -1000,7 +1000,7 @@ struct folio *filemap_alloc_folio_noprof(gfp_t gfp, unsigned int order) > do { > cpuset_mems_cookie = read_mems_allowed_begin(); > n = cpuset_mem_spread_node(); > - folio = __folio_alloc_node(gfp, order, n); > + folio = __folio_alloc_node_noprof(gfp, order, n); > } while (!folio && read_mems_allowed_retry(cpuset_mems_cookie)); > > return folio; > diff --git a/mm/mempool.c b/mm/mempool.c > index 6ece63a00acf..3223337135d0 100644 > --- a/mm/mempool.c > +++ b/mm/mempool.c > @@ -273,7 +273,7 @@ mempool_t *mempool_create_node_noprof(int min_nr, mempool_alloc_t *alloc_fn, > { > mempool_t *pool; > > - pool = kzalloc_node(sizeof(*pool), gfp_mask, node_id); > + pool = kmalloc_node_noprof(sizeof(*pool), gfp_mask | __GFP_ZERO, node_id); > if (!pool) > return NULL; > > diff --git a/mm/util.c b/mm/util.c > index c9e519e6811f..6c3e6710e4de 100644 > --- a/mm/util.c > +++ b/mm/util.c > @@ -705,7 +705,7 @@ void *kvrealloc_noprof(const void *p, size_t oldsize, size_t newsize, gfp_t flag > > if (oldsize >= newsize) > return (void *)p; > - newp = kvmalloc(newsize, flags); > + newp = kvmalloc_noprof(newsize, flags); > if (!newp) > return NULL; > memcpy(newp, p, oldsize); > @@ -726,7 +726,7 @@ void *__vmalloc_array_noprof(size_t n, size_t size, gfp_t flags) > > if (unlikely(check_mul_overflow(n, size, &bytes))) > return NULL; > - return __vmalloc(bytes, flags); > + return __vmalloc_noprof(bytes, flags); > } > EXPORT_SYMBOL(__vmalloc_array_noprof); > > @@ -737,7 +737,7 @@ EXPORT_SYMBOL(__vmalloc_array_noprof); > */ > void *vmalloc_array_noprof(size_t n, size_t size) > { > - return __vmalloc_array(n, size, GFP_KERNEL); > + return __vmalloc_array_noprof(n, size, GFP_KERNEL); > } > EXPORT_SYMBOL(vmalloc_array_noprof); > > @@ -749,7 +749,7 @@ EXPORT_SYMBOL(vmalloc_array_noprof); > */ > void *__vcalloc_noprof(size_t n, size_t size, gfp_t flags) > { > - return __vmalloc_array(n, size, flags | __GFP_ZERO); > + return __vmalloc_array_noprof(n, size, flags | __GFP_ZERO); > } > EXPORT_SYMBOL(__vcalloc_noprof); > > @@ -760,7 +760,7 @@ EXPORT_SYMBOL(__vcalloc_noprof); > */ > void *vcalloc_noprof(size_t n, size_t size) > { > - return __vmalloc_array(n, size, GFP_KERNEL | __GFP_ZERO); > + return __vmalloc_array_noprof(n, size, GFP_KERNEL | __GFP_ZERO); > } > EXPORT_SYMBOL(vcalloc_noprof); > > > base-commit: 8e06d6b9274dc504af6021a8bbc2daf6713ceb20