From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6FD69C77B61 for ; Thu, 13 Apr 2023 11:31:47 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 10F136B0072; Thu, 13 Apr 2023 07:31:47 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 0BEA76B0074; Thu, 13 Apr 2023 07:31:47 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E7B58900002; Thu, 13 Apr 2023 07:31:46 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id D74526B0072 for ; Thu, 13 Apr 2023 07:31:46 -0400 (EDT) Received: from smtpin11.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 8AA6EAB109 for ; Thu, 13 Apr 2023 11:31:46 +0000 (UTC) X-FDA: 80676153012.11.9AB14A0 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf28.hostedemail.com (Postfix) with ESMTP id 558BAC000F for ; Thu, 13 Apr 2023 11:31:44 +0000 (UTC) Authentication-Results: imf28.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=Nq3rbDXZ; spf=pass (imf28.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1681385504; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=HIm5iNvrLIrBpXBxl0Ffwy4XMhjO0OH42kfpLYYOzdU=; b=l07ROasznvKNWOa0i5UmUM2FVyT+ux3x7fbaNmpMgXGlRBvYyUV4m+n0qdt/D2EOoUmJbs VEJO9VkMj92rsl7xctH9r/Hfvsba3iscLAWucDZk0JDi945mcQ9IGGoGg0ZlvrtPC9ZkxT 4qjL/g45JyReJ+Vg8gg/wsMsLkhK6GI= ARC-Authentication-Results: i=1; imf28.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=Nq3rbDXZ; spf=pass (imf28.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1681385504; a=rsa-sha256; cv=none; b=5l9W26BIzIK8z5Q44wP0hW8LU0yiU8s9h5sk1RVm9kD7rf+bKxHoCRYTF9MO5MJuvABdlj tvCa27ncBAH9xn6ipRlBVhp3yGm4M3jsKFZuHJLJxqB/Wi5uC5LbmvWiXja+JFUjYrqMtx XZ8srIaLfE+Xz0hhTtce8h7q2LLzzqw= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1681385503; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=HIm5iNvrLIrBpXBxl0Ffwy4XMhjO0OH42kfpLYYOzdU=; b=Nq3rbDXZFLmF40Mm+Uy+8tUyzMgRXc0t0UuIa23TYS10epegkc90AuoPsajyyXITKn8SFv J2ZiEO/EVtoHqcTOaCk22U6CwkRPKYR7hKe2qcluTWmxqL1UndDJ1TWRBxqyClde8HM7nK tePQisBx4H+iUAtpus5nEnazhMp0F1k= Received: from mail-wm1-f69.google.com (mail-wm1-f69.google.com [209.85.128.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-576-kWlTGMzPPF2e37-yLjca6w-1; Thu, 13 Apr 2023 07:31:42 -0400 X-MC-Unique: kWlTGMzPPF2e37-yLjca6w-1 Received: by mail-wm1-f69.google.com with SMTP id h15-20020a05600c350f00b003f09815147dso2952392wmq.3 for ; Thu, 13 Apr 2023 04:31:42 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1681385501; x=1683977501; h=content-transfer-encoding:in-reply-to:organization:from:references :cc:to:content-language:subject:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=HIm5iNvrLIrBpXBxl0Ffwy4XMhjO0OH42kfpLYYOzdU=; b=k3fFpERsZPuIxwwB/XcTaXkpJAbON7gtv9BYFN10VB0GgQXeoSMSiQIHWf6f3+M0MC tmuiJ9hdde+noXNtsywsVfwZ+3eydqh053ZtSLK8t5RrUQ/0NSXyy/znza1HPGmmTdwI kuvpDVsW2/xjx+5vTl39O+SE9aRzrYx5JVmRZBAzb7JNSXWUgCco90ekIU1RVQhVlj0c 1Ryz2+Jauuhs70DTUHVg/2GCHVmSBaR+xfCvO2M9JKStO/E7UFukou4+qU3xo/v3hWoN key90hqbHKpgOGZXbvUscdrwM+E+J7hQ8vewsF7yaJh8FT0PPS8r+cTi1VIBOZ8bhE4e dneg== X-Gm-Message-State: AAQBX9fVN2Q3VsGuXYW7FoM1RVEZq0J+kE0bAmL0ymdOyiwVXEoTlXNw L3ZzI50j6PeDja+tkL0IEnUqp3ShiH68ONwO+rzlcOhbrfnmO4FJbHEzTDIYlnKvvc+evYPfgdX JSajzlsL2dgo= X-Received: by 2002:a05:600c:298:b0:3f0:7147:2ed7 with SMTP id 24-20020a05600c029800b003f071472ed7mr1687514wmk.16.1681385501424; Thu, 13 Apr 2023 04:31:41 -0700 (PDT) X-Google-Smtp-Source: AKy350Y4H8/rhGt4xGxQ9IGJbZT1v8VC/SsnmagiAuFB3KrJE6ARurMSfQvfmVWRsSDoFSctJZW2Ag== X-Received: by 2002:a05:600c:298:b0:3f0:7147:2ed7 with SMTP id 24-20020a05600c029800b003f071472ed7mr1687487wmk.16.1681385501058; Thu, 13 Apr 2023 04:31:41 -0700 (PDT) Received: from ?IPV6:2a09:80c0:192:0:5dac:bf3d:c41:c3e7? ([2a09:80c0:192:0:5dac:bf3d:c41:c3e7]) by smtp.gmail.com with ESMTPSA id p13-20020a05600c204d00b003ee0d191539sm1590363wmg.10.2023.04.13.04.31.39 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 13 Apr 2023 04:31:40 -0700 (PDT) Message-ID: <57be0df8-e7a8-acda-4422-d4502a8b08b7@redhat.com> Date: Thu, 13 Apr 2023 13:31:39 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.9.1 Subject: Re: [PATCH v6 3/3] mm: vmscan: refactor updating current->reclaim_state To: Yosry Ahmed Cc: Andrew Morton , Alexander Viro , "Darrick J. Wong" , Christoph Lameter , David Rientjes , Joonsoo Kim , Vlastimil Babka , Roman Gushchin , Hyeonggon Yoo <42.hyeyoo@gmail.com>, "Matthew Wilcox (Oracle)" , Miaohe Lin , Johannes Weiner , Peter Xu , NeilBrown , Shakeel Butt , Michal Hocko , Yu Zhao , Dave Chinner , Tim Chen , linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, linux-xfs@vger.kernel.org, linux-mm@kvack.org References: <20230413104034.1086717-1-yosryahmed@google.com> <20230413104034.1086717-4-yosryahmed@google.com> From: David Hildenbrand Organization: Red Hat In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Rspam-User: X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: 558BAC000F X-Stat-Signature: zq11b5ihu1wufkopnhojps6t3wwe4up8 X-HE-Tag: 1681385504-330984 X-HE-Meta: U2FsdGVkX19+57QKwtsSikYSsNlBPuEtgaEBt6/7V5QonRNyx29LnRQC4K00T/d6nZyCaAwVrNOaKUCc4HM6U6xK6bB+ieW7JWLk42ZLO9Uu35CzrUx2V0pq2+VX6ZL+h0Erewh4mreomB+JWVZo3SRqLXkOWn3ybG0+wVCKRsrVBaUBArrugpA0Xf8g4QpxQzrwc2nsjwLY0/TFM6rQ+8/QILwmqvaZIRSdh2hNR8J0wGhmDy16IzL/jXAj4VZZlZknNmGAKpGMi1H/nvvHtCAclp1RaJEAWlIzp9Cx3sowcC3w6TB85MP24XS2fjK3d7yDDVGaqmpZTdAOvM6ty/QJAvckUKhaN82bhQwtSXkplNY9oQs/xRlpeByFklLopyk8rafPSyXHC/9XnIVajUFwuhJNS0MM0SEJr1trTqRa6Bg1ifU868OQkOu3J6fN2jmA7f9Uj/IIA9okyiYv1FAVbD5g+G6jvRJIblh8ZpBbnn3No7VtRqgrmmnvzSWnjQv0aGnVMk9BPE774nDSYiPG+Z1sAvvh46++N3Ta+/SiSME3ILblNRyHI6khSpeXCsFv5f6WEfCUL/oP8PyTCozyQbwxOfwv4ltcdnv0DbC7yx+my7poWFnLB96BQvP+cwTGUskn5EDlFPvsBKDo7n3/UWt7dowEHA6LInEqzBGp0P+3h2ogMmMm+qUJvXh1KMy7ul/nL3CdckdARq7pjr5gTGlImPCFFzoOQm+bT981gXodB/pOQvlpghBv+QMOJnb+y5KLPkY1FETSJv6h/YiFzxg05cId0Q9N8s74oXK8RFzVbj5PTEHS6M/rUhkSJacxoIYouvrxf3IYRLF6YvEp05NOinrjucnjGfTBTrse+8iA12M95R4ZWK+OPm6tVhYj4ue8tcxeRtkmMyhNHZOHGCpwym6izS83U333Kx/T9U6g29RiXIrZ8RMp7+eGQDdDaE2kL8POhVdMd6J g/8IXrcH pdT6h3aBGl7c3CQlxk6nNj7eh9Y23KRSaPRYe+Tm2c6SjNZijtKMORSPt2sFxQI5lvYgIKUalrnvC4V5MpxpLw+orkgkmrI56YNW7o75a0oecsqvtRxlIEuQdFRTye/g5bs5o0fPrUxng5AuzhZaKqqFxjDK96662tpt8qq8OwHaxxk3hH+fQ15reYjy+LVBd3INX9ccLhjAIbjcqOHE46b9xSkZJ1e5F8BhxKakqQz54lgd0j0lQgYyiuSwURwjZ2pNNNaOqYebaGwi/pMyoO+k2LSX5CNVWKyhUFBMKHkSsqN9wxr1Y36eGwOfUEBo/W0TLvO6KFZNMzwpikxtLnJLnRW5itsLz08ixRijQU2fos/wZx5IjmNYwFkLvw95Vdy6fAgWZh43zfommiD8+ppPUg4AyBcnK78vftEHF8FxxVabYDOGa1unRADI1nVBIAP9JrIxyFGHX7UTcWZKD+NSSmlqFMCRFe/AO88OruoVTQFy2cD9EUa0ntnhRvKj5osMNcDbDwMfdF4nY2w3Z16PWZgEdNI2kO4F8k+56JGeG8TATgehsIm6m4JKLaJiHB3A+ X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 13.04.23 13:29, Yosry Ahmed wrote: > On Thu, Apr 13, 2023 at 4:21 AM David Hildenbrand wrote: >> >> On 13.04.23 12:40, Yosry Ahmed wrote: >>> During reclaim, we keep track of pages reclaimed from other means than >>> LRU-based reclaim through scan_control->reclaim_state->reclaimed_slab, >>> which we stash a pointer to in current task_struct. >>> >>> However, we keep track of more than just reclaimed slab pages through >>> this. We also use it for clean file pages dropped through pruned inodes, >>> and xfs buffer pages freed. Rename reclaimed_slab to reclaimed, and add >> >> Would "reclaimed_non_lru" be more expressive? Then, >> >> mm_account_reclaimed_pages() -> mm_account_non_lru_reclaimed_pages() >> >> >> Apart from that LGTM. > > Thanks! > > I suck at naming things. If you think "reclaimed_non_lru" is better, > then we can do that. FWIW mm_account_reclaimed_pages() was taken from > a suggestion from Dave Chinner. My initial version had a terrible > name: report_freed_pages(), so I am happy with whatever you see fit. > > Should I re-spin for this or can we change it in place? Respin would be good, but maybe wait a bit more on other comments. I'm bad at naming things as well :) -- Thanks, David / dhildenb