From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id A9FA6C83F34 for ; Thu, 17 Jul 2025 19:22:14 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 43F146B0092; Thu, 17 Jul 2025 15:22:14 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 416438D0009; Thu, 17 Jul 2025 15:22:14 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 2DE186B00A7; Thu, 17 Jul 2025 15:22:14 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 17ED46B0092 for ; Thu, 17 Jul 2025 15:22:14 -0400 (EDT) Received: from smtpin22.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 87952140149 for ; Thu, 17 Jul 2025 19:22:13 +0000 (UTC) X-FDA: 83674727346.22.D82CB3E Received: from mail-oi1-f171.google.com (mail-oi1-f171.google.com [209.85.167.171]) by imf22.hostedemail.com (Postfix) with ESMTP id 8D8B8C0013 for ; Thu, 17 Jul 2025 19:22:11 +0000 (UTC) Authentication-Results: imf22.hostedemail.com; dkim=pass header.d=linaro.org header.s=google header.b=nnC2AjAP; spf=pass (imf22.hostedemail.com: domain of dan.carpenter@linaro.org designates 209.85.167.171 as permitted sender) smtp.mailfrom=dan.carpenter@linaro.org; dmarc=pass (policy=none) header.from=linaro.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1752780131; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=l5p4qniICn4Er/KPRlGX7l4E+1dNZxarZk0M/pe+4XQ=; b=8jOIQZpMP3ypwNDXUN/M3F8JghF7ZYl3WnUMb4FXkfbkiEWsVRI2v4dHK4Dqw/Zp1TZFs8 umvctaIFs8yiNNEcOkaFCOOj2JdUVJMFGmR5FnILy2OnPzWJmmB90w6ZhoD06p/uJ+OJdc Lb1ow7fS29B7Y1rT9hPcGc5dfWv2U0U= ARC-Authentication-Results: i=1; imf22.hostedemail.com; dkim=pass header.d=linaro.org header.s=google header.b=nnC2AjAP; spf=pass (imf22.hostedemail.com: domain of dan.carpenter@linaro.org designates 209.85.167.171 as permitted sender) smtp.mailfrom=dan.carpenter@linaro.org; dmarc=pass (policy=none) header.from=linaro.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1752780131; a=rsa-sha256; cv=none; b=JW0hAiurHgsfJqekQdSdTb6a96goJDVmqpzX+YIOO/kVLxv0vzXHFx86rLQZfGAl0UK/Yc rxL1StkaJyyajjHNiFyuMQIinEC96PKWaCW4Ue/+KKYkPL8AgLJ783D8xaP31e52/5KOHH XrF1UDKncEWtZb7ZJ09fOzMNqJOu/iQ= Received: by mail-oi1-f171.google.com with SMTP id 5614622812f47-41baecbdd36so460143b6e.3 for ; Thu, 17 Jul 2025 12:22:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1752780130; x=1753384930; darn=kvack.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=l5p4qniICn4Er/KPRlGX7l4E+1dNZxarZk0M/pe+4XQ=; b=nnC2AjAPc1bvo5VAahmOLGYGVR/5selZAA3vqDccdf2qcuVVYWKtqDUuA442lSWVI4 Vi/2+bk7p4yRaewSikPW0zqWJuaTcSH1RPPvgrmWvK4kX8fsMHY0YjQzxy3eY90UJKdR w0ogHnQ6GIdaANjGKcWKAMD4PsT2IknXUzGEw9ZEx4sGIJWMt3PzxpfMLuAy2rNy4+cM tEZUcW6YYbvGo99dHzl/IpKQ/+66y8qoQdGSooXoDT2E3q6X0+2jikZUb5lVC6JLrjjd EbA9fq74+4FO+Yv2Iu6h1+w5OSJRYzwprka9x5kVIkpZa1Jf+Jo188pDtubtrJLRrLJd mdFA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1752780130; x=1753384930; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=l5p4qniICn4Er/KPRlGX7l4E+1dNZxarZk0M/pe+4XQ=; b=iD3aHGmmHnOwzBOCe20LPMjFLOtvAh0i/kd4I5IiBCpNEngiK6ddgZ0TBwH+qQoZDk ZiOyUnXaXCh8Jl50e6KIh77inYR0Tpf/hXJu4Ujdq0wjDlim3+zP4vxIDYkZf/DJfNMf GcHhsf53BsVya6na2HkYy7bZeTJV5I/f5WgUarp2EAaQL4WynhEXxXykVU5bOLr7Zx1U CKmJska2wQEN/fpPwTXwLeCkrynOc2FTq09lSypPrDpWVs5PNlNBgAUl/sti3UHte2A7 bOkjUKVHXgM2Lrb6ieugUCbhTOvwAXOee+qT1YIQK1C2hhlhF0x9tPIDIfVGa3wdlSC7 3miQ== X-Forwarded-Encrypted: i=1; AJvYcCXrFxAqwsk2WH+CxsmOxYlvX2eRMwdBdYvzksWt3zXacarYrV+NaZl1LTuBUGALVZOqPXL63oyGAg==@kvack.org X-Gm-Message-State: AOJu0YxtBJg7n5sjYU5z4dsINzT0ajsAhFQXg2Jbvt4Dst1r0TfE0Z2x WKqnxEwKbfx0n+BjjV6qihqVqvn+D9i0b1MX81Zd33bcOAEDqRkTNoUU3WNiPgA2bd4= X-Gm-Gg: ASbGncsib+2Q7wOWddApGyjc2/oxjROjPnjO9766+KORYpIu14qN6UOiB9PX/O1CI/V RO/6Ww7aBBRGMyLViuUuF5sBLBm+CkRkTcqBbDQixxA2jxa505GZBZrwnNw2dPJl18gIYaZzRHb 7usY9H0EmB/B6Z58rHh2HohEYSFTG+tSvP2f1SUJ058F9/wMo5GN6pLcuZBnaByU7Q+TRrZKSpL dVGrnKa3VVXUUjpNueevAVVQ+voOpK47rVtilDAbqXPugyWhJX0FXNpZbueOcxeE3pDQU2QCPCE GmeO9Be/UgnOKy7M3QBpiZutnbyVYgqrnrphBj8mOUwd8t6XkRJMcZhIGSZfwrtSVs0o4W+uY9Q 74G0e5Cok9TBbMUPosDCfwvRkBw9F X-Google-Smtp-Source: AGHT+IHUJPSTCO0Lkc3tl0LM4MP0GRen9Aqi6X5Cr/nA9CehBZZHoOGzdbOunKzCFRwHAynemmebNA== X-Received: by 2002:a05:6808:219c:b0:3fe:b1fd:527f with SMTP id 5614622812f47-41cedb8d873mr6716411b6e.1.1752780130414; Thu, 17 Jul 2025 12:22:10 -0700 (PDT) Received: from localhost ([2603:8080:b800:f700:2c38:70d4:43e:b901]) by smtp.gmail.com with ESMTPSA id 5614622812f47-41c48678a3esm1773490b6e.26.2025.07.17.12.22.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 17 Jul 2025 12:22:09 -0700 (PDT) Date: Thu, 17 Jul 2025 22:22:06 +0300 From: Dan Carpenter To: Zi Yan Cc: Lorenzo Stoakes , Andrew Morton , David Hildenbrand , Antonio Quartulli , linux-mm@kvack.org, Hugh Dickins , Kirill Shutemov , Baolin Wang , "Liam R. Howlett" , Nico Pache , Ryan Roberts , Dev Jain , Barry Song , linux-kernel@vger.kernel.org Subject: Re: [PATCH] mm/huge_memory: refactor after-split (page) cache code. Message-ID: <57a80de0-c5f8-4fd9-9b4a-fea97fe6c533@suswa.mountain> References: <20250716171112.3666150-1-ziy@nvidia.com> <31D32C5B-6719-4E3D-880A-666044C4A48B@nvidia.com> <5464ABD7-C4C9-4BEF-9E5E-21F5A18C42D9@nvidia.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <5464ABD7-C4C9-4BEF-9E5E-21F5A18C42D9@nvidia.com> X-Rspam-User: X-Rspamd-Queue-Id: 8D8B8C0013 X-Rspamd-Server: rspam06 X-Stat-Signature: atqgpen3dhf5ykfqzdpmrzrp6macs55p X-HE-Tag: 1752780131-411072 X-HE-Meta: U2FsdGVkX18u/tRk8IfYITLKB2aU1PMnnVFENWciSuNKLpl3mLikuWGiGLm6vu0ba5Curz+YWMdhiurMjZDcF7anXp9lv9jDjsyUNXcslpk8erzP6jzZG6QoKV3wJHl1o9eZTVK2E/4YAgocAGAjzNy0mM1vxHHrW4wpLNnU8vojxGIsD7/ZDl8PLEWJwmSg0SjkjjhNdhuFDl8hHfu5COlIIrlxkQz6zaNhsdmIISWdtknTlHGIGJLgkYljgLoJDHijbB4YZSVRWaDVAvdQXGSvL9CqHb0nZAAKjjS7pCyDvyNlPzqSK1FZLiqk6hiZr62oGhonujiZGwu3/I1WkidvulF/JQFzMposLvhOprVTLL6awKxSOCHETwlnVECmUcJKA5YF5tsiq4hHaXbsb781sNBKMWltEuoAepF+wRd523QEVCEiAr469f/1GvrvTe0EUtZdiAtMPQEa2jR95hN3/huE6E3lAZhfDdsig01IdAqvPZ0MPWjbQyzNL/fbEZxQChEk1k8FQeCL0WnThnKhos3kpEEieUsjjAnZckKsLimjZhcBCFEo9VLPm2aM6sW5ogo6qyDNSRm5j3w46YPaNIT3u14+iZ8DPE6I4U45dw0q1icd7t4mRJ7yob1i9pQNu5RNBqqJAHMSRK6iXslmKRMquJl9Cq7PzIkdMJMio+VrqRD2nA6jbbYY8hwQnxpIlwHs94LVKB7uf73770279+zRKMvAbVZWsTyeqZf8XRb082UBwTLATo3d3nzOpuWR3SV6pS2aA/fv8WeQU89zY18VEExI9gZnfFoWR4EHRmu0NvwEOtw81y6CbN1SfRisv7y6xQfcgr2HfKIpz1QwqS3dDnSShNDkP05vAPk1e+1c7VoFaTv4W7Tdt8taFydyirPVQSgcQclDtyX2TvR/ntSpZLAZ+jJhpNrpWQ+x009Jvxi/XJh9FmSuSbNhyHirmp69nqi9MZJB6hX W8g8PWRR NwxUxe0DwSqeEtN18vIdBLTdQMDx5VjR8f70EZ5qGZ81Ea+PmNARTK/lsCuPzjdAb9wJWQExabSly2IrEK03kUo9e3X1Ib83UrTUm9wfzEROLql5OIJKIIT4keP8DEwN+EYrS0p53H+psKHO5oemR/eCsp/+zOKKszIHtYsFNyA+47paRZ1JAaRdNRcTMlxWpz7KYRJA8UFL1weihV79mfJ45/qI/IDBaV/r/L+Bu7UNg6YWmXaTKfoCJGT/xJU2puL3ypqnrx60SzHnodi6sjNxC+xlhldgR/BT92WzVnkqWCuvu51NwH9aC6SmqNRM3F4AsoHs8mn/81Fgy1uiTKDvYQRvhggVkBPXzza+V7OmvwZBVD0gTLh1yW9Ahac4p03Wg2NE9wZGtUovnaZNaYx7v1GW60YXOEtsAUm9L8S+yqVT19INikyeS02rkFJ25qDugABAVT96dUYs9kBQ7dMOtFrwWxXMECzxJ X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, Jul 17, 2025 at 11:45:13AM -0400, Zi Yan wrote: > > >> > >> Since we no longer need to make new_folio->index >= end work for anon > >> folios, can we drop the end = -1 in the if (is_anon) { ... } branch? > > > > Sure. > > A second thought on this one. If I remove end = -1, can static analysis > tools understand that end is not used when a folio is anonymous? > Probably, I can initialize end to -1 and remove end = -1 in is_anon > branch. Smatch says that "if "mapping" is non-NULL then "end" is initialized" and it doesn't trigger a warning. I don't know how the other checkers handle it. Btw, the only thing you really have to pay attention to is Clang because we treat build warnings as failure. You're always free to ignore other checkers. regards, dan carpenter