From: Dan Carpenter <dan.carpenter@linaro.org>
To: Zi Yan <ziy@nvidia.com>
Cc: Lorenzo Stoakes <lorenzo.stoakes@oracle.com>,
Andrew Morton <akpm@linux-foundation.org>,
David Hildenbrand <david@redhat.com>,
Antonio Quartulli <antonio@mandelbit.com>,
linux-mm@kvack.org, Hugh Dickins <hughd@google.com>,
Kirill Shutemov <k.shutemov@gmail.com>,
Baolin Wang <baolin.wang@linux.alibaba.com>,
"Liam R. Howlett" <Liam.Howlett@oracle.com>,
Nico Pache <npache@redhat.com>,
Ryan Roberts <ryan.roberts@arm.com>, Dev Jain <dev.jain@arm.com>,
Barry Song <baohua@kernel.org>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mm/huge_memory: refactor after-split (page) cache code.
Date: Thu, 17 Jul 2025 22:22:06 +0300 [thread overview]
Message-ID: <57a80de0-c5f8-4fd9-9b4a-fea97fe6c533@suswa.mountain> (raw)
In-Reply-To: <5464ABD7-C4C9-4BEF-9E5E-21F5A18C42D9@nvidia.com>
On Thu, Jul 17, 2025 at 11:45:13AM -0400, Zi Yan wrote:
>
> >>
> >> Since we no longer need to make new_folio->index >= end work for anon
> >> folios, can we drop the end = -1 in the if (is_anon) { ... } branch?
> >
> > Sure.
>
> A second thought on this one. If I remove end = -1, can static analysis
> tools understand that end is not used when a folio is anonymous?
> Probably, I can initialize end to -1 and remove end = -1 in is_anon
> branch.
Smatch says that "if "mapping" is non-NULL then "end" is initialized"
and it doesn't trigger a warning. I don't know how the other checkers
handle it.
Btw, the only thing you really have to pay attention to is Clang because
we treat build warnings as failure. You're always free to ignore other
checkers.
regards,
dan carpenter
next prev parent reply other threads:[~2025-07-17 19:22 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-16 17:11 Zi Yan
2025-07-16 17:59 ` Dan Carpenter
2025-07-16 19:12 ` Zi Yan
2025-07-16 18:14 ` David Hildenbrand
2025-07-16 19:14 ` Zi Yan
2025-07-16 19:01 ` Antonio Quartulli
2025-07-16 19:13 ` Zi Yan
2025-07-17 14:46 ` Lorenzo Stoakes
2025-07-17 15:30 ` Zi Yan
2025-07-17 15:45 ` Zi Yan
2025-07-17 19:22 ` Dan Carpenter [this message]
2025-07-17 19:27 ` Zi Yan
2025-07-17 19:33 ` Lorenzo Stoakes
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=57a80de0-c5f8-4fd9-9b4a-fea97fe6c533@suswa.mountain \
--to=dan.carpenter@linaro.org \
--cc=Liam.Howlett@oracle.com \
--cc=akpm@linux-foundation.org \
--cc=antonio@mandelbit.com \
--cc=baohua@kernel.org \
--cc=baolin.wang@linux.alibaba.com \
--cc=david@redhat.com \
--cc=dev.jain@arm.com \
--cc=hughd@google.com \
--cc=k.shutemov@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=lorenzo.stoakes@oracle.com \
--cc=npache@redhat.com \
--cc=ryan.roberts@arm.com \
--cc=ziy@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox