From: Xishi Qiu <qiuxishi@huawei.com>
To: Michal Hocko <mhocko@kernel.org>
Cc: Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>, "H. Peter Anvin" <hpa@zytor.com>,
Vlastimil Babka <vbabka@suse.cz>,
Mel Gorman <mgorman@techsingularity.net>,
Andrew Morton <akpm@linux-foundation.org>,
David Rientjes <rientjes@google.com>,
Joonsoo Kim <iamjoonsoo.kim@lge.com>,
Taku Izumi <izumi.taku@jp.fujitsu.com>,
"'Kirill A . Shutemov'" <kirill.shutemov@linux.intel.com>,
Kamezawa Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>,
Linux MM <linux-mm@kvack.org>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 1/3] mm: fix set pageblock migratetype in deferred struct page init
Date: Tue, 16 Aug 2016 16:56:54 +0800 [thread overview]
Message-ID: <57B2D556.5030201@huawei.com> (raw)
In-Reply-To: <20160816084132.GA17417@dhcp22.suse.cz>
On 2016/8/16 16:41, Michal Hocko wrote:
> On Thu 04-08-16 19:25:03, Xishi Qiu wrote:
>> MAX_ORDER_NR_PAGES is usually 4M, and a pageblock is usually 2M, so we only
>> set one pageblock's migratetype in deferred_free_range() if pfn is aligned
>> to MAX_ORDER_NR_PAGES.
>
> Do I read the changelog correctly and the bug causes leaking unmovable
> allocations into movable zones?
Hi Michal,
This bug will cause uninitialized migratetype, you can see from
"cat /proc/pagetypeinfo", almost half blocks are Unmovable.
Also this bug missed to free the last block pages, it cause memory leaking.
Thanks,
Xishi Qiu
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2016-08-16 9:03 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-04 11:23 [PATCH 1/3] mem-hotplug: introduce movablenode option Xishi Qiu
2016-08-04 11:24 ` [PATCH 2/3] mem-hotplug: fix node spanned pages when we have a movable node Xishi Qiu
2016-08-04 11:25 ` [PATCH 1/3] mm: fix set pageblock migratetype in deferred struct page init Xishi Qiu
2016-08-04 11:36 ` Xishi Qiu
2016-08-16 8:41 ` Michal Hocko
2016-08-16 8:56 ` Xishi Qiu [this message]
2016-08-16 9:23 ` Michal Hocko
2016-08-16 10:01 ` [PATCH v2] " Xishi Qiu
2016-08-16 10:12 ` [PATCH 1/3] " Vlastimil Babka
2016-08-16 10:20 ` Xishi Qiu
2016-08-16 11:10 ` Michal Hocko
2016-08-11 23:13 ` [PATCH 1/3] mem-hotplug: introduce movablenode option Andrew Morton
2016-08-15 1:40 ` Xishi Qiu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=57B2D556.5030201@huawei.com \
--to=qiuxishi@huawei.com \
--cc=akpm@linux-foundation.org \
--cc=hpa@zytor.com \
--cc=iamjoonsoo.kim@lge.com \
--cc=izumi.taku@jp.fujitsu.com \
--cc=kamezawa.hiroyu@jp.fujitsu.com \
--cc=kirill.shutemov@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mgorman@techsingularity.net \
--cc=mhocko@kernel.org \
--cc=mingo@redhat.com \
--cc=rientjes@google.com \
--cc=tglx@linutronix.de \
--cc=vbabka@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox