From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id A4D01EB64DC for ; Sat, 15 Jul 2023 00:04:38 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 10C196B0071; Fri, 14 Jul 2023 20:04:38 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 0BD2F6B0072; Fri, 14 Jul 2023 20:04:38 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E9FE86B0074; Fri, 14 Jul 2023 20:04:37 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id DB1F86B0071 for ; Fri, 14 Jul 2023 20:04:37 -0400 (EDT) Received: from smtpin27.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id A2AE4403D2 for ; Sat, 15 Jul 2023 00:04:37 +0000 (UTC) X-FDA: 81011899794.27.F258084 Received: from NAM12-BN8-obe.outbound.protection.outlook.com (mail-bn8nam12on2053.outbound.protection.outlook.com [40.107.237.53]) by imf13.hostedemail.com (Postfix) with ESMTP id 6D01520018 for ; Sat, 15 Jul 2023 00:04:34 +0000 (UTC) Authentication-Results: imf13.hostedemail.com; dkim=pass header.d=Nvidia.com header.s=selector2 header.b=CKxhcZAE; dmarc=pass (policy=reject) header.from=nvidia.com; arc=pass ("microsoft.com:s=arcselector9901:i=1"); spf=pass (imf13.hostedemail.com: domain of jhubbard@nvidia.com designates 40.107.237.53 as permitted sender) smtp.mailfrom=jhubbard@nvidia.com ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1689379474; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=o8+XPvbC9JXK0y4BrnW2ftiMZnYYHjp+vE4T1okv1EU=; b=L/cW8/QpVF86nbFpVBYq/m8vkNCA2RlEr2DKSn84Ty+hm2RqXOGKejcUOXy2pGcGsG5v/f DxDNixGUYHxklsRmMYKveDv+LQy2KL9dFaBVc3RSLyyP8gpGPvYDDwUhgHzuniIJ2fhZah H+GI6/8rjlOn36Bh71HiYCYahST4cHI= ARC-Authentication-Results: i=2; imf13.hostedemail.com; dkim=pass header.d=Nvidia.com header.s=selector2 header.b=CKxhcZAE; dmarc=pass (policy=reject) header.from=nvidia.com; arc=pass ("microsoft.com:s=arcselector9901:i=1"); spf=pass (imf13.hostedemail.com: domain of jhubbard@nvidia.com designates 40.107.237.53 as permitted sender) smtp.mailfrom=jhubbard@nvidia.com ARC-Seal: i=2; s=arc-20220608; d=hostedemail.com; t=1689379474; a=rsa-sha256; cv=pass; b=c9wJU+bjSgQVHKutxGjH0LUYEUvjrAfgGde1eJQ/KDjbQIpDJS5AZiZcEzimV+tLTEPwMM UhjbWyqIzgZgJ57pO+ygPjqt3vA2z6FJkushalCZ46P6JeLE9GL5Zkp70vxI98WKBY6u31 aA4FlI6TM33Cc55LOZvo0uKAb6CDfqc= ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=LNWiosKA0nfeYHo8y5JE/MqeYn9DnA1ABXCIBb/I+p2tXIhgtlv/1EKXmZINaIP8Z4f/tZziEQazMA/rk2ZST66iMF17V3nSR1QzNA1+DofiR4w14v5//xO/Dx8ltf+UV5AwrAloWorj1GOw69BNxY5EPTkWNGA09kIM67qI28F7xUpJPoObmKiJc+Hpvv9DB0QGTi78FCjHiNcmNxQfdeSHaTeXv4bZElfYA/E4YYM3gUKZ47yJmVgAe+11vp6ls353saTszHaYMp96zik07U9Bjh721GDP06xCqYyEhj4noP0vgh0P7iOaPaJ3pMvtcOCJqKUpv1Dr3LEBg/4Qew== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=o8+XPvbC9JXK0y4BrnW2ftiMZnYYHjp+vE4T1okv1EU=; b=kC5NA5Iie5cPD8SkXIKb2XFjrSIrF8hoZCccdSSvNDwQuGf1b4tNW7HswdXTe6Jtte+O0+Hh8FM5HaHhJqp1Nqa6FAasNX4Syv3/U4qPKGGojy+hcvjntWzxZ9RNUrONYpwSQhJbBB2wkPCz14u3dFZLR17Dm7UKp64rSPTa3ULuw3lGIv2OwkeamjjJ3LTU6OvFvsHH6HYUkg/i39GBJUhAP476P52ou1z4yzOxF+4EMggbs8ys7M6P4Ac6i8GGjsgl2uqAfQSZPtUFqnHf6+vERbvYM8zTor55Xl++/18G7vqUSaT16GE+bfe6qGzsWw9R4+rkgOHbhdb7gV5s9A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.117.160) smtp.rcpttodomain=arm.com smtp.mailfrom=nvidia.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=o8+XPvbC9JXK0y4BrnW2ftiMZnYYHjp+vE4T1okv1EU=; b=CKxhcZAE+c/xtei6OlqR5NFZvckpdAJ631kQa0tDnP4H9+sEZw6ta6JCEi+NYuRavJtXfsPj0eAUerodqklwIYDYuDYvBpdXqPmkvAWGtV+PBq/P8iEHJzE//XVCH7gd89xsXE6jz/dylXl3hjeV1C68LoR7t3cLxwvljnaEjh12wltC2M82aQKxTcp5gAzfOD/n0jxkzsUi3xUfKgZyquCdasNdrEQAaBYsMWw8tPgeqk7LmeLaV7SGW9+3NbDmZvvwbiIRA5Ugub8BvQDN5SaHbYR+kmc+i6LwjaedND3bQvswKc1MAcwGs5RY+ghT0GWBTMB5yguAcPesKDGn+A== Received: from BN9PR03CA0276.namprd03.prod.outlook.com (2603:10b6:408:f5::11) by BL1PR12MB5730.namprd12.prod.outlook.com (2603:10b6:208:385::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6588.28; Sat, 15 Jul 2023 00:04:32 +0000 Received: from BN8NAM11FT014.eop-nam11.prod.protection.outlook.com (2603:10b6:408:f5:cafe::b8) by BN9PR03CA0276.outlook.office365.com (2603:10b6:408:f5::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6588.27 via Frontend Transport; Sat, 15 Jul 2023 00:04:32 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.117.160) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.117.160 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.117.160; helo=mail.nvidia.com; pr=C Received: from mail.nvidia.com (216.228.117.160) by BN8NAM11FT014.mail.protection.outlook.com (10.13.177.142) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6588.27 via Frontend Transport; Sat, 15 Jul 2023 00:04:31 +0000 Received: from rnnvmail201.nvidia.com (10.129.68.8) by mail.nvidia.com (10.129.200.66) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.5; Fri, 14 Jul 2023 17:04:20 -0700 Received: from [10.110.48.28] (10.126.230.35) by rnnvmail201.nvidia.com (10.129.68.8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.37; Fri, 14 Jul 2023 17:04:19 -0700 Message-ID: <57995c19-36c5-d868-293a-f03ad507da98@nvidia.com> Date: Fri, 14 Jul 2023 17:04:19 -0700 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 Subject: Re: [PATCH v1 3/9] selftests/mm: Skip soft-dirty tests on arm64 Content-Language: en-US To: Ryan Roberts , Andrew Morton , Shuah Khan , =?UTF-8?B?SsOpcsO0bWUgR2xpc3Nl?= , David Hildenbrand , Mark Brown , Florent Revest , "Liam R. Howlett" CC: , , References: <20230713135440.3651409-1-ryan.roberts@arm.com> <20230713135440.3651409-4-ryan.roberts@arm.com> From: John Hubbard In-Reply-To: <20230713135440.3651409-4-ryan.roberts@arm.com> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [10.126.230.35] X-ClientProxiedBy: rnnvmail201.nvidia.com (10.129.68.8) To rnnvmail201.nvidia.com (10.129.68.8) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BN8NAM11FT014:EE_|BL1PR12MB5730:EE_ X-MS-Office365-Filtering-Correlation-Id: 2cd9ec1c-6ddc-42f8-8b50-08db84c710dc X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: jgItefQStGuKBuQfgrslkgQA5GHiCuddhE/BN86f/sG5P9qxI7NfbwV2dZy2T5tjwOSufy31YIyQwxycAbM5pGogav+r/XvTW5vKAxzTXGQeYw1j7t0KybPLO9Utz1ss1RaKXnIszuDOw2f/9yjaXoKnz3v/w793xUCN1lyKdCZIZSzMjI8aWkUqPfzISQR6U3xpIP+9dEC9/1KF4QNLcRwdCHPhi7kEMvPh13riodJyp+fZQSmbIIHDoVjvAqXG8um//AXAFu2RMifWj6fGIRlYutd2PeG+K956C16kiQPq0Jpg05cKVj1L0+wCyjXa/8D39GT0/QOyniNSzH6zAlILR8bU3aMzJTO6rw8w4aKJ/laqEklaDkgYpfNOUaDURrul+H2vh7szUGnFKfE1il6uxAlNlwKps1jZVXMg2OlNI6E7Pulh/JSK5MmFePMYBrjP/vnfsCQbdFn56UWdSP3AEPEExJww0t5F14utO0p2J9TRcTmkCutyWzP6WPXElj2KnPwKvbLWC80ocp+u9ILBfwFAPsllotuQh1FVuBEJxlR/CTDpV6iN97s4O/RHiXXwnOqUs03av+ATFFGhkrg9HbccocHaDbC8+HLcKuFhDyZb5g/gpY4vUzLriaH/gMLUmZWtV4bvH0GYtBRqs55XGIy7hP1R4YLf96f2G26O0+12XD+07yyqAIJjesvZ/Z1m0UXa+bqAM6CkCWF2N+OubZA6H1ryc0EGbc8qXxW+bm26ifCM9TZaHpxJ5kPFaRZfcPtfILyfe+9/LSDGn4GfiiehndAceUKuKNbrndM= X-Forefront-Antispam-Report: CIP:216.228.117.160;CTRY:US;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:mail.nvidia.com;PTR:dc6edge1.nvidia.com;CAT:NONE;SFS:(13230028)(4636009)(136003)(346002)(376002)(39860400002)(396003)(451199021)(36840700001)(46966006)(40470700004)(82740400003)(356005)(7636003)(31696002)(86362001)(82310400005)(36756003)(31686004)(40480700001)(8676002)(5660300002)(110136005)(54906003)(16576012)(41300700001)(7416002)(26005)(8936002)(53546011)(16526019)(186003)(336012)(2616005)(2906002)(47076005)(40460700003)(83380400001)(426003)(36860700001)(316002)(4326008)(478600001)(70586007)(70206006)(14143004)(43740500002);DIR:OUT;SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Jul 2023 00:04:31.7273 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 2cd9ec1c-6ddc-42f8-8b50-08db84c710dc X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a;Ip=[216.228.117.160];Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: BN8NAM11FT014.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL1PR12MB5730 X-Rspam-User: X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: 6D01520018 X-Stat-Signature: keqyp845ou3qmg6cmzby74ty9m5uu7t8 X-HE-Tag: 1689379474-238075 X-HE-Meta: U2FsdGVkX1+BdEmN/LHouPCv25+EqlomcPrVRg/A99bwjI/BfLI8KJ5Lfx0pg1QjA1xPffaXg6Q+BtDxJ1Dt5n7n95ImpuzJuzoPzoSTPMbc8ltaYipv6WI0z8WGtfGa98k5bj1AaNS5d8AqFgoAP+X9F7GWbj13ir/HmqIKm7zv5S+NfBQuxmXIoBqqZ0ENQf1xkE5Hcmk31z4ixyXVu5G/bBuremuTyOivUQFU9kqz2fgIx+0jG4EegM4m6Awmd5LW1ybJhXi9wPwOxN2z7Jz671z88Cmxx4KMGHGNsZEB+/+jzfX/7dIgSopax+CtJZY5TvgJauXE6mSDiKFk7f5Sb2IcyYc2ky2acDEia8vR9nhQWoZZ3WuYqFLfZgzkPV3RuncYSjdsxXhsvrv6ok0Kb80GpOJ9q2oprk77UTsMWh+DKLgmsRmy1aliaK1pby/d5h/T6wZ6E96Oq5F4YPothfTAlkp45/lKUnAlCVJ3o/Tv5OwFUQsXDgujPOctc5/MEDDPnfBqGMZGHZoWzdYI8FzABLQp2kuXbuA4gOBec8OqRPwNLVR6jkYzShJp3c64Y0693aGYgkDk9gjVEdsq81Gzv7xX2GBtZ5+XbnsJFVo1IGal8qA1+tDIev9CW606qkHMjTuiaLbGGyeCy26nStar69pkAoJzI0RdB23rEjsUZSsmY6wCVxqob+46RDMaZpBkE2nv4wMxbCRKwrBQRFjdaBwedv4O4YYSmHfjLwVz3bErAQsVYZQL1ioMwLl3/A/W4TgjLNXAnv3ys/nZuld9yWn9hhq3RqtvaxEsMFNSIhibztUZG1JUJvE9qgC79CuqE1V48CSsGjCC3bxFP6XFf6J2pHY+c60+ggs62VXfWXPfGPhunsMY0lDihPBDiJbJp4uRtFk8IR+Nb5VfD52apCt0FuVO9l/4lx1Bm8iQM7fETCUhp5KtqpKvqCpAZOA74WsIZMbiPUY Kbtv+Zxf LExTw11PIu8ir4aV4gnGd3XzqlAy0uNlH+nqAAUXkAgwYfAWIPqkxueyN2f2AEpxhFtqv0+EvlvXzAzUphEvk1UvutKQkooMC+Wiv2Oyc2X8lZV1zXlZjtfUJ2+MY1liPu4uE3C/G8pw1YR8nWhJUbwKOXoOEH4mKedN/v79XmAPeA4Rugc1k2u5UPojJUq/wXtDhmqDpdbVu6/wO+ewSv8rz8K6n1LC7+ZeJoJIWcgTcQ2+UvtZChxlJ1tcBz+96vGOrdaMn4zVB4v9IBVe1LJoQRw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 7/13/23 06:54, Ryan Roberts wrote: > arm64 does not support the soft-dirty PTE bit. However there are tests > in `madv_populate` and `soft-dirty` which assume it is supported and > cause spurious failures to be reported when preferred behaviour would be > to mark the tests as skipped. > > Unfortunately, the only way to determine if the soft-dirty dirty bit is > supported is to write to a page, then see if the bit is set in > /proc/self/pagemap. But the tests that we want to conditionally execute > are testing precicesly this. So if we introduced this feature check, we > could accedentally turn a real failure (on a system that claims to > support soft-dirty) into a skip. ... > diff --git a/tools/testing/selftests/mm/soft-dirty.c b/tools/testing/selftests/mm/soft-dirty.c > index cc5f144430d4..8a2cd161ec4d 100644 > --- a/tools/testing/selftests/mm/soft-dirty.c > +++ b/tools/testing/selftests/mm/soft-dirty.c Hi Ryan, Probably very similar to what David is requesting: given that arm64 definitively does not support soft dirty, I'd suggest that we not even *build* the soft dirty tests on arm64! There is no need to worry about counting, skipping or waiving such tests, either. Because it's just a non-issue: one does not care about test status for something that is documented as "this feature is simply unavailable here". thanks, -- John Hubbard NVIDIA