From: Xishi Qiu <qiuxishi@huawei.com>
To: Linux MM <linux-mm@kvack.org>, LKML <linux-kernel@vger.kernel.org>
Subject: why not add __GFP_HIGHMEM directly in alloc_migrate_target()?
Date: Tue, 12 Jul 2016 21:16:07 +0800 [thread overview]
Message-ID: <5784ED97.1080807@huawei.com> (raw)
alloc_migrate_target() is called from migrate_pages(),
so the page is always from user space, so why not add
__GFP_HIGHMEM directly, instead of the following code.
if (PageHighMem(page)) // it always return false in x86_64
gfp_mask |= __GFP_HIGHMEM;
Another question, when we do migration, why should split THP
first?
e.g. 2M(512*4kb) should flush 512 times TLB, and 2M(2M*1) only need one.
I find flush TLB takes a lot of time, especially multithreaded app.
Thanks,
Xishi Qiu
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
reply other threads:[~2016-07-12 13:33 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5784ED97.1080807@huawei.com \
--to=qiuxishi@huawei.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox