From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 332B7C77B7C for ; Mon, 23 Jun 2025 18:09:37 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id B11C06B00AD; Mon, 23 Jun 2025 14:09:36 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id AE7A46B00C1; Mon, 23 Jun 2025 14:09:36 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 9D6196B00C5; Mon, 23 Jun 2025 14:09:36 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 8C6106B00AD for ; Mon, 23 Jun 2025 14:09:36 -0400 (EDT) Received: from smtpin03.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id D2D9A80BC2 for ; Mon, 23 Jun 2025 18:09:35 +0000 (UTC) X-FDA: 83587453110.03.7953C9C Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.223.131]) by imf07.hostedemail.com (Postfix) with ESMTP id 762F74000A for ; Mon, 23 Jun 2025 18:09:33 +0000 (UTC) Authentication-Results: imf07.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=slKywCNN; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=Oc7WKwNP; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=slKywCNN; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=Oc7WKwNP; spf=pass (imf07.hostedemail.com: domain of vbabka@suse.cz designates 195.135.223.131 as permitted sender) smtp.mailfrom=vbabka@suse.cz; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1750702173; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=vwP5saSx0e7sxZN1AuhvkkxhOInv9FUKxB78L00Zgcc=; b=HipelELuR5OXtzIaaOyaxDgKrP4HrwtQ8vPbnJD+yiUA5X/e/mi6re7X9I6rC5vWXYTW3H 7qnJwUa/L0Ol0kWeUKBXgPKpMnqqMSplVANLXcr25mfPZQDQWVoTXW0k46lyBim5doPpfN 8ykkaSE1BzSxzHA0eSrfatN0kblPBCs= ARC-Authentication-Results: i=1; imf07.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=slKywCNN; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=Oc7WKwNP; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=slKywCNN; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=Oc7WKwNP; spf=pass (imf07.hostedemail.com: domain of vbabka@suse.cz designates 195.135.223.131 as permitted sender) smtp.mailfrom=vbabka@suse.cz; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1750702173; a=rsa-sha256; cv=none; b=ZOj4SBEd40vDMLPhVnzRN9MJSQKmBcSYTcebIAa3JvSyHwqUk0sLohwdZtuO5IeTtcJkOa Tpskec3CXk14ndZBd5x0p7zx/ew9O+AU3bIdl4cZQJVeleLzG6VW+9u83kdTBKQ7EV0T+u kdJKe9B0n5UVQxzChDW8a/LyRTrP9eo= Received: from imap1.dmz-prg2.suse.org (unknown [10.150.64.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 594451F391; Mon, 23 Jun 2025 18:09:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1750702171; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=vwP5saSx0e7sxZN1AuhvkkxhOInv9FUKxB78L00Zgcc=; b=slKywCNN1vGDVbwNDLNZHYyYY+KF+iWUoE5D12DwHZ0Zx0U2c8A1sqIvXqNL5myhLAccpV 4ZAF33Ttl3ES3037QDxwoCs0bjJLVTfekkQiG2vebith98jUimjjuu3KgqY/Hqlagy4dbr LIf9kjYhTjbqz8XXIK70ktj5HJNeFQ8= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1750702171; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=vwP5saSx0e7sxZN1AuhvkkxhOInv9FUKxB78L00Zgcc=; b=Oc7WKwNPOjEi4li/tH5KJJGhGZheOvenb9urWnnobCgG7VhEN+YHvYddVZ2nmpkN8R7L8P E99t8SowBL9sXBAQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1750702171; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=vwP5saSx0e7sxZN1AuhvkkxhOInv9FUKxB78L00Zgcc=; b=slKywCNN1vGDVbwNDLNZHYyYY+KF+iWUoE5D12DwHZ0Zx0U2c8A1sqIvXqNL5myhLAccpV 4ZAF33Ttl3ES3037QDxwoCs0bjJLVTfekkQiG2vebith98jUimjjuu3KgqY/Hqlagy4dbr LIf9kjYhTjbqz8XXIK70ktj5HJNeFQ8= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1750702171; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=vwP5saSx0e7sxZN1AuhvkkxhOInv9FUKxB78L00Zgcc=; b=Oc7WKwNPOjEi4li/tH5KJJGhGZheOvenb9urWnnobCgG7VhEN+YHvYddVZ2nmpkN8R7L8P E99t8SowBL9sXBAQ== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 16C9313485; Mon, 23 Jun 2025 18:09:31 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id VwfkBFuYWWg+JwAAD6G6ig (envelope-from ); Mon, 23 Jun 2025 18:09:31 +0000 Message-ID: <577ff7bd-3f30-4531-a7f4-5c63da797848@suse.cz> Date: Mon, 23 Jun 2025 20:09:30 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH net-next v6 9/9] page_pool: access ->pp_magic through struct netmem_desc in page_pool_page_is_pp() Content-Language: en-US To: Mina Almasry , Pavel Begunkov Cc: David Hildenbrand , Zi Yan , Byungchul Park , willy@infradead.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, kernel_team@skhynix.com, kuba@kernel.org, ilias.apalodimas@linaro.org, harry.yoo@oracle.com, hawk@kernel.org, akpm@linux-foundation.org, davem@davemloft.net, john.fastabend@gmail.com, andrew+netdev@lunn.ch, toke@redhat.com, tariqt@nvidia.com, edumazet@google.com, pabeni@redhat.com, saeedm@nvidia.com, leon@kernel.org, ast@kernel.org, daniel@iogearbox.net, lorenzo.stoakes@oracle.com, Liam.Howlett@oracle.com, rppt@kernel.org, surenb@google.com, mhocko@suse.com, horms@kernel.org, linux-rdma@vger.kernel.org, bpf@vger.kernel.org, vishal.moola@gmail.com, hannes@cmpxchg.org, jackmanb@google.com References: <20250620041224.46646-1-byungchul@sk.com> <20250620041224.46646-10-byungchul@sk.com> <20250623101622.GB3199@system.software.com> <460ACE40-9E99-42B8-90F0-2B18D2D8C72C@nvidia.com> <41e68e52-5747-4b18-810d-4b20ada01c9a@gmail.com> From: Vlastimil Babka Autocrypt: addr=vbabka@suse.cz; keydata= xsFNBFZdmxYBEADsw/SiUSjB0dM+vSh95UkgcHjzEVBlby/Fg+g42O7LAEkCYXi/vvq31JTB KxRWDHX0R2tgpFDXHnzZcQywawu8eSq0LxzxFNYMvtB7sV1pxYwej2qx9B75qW2plBs+7+YB 87tMFA+u+L4Z5xAzIimfLD5EKC56kJ1CsXlM8S/LHcmdD9Ctkn3trYDNnat0eoAcfPIP2OZ+ 9oe9IF/R28zmh0ifLXyJQQz5ofdj4bPf8ecEW0rhcqHfTD8k4yK0xxt3xW+6Exqp9n9bydiy tcSAw/TahjW6yrA+6JhSBv1v2tIm+itQc073zjSX8OFL51qQVzRFr7H2UQG33lw2QrvHRXqD Ot7ViKam7v0Ho9wEWiQOOZlHItOOXFphWb2yq3nzrKe45oWoSgkxKb97MVsQ+q2SYjJRBBH4 8qKhphADYxkIP6yut/eaj9ImvRUZZRi0DTc8xfnvHGTjKbJzC2xpFcY0DQbZzuwsIZ8OPJCc LM4S7mT25NE5kUTG/TKQCk922vRdGVMoLA7dIQrgXnRXtyT61sg8PG4wcfOnuWf8577aXP1x 6mzw3/jh3F+oSBHb/GcLC7mvWreJifUL2gEdssGfXhGWBo6zLS3qhgtwjay0Jl+kza1lo+Cv BB2T79D4WGdDuVa4eOrQ02TxqGN7G0Biz5ZLRSFzQSQwLn8fbwARAQABzSBWbGFzdGltaWwg QmFia2EgPHZiYWJrYUBzdXNlLmN6PsLBlAQTAQoAPgIbAwULCQgHAwUVCgkICwUWAgMBAAIe AQIXgBYhBKlA1DSZLC6OmRA9UCJPp+fMgqZkBQJnyBr8BQka0IFQAAoJECJPp+fMgqZkqmMQ AIbGN95ptUMUvo6aAdhxaOCHXp1DfIBuIOK/zpx8ylY4pOwu3GRe4dQ8u4XS9gaZ96Gj4bC+ jwWcSmn+TjtKW3rH1dRKopvC07tSJIGGVyw7ieV/5cbFffA8NL0ILowzVg8w1ipnz1VTkWDr 2zcfslxJsJ6vhXw5/npcY0ldeC1E8f6UUoa4eyoskd70vO0wOAoGd02ZkJoox3F5ODM0kjHu Y97VLOa3GG66lh+ZEelVZEujHfKceCw9G3PMvEzyLFbXvSOigZQMdKzQ8D/OChwqig8wFBmV QCPS4yDdmZP3oeDHRjJ9jvMUKoYODiNKsl2F+xXwyRM2qoKRqFlhCn4usVd1+wmv9iLV8nPs 2Db1ZIa49fJet3Sk3PN4bV1rAPuWvtbuTBN39Q/6MgkLTYHb84HyFKw14Rqe5YorrBLbF3rl M51Dpf6Egu1yTJDHCTEwePWug4XI11FT8lK0LNnHNpbhTCYRjX73iWOnFraJNcURld1jL1nV r/LRD+/e2gNtSTPK0Qkon6HcOBZnxRoqtazTU6YQRmGlT0v+rukj/cn5sToYibWLn+RoV1CE Qj6tApOiHBkpEsCzHGu+iDQ1WT0Idtdynst738f/uCeCMkdRu4WMZjteQaqvARFwCy3P/jpK uvzMtves5HvZw33ZwOtMCgbpce00DaET4y/UzsBNBFsZNTUBCACfQfpSsWJZyi+SHoRdVyX5 J6rI7okc4+b571a7RXD5UhS9dlVRVVAtrU9ANSLqPTQKGVxHrqD39XSw8hxK61pw8p90pg4G /N3iuWEvyt+t0SxDDkClnGsDyRhlUyEWYFEoBrrCizbmahOUwqkJbNMfzj5Y7n7OIJOxNRkB IBOjPdF26dMP69BwePQao1M8Acrrex9sAHYjQGyVmReRjVEtv9iG4DoTsnIR3amKVk6si4Ea X/mrapJqSCcBUVYUFH8M7bsm4CSxier5ofy8jTEa/CfvkqpKThTMCQPNZKY7hke5qEq1CBk2 wxhX48ZrJEFf1v3NuV3OimgsF2odzieNABEBAAHCwXwEGAEKACYCGwwWIQSpQNQ0mSwujpkQ PVAiT6fnzIKmZAUCZ8gcVAUJFhTonwAKCRAiT6fnzIKmZLY8D/9uo3Ut9yi2YCuASWxr7QQZ lJCViArjymbxYB5NdOeC50/0gnhK4pgdHlE2MdwF6o34x7TPFGpjNFvycZqccSQPJ/gibwNA zx3q9vJT4Vw+YbiyS53iSBLXMweeVV1Jd9IjAoL+EqB0cbxoFXvnjkvP1foiiF5r73jCd4PR rD+GoX5BZ7AZmFYmuJYBm28STM2NA6LhT0X+2su16f/HtummENKcMwom0hNu3MBNPUOrujtW khQrWcJNAAsy4yMoJ2Lw51T/5X5Hc7jQ9da9fyqu+phqlVtn70qpPvgWy4HRhr25fCAEXZDp xG4RNmTm+pqorHOqhBkI7wA7P/nyPo7ZEc3L+ZkQ37u0nlOyrjbNUniPGxPxv1imVq8IyycG AN5FaFxtiELK22gvudghLJaDiRBhn8/AhXc642/Z/yIpizE2xG4KU4AXzb6C+o7LX/WmmsWP Ly6jamSg6tvrdo4/e87lUedEqCtrp2o1xpn5zongf6cQkaLZKQcBQnPmgHO5OG8+50u88D9I rywqgzTUhHFKKF6/9L/lYtrNcHU8Z6Y4Ju/MLUiNYkmtrGIMnkjKCiRqlRrZE/v5YFHbayRD dJKXobXTtCBYpLJM4ZYRpGZXne/FAtWNe4KbNJJqxMvrTOrnIatPj8NhBVI0RSJRsbilh6TE m6M14QORSWTLRg== In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Rspam-User: X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: 762F74000A X-Stat-Signature: m7d1w4jnw49ihkmj3d1sd8qguo7fzd9x X-HE-Tag: 1750702173-238905 X-HE-Meta: U2FsdGVkX1+9/DhOjMIFg9yibuSsRGcjTAWfFC+60Hg9cHjhNc+wnIG6G0CGw3/cCv5d8vLR5oZvOe4twGazR2czXt32euLVi87jfJVNywabmB+LWA9jJA7O3uKrjbqetiiV8v5jJaUFzYab3lZnrt0hDHdnDP5NYYmz4wwv6UYSXSB2L+ICfpsdA2Jz+7zy/PqrueuQSrtdjH+ynCrB5RziTd8ZmyQgHhEv5z2ZqHclw0aH+3PrlGv8dgFpW+5ut4Qu6NceLUCWaQQT8ro9a7BVgN4ovEPuXzsUOPUifNHieLFVpNbYAFROvgz+tBctW/AWGUpBCByLfrU8aYL/2znGyYosdCOmeBWIzRHKNsQQVLCi5hV5ZI8J+unwFj90mZ4ry1ewlO4Sz5it1V4kM4C/aUvQfEDaF+xgOBRCVLWrOMb3ACZjR4zNhPHgYh398wgHjIPuL5na6w/jcMP6tu8VF4yvQL00UQ/WKRrEuJZLZzDTgUvnUmzXAGjwrgmITncrv6Byhs0hnlK2hCaMLfIAvf56gPKSiszOjTEciX8fYA/AmI5wrYPp40D6lhxC7ZN1aP/kYvCXzLubFobXCiKq2HOa5gegc7s6A5m1dNmG1H385pl8hUGr3BI8QoZISRniCFNOghTXqy5evmHpOPASjOddBUC2XCXyz85qZfJsjNFq0Gh7mFZ4gBW5H3joH2uxLCasTY6HQEfI7TrNDNidVE+k4u608Ui4yhAGRvNEXUstMUeS2leB+yqMAhATW2MxGnwlUAnOYJClgDmsCDGwMisvtVi3z/KMcubIWxouruhzM4w7mztxuIt28Hk9bp+5nwnsBT3TEwyQCokMjV3HEcgjgS7PRtTRD0n06FW7zkcGKIxjh7CvEkZ6LsaTlEtrBNjbD6VHLlMs38C0UpKB7PqXF4STVR9shZtKrr9C/d6M8nmFFQpsY2lmCawg3UaXjaUiox7GAFR+agB 6zECGWL6 SeS0tKc2I9vSjHmEN17CccqNE3fCoWnLlM5MJGD91k2RT3pyqV9kl35vCzYavO4Ft/ZJZyWOsy5opv7vCY2C3XirR3ph6ksbQzguyouy1NKGBEU/Rp/cix2V0b8m80yliDCKUkgDxIKdrOka4/1DygxeknHmGvnlUzwdE9UED/toM3dLGVCH+HqQTCv6eU8Ux6K/mJfJpJcKmDbyCe4NJHoWaZlC/Vxwh7wlyR7YIGbP19EFiSyM/PN8BKfFhKTy4G01o2L0jmBC1KD8bE4TI+ZH288IbE9hf/8jxUpA7zNgODpJZvti7Wl7dnyQdARrzXMnVNYs9LfqQzog2LUGJaWM3Vw75xk+H5hnDFbDEKrfEkbAHLnEL8ttBoVmki8EBhTNUbWSIWSVPOtvNKsSIZv3iPny3Z3DO/coe29sEr5ogicbAwSMWIp8pddF7SZztZE76BDBBVgmQPlDwArk1X4YlaQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 6/23/25 19:28, Mina Almasry wrote: > On Mon, Jun 23, 2025 at 10:05 AM Pavel Begunkov wrote: >> >> >> As you said, it's just a sanity check, all page pool pages should >> be freed by the networking code. It checks the ownership with >> netmem_is_pp(), which is basically the same as page_pool_page_is_pp() >> but done though some aliasing. >> >> static inline bool netmem_is_pp(netmem_ref netmem) >> { >> return (netmem_get_pp_magic(netmem) & PP_MAGIC_MASK) == PP_SIGNATURE; >> } >> >> I assume there is no point in moving the check to skbuff.c as it >> already does exactly same test, but we can probably just kill it. >> > > Even if we do kill it, maybe lets do that in a separate patch, and > maybe a separate series. I would recommend not complicating this one? > > Also, AFAIU, this is about removing/moving the checks in > bad_page_reason() and page_expected_state()? I think this check does > fire sometimes. I saw at least 1 report in the last year of a > bad_page_reason() check firing because the page_pool got its > accounting wrong and released a page to the buddy allocator early, so > maybe that new patch that removes that check should explain why this > check is no longer necessary. Note these checks are these days only done with CONFIG_DEBUG_VM, or debugging/hardening options like debug_pagealloc/init_on_alloc/init_on_free, see mem_debugging_and_hardening_init() and when check_pages_enabled static key is enabled.