From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 56601C197A0 for ; Fri, 17 Nov 2023 15:37:58 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id EB6F16B04E9; Fri, 17 Nov 2023 10:37:57 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id E673D6B04EB; Fri, 17 Nov 2023 10:37:57 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D09A46B04EC; Fri, 17 Nov 2023 10:37:57 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id BF19C6B04E9 for ; Fri, 17 Nov 2023 10:37:57 -0500 (EST) Received: from smtpin25.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 8F3B0A015E for ; Fri, 17 Nov 2023 15:37:57 +0000 (UTC) X-FDA: 81467851794.25.65AED7D Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf17.hostedemail.com (Postfix) with ESMTP id 4E3E240005 for ; Fri, 17 Nov 2023 15:37:55 +0000 (UTC) Authentication-Results: imf17.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=A6+QOV28; spf=pass (imf17.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1700235475; a=rsa-sha256; cv=none; b=4oXHZo8PZIWN9wwFn+hGIy0jnNKpGCfhXnbfz0WVOFNF7h81ZpS3KlhOIHneHsFaZheDN4 1UW/4vHWGZCQXKsafuhQUsuAoH+iTKcZsoBCU/lTNMOzZ3xjHRsK689CM6sHDoNVbYVbRz uFZt7Sklz1Qsg3im+or7ZUnznbEFrAw= ARC-Authentication-Results: i=1; imf17.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=A6+QOV28; spf=pass (imf17.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1700235475; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=fweTSD3me3Mx8GyQIQZU14sJeAzjgkPwJ7KyqiFU4BQ=; b=5HTqGznf4nu2yVIZo5Ym9cjCsphyM6ijp9LAuebvHiDpsbJl1A/s4SVISb4dODlnBbBXvi DRthKdgsaNmVOP9B1GBzDS1fdIom/BWJ5WG84lgnvY6GbOoQaOmT9ZllgZ2XEJuEttVs3c LHmcC1eugsmMdrruWujna3DJqvm+OWg= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1700235474; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=fweTSD3me3Mx8GyQIQZU14sJeAzjgkPwJ7KyqiFU4BQ=; b=A6+QOV28p073u7cAcu6x4pwZsD4bPDUdp1pSzacr1JP4B2s2XgbDZRrCiKj0/MoYxebBoV 4pBrVHgG+D0L24B9azFjXTrRginjVXCMsm0RsFCOVg7Hu/zn1YTE2CboyIMGBIPVIkt51n pSHb+/GtjaAlgoXTWQjpuc8oJ0LzKCI= Received: from mail-wm1-f71.google.com (mail-wm1-f71.google.com [209.85.128.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-637-yPjXWIRKOI2lcvthBFtYKQ-1; Fri, 17 Nov 2023 10:37:52 -0500 X-MC-Unique: yPjXWIRKOI2lcvthBFtYKQ-1 Received: by mail-wm1-f71.google.com with SMTP id 5b1f17b1804b1-4095fcbba0aso12159195e9.1 for ; Fri, 17 Nov 2023 07:37:52 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1700235471; x=1700840271; h=content-transfer-encoding:in-reply-to:organization:autocrypt:from :references:cc:to:content-language:subject:user-agent:mime-version :date:message-id:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=fweTSD3me3Mx8GyQIQZU14sJeAzjgkPwJ7KyqiFU4BQ=; b=p0aISoZM2yRrvP8/VU8kD6GNVTt+US7uH7eXLbG8l3Xt5ziU0072Xv+jkkFRXAEqdL WhytO+AyIg36ROjIYGOBsHPfxqI687i1VlbeevGrDmkzHk0BkE+WHR1jOuoxCJ4erhJx tse0pWcY6ZpdN+QkfmOofvLs9Iz1D8kaAjPvDsXg1oFzBKj0MhhMtOHf5dJvFGhPlqtO P7aLXnrJs9T6utaN3/5hhEOwqOLwnZR+ydYFFMKEqZdhtJdR33qhLKmE8CI0g4CgEU4h yEDGwsfjazGFY978fOE3jSHxKoO+/x8OfTlArnxY0HYyKIRGTlm+Zw42FMKJ6YSV9Hft 1FhQ== X-Gm-Message-State: AOJu0YzOvtWLFxhzF1BXHHSpLw1sQh7oiZDkgv11xc0ANN/ta69a/chD +CZ0Ihdk3zz+Wv6JeoFELLgUgoT9kOlfEvQf30ujU35hm1iv0WFVDGsobmB0ME34ZYbI6c/iuPo sXh/setflAo8= X-Received: by 2002:a05:600c:2e4c:b0:408:3f87:cba with SMTP id q12-20020a05600c2e4c00b004083f870cbamr15450229wmf.39.1700235471089; Fri, 17 Nov 2023 07:37:51 -0800 (PST) X-Google-Smtp-Source: AGHT+IFXiSLvfsFsx2ecWHmPMg5XOcGZDFC3T/0kLsJ3TJWJXg6BmsCf7Un0EtNCoPcc+mfW8Jei1A== X-Received: by 2002:a05:600c:2e4c:b0:408:3f87:cba with SMTP id q12-20020a05600c2e4c00b004083f870cbamr15450212wmf.39.1700235470731; Fri, 17 Nov 2023 07:37:50 -0800 (PST) Received: from [192.168.3.108] (p4ff23170.dip0.t-ipconnect.de. [79.242.49.112]) by smtp.gmail.com with ESMTPSA id z16-20020a05600c221000b0040472ad9a3dsm3084684wml.14.2023.11.17.07.37.49 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 17 Nov 2023 07:37:50 -0800 (PST) Message-ID: <57762a6b-24c1-44a7-b1f3-4e73fe3b963d@redhat.com> Date: Fri, 17 Nov 2023 16:37:49 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 0/8] implement "memmap on memory" feature on s390 To: Sumanth Korikkar Cc: linux-mm , Andrew Morton , Oscar Salvador , Michal Hocko , "Aneesh Kumar K.V" , Anshuman Khandual , Gerald Schaefer , Alexander Gordeev , Heiko Carstens , Vasily Gorbik , linux-s390 , LKML References: <20231114180238.1522782-1-sumanthk@linux.ibm.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam08 X-Rspamd-Queue-Id: 4E3E240005 X-Stat-Signature: soi18b7h5g17fxa16o564einha3br5zc X-Rspam-User: X-HE-Tag: 1700235475-138201 X-HE-Meta: U2FsdGVkX18YRHrUfJXx8xd1qW7UCFxclA3BevtKOLS0pYLgQzM1W4hKceUYiZttC+1JafGB49bqPqlNAcqZfYTejyKDWWliyZBH4G7mtz36PU9SJyCmOiGoEyaKlsqhjHLYVVC0OBZwdhBErUaUVr1w8FFiUrxWKabZE4RQuVQtZNVKAETd4WTHjfKq4t7yA3WR+oyPRE7Ag8/wfcEOF92swFtpwF0mHPJZsdy9nhTmu+74yzW1Fdqr1idon0KdYpSOmY8MpkwnX1P8i+5Twdy1onT1CGU/jvTY0GF17kzjkuOgRpvUu3OOS28LVUt+nOA8tc/PMdxPcQRGprqWWxkCg9If+kPQZVLuXjz8n4VLy5znH3o7LWUGhhJcohqjvmPMVu5oFUprKwexfmOyVh92rB2nufN2mdlUCpg+BYmMS8XvLSI2oCfnoTZZzN5i3lbA/VD5bmQwxUwf0Ty0t89gxIbIDZmZUuD7nWW8iRO9ZB41uHqo9YJb4i7l3lWyd3J6O+xuYrKJFwecGIiQQCWA9yPnBRRqg+B2UeipyBPxD6wt86l6BB1FhbumTB1sU25Hw/6i1n86I1FkCK77BnqsU/aGPEqbofMnsCHr7qKOx6FkVAHz0dRtaZxqfTMT5Ruw7PFVezLFmVv8Boayky4klAWTa0QfH1CwIRrZUtOBORMFFUMU3F1J30nv3O6tYI90oSHx6X2yvJeJZi/N2AoNesnGPHbGRFXlqIZCpan/tfi/rs0WVD2L+f26yzD3SWc/nztlJ6ERNz9Bwt91VNLoi8x/en3tEvMYQvOJRpj+UPtdRXUQt5Uk0M+YZF+V95SCwRwRdfEIms44pNe3Npd2Z32KKwcEEeLSMvan8JRhNQLGg34j3f+bNohsf5EsQAyQPrFOJHHEDWpnSVxqutn3UEZNUHfzFMqgUF5laWWBpeOba6dvfg6mKtm/bPOD0it79u+di6EdM4ZVq9H 7FGIF4Uh utt7sFQFFFnhvB/lhn9C/E+wu3Zb3MSscRXd44rZ1odw3c32XmGD5mOwurcap5D6bSN4JZFa1Rq5sgrwGtsqpp19jI6bPTiPZTghiBm8FrBoz0A82RKA7UYV405yL0A2wAuDJW5YfpGf1AUhVWn59jfOL7ZROyGl6QgQP7RdDLuq3XJVg4NwAnrI9b2brj3d1FVeIb/4JE+S60zqOH3zdLdmtQLYhBDwfE5ywdj74qvHVxLI6OAHX3iysSBBPcM4vYGC7oZ03xu+WfQ5LLwmjjiMLaJVzC+GJnwPvOgGrft5Cdfdmcm+oYrETDyjwGJnHCuAFSaPA+L2z30Pqvm9dvBN/DA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 17.11.23 14:56, Sumanth Korikkar wrote: > On Fri, Nov 17, 2023 at 12:08:31AM +0100, David Hildenbrand wrote: >> On 14.11.23 19:02, Sumanth Korikkar wrote: >>> Hi All, >>> >>> The patch series implements "memmap on memory" feature on s390 and >>> provides the necessary fixes for it. >> >> Thinking about this, one thing that makes s390x different from all the other >> architectures in this series is the altmap handling. >> >> I'm curious, why is that even required? >> >> A memmep that is not marked as online in the section should not be touched >> by anybody (except memory onlining code :) ). And if we do, it's usually a >> BUG because that memmap might contain garbage/be poisoned or completely >> stale, so we might want to track that down and fix it in any case. >> >> So what speaks against just leaving add_memory() populate the memmap from >> the altmap? Then, also the page tables for the memmap are already in place >> when onlining memory. >> > > we do have page_init_poison() in sparse_add_section() which should be > handled later then. not in add_pages() Was that all, or did you stumble over other things? -- Cheers, David / dhildenb