Re: [PATCH 2/4] mm: Rename node_get_allowed_targets() to make it more explicit

Joshua Hahn
2026-03-11T15:02:47Z

On Wed, 11 Mar 2026 12:02:41 +0100 Alexandre Ghiti <alex@ghiti.fr> wrote:

> This function actually returns the tier nodes that are targeted during a
> demotion, so rename it to be more explicit.
>
> No functional change intended.

Agreed, node_get_allowed_targets is pretty vague ; -)

I do think that node_get_allowed_demotion_targets could be considered
a bit too long, but I don't think it's called in too many places where
there would be more than just this function call in the line so LGTM!

Please feel free to add my review tag, have a great day Alexandre!

Reviewed-by: Joshua Hahn <joshua.hahnjy@gmail.com>

> Signed-off-by: Alexandre Ghiti <alex@ghiti.fr>
> ---
> include/linux/memory-tiers.h | 6 +++---
> mm/memory-tiers.c | 4 ++--
> mm/vmscan.c | 2 +-
> 3 files changed, 6 insertions(+), 6 deletions(-)