* [PATCH mm] kasan: initialize read-write lock in stack ring
@ 2022-09-20 18:58 andrey.konovalov
2022-09-20 19:09 ` Marco Elver
0 siblings, 1 reply; 3+ messages in thread
From: andrey.konovalov @ 2022-09-20 18:58 UTC (permalink / raw)
To: Andrew Morton
Cc: Andrey Konovalov, Marco Elver, Alexander Potapenko,
Dmitry Vyukov, Andrey Ryabinin, kasan-dev, linux-mm, Yu Zhao,
linux-kernel, Andrey Konovalov
From: Andrey Konovalov <andreyknvl@google.com>
Use __RW_LOCK_UNLOCKED to initialize stack_ring.lock.
Reported-by: Yu Zhao <yuzhao@google.com>
Signed-off-by: Andrey Konovalov <andreyknvl@google.com>
---
Andrew, could you please fold this patch into:
"kasan: implement stack ring for tag-based modes".
---
mm/kasan/tags.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/mm/kasan/tags.c b/mm/kasan/tags.c
index 9d867cae1b7b..67a222586846 100644
--- a/mm/kasan/tags.c
+++ b/mm/kasan/tags.c
@@ -36,7 +36,9 @@ DEFINE_STATIC_KEY_TRUE(kasan_flag_stacktrace);
/* Non-zero, as initial pointer values are 0. */
#define STACK_RING_BUSY_PTR ((void *)1)
-struct kasan_stack_ring stack_ring;
+struct kasan_stack_ring stack_ring = {
+ .lock = __RW_LOCK_UNLOCKED(stack_ring.lock)
+};
/* kasan.stacktrace=off/on */
static int __init early_kasan_flag_stacktrace(char *arg)
--
2.25.1
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH mm] kasan: initialize read-write lock in stack ring
2022-09-20 18:58 [PATCH mm] kasan: initialize read-write lock in stack ring andrey.konovalov
@ 2022-09-20 19:09 ` Marco Elver
2022-09-20 19:13 ` Yu Zhao
0 siblings, 1 reply; 3+ messages in thread
From: Marco Elver @ 2022-09-20 19:09 UTC (permalink / raw)
To: andrey.konovalov
Cc: Andrew Morton, Andrey Konovalov, Alexander Potapenko,
Dmitry Vyukov, Andrey Ryabinin, kasan-dev, linux-mm, Yu Zhao,
linux-kernel, Andrey Konovalov
On Tue, 20 Sept 2022 at 20:58, <andrey.konovalov@linux.dev> wrote:
>
> From: Andrey Konovalov <andreyknvl@google.com>
>
> Use __RW_LOCK_UNLOCKED to initialize stack_ring.lock.
>
> Reported-by: Yu Zhao <yuzhao@google.com>
> Signed-off-by: Andrey Konovalov <andreyknvl@google.com>
>
> ---
>
> Andrew, could you please fold this patch into:
> "kasan: implement stack ring for tag-based modes".
> ---
> mm/kasan/tags.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/mm/kasan/tags.c b/mm/kasan/tags.c
> index 9d867cae1b7b..67a222586846 100644
> --- a/mm/kasan/tags.c
> +++ b/mm/kasan/tags.c
> @@ -36,7 +36,9 @@ DEFINE_STATIC_KEY_TRUE(kasan_flag_stacktrace);
> /* Non-zero, as initial pointer values are 0. */
> #define STACK_RING_BUSY_PTR ((void *)1)
>
> -struct kasan_stack_ring stack_ring;
> +struct kasan_stack_ring stack_ring = {
> + .lock = __RW_LOCK_UNLOCKED(stack_ring.lock)
> +};
Reviewed-by: Marco Elver <elver@google.com>
> /* kasan.stacktrace=off/on */
> static int __init early_kasan_flag_stacktrace(char *arg)
> --
> 2.25.1
>
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH mm] kasan: initialize read-write lock in stack ring
2022-09-20 19:09 ` Marco Elver
@ 2022-09-20 19:13 ` Yu Zhao
0 siblings, 0 replies; 3+ messages in thread
From: Yu Zhao @ 2022-09-20 19:13 UTC (permalink / raw)
To: Marco Elver
Cc: andrey.konovalov, Andrew Morton, Andrey Konovalov,
Alexander Potapenko, Dmitry Vyukov, Andrey Ryabinin, kasan-dev,
linux-mm, linux-kernel, Andrey Konovalov
On Tue, Sep 20, 2022 at 1:10 PM Marco Elver <elver@google.com> wrote:
>
> On Tue, 20 Sept 2022 at 20:58, <andrey.konovalov@linux.dev> wrote:
> >
> > From: Andrey Konovalov <andreyknvl@google.com>
> >
> > Use __RW_LOCK_UNLOCKED to initialize stack_ring.lock.
> >
> > Reported-by: Yu Zhao <yuzhao@google.com>
> > Signed-off-by: Andrey Konovalov <andreyknvl@google.com>
> >
> > ---
> >
> > Andrew, could you please fold this patch into:
> > "kasan: implement stack ring for tag-based modes".
> > ---
> > mm/kasan/tags.c | 4 +++-
> > 1 file changed, 3 insertions(+), 1 deletion(-)
> >
> > diff --git a/mm/kasan/tags.c b/mm/kasan/tags.c
> > index 9d867cae1b7b..67a222586846 100644
> > --- a/mm/kasan/tags.c
> > +++ b/mm/kasan/tags.c
> > @@ -36,7 +36,9 @@ DEFINE_STATIC_KEY_TRUE(kasan_flag_stacktrace);
> > /* Non-zero, as initial pointer values are 0. */
> > #define STACK_RING_BUSY_PTR ((void *)1)
> >
> > -struct kasan_stack_ring stack_ring;
> > +struct kasan_stack_ring stack_ring = {
> > + .lock = __RW_LOCK_UNLOCKED(stack_ring.lock)
> > +};
>
> Reviewed-by: Marco Elver <elver@google.com>
Tested-by: Yu Zhao <yuzhao@google.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-09-20 19:14 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-09-20 18:58 [PATCH mm] kasan: initialize read-write lock in stack ring andrey.konovalov
2022-09-20 19:09 ` Marco Elver
2022-09-20 19:13 ` Yu Zhao
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox