From: Thomas Zimmermann <tzimmermann@suse.de>
To: Michael Kelley <mhklinux@outlook.com>,
Simona Vetter <simona.vetter@ffwll.ch>
Cc: David Hildenbrand <david@redhat.com>,
"simona@ffwll.ch" <simona@ffwll.ch>,
"deller@gmx.de" <deller@gmx.de>,
"haiyangz@microsoft.com" <haiyangz@microsoft.com>,
"kys@microsoft.com" <kys@microsoft.com>,
"wei.liu@kernel.org" <wei.liu@kernel.org>,
"decui@microsoft.com" <decui@microsoft.com>,
"akpm@linux-foundation.org" <akpm@linux-foundation.org>,
"weh@microsoft.com" <weh@microsoft.com>,
"hch@lst.de" <hch@lst.de>,
"dri-devel@lists.freedesktop.org"
<dri-devel@lists.freedesktop.org>,
"linux-fbdev@vger.kernel.org" <linux-fbdev@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-hyperv@vger.kernel.org" <linux-hyperv@vger.kernel.org>,
"linux-mm@kvack.org" <linux-mm@kvack.org>
Subject: Re: [PATCH v3 3/4] fbdev/deferred-io: Support contiguous kernel memory framebuffers
Date: Fri, 6 Jun 2025 09:05:04 +0200 [thread overview]
Message-ID: <575e098d-ef9f-4431-bef9-bfc8070a0dfd@suse.de> (raw)
In-Reply-To: <SN6PR02MB4157F630284939E084486AFED46FA@SN6PR02MB4157.namprd02.prod.outlook.com>
Hi
Am 05.06.25 um 19:38 schrieb Michael Kelley:
[...]
>> I try to address the problem with the patches at
>>
>> https://lore.kernel.org/dri-devel/20250605152637.98493-1-tzimmermann@suse.de/
>>
>> Testing and feedback is much appreciated.
>>
> Nice!
>
> I ran the same test case with your patches, and everything works well. The
> hyperv_drm numbers are now pretty much the same as the hyperv_fb
> numbers for both elapsed time and system CPU time -- within a few percent.
> For hyperv_drm, there's no longer a gap in the elapsed time and system
> CPU time. No errors due to the guest-to-host ring buffer being full. Total
> messages to Hyper-V for hyperv_drm are now a few hundred instead of 3M.
Sounds great. Credit also goes to the vkms devs, which already have the
software vblank in their driver.
This might need better support for cases where display updates take
exceptionally long, but I can see this being merged as a DRM feature.
> The hyperv_drm message count is still a little higher than for hyperv_fb,
> presumably because the simulated vblank rate in hyperv_drm is higher than
> the 20 Hz rate used by hyperv_fb deferred I/O. But the overall numbers are
> small enough that the difference is in the noise. Question: what is the default
> value for the simulated vblank rate? Just curious ...
As with a hardware interrupt, the vblank rate comes from the programmed
display mode, so most likely 60 Hz. The difference in the update
frequency could explain the remaining differences to hyperv_fb.
Best regards
Thomas
>
> Michael
--
--
Thomas Zimmermann
Graphics Driver Developer
SUSE Software Solutions Germany GmbH
Frankenstrasse 146, 90461 Nuernberg, Germany
GF: Ivo Totev, Andrew Myers, Andrew McDonald, Boudien Moerman
HRB 36809 (AG Nuernberg)
next prev parent reply other threads:[~2025-06-06 7:05 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-23 16:15 [PATCH v3 0/4] fbdev: Add deferred I/O support for " mhkelley58
2025-05-23 16:15 ` [PATCH v3 1/4] mm: Export vmf_insert_mixed_mkwrite() mhkelley58
2025-05-23 16:15 ` [PATCH v3 2/4] fbdev: Add flag indicating framebuffer is allocated from kernel memory mhkelley58
2025-05-23 16:15 ` [PATCH v3 3/4] fbdev/deferred-io: Support contiguous kernel memory framebuffers mhkelley58
2025-05-24 7:28 ` kernel test robot
2025-05-26 6:54 ` Christoph Hellwig
2025-06-02 9:47 ` David Hildenbrand
2025-06-03 1:49 ` Michael Kelley
2025-06-03 6:25 ` Thomas Zimmermann
2025-06-03 17:50 ` Michael Kelley
2025-06-04 8:12 ` Thomas Zimmermann
2025-06-04 14:45 ` Simona Vetter
2025-06-04 21:43 ` Michael Kelley
2025-06-05 7:55 ` Thomas Zimmermann
2025-06-05 15:35 ` Thomas Zimmermann
2025-06-05 17:38 ` Michael Kelley
2025-06-06 7:05 ` Thomas Zimmermann [this message]
2025-06-11 23:18 ` Michael Kelley
2025-06-12 7:25 ` Thomas Zimmermann
2025-06-03 7:55 ` David Hildenbrand
2025-06-03 17:24 ` Michael Kelley
2025-06-04 21:58 ` Michael Kelley
2025-06-05 8:10 ` David Hildenbrand
2025-05-23 16:15 ` [PATCH v3 4/4] fbdev: hyperv_fb: Fix mmap of framebuffers allocated using alloc_pages() mhkelley58
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=575e098d-ef9f-4431-bef9-bfc8070a0dfd@suse.de \
--to=tzimmermann@suse.de \
--cc=akpm@linux-foundation.org \
--cc=david@redhat.com \
--cc=decui@microsoft.com \
--cc=deller@gmx.de \
--cc=dri-devel@lists.freedesktop.org \
--cc=haiyangz@microsoft.com \
--cc=hch@lst.de \
--cc=kys@microsoft.com \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-hyperv@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mhklinux@outlook.com \
--cc=simona.vetter@ffwll.ch \
--cc=simona@ffwll.ch \
--cc=weh@microsoft.com \
--cc=wei.liu@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox