linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: "Yin, Fengwei" <fengwei.yin@intel.com>
To: Yang Shi <shy828301@gmail.com>
Cc: kernel test robot <oliver.sang@intel.com>,
	Rik van Riel <riel@surriel.com>, <oe-lkp@lists.linux.dev>,
	<lkp@intel.com>,
	"Linux Memory Management List" <linux-mm@kvack.org>,
	Andrew Morton <akpm@linux-foundation.org>,
	Matthew Wilcox <willy@infradead.org>,
	Christopher Lameter <cl@linux.com>, <ying.huang@intel.com>,
	<feng.tang@intel.com>
Subject: Re: [linux-next:master] [mm] 1111d46b5c: stress-ng.pthread.ops_per_sec -84.3% regression
Date: Thu, 21 Dec 2023 21:39:57 +0800	[thread overview]
Message-ID: <5753c5cb-62e3-42e6-bf04-b12b4c77b259@intel.com> (raw)
In-Reply-To: <b1974dc2-0e25-4075-a9ba-5e1face6c0cd@intel.com>



On 12/21/2023 8:58 AM, Yin Fengwei wrote:
> But what I am not sure was whether it's worthy to do such kind of change
> as the regression only is seen obviously in micro-benchmark. No evidence
> showed the other regressionsin this report is related with madvise. At
> least from the perf statstics. Need to check more on stream/ramspeed. 
> Thanks.

With debugging patch (filter out the stack mapping from THP aligned),
the result of stream can be restored to around 2%:

commit:
   30749e6fbb3d391a7939ac347e9612afe8c26e94
   1111d46b5cbad57486e7a3fab75888accac2f072
   89f60532d82b9ecd39303a74589f76e4758f176f  -> 1111d46b5cbad with 
debugging patch

30749e6fbb3d391a 1111d46b5cbad57486e7a3fab75 89f60532d82b9ecd39303a74589
---------------- --------------------------- ---------------------------
     350993           -15.6%     296081 ±  2%      -1.5%     345689 
   stream.add_bandwidth_MBps
     349830           -16.1%     293492 ±  2%      -2.3%     341860 ± 
2%  stream.add_bandwidth_MBps_harmonicMean
     333973           -20.5%     265439 ±  3%      -1.7%     328403 
   stream.copy_bandwidth_MBps
     332930           -21.7%     260548 ±  3%      -2.5%     324711 ± 
2%  stream.copy_bandwidth_MBps_harmonicMean
     302788           -16.2%     253817 ±  2%      -1.4%     298421 
   stream.scale_bandwidth_MBps
     302157           -17.1%     250577 ±  2%      -2.0%     296054 
   stream.scale_bandwidth_MBps_harmonicMean
     339047           -12.1%     298061            -1.4%     334206 
   stream.triad_bandwidth_MBps
     338186           -12.4%     296218            -2.0%     331469 
   stream.triad_bandwidth_MBps_harmonicMean


The regression of ramspeed is still there.


Regards
Yin, Fengwei


  parent reply	other threads:[~2023-12-21 13:40 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-12-19 15:41 kernel test robot
2023-12-20  5:27 ` Yang Shi
2023-12-20  8:29   ` Yin Fengwei
2023-12-20 15:42     ` Christoph Lameter (Ampere)
2023-12-20 20:14       ` Yang Shi
2023-12-20 20:09     ` Yang Shi
2023-12-21  0:26       ` Yang Shi
2023-12-21  0:58         ` Yin Fengwei
2023-12-21  1:02           ` Yin Fengwei
2023-12-21  4:49           ` Matthew Wilcox
2023-12-21  4:58             ` Yin Fengwei
2023-12-21 18:07             ` Yang Shi
2023-12-21 18:14               ` Matthew Wilcox
2023-12-22  1:06                 ` Yin, Fengwei
2023-12-22  2:23                   ` Huang, Ying
2023-12-21 13:39           ` Yin, Fengwei [this message]
2023-12-21 18:11             ` Yang Shi
2023-12-22  1:13               ` Yin, Fengwei
2024-01-04  1:32                 ` Yang Shi
2024-01-04  8:18                   ` Yin Fengwei
2024-01-04  8:39                     ` Oliver Sang
2024-01-05  9:29                       ` Oliver Sang
2024-01-05 14:52                         ` Yin, Fengwei
2024-01-05 18:49                         ` Yang Shi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5753c5cb-62e3-42e6-bf04-b12b4c77b259@intel.com \
    --to=fengwei.yin@intel.com \
    --cc=akpm@linux-foundation.org \
    --cc=cl@linux.com \
    --cc=feng.tang@intel.com \
    --cc=linux-mm@kvack.org \
    --cc=lkp@intel.com \
    --cc=oe-lkp@lists.linux.dev \
    --cc=oliver.sang@intel.com \
    --cc=riel@surriel.com \
    --cc=shy828301@gmail.com \
    --cc=willy@infradead.org \
    --cc=ying.huang@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox