From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8E9C9C54EBC for ; Tue, 10 Jan 2023 14:41:41 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 2AB908E0002; Tue, 10 Jan 2023 09:41:41 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 25A9D8E0001; Tue, 10 Jan 2023 09:41:41 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 0FBE58E0002; Tue, 10 Jan 2023 09:41:41 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 00EA08E0001 for ; Tue, 10 Jan 2023 09:41:40 -0500 (EST) Received: from smtpin19.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id C14534073F for ; Tue, 10 Jan 2023 14:41:40 +0000 (UTC) X-FDA: 80339153160.19.7D0D90F Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf13.hostedemail.com (Postfix) with ESMTP id C9B1C20006 for ; Tue, 10 Jan 2023 14:41:38 +0000 (UTC) Authentication-Results: imf13.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=JuEEQ+XS; spf=pass (imf13.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1673361698; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=b4g9pnWT43DUunpQsxzG5qZh/RY4G1cVAtYK0Irtegc=; b=IcFDZcSlaBt2EBqIEumPl9O5hq6qVL1OOcSe8UxTurBDE1ttG03VHNireyWPiDb8N26we9 xlmWN1ZrlsJGRnXhgqRMOyLCemFk2tS1sQVZjmZ+DJOMVCZcMZYUOGYRAA3+jPZhOoKwcS r95yc1kJiKUQNcOU31qw3seDpWdzSYQ= ARC-Authentication-Results: i=1; imf13.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=JuEEQ+XS; spf=pass (imf13.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1673361698; a=rsa-sha256; cv=none; b=tNfy5VwuTkDhbnUUesNuj9FEUGUQf8jeNTZU2jLTPzbAre3fblF5ybDfeTNUUj8G3oe6/4 PWbCWOf2mOy6Nmz4Tz1t+Z6TX6yfK3uUpGS4YIghg17PCPzS1hEO79AGPPfrBF5zOkgflv 1EBer/rVYmZuvNVqaYtwVceJi0lSLFk= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1673361698; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=b4g9pnWT43DUunpQsxzG5qZh/RY4G1cVAtYK0Irtegc=; b=JuEEQ+XSvGEh67xi0aYU9aHzadE2nnPuxN4+hvQad2sd8reS+t8gIjhTv9phI1cUk0xfTr EQOYS9zCEWXOANaP+qw9UC0xMaEYM58tC5A9CX+2wOhsFXk/DlP0QzpFYM5PcOGcoS+rhA RIu3VPwxdT4CGigNV0JavhVzn02JlIA= Received: from mail-wr1-f70.google.com (mail-wr1-f70.google.com [209.85.221.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-441-PfhLkRhnM4--Ljbff7i_yg-1; Tue, 10 Jan 2023 09:41:36 -0500 X-MC-Unique: PfhLkRhnM4--Ljbff7i_yg-1 Received: by mail-wr1-f70.google.com with SMTP id u4-20020adfc644000000b002ad64393461so2049398wrg.7 for ; Tue, 10 Jan 2023 06:41:35 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:organization:from:references :cc:to:content-language:subject:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=b4g9pnWT43DUunpQsxzG5qZh/RY4G1cVAtYK0Irtegc=; b=zgoEnaclS0bMscLmeYq9POi96R2HZvng1tJoXBIQuR5CQ+364171OdfHyiga/i6Mh/ JKcP9L1aQk0CcKStvIxGWifQdyKfm/I6pbc1adBnRAUuoV1NnnBUpy3ynbveAUWwBL3K fblu1R2DrwgiHf7/8BVRrxZSuTQzOx74kdKHwRRrQxoVY0HO8gHm5KpO3NTIFVaSySg2 8Q4vxX8Ms2TYdBz7pIFkSECyF8pwqkwi/DsmsV7E+xiAIwmxQ0QHyXbpzyRYHPcr1S7V H4sBIZt03qthNBcy/kDdEdrwJ2t9UFx4StEsRjQfyWbrN+frSqjCJb9Jn0ZlSec9lrBx 1Kdg== X-Gm-Message-State: AFqh2krJEEPnVYujvK3AA68j51qX+FtgEkhd3MHYunfmXnSqQY27is+q W95AanLyH3Bmp85Pxtvn4LcwFccmX+SqPxOwDRVGVW0knmR1LBlb2VBM3HCA03tRGGRHWgNWdvl CchlC7uvo9v8= X-Received: by 2002:adf:e303:0:b0:26e:4bdc:6ae1 with SMTP id b3-20020adfe303000000b0026e4bdc6ae1mr43599791wrj.28.1673361694551; Tue, 10 Jan 2023 06:41:34 -0800 (PST) X-Google-Smtp-Source: AMrXdXtU76tgOOv4RdpJd4IzrQciHyEboZ0J4tfjr9YHe5XNutbSBgO0YUH1mLuXQ9UPiWZ4YhbE8Q== X-Received: by 2002:adf:e303:0:b0:26e:4bdc:6ae1 with SMTP id b3-20020adfe303000000b0026e4bdc6ae1mr43599775wrj.28.1673361694301; Tue, 10 Jan 2023 06:41:34 -0800 (PST) Received: from ?IPV6:2003:cb:c708:4200:65d9:4d0d:bb61:14c8? (p200300cbc708420065d94d0dbb6114c8.dip0.t-ipconnect.de. [2003:cb:c708:4200:65d9:4d0d:bb61:14c8]) by smtp.gmail.com with ESMTPSA id bw28-20020a0560001f9c00b002421888a011sm11178824wrb.69.2023.01.10.06.41.33 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 10 Jan 2023 06:41:33 -0800 (PST) Message-ID: <5751732b-67c4-bff5-a7eb-8432cdac5174@redhat.com> Date: Tue, 10 Jan 2023 15:41:33 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.6.0 Subject: Re: [PATCH] mm/sl{a,u}b: fix wrong usages of folio_page() for getting head pages To: SeongJae Park , akpm@linux-foundation.org Cc: willy@infradead.org, vbabka@suse.cz, linux-mm@kvack.org, linux-kernel@vger.kernel.org References: <20230110005124.1609-1-sj@kernel.org> From: David Hildenbrand Organization: Red Hat In-Reply-To: <20230110005124.1609-1-sj@kernel.org> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Stat-Signature: ttj5wjs5dcpoadrgbg1rhq3d8jktrbb9 X-Rspam-User: X-Rspamd-Queue-Id: C9B1C20006 X-Rspamd-Server: rspam06 X-HE-Tag: 1673361698-301175 X-HE-Meta: U2FsdGVkX1/P4BSLLyOei/xgLK/61Ng9Jpo22yS7jvjt6rBj63dQ4PoZooH/8lT1vFA3ub16V/O+0bUQyr0Hv8mgn/xl8K7BY7CJXDaFps4DfLLVN9tyEc+JZnQhLW0HYdovYh6UD3bwWRBIFmM/PqauIlZvu0vQGAgbiqx916ZKDA0ZiPp5tTa4AZPCHXevz2VX1HaiBBj7HaMoZyxbAW/bnQljPvuFogCzD4ArY7Jjfjbqw7XCO0ncsQ57RmEG9W6yly8nxFL3d1lkgHiE0ASG4ZmhETcVt+6zIpo94OC/wjBC19G29etpHDz1p9bAQp2UojNd8c7WtyTv5w1f4sdeQZTrLfteWZqV5ppyjAEbxEbwwo+iqO5P+/9jVD8gAzntXMBdtT5YZbvaywzq9/6HWr8N2qdhEpcBXdW1K4tu5MyPGr+2/mW7IVk8TTK/uFUvYWlbOt1yvXmzQ6FuhX0Wuw55+eZVMPJ40JkdBIkPj0PHZap2pkjU3lXrsQNs99ylmXPylyznWXqBGo7ramb11fGN4v/h3yMiAYO7utOiFfkEsf3+ZX7zrixJF+qYF9PwPsKXhVGdR7R2jf56Z1AojeL6zIFe8PH4u62DEz/Psy5WswRgdx1NAj8oclVeB2W1QxKiwlPK6krRBKU0BMgzZOT0Mzy2Uv9SSEfUla4i1VV3cKtwNMuDKXAbFp/3hOK/bYLtE+auMRJ6cXnTy8Qm3ctPR8LfFUf5CvBh5PRPHA3WzZ9auQvt6G21WXfEIFoXAjjCh+/o+OCw4gAoCm2cUPCu87UjuquS7s8PiVTEXX0wIjfi4w1qCziy1VQH4CgrX8lVM8IpU82wrZAgRaV9e9/Dk9qdJSGI5UTaF5H1wNXot0WhbOWBOO55hqbPuUSJEVg9jICEOuNIRdElprzB2Z7wiFcwMCpwjnRDZl4FE7qOc3EMj0hww3BO6ZG+BxYPh9yhBgBS/1E7RKD IRd58A1y /Qh8HdCq86rVn4iosLD2ydFh3GxGT9n/lGcCzmq1FK7zvRU1EvA5UiZNA5estctGCwrGJAk0Ffs1d0/DKGbfKEyW2N7Ckl2hwdnWjJGW+0NFkAIdmHS3mv32rDaDnEjR9t5NXjyMgFxn4efrNckMbPV2L+YoeqvejZ1x+qJuo92xnCttDS5468LXUERMrmk14W68Y X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 10.01.23 01:51, SeongJae Park wrote: > The standard idiom for getting head page of a given folio is > '&folio->page', but some are wrongly using 'folio_page(folio, 0)' for > the purpose. Fix those to use the idiom. > > Suggested-by: Matthew Wilcox > Signed-off-by: SeongJae Park > --- > mm/slab.c | 4 ++-- > mm/slub.c | 2 +- > 2 files changed, 3 insertions(+), 3 deletions(-) > > diff --git a/mm/slab.c b/mm/slab.c > index b77be9c6d6b1..a5398676dc60 100644 > --- a/mm/slab.c > +++ b/mm/slab.c > @@ -1389,7 +1389,7 @@ static void kmem_freepages(struct kmem_cache *cachep, struct slab *slab) > > BUG_ON(!folio_test_slab(folio)); > __slab_clear_pfmemalloc(slab); > - page_mapcount_reset(folio_page(folio, 0)); > + page_mapcount_reset(&folio->page); > folio->mapping = NULL; > /* Make the mapping reset visible before clearing the flag */ > smp_wmb(); > @@ -1398,7 +1398,7 @@ static void kmem_freepages(struct kmem_cache *cachep, struct slab *slab) > if (current->reclaim_state) > current->reclaim_state->reclaimed_slab += 1 << order; > unaccount_slab(slab, order, cachep); > - __free_pages(folio_page(folio, 0), order); > + __free_pages(&folio->page, order); > } > > static void kmem_rcu_free(struct rcu_head *head) > diff --git a/mm/slub.c b/mm/slub.c > index 67020074ecb4..d5f20c062004 100644 > --- a/mm/slub.c > +++ b/mm/slub.c > @@ -2066,7 +2066,7 @@ static void __free_slab(struct kmem_cache *s, struct slab *slab) > if (current->reclaim_state) > current->reclaim_state->reclaimed_slab += pages; > unaccount_slab(slab, order, s); > - __free_pages(folio_page(folio, 0), order); > + __free_pages(&folio->page, order); > } > > static void rcu_free_slab(struct rcu_head *h) Reviewed-by: David Hildenbrand -- Thanks, David / dhildenb