From: Jaewon Kim <jaewon31.kim@samsung.com>
To: robh+dt@kernel.org, m.szyprowski@samsung.com
Cc: r64343@freescale.com, grant.likely@linaro.org,
linux-kernel@vger.kernel.org, linux-mm@kvack.org,
jaewon31.kim@gmail.com
Subject: Re: Re: [RESEND][PATCH] drivers: of: of_reserved_mem: fixup the CMA alignment not to affect dma-coherent
Date: Tue, 31 May 2016 17:45:15 +0900 [thread overview]
Message-ID: <574D4F1B.4000702@samsung.com> (raw)
>Hello,
>
>
>On 2016-05-25 16:38, Rob Herring wrote:
>> On Tue, May 24, 2016 at 11:29 PM, Jaewon Kim <jaewon31.kim@samsung.com> wrote:
>>> From: Jaewon <jaewon31.kim@samsung.com>
>>>
>>> There was an alignment mismatch issue for CMA and it was fixed by
>>> commit 1cc8e3458b51 ("drivers: of: of_reserved_mem: fixup the alignment with CMA setup").
>>> However the way of the commit considers not only dma-contiguous(CMA) but also
>>> dma-coherent which has no that requirement.
>>>
>>> This patch checks more to distinguish dma-contiguous(CMA) from dma-coherent.
>>>
>>> Signed-off-by: Jaewon Kim <jaewon31.kim@samsung.com>
>> I suppose this needs to go to stable? If so, adding the stable tag and
>> kernel version would be nice so I don't have to.
Hello
In my opinion, this patch is not that critical.
Commit 1cc8e3458b51 might move unaligned(pageblock size) dma-coherent region.
And this patch will move the region back to different address which is aligned less than pageblock size.
But if you think it need to stable branch, please let me know how to add the stable tag.
>>
>>> ---
>>> drivers/of/of_reserved_mem.c | 5 ++++-
>>> 1 file changed, 4 insertions(+), 1 deletion(-)
>> I'm looking for an ack from Marek on this.
>
>Acked-by: Marek Szyprowski <m.szyprowski@samsung.com>
Thank you for your Ack
>
>Best regards
>--
>Marek Szyprowski, PhD
>Samsung R&D Institute Poland
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next reply other threads:[~2016-05-31 8:45 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-31 8:45 Jaewon Kim [this message]
2016-06-07 2:17 Jaewon Kim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=574D4F1B.4000702@samsung.com \
--to=jaewon31.kim@samsung.com \
--cc=grant.likely@linaro.org \
--cc=jaewon31.kim@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=m.szyprowski@samsung.com \
--cc=r64343@freescale.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox