From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id C381FE77188 for ; Fri, 10 Jan 2025 19:04:36 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 58E998D000C; Fri, 10 Jan 2025 14:04:36 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 53C6B8D0005; Fri, 10 Jan 2025 14:04:36 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 38FCA8D000C; Fri, 10 Jan 2025 14:04:36 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 1794B8D0005 for ; Fri, 10 Jan 2025 14:04:36 -0500 (EST) Received: from smtpin21.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id B2FA8A0E6D for ; Fri, 10 Jan 2025 19:04:35 +0000 (UTC) X-FDA: 82992468510.21.FC42441 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf21.hostedemail.com (Postfix) with ESMTP id 39F0D1C0008 for ; Fri, 10 Jan 2025 19:04:33 +0000 (UTC) Authentication-Results: imf21.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=AIPwKer+; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf21.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1736535873; a=rsa-sha256; cv=none; b=ThjqLYcP/mph274FqPuIkdhx4XVROHAdux/GHnbZCMyanwtPcSUBm7QJM597va7qiQnnH5 eYp/GE63z7VRF+5cvCOZ7xMtk6QpLU9NwodWs8c8GbBb+E4LFGERBjKDw/prKG9OFN937g iL+kQxIFi0tN7UbtirrMRUhWNIpRWr4= ARC-Authentication-Results: i=1; imf21.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=AIPwKer+; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf21.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1736535873; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=lEcv2bR+N+j2S9TKknwSTJbzoMGoKYdxh7ujApm/eO8=; b=LmD0G83v9g88P0BXUjnsTq9xFSBwBDoVKwP37KlCUYu0uHq/4Xj75TmkkB4SfvBKfpWhWp +RdFzNMvfV5FIaBKpbfSoUp9AJ4rYC7/CsGMbD87+O0O1PESMNmtlPQ5s7j9ZZ/sqlzgcb GjlLBDNjeBHT+R+/pxd5Bz0T0wCI+zM= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1736535872; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=lEcv2bR+N+j2S9TKknwSTJbzoMGoKYdxh7ujApm/eO8=; b=AIPwKer+AxjACzsJG+RV8vi/ligknu/Vk6MQSCs/MDUBI/Isvf8HNa46Kwq9UiXpuLupMX 5jBiT5u64y3x6FOhPNamxf/aXAHYWHjwFFbH7xzDbQa+kfaAbmUKNKL5MqNdA13VR8MsZh +DFRmmvtb+LeNNTI7Gfwy8YVmx7Aw7c= Received: from mail-wr1-f70.google.com (mail-wr1-f70.google.com [209.85.221.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-561-8w6jSd22NPS0XUR97wsryA-1; Fri, 10 Jan 2025 14:04:31 -0500 X-MC-Unique: 8w6jSd22NPS0XUR97wsryA-1 X-Mimecast-MFC-AGG-ID: 8w6jSd22NPS0XUR97wsryA Received: by mail-wr1-f70.google.com with SMTP id ffacd0b85a97d-38639b4f19cso1446068f8f.0 for ; Fri, 10 Jan 2025 11:04:31 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1736535870; x=1737140670; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:references:cc:to:from:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=lEcv2bR+N+j2S9TKknwSTJbzoMGoKYdxh7ujApm/eO8=; b=t8Ugg6VsUTXRjfUCnUPhvVEn6Uw5TCxjongQvCuB8r6mp9BPlvqUOjfCOpB7BY8v3J raKLHwswC3Tn9EMQcyUbn3AixItefrDN3H9rFMFfSsfXWQ5oQeh6U2LPcYjt8qOS3CEq E7qACUKfoX7hH0pwc9wtFigHbWOafBnZN4d/1BMCOQ7nPcbzKwwm2gKdSj+kEpsw+nNC 0oJFtmcU4hwz3d6qAKh0I5IAQ1jUFG4sJRKq26gayepkh66W3DAuBIdwd90XeBwbjVYL 3gTpA345EsNgdOkvl4OgNQSiUDF0ySHmStP3wuKkESzZLgcgmq0kb6b5pQVCH1N/8w4b zJMw== X-Forwarded-Encrypted: i=1; AJvYcCXpPlf2+TsIodn8dtOTzFOhvxXJbyCAB7Y4XCJS4LXgExId3TlDz7CQJpJfJ95icJ7HpHn9twONwg==@kvack.org X-Gm-Message-State: AOJu0Yx32N51KZ5r8pJPjxWOcbJyZlIXMJVUZsL/Y9gmXdE00+DfwTQN pUWZ956OhzNRZd/EaKSvzX9oEfKoKmetf8lNEF8XPsNXaBI4nKArVYXBxnDboGAv4izAKV5yE8q FZI4OVSz0lXCmSXDOx/voLJf8L6pPygeDjfHm7GNawVFW7s1t X-Gm-Gg: ASbGnctKNtU9GuSgu+lTR5lGZcBmQBXX0YYKKV4Y72I3JwvwXMNe4Q7mkqvS1e13FTO pZdKXBShuhdN60y/0aOZ+kG6FZCUpViQ4crLRguIjJyqrv7DrOJnNlp32NLkWnyczkqGxAbb5Yb sS3B1umMyr9M9teuseD86XzSfa5ASkaUm9WhiHNpKRMIqZV75LmXVIiF+k0XRxJaF9iPOCp7pwX wdTlpAI/rj7sCFYhbzhTZKJ/9EmZ7wOMmUurK4fRbycLdMJq/cBHJWDraq+a7L+Apj+3/wyupkZ YlgwRZj0himJvqVxgNDyWIiEY1UACwIVoN237oa1IWUkFDbP2/0iJMpFt8jQ4zPpPJjSM0zIxSI D/2dszx1O X-Received: by 2002:a5d:59ab:0:b0:385:eb7c:5d0f with SMTP id ffacd0b85a97d-38a8730db6cmr11780669f8f.26.1736535870278; Fri, 10 Jan 2025 11:04:30 -0800 (PST) X-Google-Smtp-Source: AGHT+IEAjPbn71WgoMpCR/3TohyUzS0V/cqWZ7isxGDm8Eu5gUHSRxh8H+ZYWPfYGEtoN3sAPxg/HA== X-Received: by 2002:a5d:59ab:0:b0:385:eb7c:5d0f with SMTP id ffacd0b85a97d-38a8730db6cmr11780642f8f.26.1736535869926; Fri, 10 Jan 2025 11:04:29 -0800 (PST) Received: from ?IPV6:2003:cb:c708:e100:4f41:ff29:a59f:8c7a? (p200300cbc708e1004f41ff29a59f8c7a.dip0.t-ipconnect.de. [2003:cb:c708:e100:4f41:ff29:a59f:8c7a]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-38a8e38378csm5206863f8f.25.2025.01.10.11.04.27 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 10 Jan 2025 11:04:28 -0800 (PST) Message-ID: <57447786-9184-427b-b5de-321784e946f5@redhat.com> Date: Fri, 10 Jan 2025 20:04:26 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH mm-unstable v1] mm/hugetlb_vmemmap: fix memory loads ordering From: David Hildenbrand To: Matthew Wilcox Cc: Yu Zhao , Andrew Morton , Mateusz Guzik , Muchun Song , linux-mm@kvack.org, linux-kernel@vger.kernel.org, Will Deacon References: <20250107043505.351925-1-yuzhao@google.com> <85ea0bc9-0892-489d-b42b-430ff8a1f368@redhat.com> <559ea5ca-fea2-4a0a-a099-23e2d972f6e6@redhat.com> Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <559ea5ca-fea2-4a0a-a099-23e2d972f6e6@redhat.com> X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: YXcO09Jz_UPBg-wOwRpX7k-guQzqgEJiJTzrZa8yU9g_1736535870 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspam-User: X-Rspamd-Server: rspam03 X-Rspamd-Queue-Id: 39F0D1C0008 X-Stat-Signature: 8731jx44dhtiy1tnpwyjxpina95j8nt8 X-HE-Tag: 1736535873-567917 X-HE-Meta: U2FsdGVkX18uZkzbqDU+8kfvf/gEHwJ9gNKCFRX8LEB1dVN4r3KX4YIJUa9SnvXgDM82zf+hg4ASghdWrT7blpH0D4HyXiQgNc9PKZMlmn3pT33Edg/25vUVCOgUmQmTf1Ah9DHEVlTD0MqSj43SEAD/NpjLOI7++StH4L7sKYXx8O747Qy/obPQhwRwX7HcMYiBQcfKRCloRIbpVgTbxnke2clCXq83O1xbiicfiq+p0r/D2AEYYAjukt3CceZqSDCWVo3Gg00NOnTayEyu5J0F+gI2Dv9p31BmM+YxhmuRySVHF1zbA51szsHpO/Wga2FSRGFq24T7hEDIGFSjFsce+ZAVS0ZNZ0cp2smBWM9LIunK91bcCnr2AMgbHC4SydfH4Aw/bL8Evk5xTXHxogBDj+VzLk/Bb7oh14fOc1fhC8HBI5KRGiqH+5mxZ9vdjbQ92qSclxLK5UcudTGWrgGer1xGXN6iH2vgRMyPJcuaCCRcrWHkD9AObv8Mv+2G8d0yalcp8/d57Ylxu1KhW/M3oqfvIqfRgVgebK9lbJe9AkFCB2cvewG1V8QrAD36JzW7ATFLURjVptXJZ8Udw2zpV9ov7kUPotj1mAy+0wttr8Xtmzf0TzbTQOL5ds84Uv0nBTh4EZch2ZqRkKMTBlU6NCfSO4gcG3Oy7HYl+e3Ib+Cf0errYUABDMGcM3f8lf2xaebu3pCGrJOrgedsza1fJ9RAGxIC0jjTp+UKUATWemTgj064LWygLiizZhrnp8yAMX6lByrCQMbP+n9E0l4WkrwnLK8OdN4ak6E9s8YjYfZGeeRFbCB6hkEdutzu0dh38OQuW3ngqGATOX/Zctwhxo/yldhbbGeGme90hJyLpC5WVKzUe9XIfWNrN+JSpdXIRubi+a6icvAbl9ODOVQjm8yHO/6x5Cr3WyxKPo/DC4H6wPYIMJZhOx/JwcgaPQ2PNIuiz7j6TCEmcwj 6QhjVP6c UT5HLr7uAEsYiIiNpNUkPTItsE9nWW/XjPuwhtvs77TzIdEd3qJAse6ZPs5a+ww4y/+0nXBdop1fsjAN0CVpP6X6SVHIzTcmdY/OgI/FxchHICfwhgSTEOYPVeAeocZsdOYyt4vFcAoYabobnVLrOnBP8d+njunXEvSP6oA2B82SgE7QBaClJ07o8IAnWRyTxPI21zYsk2XI9AWN7z9B70AscgziGIFdnQRa3dDnqkXw5RQqiUXvCUjA+S/RuHii517+3e2tbbh7FgZ0az4ssSHzkPzL6jrrnR7Z/xSCYTMNH3fPchdyJzJqMKH9tpA5NKKggRteGeuB6CeRmRGTmzpK/KQvoGqoSx01LpQtOxgIaDcN765qS0HY/oYlueLJ9O0i8nu8HRLRJzxpU31lzVd2/yVWr1Fi8IBBlKgjyjiCk53yxON9LexIY/oSpa+MmYgQf X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 07.01.25 18:02, David Hildenbrand wrote: > On 07.01.25 17:35, Matthew Wilcox wrote: >> On Tue, Jan 07, 2025 at 09:49:18AM +0100, David Hildenbrand wrote: >>>> +++ b/include/linux/page-flags.h >>>> @@ -212,7 +212,7 @@ static __always_inline const struct page *page_fixed_fake_head(const struct page >>>> * cold cacheline in some cases. >>>> */ >>>> if (IS_ALIGNED((unsigned long)page, PAGE_SIZE) && >>>> - test_bit(PG_head, &page->flags)) { >>>> + test_bit_acquire(PG_head, &page->flags)) { >>> >>> This change will affect all page_fixed_fake_head() users, like ordinary >>> PageTail even on !hugetlb. >> >> I've been looking at the callers of PageTail() because it's going to >> be a bit of a weird thing to be checking in the separate-page-and-folio >> world. Obviously we can implement it, but there's a bit of a "But why >> would you want to ask that question" question. >> >> Most current occurrences of PageTail() are in assertions of one form or >> another. Fair enough, not performance critical. >> >> make_device_exclusive_range() is a little weird; looks like it's trying >> to make sure that each folio is only made exclusive once, and ignore any >> partial folios which overlap the start of the area. > > I could have sworn we only support small folios here, but looks like > we do support large folios. > > IIUC, there is no way to identify reliably "this folio is device exclusive", > the only hint is "no mappings". The following might do: > > diff --git a/mm/rmap.c b/mm/rmap.c > index c6c4d4ea29a7e..1424d0a351a86 100644 > --- a/mm/rmap.c > +++ b/mm/rmap.c > @@ -2543,7 +2543,13 @@ int make_device_exclusive_range(struct mm_struct *mm, unsigned long start, > > for (i = 0; i < npages; i++, start += PAGE_SIZE) { > struct folio *folio = page_folio(pages[i]); > - if (PageTail(pages[i]) || !folio_trylock(folio)) { > + > + /* > + * If there are no mappings, either the folio is actually > + * unmapped or only device-exclusive swap entries point at > + * this folio. > + */ > + if (!folio_mapped(folio) || !folio_trylock(folio)) { > folio_put(folio); > pages[i] = NULL; > continue; I stared longer at this, and not sure if that will work. The PageTail() is in place because we return with the folio locked on success, so we won't trylock again on tail pages. But staring at page_make_device_exclusive_one(), I am not sure if it does what we want in all cases ... ... and the hmm selftests just keeps failing upstream as well?! huh. :) I'll try spending some time on this to see if I can grasp what needs to be done and how it could be handled ... better. -- Cheers, David / dhildenb