From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 69629C83F09 for ; Wed, 9 Jul 2025 12:41:58 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id F10FE6B00C1; Wed, 9 Jul 2025 08:41:57 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id EE89E6B00C4; Wed, 9 Jul 2025 08:41:57 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id DB0AD6B00C6; Wed, 9 Jul 2025 08:41:57 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id C0DEA6B00C1 for ; Wed, 9 Jul 2025 08:41:57 -0400 (EDT) Received: from smtpin24.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 5CB2D56CD0 for ; Wed, 9 Jul 2025 12:41:57 +0000 (UTC) X-FDA: 83644688274.24.2A25261 Received: from mx0b-00069f02.pphosted.com (mx0b-00069f02.pphosted.com [205.220.177.32]) by imf15.hostedemail.com (Postfix) with ESMTP id DFBD2A0003 for ; Wed, 9 Jul 2025 12:41:53 +0000 (UTC) Authentication-Results: imf15.hostedemail.com; dkim=pass header.d=oracle.com header.s=corp-2025-04-25 header.b=c4QmCaQF; dkim=pass header.d=oracle.onmicrosoft.com header.s=selector2-oracle-onmicrosoft-com header.b=pIb7jSa0; dmarc=pass (policy=reject) header.from=oracle.com; spf=pass (imf15.hostedemail.com: domain of lorenzo.stoakes@oracle.com designates 205.220.177.32 as permitted sender) smtp.mailfrom=lorenzo.stoakes@oracle.com; arc=pass ("microsoft.com:s=arcselector10001:i=1") ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1752064914; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=tUqwQz5L22WgPx4Vg3ptsLp3/mhHzo06PF/25ayZb8c=; b=U5EUJ/tYldGYU3gvb+sENWP3WA2vvi0YYgjV/KUILKSxhH9jWI2aX0WYLptAe4e/sO9cyF WsTU4iGYVUa5zaoFZlcpc6qUXyLyEunhGq7DdRGSHPv46XgQLBNlaYOC5oxJNwTc142T2+ hGJvbDMCqY/QGbWYdHQiUYmSThlUNWA= ARC-Seal: i=2; s=arc-20220608; d=hostedemail.com; t=1752064914; a=rsa-sha256; cv=pass; b=79o+XU7kIU6xkyKX8Y5nCgBkKU0DDd15FHLB4zMuKNNY+SzpIdPmtRrlIsQ4VT84Sfwv3P rxvO0Vft0nK5I/PruwcskObf0aFA3beZ7Xa85Y9huRKmNYUWJm4CWMkAVG7krhv65NGryt TCDLRHOo5s0FKuiFl948CZhRjjh/01M= ARC-Authentication-Results: i=2; imf15.hostedemail.com; dkim=pass header.d=oracle.com header.s=corp-2025-04-25 header.b=c4QmCaQF; dkim=pass header.d=oracle.onmicrosoft.com header.s=selector2-oracle-onmicrosoft-com header.b=pIb7jSa0; dmarc=pass (policy=reject) header.from=oracle.com; spf=pass (imf15.hostedemail.com: domain of lorenzo.stoakes@oracle.com designates 205.220.177.32 as permitted sender) smtp.mailfrom=lorenzo.stoakes@oracle.com; arc=pass ("microsoft.com:s=arcselector10001:i=1") Received: from pps.filterd (m0246630.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 569A20rS012744; Wed, 9 Jul 2025 12:41:47 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=cc :content-type:date:from:in-reply-to:message-id:mime-version :references:subject:to; s=corp-2025-04-25; bh=tUqwQz5L22WgPx4Vg3 ptsLp3/mhHzo06PF/25ayZb8c=; b=c4QmCaQFnr7G5eM7+1YgbCjo2cPGaZwDC6 EjbjA/g7vaHvcGK9cNoHjkoG2bwZfLF5TNhM1llkNxOWZMIPYlBOa8tVPzZp8mhl QRgjWJvwaffkYkG6aHs1aT3e5ityZ/TYl+8pOlaH9hH8KVPLA2DgoeJ9dvedKjAK gvTZ/TQ7rkSH1Wbks8Oti5sZqFDFPripXXsvFLPfCL1orDmDqULrYeg0a/PZqd4B R9wcQPQVwPqsX/Z9rrkZLREy5Aij7K1Ub9F4EtJRsTyeXfd+44ya7jzoNx/7HRsU VNa3V5jyWB7reA8PF0PSuQ35vPrhwascQXmI8w06nxmykuh9GYvA== Received: from phxpaimrmta02.imrmtpd1.prodappphxaev1.oraclevcn.com (phxpaimrmta02.appoci.oracle.com [147.154.114.232]) by mx0b-00069f02.pphosted.com (PPS) with ESMTPS id 47spadr8d5-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 09 Jul 2025 12:41:47 +0000 (GMT) Received: from pps.filterd (phxpaimrmta02.imrmtpd1.prodappphxaev1.oraclevcn.com [127.0.0.1]) by phxpaimrmta02.imrmtpd1.prodappphxaev1.oraclevcn.com (8.18.1.2/8.18.1.2) with ESMTP id 569AUwAl021551; Wed, 9 Jul 2025 12:36:46 GMT Received: from nam12-dm6-obe.outbound.protection.outlook.com (mail-dm6nam12on2076.outbound.protection.outlook.com [40.107.243.76]) by phxpaimrmta02.imrmtpd1.prodappphxaev1.oraclevcn.com (PPS) with ESMTPS id 47ptgawcv3-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 09 Jul 2025 12:36:46 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=e28YZLSQDqWRCE9VYQ7vOpoDpRZ3YXIxjUWbOpKg8e3SziNQudky8cdkJz6y+gk+4XnU9tDb+dtYNJ/k6VqmnRIj23ybSgTmuccFGoeSALQM6/L5QgmB0IpNIFOFyRI0OQcAY5C7WutuBWCs9A82m9RdJOdbcWsy/xV1KCuoQZRirR2vD862D1Zm89KAyQzID0uTNAT/KNc6iucxjqdQ8zyOICFxwVL7UiJC4xIcBOnb2ti1SkjfdBrkGJ6Zuxl9xvOq8ZVYrS/YhIWzoBsVBXwRkPSKq7VybA6Is7JUkEnI0n4crY3upUdEzOdweaP2439xvcBncJGqEaPqpZ5RFQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=tUqwQz5L22WgPx4Vg3ptsLp3/mhHzo06PF/25ayZb8c=; b=fP2Ea6mCAynZVYHmNyzVJHJDqWzYTyCZwkQ+2VcpPACtcWoX0fxmlqVpgRvivRW32zPbGORA2/ur5/j17KpuWnBJk/8knoSu56xYEA/acaYkdKRB2mrZIVdKGAiMwbqUbGbbQTX1Ytc9LhD/kzB48assD7yaW1ENJmggvs8LE6Eo9fRi4Kk2j5yLgzMycg/us0b0WbSXV9V3QOUQ9dGEIjy01QAlst0o9Ml9cuK6kJ1g7vhd6gaRjVhzJKC28sVYreSbKd2I+prNg2olVbfBUfaRC4NiYtsdULBkBt1rM45l0hYKdu8oohfHPYMdqgjW+mUNTY9+q45Ulyh+i2z2Ww== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=tUqwQz5L22WgPx4Vg3ptsLp3/mhHzo06PF/25ayZb8c=; b=pIb7jSa0kJY0fIGS+YLBTmxQKtUctp9A/gLSjkTtkDkrPc5YBwoMfcqxqDSkU2u8gIsG26s46BusAp5btAjErmH9KCD1DK63xLOvj1pp4IaLTdwZeecUSmh1rurqteNJ29t7NTkK+Yd+G58REEqiRJcddmaEKpDFc4PW0miS2zc= Received: from DM4PR10MB8218.namprd10.prod.outlook.com (2603:10b6:8:1cc::16) by SJ0PR10MB4494.namprd10.prod.outlook.com (2603:10b6:a03:2d4::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8901.28; Wed, 9 Jul 2025 12:36:42 +0000 Received: from DM4PR10MB8218.namprd10.prod.outlook.com ([fe80::2650:55cf:2816:5f2]) by DM4PR10MB8218.namprd10.prod.outlook.com ([fe80::2650:55cf:2816:5f2%6]) with mapi id 15.20.8901.024; Wed, 9 Jul 2025 12:36:42 +0000 Date: Wed, 9 Jul 2025 13:36:40 +0100 From: Lorenzo Stoakes To: Baolin Wang Cc: akpm@linux-foundation.org, hughd@google.com, david@redhat.com, ziy@nvidia.com, Liam.Howlett@oracle.com, npache@redhat.com, ryan.roberts@arm.com, dev.jain@arm.com, baohua@kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, Pedro Falcato Subject: Re: [PATCH v4 0/2] fix MADV_COLLAPSE issue if THP settings are disabled Message-ID: <573eb43a-8536-4206-a7c6-d0daa1fd7e70@lucifer.local> References: Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-ClientProxiedBy: LO4P123CA0508.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:272::10) To DM4PR10MB8218.namprd10.prod.outlook.com (2603:10b6:8:1cc::16) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DM4PR10MB8218:EE_|SJ0PR10MB4494:EE_ X-MS-Office365-Filtering-Correlation-Id: 43b8a08f-b89a-4aff-4a69-08ddbee54211 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|366016|7416014|376014|1800799024; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?rGmnINiKyN0k7NM7I1ua0+NWVz0GRaYSDWfxvnfborCGs7y39TRR/4cXO2zk?= =?us-ascii?Q?enQchuWJ/kRNnd1y9stleDDSXXVfeObnACpz5e9RhEj6BIDgfiy/RBxi1GWR?= =?us-ascii?Q?ChJ+vFgUta1EBn2oYWTz3OkEeFdjyk22+zeRlIkbNY7uBbaGtvrpiOiImrym?= =?us-ascii?Q?VlopRrZ5q63uPpvo5EkStMxg5N0KeFFn/1S6XIteU/727qbANu4WcVLPtZnn?= =?us-ascii?Q?+BWtc0u/IKOAbqHP9Ly4mzV2ceVlDaZ8rWiiz7v1Iz2Jji2VFUthPXvsN1+r?= =?us-ascii?Q?AA+LPuHyCc98VC7QGU7/jKfwXTOCq+Ahm9yeuiMJyO/Qq45PyQoj4YXkYw5K?= =?us-ascii?Q?hkn2IfMfEtPr/1QkjBBZbXruM/l04WGOFpuux2J3PLzVv5bXc7I73hy/IZfe?= =?us-ascii?Q?7BTV0+DU3ntEJUDguvo2Ogoat6klQybFEq6787TQBC4VEDe5FA16v1gKuSWS?= =?us-ascii?Q?3hht6/PkcV94LAMyGVXC7qIZmrPNwePwD/QyCW3nvbcenG5Ms8kE7Fi14lCP?= =?us-ascii?Q?1Xaw7krGn7c04CvnZva7bczr3Qc/AKNK9EDGimC3BcGMx0Ll87Wr7hgHAE7/?= =?us-ascii?Q?vBsYKGj30EBMOZ8XsdOg6SYI7fuEmcpI6Cxj8iJ7FbWhdC7NniN0RATVFkr7?= =?us-ascii?Q?LBoVwDBqBB3IsQl3dhpZ4T/BZdnxSlhvnk3jjwTWIyGQEVypIiD/amzOr4sX?= =?us-ascii?Q?1M4Mdifv9kc9nqiYfsyv+ZfcrKmqRylyoWjca7vI/JyspL0j0UhKQYibZ4Kk?= =?us-ascii?Q?CqeXtZ3mUyZ+sIFIdRQH/nu7bIi1OpGHZlm0QpTCDRXkpntksroGVDM5wfFi?= =?us-ascii?Q?ZH1XCW+GNwhALXeGwEX6IDQnHPJYtegWSZd93BV8oQ3EzpJK5fRkezGBZnxW?= =?us-ascii?Q?AqFtBV/1zqmr/+AyBxfFClruDROKIXoquuJTGToyzmklPpqUxCVXkzI9g+vu?= =?us-ascii?Q?mS9keO20fcfn1w/+gUAej/lgo2HEFdjIBgorgdH04EmJyiPlxXreYqZkl5L3?= =?us-ascii?Q?aZzHunkoHYloQnP7R1JKVNtF9zC6jRPyxcyAuNBscGWQT31Y57M1jTRHbn/l?= =?us-ascii?Q?n5rqz4czdul1nB5MYtxpj9GXxbxofwrzAXJNfFFwrSFSFC3oFenkLfXDclfY?= =?us-ascii?Q?N5ieABmTVZPahKqIJ+wi+A76fFbUUTDn1HEjVhMtkvgLRUdAInQrUfQQQSge?= =?us-ascii?Q?rxWOIlJPfzK0s2xFzBTMb9Okl0QdzLcusGnckQzKqxNGKWwUXSVtVn9J7tn+?= =?us-ascii?Q?9GLZ57xm50vJ7O0+8TYLg5aBXVxC2IVOwvnTCAsE880WClHikcVtUuUKltDO?= =?us-ascii?Q?BRXTM6z6i6v7ytVNFfO650jwOh3Z075ifXA+6KEhGbKFs3wcnlNX+NukxC6t?= =?us-ascii?Q?C0ZkUJbBOwSNOi+IzPELNzRzD9fj6PFMEtsc1tFz4Z3Qrt0mh97ie78J4DlB?= =?us-ascii?Q?AYxEWj7U1to=3D?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DM4PR10MB8218.namprd10.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(366016)(7416014)(376014)(1800799024);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?tmGTE6Abz7RsCkZIplSUiHwEcHRJGiv6FZGE+bup81HYbHc5eHJ5hEHf/2ZN?= =?us-ascii?Q?0lqgfmPI+J2egRuqPZ45ibpYjYmAakedCsruDH6iaBxwD/zv4G2ydv/orkjg?= =?us-ascii?Q?bEoTc0g52lNZNgy4Ui4uCTUwsLZNITzGwMKErZv62kuCLvZn/afybjjejKDR?= =?us-ascii?Q?4TYnGcVddMOCbAsrRGCQoNbhAlTHCCGV0heeH0vpSAJCdY4f3dfXLgqV7zjg?= =?us-ascii?Q?rvI4k+pHMqYXOymoOvP3z4I8ay3+VC1cMKlhJdXRaP6wpAXx0gr3I4la6KHT?= =?us-ascii?Q?P45wEwDsiqYRT0RiNe1Eocf5jblo9f5oW6TpWvFt+bdhpWQRL7ZR/frW4j0e?= =?us-ascii?Q?yRtXCfIjqHgRNTdxFg6euiIDiFAOgY2cMbUnf2gZbccX2nil5YXW8RDRo6Iz?= =?us-ascii?Q?r/Ank5S83aPAD8cKawumm3L375MDCk2QHgCx4oMFBUdBUypvVLPDw6K4H2ye?= =?us-ascii?Q?dmwIA4orbIcYrqs2AQefiEkbFkjsaXw36s6oHVoIMb/Zxv5sv+GflmEEpXU0?= =?us-ascii?Q?f/5phT7dGT2vUEGeJgYMTIkbiWOpjjkbUwJ2Fxh0TFqWLM4OlwaVPQjkDYLD?= =?us-ascii?Q?TLAb0pAxhU7FKl3tdn8M1zkZyN1c2fl4SDtqw62Ft1gBgPoqtFQnlnYzJd5r?= =?us-ascii?Q?9ySm3vNDFtHLGtU173gglhs4XLCPDWO9M6QV0iIuQAT9bZbmO8MGfjNj6jQD?= =?us-ascii?Q?vKkXoYbbe40cjbTiXgdXPctP/L0gVWtfEjlOIopPWIbfx/i08ifXbNZAXkS5?= =?us-ascii?Q?nhRAKIAcvzymIWkFj2xYaUhaNNSXiTkSzah8P5UhlQmD+98yYTreO2zwHWHy?= =?us-ascii?Q?jTINYyJ+q4sVV93/tQUNE1+t/gqUqzgTXe/h6Rrtee9Ij8wq3k1dacfwdD8P?= =?us-ascii?Q?ur8BEp3DO61A8VduGuHNBL8ClYvWrhoMHwuhODO88M4pO0c5d7KmWEcBSVGK?= =?us-ascii?Q?0kNZjBQ5hh5sjobiMieaqKa+WW/JZejo8R7p1mMkFSh0HBr9f+cWxsql740h?= =?us-ascii?Q?4XctJDatGVChIuK3COelhXTrZUuUVape+6fXIVkxsuqrZqAp/yYYBu0kCgwT?= =?us-ascii?Q?81EcmH2JVWumE7D6WDCb7nmdQLunZYykOuCrZOdktZrWAYtnt6qx+5OzOnCU?= =?us-ascii?Q?PRMWK+xy0kWFrwvEFkcclBQc9cA8wMxZiWoDD7H+yfFaZtA0zkIb0+X2ZJXw?= =?us-ascii?Q?VjgyPrOdbTI2xlShEernHaTAZ94pXmOr4KFA40Aa4S974dMVTjj1nzxXwzZV?= =?us-ascii?Q?x4rs09q12S8B409UhenC2VEWwVgGBPXTaX+jLkN0tjGVwA+XaYBs9Ay9rqBa?= =?us-ascii?Q?/Lih2IHK/pTHeYDvLj6UwqYAGN1nR7PNZIh5mJyIiFZMTg/X5CVfZKbgZHcM?= =?us-ascii?Q?mraP/6YS2sawlUoH3xriKX8CE/xBMcVa8CiRupDNTdwk+FgtOST7q74joo6Y?= =?us-ascii?Q?Q17oDgVyN98SQV0jwsks/ghzrJ/pvjguHokluWm0SAj1bZ1omzg2IW8qmxiX?= =?us-ascii?Q?NyrQ4E2IW5sbaLT0JudrWxC4hrE9fGJnqG9yZizWDW9ltE5861XSukUqnRI+?= =?us-ascii?Q?X2SG9McJ5H65EPT/U+lINYobp+0DM3fj6HD8/7ggtsFu6UwWNzk2jIAcdDQ2?= =?us-ascii?Q?Zg=3D=3D?= X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: 29qTmbqPY8c2yiSryxcSpXbdqSGFXsILlGipZSI6j4Nh13TD+TeWttJCLRCM//qsSt6DdWvULQk1X6zKGJD0upiSNy0uy3zrFIg4ity2sF1lob4MroA0MvbAZhkV/WzoTlpAO5ruUyeo4D6Ge5WMRcg8XGIsI5HOjNS55aT2Una76FxOKTysOWcM9oin29icLJ87cQbUkqgPwFzvolUppX4xoUEpRMQb/D9cuznYBxNJZDYkoDOFPJR0tlM2BVwNXK06zUlavudc3rdE9sYHLSCf6wURJvuAoQU84iRflFcQbHke+sOAbZ3HGJiGN4WLHnAuHclvgrXorVQbQspEYvceLWPAb9r26Wn6mNIdBkvqYvIkqYQtmS5ZdlyQXQzCifLPB1RbhiCIIk9eUav2VvJWcmMrWFr1Ot2rsRPbImpkL0Apd9IRr73KUYCHSaRMs2oNRt5UXtx7Q4oSXtCXtdo9TGErJgFi9SSkLNR4GWu9AoiR50NfpMs5D35ZBFTVge0JfsSBTXLeh2moG5vkx4MzWvoKmTdP8+LMha1qUHGotnb9ubEarFFgyPN3oPoxxLjo4rVYQe8IVUJhG7yHjy7DFLES9QxvE3wwo5vJu9g= X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-Network-Message-Id: 43b8a08f-b89a-4aff-4a69-08ddbee54211 X-MS-Exchange-CrossTenant-AuthSource: DM4PR10MB8218.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Jul 2025 12:36:42.2698 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: bCJ8n0aGl4ScjtrqTiTekNiWOniUZb4JIBgGZvAkgnGXUOLlISfeGFFEPWiNPNRL4rDw2kskZASH7cDqH8ZgEiVYKOTRMGgF9hMtJzCFiJw= X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR10MB4494 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1099,Hydra:6.1.7,FMLib:17.12.80.40 definitions=2025-07-09_02,2025-07-08_01,2025-03-28_01 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 spamscore=0 adultscore=0 suspectscore=0 mlxlogscore=999 phishscore=0 malwarescore=0 mlxscore=0 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2505160000 definitions=main-2507090113 X-Proofpoint-ORIG-GUID: P95CiKB7grUXyAK2Bln24zh99LF5GTxH X-Authority-Analysis: v=2.4 cv=caXSrmDM c=1 sm=1 tr=0 ts=686e638b cx=c_pps a=OOZaFjgC48PWsiFpTAqLcw==:117 a=OOZaFjgC48PWsiFpTAqLcw==:17 a=6eWqkTHjU83fiwn7nKZWdM+Sl24=:19 a=lCpzRmAYbLLaTzLvsPZ7Mbvzbb8=:19 a=wKuvFiaSGQ0qltdbU6+NXLB8nM8=:19 a=Ol13hO9ccFRV9qXi2t6ftBPywas=:19 a=xqWC_Br6kY4A:10 a=kj9zAlcOel0A:10 a=Wb1JkmetP80A:10 a=GoEa3M9JfhUA:10 a=VwQbUJbxAAAA:8 a=SRrdq9N9AAAA:8 a=WJxuc7IjJ3eoLCQNQEsA:9 a=CjuIK1q_8ugA:10 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUwNzA5MDExNCBTYWx0ZWRfX9+w61xQE/XFS EoKHwleIWfjP9caRIq0LG9D826N7+5esKTFJSFJ647V13vNGk1KhdHk0Xg+FClCZ9Z6/OnNcfZY T5ZIzSZWdPtGbn42uHsDn0FgYjZmTMJ71WNR5doZ1rE4U11ut+whR+mVmjS2PMRlVdxkNFaD9OS M0qB52ViUgsoRQxfYv1XobOpaNJ8TFFIureXnHjGn+yx/9ViLv4XrAp6CvI5FYH+hBD6dC9kOk3 JgNeJDIQ8m3y8lOZ/7nSMDgeGGm3gEmnYZuvkcvtHHJDcLhgFbi8rAURgx3NzNCbIwpme650Rl/ uRGNYnx6dv5NeQQxABJJn+laPGPXRY41BpgQkoxL4+Salnrj61zeHXwhheHuKo2UP90IyrO0XH9 0yM7DOs1A4e1RBkUzfLPspSmF8J0OsjD4Hp8p8wmvl9pkYNeNkxjY8JlaKIm1uSf/vReOkm3 X-Proofpoint-GUID: P95CiKB7grUXyAK2Bln24zh99LF5GTxH X-Rspam-User: X-Rspamd-Queue-Id: DFBD2A0003 X-Rspamd-Server: rspam03 X-Stat-Signature: 8wxsrnjbcguo1imup6otuhfb7pmtnroe X-HE-Tag: 1752064913-235689 X-HE-Meta: U2FsdGVkX18C93buCkaBP9McpKdf+9qlwBG5mC25AnkNf0AmimWAAiouVYMok2Y53nP3KXutH1XwpLC71iJcxV8GJ/l0jlBMImfYAH5SwfNm1xyztpResadjRIEhTx6ADRG0FOEeg4XOJfmVTkMfQ6uxKDR6CHF2gsMoV6byJMh2SYNO7/6HnPmduigJygvQv0kHOebHIRntXcZ3EeK5z3jjEN4SEc4vMSIKthLl3JXMlqGWC0kd2LvXVSyU4/CSlAIfRYaGjY/S2flcmqaQa2yyWOIOKW4eifDxo93HkngSx4trhfm89l6I/HjxEeiPnbPcEe+/nDPsIQbcLF/UuM/zWpyXY2gULYyDo5cSqM5hPAJZHxoi1fOcfuOb/FG4vYqNvJRHWQAbYyez/cm/KpsnS2YI7piZ0kfJXwkL4SbnLCG++tdPNzROuc5NO+pVRICjqQ3/p5gvioO05Mvw395r2+ojRUqKVdQmkl2iCzbrsNrryVEbkPNypYMmWXeG2Eh7/LS6na7KVBI/ie26rjuctHPhgnQuwAQ/rAndam5nH18TaXcgaOK/yl/BcimRvDsc6vP+wd8Qo/CwJgITSBoH5IWjrT76I+UKSP8MA5bwR25V/XDcCbUaQRETo3vYceOPVlvB1ydqsEgeyiEpM2VSGdGj+PzKaPcK8uL7b9tmoerJ5btcSlQFcANe0o0JbJR6TpKTfdymz3y99k/dtIK36tgiATKDOweSNshmEJVybr0xnXN7UC6T51yQW6H8AZl6bGd/3P+fPx/qsyULxvIjyRlaqWa2PEgev++giwJc02Yy9+zZSJXruWs+UJt+VYbbVAjK85+nrwbDL4BzqGPuvJo3rYqvbRrBQwOkEBWpWSP3RyfM8oJNqg5TeicSJ5M+kY7SXtIQK/lqOkIvHBUM24oJUQhzPnFfDoQhK64QS2Yu+PPjtR81wE5MXTS2g/YNO3hKDWUDTnv94CD 21gwsl3v Y18eAFEg5AT50NSXgPqYKfsg31XkZv2R9c6CRQbEjecndgYllh3qmzaccGvyVFe2Cf5+/ShHXBlPgy4AXh5KjhpcT+f8DK6awNTyO3IkFuOmcagxgzGgfB7cNbLBR2XhASU6AYSHA9zmEC8eoNd6sqHJB3EUxizFGillBb+ZanAu+dKBUeDEQ+LQJj0iwqO+IvXaT7E8p6mzQbZDo1CXLYUYmDQERG7fb7edyJtfNog0Ex2PF5tVIlyXxv4/e2tkE4qbPDpIIPX4FUDI/MA2J9jYFx8VkPgFoCp0QGqiBYMcODpePr/wfApCx80D28VGvF+HdsFZjcQV7fjQIFMlOpRSXCp9SjNz0moVRJR3l6t1DctceEWwhM0XvF2qAS42cXKhTB5CLLrlLWU7NYlAQ3sSr11TUkeNNTxW0/5/YyQKaRwUsuGZ+0ymK5tAWbdniygK2EayOmkBBj5fNrECodqAdaiaIQVAXAh/UacagrZEXjBFvvPNXLAJGZuwbJO6nm+x1z1hZN/I2vGzKL4kOFTy3IgW0ZN2Qy+U4buIMzcJjgcDIX4vy7eqSTjXXD7tHD6zYSh2PDEE96cBLAI4P4vQSKhfRLEusM4DLufqUF6JuZW3IRWilr5v6/th82cE/Lp+y880sotDjKVAVSuuu/hQ3g7MU/rw1ZjwTjzYHI10vIYBfVmag4mkZVY5ihbbvbBDTw/r3BLGPm8mRJbpW6Tw9XRWvrKKnK6LO X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: +cc Pedro as he'd raised concerns here also. Hi Baolin, Just for some clarification on this - thank you very much for this series, but based on discussion with David and concerns raised by Hugh + others, overall it feels as if, while the documentation is no doubt vague in ways it ought not to be, this behaviour is something we have put out into the world and we should continue to support it. So overall I feel that this series should not be applied. Your work here is great, and really massive apologies for this after all the work you've put in (and of course the review work here also), but on reflection I think it's a risk we shouldn't take. I understand this means that MADV_COLLAPSE can't be used to collapse at a mTHP granularity - we definitely need to have a think about how we might provide this sensibly. As for how to move forward - I will go ahead and update documentation to make the situation absolutely crystal clear, both in the man page and the rst. Thanks, Lorenzo On Wed, Jun 25, 2025 at 09:40:08AM +0800, Baolin Wang wrote: > When invoking thp_vma_allowable_orders(), if the TVA_ENFORCE_SYSFS flag is not > specified, we will ignore the THP sysfs settings. Whilst it makes sense for the > callers who do not specify this flag, it creates a odd and surprising situation > where a sysadmin specifying 'never' for all THP sizes still observing THP pages > being allocated and used on the system. And the MADV_COLLAPSE is an example of > such a case, that means it will not set TVA_ENFORCE_SYSFS when calling > thp_vma_allowable_orders(). > > As we discussed in the previous thread [1], the MADV_COLLAPSE will ignore > the system-wide anon/shmem THP sysfs settings, which means that even though > we have disabled the anon/shmem THP configuration, MADV_COLLAPSE will still > attempt to collapse into a anon/shmem THP. This violates the rule we have > agreed upon: never means never. > > For example, system administrators who disabled THP everywhere must indeed very > much not want THP to be used for whatever reason - having individual programs > being able to quietly override this is very surprising and likely to cause headaches > for those who desire this not to happen on their systems. > > This patch set will address the MADV_COLLAPSE issue. > > Test > ==== > 1. Tested the mm selftests and found no regressions. > 2. With toggling different Anon mTHP settings, the allocation and madvise collapse for > anonymous pages work well. > 3. With toggling different shmem mTHP settings, the allocation and madvise collapse for > shmem work well. > 4. Tested the large order allocation for tmpfs, and works as expected. > > [1] https://lore.kernel.org/all/1f00fdc3-a3a3-464b-8565-4c1b23d34f8d@linux.alibaba.com/ > > Changes from v3: > - Collect reviewed tags. Thanks. > - Update the commit message, per David. > > Changes from v2: > - Update the commit message and cover letter, per Lorenzo. Thanks. > - Simplify the logic in thp_vma_allowable_orders(), per Lorenzo and David. Thanks. > > Changes from v1: > - Update the commit message, per Zi. > - Add Zi's reviewed tag. Thanks. > - Update the shmem logic. > > Baolin Wang (2): > mm: huge_memory: disallow hugepages if the system-wide THP sysfs > settings are disabled > mm: shmem: disallow hugepages if the system-wide shmem THP sysfs > settings are disabled > > include/linux/huge_mm.h | 51 ++++++++++++++++++------- > mm/shmem.c | 6 +-- > tools/testing/selftests/mm/khugepaged.c | 8 +--- > 3 files changed, 43 insertions(+), 22 deletions(-) > > -- > 2.43.5 >