linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: andrey.konovalov@linux.dev
To: Marco Elver <elver@google.com>, Alexander Potapenko <glider@google.com>
Cc: Andrey Konovalov <andreyknvl@gmail.com>,
	Dmitry Vyukov <dvyukov@google.com>,
	Andrey Ryabinin <ryabinin.a.a@gmail.com>,
	kasan-dev@googlegroups.com, Evgenii Stepanov <eugenis@google.com>,
	Andrew Morton <akpm@linux-foundation.org>,
	linux-mm@kvack.org, linux-kernel@vger.kernel.org,
	Andrey Konovalov <andreyknvl@google.com>
Subject: [PATCH RFC 07/20] kasan: introduce kasan_mempool_unpoison_pages
Date: Mon,  6 Nov 2023 21:10:16 +0100	[thread overview]
Message-ID: <573ab13b08f2e13d8add349c3a3900bcb7d79680.1699297309.git.andreyknvl@google.com> (raw)
In-Reply-To: <cover.1699297309.git.andreyknvl@google.com>

From: Andrey Konovalov <andreyknvl@google.com>

Introduce and document a new kasan_mempool_unpoison_pages hook to be used
by the mempool code instead of kasan_unpoison_pages.

This hook is not functionally different from kasan_unpoison_pages, but
using it improves the mempool code readability.

Signed-off-by: Andrey Konovalov <andreyknvl@google.com>
---
 include/linux/kasan.h | 25 +++++++++++++++++++++++++
 mm/kasan/common.c     |  6 ++++++
 2 files changed, 31 insertions(+)

diff --git a/include/linux/kasan.h b/include/linux/kasan.h
index de2a695ad34d..f8ebde384bd7 100644
--- a/include/linux/kasan.h
+++ b/include/linux/kasan.h
@@ -225,6 +225,9 @@ bool __kasan_mempool_poison_pages(struct page *page, unsigned int order,
  * This function is similar to kasan_mempool_poison_object() but operates on
  * page allocations.
  *
+ * Before the poisoned allocation can be reused, it must be unpoisoned via
+ * kasan_mempool_unpoison_pages().
+ *
  * Return: true if the allocation can be safely reused; false otherwise.
  */
 static __always_inline bool kasan_mempool_poison_pages(struct page *page,
@@ -235,6 +238,27 @@ static __always_inline bool kasan_mempool_poison_pages(struct page *page,
 	return true;
 }
 
+void __kasan_mempool_unpoison_pages(struct page *page, unsigned int order,
+				    unsigned long ip);
+/**
+ * kasan_mempool_unpoison_pages - Unpoison a mempool page allocation.
+ * @page: Pointer to the page allocation.
+ * @order: Order of the allocation.
+ *
+ * This function is intended for kernel subsystems that cache page allocations
+ * to reuse them instead of freeing them back to page_alloc (e.g. mempool).
+ *
+ * This function unpoisons a page allocation that was previously poisoned by
+ * kasan_mempool_poison_pages() without zeroing the allocation's memory. For
+ * the tag-based modes, this function assigns a new tag to the allocation.
+ */
+static __always_inline void kasan_mempool_unpoison_pages(struct page *page,
+							 unsigned int order)
+{
+	if (kasan_enabled())
+		__kasan_mempool_unpoison_pages(page, order, _RET_IP_);
+}
+
 bool __kasan_mempool_poison_object(void *ptr, unsigned long ip);
 /**
  * kasan_mempool_poison_object - Check and poison a mempool slab allocation.
@@ -353,6 +377,7 @@ static inline bool kasan_mempool_poison_pages(struct page *page, unsigned int or
 {
 	return true;
 }
+static inline void kasan_mempool_unpoison_pages(struct page *page, unsigned int order) {}
 static inline bool kasan_mempool_poison_object(void *ptr)
 {
 	return true;
diff --git a/mm/kasan/common.c b/mm/kasan/common.c
index 9ccc78b20cf2..6283f0206ef6 100644
--- a/mm/kasan/common.c
+++ b/mm/kasan/common.c
@@ -439,6 +439,12 @@ bool __kasan_mempool_poison_pages(struct page *page, unsigned int order,
 	return true;
 }
 
+void __kasan_mempool_unpoison_pages(struct page *page, unsigned int order,
+				    unsigned long ip)
+{
+	__kasan_unpoison_pages(page, order, false);
+}
+
 bool __kasan_mempool_poison_object(void *ptr, unsigned long ip)
 {
 	struct folio *folio;
-- 
2.25.1



  parent reply	other threads:[~2023-11-06 20:11 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-11-06 20:10 [PATCH RFC 00/20] kasan: save mempool stack traces andrey.konovalov
2023-11-06 20:10 ` [PATCH RFC 01/20] kasan: rename kasan_slab_free_mempool to kasan_mempool_poison_object andrey.konovalov
2023-11-06 20:10 ` [PATCH RFC 02/20] kasan: move kasan_mempool_poison_object andrey.konovalov
2023-11-06 20:10 ` [PATCH RFC 03/20] kasan: document kasan_mempool_poison_object andrey.konovalov
2023-11-06 20:10 ` [PATCH RFC 04/20] kasan: add return value for kasan_mempool_poison_object andrey.konovalov
2023-11-06 20:10 ` [PATCH RFC 05/20] kasan: introduce kasan_mempool_unpoison_object andrey.konovalov
2023-11-06 20:10 ` [PATCH RFC 06/20] kasan: introduce kasan_mempool_poison_pages andrey.konovalov
2023-11-06 20:10 ` andrey.konovalov [this message]
2023-11-06 20:10 ` [PATCH RFC 08/20] kasan: clean up __kasan_mempool_poison_object andrey.konovalov
2023-11-06 20:10 ` [PATCH RFC 09/20] kasan: save free stack traces for slab mempools andrey.konovalov
2023-11-06 20:10 ` [PATCH RFC 10/20] kasan: clean up and rename ____kasan_kmalloc andrey.konovalov
2023-11-06 20:10 ` [PATCH RFC 11/20] kasan: introduce poison_kmalloc_large_redzone andrey.konovalov
2023-11-06 20:10 ` [PATCH RFC 12/20] kasan: save alloc stack traces for mempool andrey.konovalov
2023-11-06 20:10 ` [PATCH RFC 13/20] mempool: use new mempool KASAN hooks andrey.konovalov
2023-11-06 20:10 ` [PATCH RFC 14/20] mempool: introduce mempool_use_prealloc_only andrey.konovalov
2023-11-22 17:20   ` Marco Elver
2023-11-23 18:06     ` Andrey Konovalov
2023-11-23 18:47       ` Marco Elver
2023-11-06 20:10 ` [PATCH RFC 15/20] kasan: add mempool tests andrey.konovalov
2023-11-06 20:10 ` [PATCH RFC 16/20] kasan: rename pagealloc tests andrey.konovalov
2023-11-06 20:10 ` [PATCH RFC 17/20] kasan: reorder tests andrey.konovalov
2023-11-06 20:10 ` [PATCH RFC 18/20] kasan: rename and document kasan_(un)poison_object_data andrey.konovalov
2023-11-06 20:10 ` [PATCH RFC 19/20] skbuff: use mempool KASAN hooks andrey.konovalov
2023-11-06 20:10 ` [PATCH RFC 20/20] io_uring: use mempool KASAN hook andrey.konovalov
2023-11-22 17:13 ` [PATCH RFC 00/20] kasan: save mempool stack traces Marco Elver
2023-11-23 18:06   ` Andrey Konovalov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=573ab13b08f2e13d8add349c3a3900bcb7d79680.1699297309.git.andreyknvl@google.com \
    --to=andrey.konovalov@linux.dev \
    --cc=akpm@linux-foundation.org \
    --cc=andreyknvl@gmail.com \
    --cc=andreyknvl@google.com \
    --cc=dvyukov@google.com \
    --cc=elver@google.com \
    --cc=eugenis@google.com \
    --cc=glider@google.com \
    --cc=kasan-dev@googlegroups.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=ryabinin.a.a@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox