From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 75398C3ABAC for ; Tue, 29 Apr 2025 16:08:52 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 4E7346B000D; Tue, 29 Apr 2025 12:08:51 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 496D86B000E; Tue, 29 Apr 2025 12:08:51 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 24D5B6B0010; Tue, 29 Apr 2025 12:08:51 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 0A0666B000D for ; Tue, 29 Apr 2025 12:08:51 -0400 (EDT) Received: from smtpin09.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 1FC47B9730 for ; Tue, 29 Apr 2025 16:08:51 +0000 (UTC) X-FDA: 83387564862.09.7CA98D0 Received: from mx0a-001b2d01.pphosted.com (mx0a-001b2d01.pphosted.com [148.163.156.1]) by imf05.hostedemail.com (Postfix) with ESMTP id 886EE10001C for ; Tue, 29 Apr 2025 16:08:48 +0000 (UTC) Authentication-Results: imf05.hostedemail.com; dkim=pass header.d=ibm.com header.s=pp1 header.b=f0r37keo; dmarc=pass (policy=none) header.from=ibm.com; spf=pass (imf05.hostedemail.com: domain of agordeev@linux.ibm.com designates 148.163.156.1 as permitted sender) smtp.mailfrom=agordeev@linux.ibm.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1745942928; a=rsa-sha256; cv=none; b=rEeLgDCsUx8/N10Q67jwA+x4XE9mmH/b6hUxOHvmbLEBY8o3rvjFYlgiUWKr0x++YO5SXu ebpFJswvoXlBxq+HeGpGOW2TpOOe8m9TJitmDOdzg3E18aPeJhYi+6AwXbgpjh16+O5lhZ yQlSUGl69xM+M25r+1+VKusMUKLz8/g= ARC-Authentication-Results: i=1; imf05.hostedemail.com; dkim=pass header.d=ibm.com header.s=pp1 header.b=f0r37keo; dmarc=pass (policy=none) header.from=ibm.com; spf=pass (imf05.hostedemail.com: domain of agordeev@linux.ibm.com designates 148.163.156.1 as permitted sender) smtp.mailfrom=agordeev@linux.ibm.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1745942928; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=exXFY8c3sXTfLTJs5WHyoRrJ3cCFL+f9yepX0KeVH5A=; b=i5UelICe8Y+cVyJhLghe6mDVqjak1tadXOG7Xeg6o4pXPxOi3jUG1WCPyLvsBnN3hANXfl ACPuE487XEO7weRsYdA2Q6gQTNS3YV4gtA/0be57bDLrs5h4BPnOYcUlglWBJX8Oqhl+kG vl7AMT22cGB+LqoN+4rv0qDBPe6sJhM= Received: from pps.filterd (m0356517.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 53TFi49e007384; Tue, 29 Apr 2025 16:08:45 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=cc :content-transfer-encoding:date:from:in-reply-to:message-id :mime-version:references:subject:to; s=pp1; bh=exXFY8c3sXTfLTJs5 WHyoRrJ3cCFL+f9yepX0KeVH5A=; b=f0r37keoFcE4fNY5TlSCmQn35veUJkzF8 QHLeUS9bZ5FC3Ece/9PJGQXnxXRLztP/D7NfMRd3MGe+64g/OFgix/mVapPdddKR Ywkxly+57OETr3pXbkk2/qIbEWKEIZR331dOrHo6ct2aWYWBuI7m82yACCzBq0/0 4wqPFlVDp0M+v2TmoGWUjYQDaKTebGe4V6xbtJz+VX4hLNsvH75UZcrRX+QrvvWP Zjh1xv9agbfqkVTJ9Z/nlrN1OvTQn245UybF4E8pziZ+d1ZC9rplw+LmR/cSkBy5 TkDPMGDobg6SCSteO1SQuFy9qpoT1U6Ejq5/gT4IuR99RMEfS96DA== Received: from pps.reinject (localhost [127.0.0.1]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 46ahs9c4v6-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 29 Apr 2025 16:08:45 +0000 (GMT) Received: from m0356517.ppops.net (m0356517.ppops.net [127.0.0.1]) by pps.reinject (8.18.0.8/8.18.0.8) with ESMTP id 53TFi9Wf012165; Tue, 29 Apr 2025 16:08:44 GMT Received: from ppma11.dal12v.mail.ibm.com (db.9e.1632.ip4.static.sl-reverse.com [50.22.158.219]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 46ahs9c4v4-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 29 Apr 2025 16:08:44 +0000 (GMT) Received: from pps.filterd (ppma11.dal12v.mail.ibm.com [127.0.0.1]) by ppma11.dal12v.mail.ibm.com (8.18.1.2/8.18.1.2) with ESMTP id 53TF2ptu008490; Tue, 29 Apr 2025 16:08:43 GMT Received: from smtprelay04.fra02v.mail.ibm.com ([9.218.2.228]) by ppma11.dal12v.mail.ibm.com (PPS) with ESMTPS id 469ch33p5a-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 29 Apr 2025 16:08:43 +0000 Received: from smtpav07.fra02v.mail.ibm.com (smtpav07.fra02v.mail.ibm.com [10.20.54.106]) by smtprelay04.fra02v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 53TG8fmE19005828 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 29 Apr 2025 16:08:41 GMT Received: from smtpav07.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id B530420043; Tue, 29 Apr 2025 16:08:41 +0000 (GMT) Received: from smtpav07.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 9C5A520040; Tue, 29 Apr 2025 16:08:41 +0000 (GMT) Received: from tuxmaker.boeblingen.de.ibm.com (unknown [9.152.85.9]) by smtpav07.fra02v.mail.ibm.com (Postfix) with ESMTPS; Tue, 29 Apr 2025 16:08:41 +0000 (GMT) Received: by tuxmaker.boeblingen.de.ibm.com (Postfix, from userid 55669) id 4F3C9E1D62; Tue, 29 Apr 2025 18:08:41 +0200 (CEST) From: Alexander Gordeev To: Andrew Morton , Andrey Ryabinin , Daniel Axtens Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, kasan-dev@googlegroups.com, linux-s390@vger.kernel.org, stable@vger.kernel.org Subject: [PATCH v3 1/1] kasan: Avoid sleepable page allocation from atomic context Date: Tue, 29 Apr 2025 18:08:41 +0200 Message-ID: <573a823565734e1eac3aa128fb9d3506ec918a72.1745940843.git.agordeev@linux.ibm.com> X-Mailer: git-send-email 2.45.2 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-TM-AS-GCONF: 00 X-Authority-Analysis: v=2.4 cv=LuKSymdc c=1 sm=1 tr=0 ts=6810f98d cx=c_pps a=aDMHemPKRhS1OARIsFnwRA==:117 a=aDMHemPKRhS1OARIsFnwRA==:17 a=XR8D0OoHHMoA:10 a=pGLkceISAAAA:8 a=VwQbUJbxAAAA:8 a=VnNF1IyMAAAA:8 a=5xA_3oZvIydUEubUgb0A:9 X-Proofpoint-ORIG-GUID: eKosXnLkU16YdrMOn0HBc3RHeNNSB_B9 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUwNDI5MDEyMCBTYWx0ZWRfX2IGG+lmTdPaB wCQTgHqF/pn5FxI4xPz0sOcj4WE0vLUd8BxQaL7T9RfoxReeiW8WaH+0LZ9y9AjrfEVNbAURcby ZJ18Hfp6JC0emTYaITP3j1DZrqHllnldPcdC8KZ2sA3PPZcOSqJUyGPbfqLnivwfyfq9uQrV7LM uj3CWFzl+9RNyzde+dpU1+EbY2Kg3FqZWgcoCEjFAOjQrH14065mFxjm2dILaAyex/TQfgyrIYe m2BnFl6vmtlFNHDmTnIpVjFTpdPwNyk3cWAMfVQwIoDbFnMxcsIZOVVxz+cLT1eSM8A6+gaKjtb odjriVZ1221loHCTvYfTEZD1CvqjvJxbDK2dgR3LC6HOCFSAiJMbX1pqmnfmUzCJYTm9Ir3EnBb HQ6fejZfxDNwcwYhktrk32uOGuKS/c9/LIWTX6isE0fEzeC1DQZBuxhxazRCQGZNDdgQB3LX X-Proofpoint-GUID: 0-B2yVFWNPdkcAEAxw-pzdBB9vj7F0Ff X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1099,Hydra:6.0.736,FMLib:17.12.80.40 definitions=2025-04-29_06,2025-04-24_02,2025-02-21_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 adultscore=0 phishscore=0 mlxlogscore=459 clxscore=1011 spamscore=0 lowpriorityscore=0 priorityscore=1501 bulkscore=0 mlxscore=0 impostorscore=0 suspectscore=0 malwarescore=0 classifier=spam authscore=0 authtc=n/a authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.19.0-2504070000 definitions=main-2504290120 X-Rspamd-Queue-Id: 886EE10001C X-Stat-Signature: a5kw7odwx6cj3yumxzufihn54gju4pdr X-Rspam-User: X-Rspamd-Server: rspam08 X-HE-Tag: 1745942928-714711 X-HE-Meta: U2FsdGVkX1+JByVuUDulMQl1o8e8CK9BFP/tmUrzMlryqZMBurh9F14lKG1EUVz4cOxx29DsoPtx09JDCE6q91lP7DTg7cLL8dQU7mYywidmVos8ovlp3aXYZmEkWrenasG1voWPSGKIbTh+/Z0ZH+cQi90X+cFYV2iDiM2SBvgGQiao+SHzCWvED9Hxu+SvPT3tTI7NYJnX/8w4i8uCsdGMWjXOgC6wUuQQsg3wqDUDKmHQ2MzEMO6bSkdD7cHjqIyvFlV179de9IujUfNjt4nJQrEluMMgGkaWEG65a2yJj5bLE+Q6/jfQmbs2d5YYbOxo1S2oM5BoFxPX43QOhn94zQNkv4Vmwt6DOhxMnWKY6ONtWDrg5GHQT6WcAexqDkI2qNDJ7fWURLk7bbg0WsYJDFEb4N1FBA072EP1E0Lm1Rc85RfqFvpnW0OXq2BxeNgVRSmbRwQlGzN1XN+NM5DUaJwEKtTKE4aXlXrHPNRT5TpbuktnklxrpU2KfSF402/MijA35cI0lg1ew49ULYe+NWupMJuryHFRXx39VJfdiwx1k6y/ZlbddQ+SL4zn3NaI7FpXBG9/4SF/mQhRwSkCTeYhz+0mEdNvesW2K6q+crwbrHWFQMCDC+dtnyzExPtsxZijqzCT0c/T/UlU9AbbVZqnednKBXP3hCzNeMiamuhhBxdjbZ12khe/lSOreD2hUwEIlpMFeaoN4bzVsIVaghSUEKCJlLkgoAs9tIxc159o1RBhMdZSs7y9AqKCMeRZL5MkTfMGbsUkkE8Z4r4oipr8sXLaQUXKm+p06i0VUDvlUWoP95LqtIVW0QcHN/qgcUUKASsAdIIf/vXoCBb3O0ZsLd6WWPheb8zlA/1CJ4qZ4M1UDAfBNEVxuIvcVjE/jXfAdM1faUe/HKLUN+/kctNq98Ez+CcWR6LPVj60VESQMMHaPSJLGcu8R2g6941W0/IonrN1kefr8vj zMaTbK5s SVwj0u9mzORJzKMSxIWzEW73Ud7RkLYAXbUYd9wt8x53IrOUsCcgcLoZSZVZmEDmxolscQnnnKqC53Ozj4ZwY+yp53oTpDrRlL3mYG1gl/u5a+dJzv+LASAhF3ODAc1Jm7kt7l29BRyoSG7DXlP1OEAtvFwYRs6oFDr2KbOT8IdJGQ7oT8OyHT3IGIgY7ScLYJTdawRPllljOi/ETFQfKtXC/mHEQO+Afk02NrnLYg7JUJCFBmS7g0Jn9K6MkTNDwQRbStiheLAh73lGVTqd+qA0/aizg+xH4K5S7BuuM7IDk4GSAbggSwRDCi0RQ1/9n/PBlwUDmCuMapnOGV9IJoJBSpotssjcARYqjPDIoPQwOsL/h1QZksnc0paCgQ+bNr9GFLJF06BmtWZtRQPuRHmOrXw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: apply_to_pte_range() enters the lazy MMU mode and then invokes kasan_populate_vmalloc_pte() callback on each page table walk iteration. However, the callback can go into sleep when trying to allocate a single page, e.g. if an architecutre disables preemption on lazy MMU mode enter. On s390 if make arch_enter_lazy_mmu_mode() -> preempt_enable() and arch_leave_lazy_mmu_mode() -> preempt_disable(), such crash occurs: [ 553.332108] preempt_count: 1, expected: 0 [ 553.332117] no locks held by multipathd/2116. [ 553.332128] CPU: 24 PID: 2116 Comm: multipathd Kdump: loaded Tainted: [ 553.332139] Hardware name: IBM 3931 A01 701 (LPAR) [ 553.332146] Call Trace: [ 553.332152] [<00000000158de23a>] dump_stack_lvl+0xfa/0x150 [ 553.332167] [<0000000013e10d12>] __might_resched+0x57a/0x5e8 [ 553.332178] [<00000000144eb6c2>] __alloc_pages+0x2ba/0x7c0 [ 553.332189] [<00000000144d5cdc>] __get_free_pages+0x2c/0x88 [ 553.332198] [<00000000145663f6>] kasan_populate_vmalloc_pte+0x4e/0x110 [ 553.332207] [<000000001447625c>] apply_to_pte_range+0x164/0x3c8 [ 553.332218] [<000000001448125a>] apply_to_pmd_range+0xda/0x318 [ 553.332226] [<000000001448181c>] __apply_to_page_range+0x384/0x768 [ 553.332233] [<0000000014481c28>] apply_to_page_range+0x28/0x38 [ 553.332241] [<00000000145665da>] kasan_populate_vmalloc+0x82/0x98 [ 553.332249] [<00000000144c88d0>] alloc_vmap_area+0x590/0x1c90 [ 553.332257] [<00000000144ca108>] __get_vm_area_node.constprop.0+0x138/0x260 [ 553.332265] [<00000000144d17fc>] __vmalloc_node_range+0x134/0x360 [ 553.332274] [<0000000013d5dbf2>] alloc_thread_stack_node+0x112/0x378 [ 553.332284] [<0000000013d62726>] dup_task_struct+0x66/0x430 [ 553.332293] [<0000000013d63962>] copy_process+0x432/0x4b80 [ 553.332302] [<0000000013d68300>] kernel_clone+0xf0/0x7d0 [ 553.332311] [<0000000013d68bd6>] __do_sys_clone+0xae/0xc8 [ 553.332400] [<0000000013d68dee>] __s390x_sys_clone+0xd6/0x118 [ 553.332410] [<0000000013c9d34c>] do_syscall+0x22c/0x328 [ 553.332419] [<00000000158e7366>] __do_syscall+0xce/0xf0 [ 553.332428] [<0000000015913260>] system_call+0x70/0x98 Instead of allocating single pages per-PTE, bulk-allocate the shadow memory prior to applying kasan_populate_vmalloc_pte() callback on a page range. Suggested-by: Andrey Ryabinin Cc: stable@vger.kernel.org Fixes: 3c5c3cfb9ef4 ("kasan: support backing vmalloc space with real shadow memory") Signed-off-by: Alexander Gordeev --- mm/kasan/shadow.c | 65 +++++++++++++++++++++++++++++++++++------------ 1 file changed, 49 insertions(+), 16 deletions(-) diff --git a/mm/kasan/shadow.c b/mm/kasan/shadow.c index 88d1c9dcb507..ea9a06715a81 100644 --- a/mm/kasan/shadow.c +++ b/mm/kasan/shadow.c @@ -292,30 +292,65 @@ void __init __weak kasan_populate_early_vm_area_shadow(void *start, { } +struct vmalloc_populate_data { + unsigned long start; + struct page **pages; +}; + static int kasan_populate_vmalloc_pte(pte_t *ptep, unsigned long addr, - void *unused) + void *_data) { - unsigned long page; + struct vmalloc_populate_data *data = _data; + struct page *page; + unsigned long pfn; pte_t pte; if (likely(!pte_none(ptep_get(ptep)))) return 0; - page = __get_free_page(GFP_KERNEL); - if (!page) - return -ENOMEM; - - __memset((void *)page, KASAN_VMALLOC_INVALID, PAGE_SIZE); - pte = pfn_pte(PFN_DOWN(__pa(page)), PAGE_KERNEL); + page = data->pages[PFN_DOWN(addr - data->start)]; + pfn = page_to_pfn(page); + __memset(pfn_to_virt(pfn), KASAN_VMALLOC_INVALID, PAGE_SIZE); + pte = pfn_pte(pfn, PAGE_KERNEL); spin_lock(&init_mm.page_table_lock); - if (likely(pte_none(ptep_get(ptep)))) { + if (likely(pte_none(ptep_get(ptep)))) set_pte_at(&init_mm, addr, ptep, pte); - page = 0; - } spin_unlock(&init_mm.page_table_lock); - if (page) - free_page(page); + + return 0; +} + +static int __kasan_populate_vmalloc(unsigned long start, unsigned long end) +{ + unsigned long nr_pages, nr_total = PFN_UP(end - start); + struct vmalloc_populate_data data; + int ret; + + data.pages = (struct page **)__get_free_page(GFP_KERNEL); + if (!data.pages) + return -ENOMEM; + + while (nr_total) { + nr_pages = min(nr_total, PAGE_SIZE / sizeof(data.pages[0])); + __memset(data.pages, 0, nr_pages * sizeof(data.pages[0])); + if (nr_pages != alloc_pages_bulk(GFP_KERNEL, nr_pages, data.pages)) { + free_page((unsigned long)data.pages); + return -ENOMEM; + } + + data.start = start; + ret = apply_to_page_range(&init_mm, start, nr_pages * PAGE_SIZE, + kasan_populate_vmalloc_pte, &data); + if (ret) + return ret; + + start += nr_pages * PAGE_SIZE; + nr_total -= nr_pages; + } + + free_page((unsigned long)data.pages); + return 0; } @@ -348,9 +383,7 @@ int kasan_populate_vmalloc(unsigned long addr, unsigned long size) shadow_start = PAGE_ALIGN_DOWN(shadow_start); shadow_end = PAGE_ALIGN(shadow_end); - ret = apply_to_page_range(&init_mm, shadow_start, - shadow_end - shadow_start, - kasan_populate_vmalloc_pte, NULL); + ret = __kasan_populate_vmalloc(shadow_start, shadow_end); if (ret) return ret; -- 2.45.2