From: Andrey Ryabinin <aryabinin@virtuozzo.com>
To: Alexander Potapenko <glider@google.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
kasan-dev <kasan-dev@googlegroups.com>,
Linux Memory Management List <linux-mm@kvack.org>,
LKML <linux-kernel@vger.kernel.org>,
Dmitry Vyukov <dvyukov@google.com>
Subject: Re: [PATCH] mm-kasan-initial-memory-quarantine-implementation-v8-fix
Date: Wed, 11 May 2016 14:11:36 +0300 [thread overview]
Message-ID: <57331368.9070101@virtuozzo.com> (raw)
In-Reply-To: <CAG_fn=UdD=gvFXOSMh3b+PzHerh6HD0ydrDYTEeXf1gPgMuBZw@mail.gmail.com>
On 05/11/2016 01:18 PM, Alexander Potapenko wrote:
> On Tue, May 10, 2016 at 3:38 PM, Andrey Ryabinin
> <aryabinin@virtuozzo.com> wrote:
>> * Fix comment styles,
> yDid you remove the comments from include/linux/kasan.h because they
> were put inconsistently, or was there any other reason?
We usually comment functions near definition, not declarations.
If you like, put comment back. Just place it near definition.
>> * Get rid of some ifdefs
> Thanks!
>> * Revert needless functions renames in quarantine patch
> I believe right now the names are somewhat obscure. I agree however
> the change should be done in a separate patch.
Besides that, I didn't like the fact that you made names longer and exceeded
80-char limit in some places.
>> * Remove needless local_irq_save()/restore() in per_cpu_remove_cache()
> Ack
>> * Add new 'struct qlist_node' instead of 'void **' types. This makes
>> code a bit more redable.
> Nice, thank you!
>
> How do I incorporate your changes? Is it ok if I merge it with the
> next version of my patch and add a "Signed-off-by: Andrey Ryabinin
> <aryabinin@virtuozzo.com>" line to the description?
>
Ok, but I don't think that this is matters. Andrew will just craft a diff patch
on top of the current code anyways.
Or you can make such diff by yourself and send it, it's easier to review, after all.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2016-05-11 11:11 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-10 13:38 Andrey Ryabinin
2016-05-11 10:18 ` Alexander Potapenko
2016-05-11 11:11 ` Andrey Ryabinin [this message]
2016-05-11 14:30 ` Alexander Potapenko
2016-05-11 15:33 ` Alexander Potapenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=57331368.9070101@virtuozzo.com \
--to=aryabinin@virtuozzo.com \
--cc=akpm@linux-foundation.org \
--cc=dvyukov@google.com \
--cc=glider@google.com \
--cc=kasan-dev@googlegroups.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox