From: "Huang, Shaoqin" <shaoqin.huang@intel.com>
To: Mike Rapoport <rppt@kernel.org>
Cc: Rebecca Mckeever <remckee0@gmail.com>, <linux-mm@kvack.org>,
<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2] memblock test: Modify the obsolete description in README
Date: Thu, 28 Jul 2022 17:14:35 +0800 [thread overview]
Message-ID: <5729cfad-7840-6e06-f066-ac69374d1217@intel.com> (raw)
In-Reply-To: <YuJQgAJBxQkkooVT@kernel.org>
On 7/28/2022 5:01 PM, Mike Rapoport wrote:
> On Thu, Jul 28, 2022 at 01:08:25PM +0800, Huang, Shaoqin wrote:
>>
>>
>> On 7/28/2022 12:05 PM, Rebecca Mckeever wrote:
>>> On Wed, Jul 27, 2022 at 07:12:28PM -0600, shaoqin.huang@intel.com wrote:
>>>> From: Shaoqin Huang <shaoqin.huang@intel.com>
>>>>
>>>> The VERBOSE option in Makefile has been moved, but there still have the
>>>> description left in README. For now, we use `-v` options when running
>>>> memblock test to print information, so using the new to replace the
>>>> obsolete items.
>>>>
>>> Thanks for catching this!
>>>
>>>> Signed-off-by: Shaoqin Huang <shaoqin.huang@intel.com>
>>>> ---
>
> ...
>
>>>> This will print information about which functions are being tested and the
>>>> number of test cases that passed.
>>>> -To simulate enabled NUMA, use:
>>>> +For the full list of options from command line, see `./main --help`.
>>>
>>> --help will display the list of command line options by default, but a
>>> help command line option isn't explicitly implemented. I'm planning to add
>>> the help option, so if you want to remove this sentence, I will add it when
>>> I implement the help option.
>>
>> Hi, Rebecca.
>>
>> That's ok. I didn't notice the --help has not been implemented. So I can
>> remove the line:
>> -For the full list of options from command line, see `./main --help`.
>>
>> But after remove it. There seems a little stranger about how to get the full
>> list of options at the time. How do you think about it?
>
> I '--help' option is implemented, it just does not list help for itself.
> I think it's fine to keep the "For the full list..." line.
>
>
Ok, if no other problem. I will resend this patch with a minimal tweak:
-For the full list of options, see `make help`.
+For the full list of build options, see `make help`.
prev parent reply other threads:[~2022-07-28 9:14 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-28 1:12 shaoqin.huang
2022-07-28 4:05 ` Rebecca Mckeever
2022-07-28 5:08 ` Huang, Shaoqin
2022-07-28 9:01 ` Mike Rapoport
2022-07-28 9:14 ` Huang, Shaoqin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5729cfad-7840-6e06-f066-ac69374d1217@intel.com \
--to=shaoqin.huang@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=remckee0@gmail.com \
--cc=rppt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox