From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id CA638EB64D8 for ; Wed, 14 Jun 2023 21:23:19 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 497556B0072; Wed, 14 Jun 2023 17:23:19 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 4478E8E0002; Wed, 14 Jun 2023 17:23:19 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 30F566B007B; Wed, 14 Jun 2023 17:23:19 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 213AF6B0072 for ; Wed, 14 Jun 2023 17:23:19 -0400 (EDT) Received: from smtpin28.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id D972B405B0 for ; Wed, 14 Jun 2023 21:23:18 +0000 (UTC) X-FDA: 80902629276.28.C254837 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf21.hostedemail.com (Postfix) with ESMTP id 0BCB41C000C for ; Wed, 14 Jun 2023 21:23:15 +0000 (UTC) Authentication-Results: imf21.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=JSy2cjQ3; dmarc=pass (policy=none) header.from=kernel.org; spf=pass (imf21.hostedemail.com: domain of dinguyen@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=dinguyen@kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1686777796; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=crK0eAvYmMEjCGSxXvPftFO54R9NX7KiFDASMxAbLk0=; b=kJn2+PlB9Gu4tX2YsDwYOteLGP+/oynma0/q9VUwTBfdAC0HNlaF2uDX1ZSeD0foqKcDwn +CqCN6m2rKOojvAqa38SaMceNTUq/4FSX0hwThuceVJcwdC2uU1Zm8qkTz45L8Kr7OHKVV 0PDg9zOxkNcMGyKGCTuqfaBSsi9uI9A= ARC-Authentication-Results: i=1; imf21.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=JSy2cjQ3; dmarc=pass (policy=none) header.from=kernel.org; spf=pass (imf21.hostedemail.com: domain of dinguyen@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=dinguyen@kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1686777796; a=rsa-sha256; cv=none; b=VfdE44C1wnFD9oT4f7w3Jjp+o3C8pg8GK84lq52iDW06bE6S54OfR4S94tbC0nbtAYnHRP e+UMpmomU9Diy3nm7DiCkG4aEdr2Oyuho8s5WoPQJqMJJnPRxM1n5MUwM6RUoK88pP91lf nwf/gQh6OocxmfyFksS2hVNlFwOSuCc= Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 34A296257E; Wed, 14 Jun 2023 21:23:15 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 8E219C433C8; Wed, 14 Jun 2023 21:23:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1686777794; bh=sfZlQC0KRiU3VFMaS6H5djLiaDuaR3UyKKAHotXoEC4=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=JSy2cjQ3EfZqDH+GRmJ+mjVAAcseGIvPUq3lquiQxXqEjjGqwU+HemD7F3wiC1btN oSofDjGtfqLFUZE6+eF26LaNmlZ0XJSVLI8h3M4XLmim/HM29Na3QWm9DVPo2aVCXI K79BAGLxK+0MfFwKGWozB9O2gr9yZd3Cu5CIDwhRjdpR3tn5b309NHjtR2IQGAy5FI ii48Ct/zrPJGlO6GMB0nxU3tTn8XzvIvT2D58R4sk2Mn4rxTjXdkRPrgiKhp+20BR7 UEwrTSQZ099UBshJbATcCyWw+lXzjKCSDECSlkjbQFiwFpFsJU9nBH5UIC1JXPi4An txkWeQKuOaEyQ== Message-ID: <5729b45b-6a19-2aa8-8722-c50e6a1fceea@kernel.org> Date: Wed, 14 Jun 2023 16:23:10 -0500 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.11.0 Subject: Re: [PATCH v4 27/34] nios2: Convert __pte_free_tlb() to use ptdescs Content-Language: en-US To: Geert Uytterhoeven Cc: "Vishal Moola (Oracle)" , Andrew Morton , Matthew Wilcox , linux-mm@kvack.org, linux-arch@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-csky@vger.kernel.org, linux-hexagon@vger.kernel.org, loongarch@lists.linux.dev, linux-m68k@lists.linux-m68k.org, linux-mips@vger.kernel.org, linux-openrisc@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-riscv@lists.infradead.org, linux-s390@vger.kernel.org, linux-sh@vger.kernel.org, sparclinux@vger.kernel.org, linux-um@lists.infradead.org, xen-devel@lists.xenproject.org, kvm@vger.kernel.org, Hugh Dickins References: <20230612210423.18611-1-vishal.moola@gmail.com> <20230612210423.18611-28-vishal.moola@gmail.com> From: Dinh Nguyen In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Rspamd-Queue-Id: 0BCB41C000C X-Rspam-User: X-Rspamd-Server: rspam02 X-Stat-Signature: arsk4gqr6y956aug5s33nssr5w6u966m X-HE-Tag: 1686777795-393760 X-HE-Meta: U2FsdGVkX18V2pq6XAjYDCNVknvPzCQ4gKM6xzroj+x51A55Une6PnJeuY090S6C23/+gJU5dMAh9AFRDsMKq4t6bGX9wYJbiHpQ0LHB+X8XwBp35WdiWgBu5OTevLKBm4Q94sPlGY/WAHk7VnbeCTQM9vYEW7GmQDT7GmgLeqoyrunxp8by2pXsb7UbJMO+1Wdx9Vm/ZgYnibe77SJ/yorsDbwEBe1tQfLs39/eOHKsWRjrkBCcXP2lj17cOt+R9OxK9gU4cyLDAxlMCal7XCmRlWwrcDNYHTC8VUereYRiX64Qyty+xXoOl+y/yW3M7G5e5RBTamMbdgxd98Q4bEmKrNfsyZc7+tm0xhI8jnrVU5Tc3Bu3YF4ADMeVAUUXOIBCWYN+czl+99qvUAk9acbot4cUB2+62vBXdAjErKTja4sMToYL6yW9Zx+NyuEZAyFPqatT5noDIK8t8Y4J5NkJhRVFCruA+IwKloDyV+M7fYmNho7YEixtqIgcLpAdLB22NAmWPBGvZggqY/5S7pQ6BCUB3C6z9jfU86rsExMuIMktiWTkAZIiWt4Pzq9as7bNINL3ydRL4jCmZvf5UwImIgACjhwYF5Ex3l8DEv/ldtSTNZF4yW4f/HKavHi5mObT92a01dDsGtloaQmq7g1QfKaas3bqh9TYi31lkuee+NZc3vvrw9VYoP/XYDSga27wFcjRNtw3mx8VitK//2KP4zgYLn2SGh8KTLg0wkkrEvTfsEsAhvEjIwK1FHMc+pcWqX5maH8aeM36noYMp1/jgWC6katPtgoNEW1l5+yWduy77Z+bPGniFg+emzcgLC9+5X83Nb0XVZ7maV8lxG39Tpb1UIapBhd/pP8T192N+reC+7UL7Vy1Hu/KGJbb6UirCEnUPkohrp9I4zUM0q6AUblJxnmog2SX3fP4PR84JeK1fH+sYSVjCuXaIRZK65MX+eaTnSV74MWMLfm Z916iMlw TkUsAL8nPyinzz8JAY012jw3HIFiJnmg3c977sE3YMh8EZKxX6kyMd6TVhOqwA13S+2/il0cHZhShx7Z3/izqE05yqaPQgMpxrwa3DFVPRO2uGZYKYesusHarW3YTQYvlXHZ27pDwCtZMjcp1U7+bSM/iDHYD4T7U6+Mm9Q8xz2D3BKBgJMvmXNcI9D+ROxKmUgLmwbA5tcFQK80tc1ZaJqCfUqblu9339JDJSezwB5TRRiBrRYziS9swS8pENOwwIPIAS8QMS2yqjiKQ52enbXNhNL3UQG1QdI6Pb6kRjj56LU6kyh1rLbPpV/cVQxFTDTC8zKRqh43Yon4Gi8A42arFdDQGPCMaxLulF4GfWmd9q8FGmRrBiriaZ6MQYoQzgPxuZIslmmaSYwPh0H2zodvCcrPxyigD/oooR/WdCBIEqTlUZYxlrmC2M2J1VJrDP7QFziZsBWW5ZU5xBQreC4OPaGQhDSSm+6q2Z162By4CcyU= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 6/14/23 04:30, Geert Uytterhoeven wrote: > Hi Dinh, > > On Wed, Jun 14, 2023 at 12:17 AM Dinh Nguyen wrote: >> On 6/12/23 16:04, Vishal Moola (Oracle) wrote: >>> Part of the conversions to replace pgtable constructor/destructors with >>> ptdesc equivalents. >>> >>> Signed-off-by: Vishal Moola (Oracle) >>> --- >>> arch/nios2/include/asm/pgalloc.h | 8 ++++---- >>> 1 file changed, 4 insertions(+), 4 deletions(-) >>> >>> diff --git a/arch/nios2/include/asm/pgalloc.h b/arch/nios2/include/asm/pgalloc.h >>> index ecd1657bb2ce..ce6bb8e74271 100644 >>> --- a/arch/nios2/include/asm/pgalloc.h >>> +++ b/arch/nios2/include/asm/pgalloc.h >>> @@ -28,10 +28,10 @@ static inline void pmd_populate(struct mm_struct *mm, pmd_t *pmd, >>> >>> extern pgd_t *pgd_alloc(struct mm_struct *mm); >>> >>> -#define __pte_free_tlb(tlb, pte, addr) \ >>> - do { \ >>> - pgtable_pte_page_dtor(pte); \ >>> - tlb_remove_page((tlb), (pte)); \ >>> +#define __pte_free_tlb(tlb, pte, addr) \ >>> + do { \ >>> + pagetable_pte_dtor(page_ptdesc(pte)); \ >>> + tlb_remove_page_ptdesc((tlb), (page_ptdesc(pte))); \ >>> } while (0) >>> >>> #endif /* _ASM_NIOS2_PGALLOC_H */ >> >> Applied! > > I don't think you can just apply this patch, as the new functions > were only introduced in [PATCH v4 05/34] of this series. > Ah, thanks for the pointer! Dinh