From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1F1F4CE7AEB for ; Fri, 6 Sep 2024 08:52:10 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 529846B007B; Fri, 6 Sep 2024 04:52:09 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 4D8B46B0082; Fri, 6 Sep 2024 04:52:09 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 352806B0085; Fri, 6 Sep 2024 04:52:09 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 140336B007B for ; Fri, 6 Sep 2024 04:52:09 -0400 (EDT) Received: from smtpin01.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 9015EA11A0 for ; Fri, 6 Sep 2024 08:52:08 +0000 (UTC) X-FDA: 82533696336.01.47E9A6E Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.223.131]) by imf10.hostedemail.com (Postfix) with ESMTP id 2AE20C0015 for ; Fri, 6 Sep 2024 08:52:05 +0000 (UTC) Authentication-Results: imf10.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=JDppy8VF; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=6jG5vXZT; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=JDppy8VF; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=6jG5vXZT; spf=pass (imf10.hostedemail.com: domain of vbabka@suse.cz designates 195.135.223.131 as permitted sender) smtp.mailfrom=vbabka@suse.cz; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1725612701; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=IzogC8JuQRtj+kiGfSeOCXmpLa3gvh93o14fVFDPkWg=; b=I0vNFbpy54SsCFi9Z6U2Dc0pTy7b8DfGvfMnpNThv0i8KDACBhPiMXrGgUQG/4sgZHDIoh dRVu9dUY7jMUibw3+svjCwxHJ+MPZoQYsw2Cikc+f4lCnglEL43TWEIR+KWcekrwpLJDqy WHfeTjuijY129oIIIiEJujRSn9RSLDY= ARC-Authentication-Results: i=1; imf10.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=JDppy8VF; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=6jG5vXZT; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=JDppy8VF; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=6jG5vXZT; spf=pass (imf10.hostedemail.com: domain of vbabka@suse.cz designates 195.135.223.131 as permitted sender) smtp.mailfrom=vbabka@suse.cz; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1725612701; a=rsa-sha256; cv=none; b=MZEeff1pQFLHnI20/3NXOsOAtuxkt+9ZRBw2d708xDVl4Dhb4AsvZ1lRm0Gyo/kg++qAne R8U4g6cpUA3U+YxM/HJM7znA7UTgBnpBLGYcXUtmxUdDmpFpEMc5oMhYDjocHSDxDJ2ThS dUnC2RYzkCloN6iMgblh3KqX0OI/jXY= Received: from imap1.dmz-prg2.suse.org (unknown [10.150.64.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 70BD61F8A8; Fri, 6 Sep 2024 08:52:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1725612724; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=IzogC8JuQRtj+kiGfSeOCXmpLa3gvh93o14fVFDPkWg=; b=JDppy8VF9Irao39PPHgk/YTpy7wQbVJKMM/vshTpo3I5+o5BZvzJvOHhoF180EYK/mvLUR DchdsGGC3rcaD1seufLf/g7uBwp3H0W01sSoe9hQ7C7DFFsdv/8inw7bjqsW8TD6K9fef/ Sma0AovEmjISO5qSNJSDYJHNN9Fcn9k= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1725612724; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=IzogC8JuQRtj+kiGfSeOCXmpLa3gvh93o14fVFDPkWg=; b=6jG5vXZT6yq3mZZyE0V2evrOPr1vy89l8hKTevfsKWau7UMtuyl+IMY6UHwk+sCGwF0t8v zyfXHi6Yxh9OPCCg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1725612724; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=IzogC8JuQRtj+kiGfSeOCXmpLa3gvh93o14fVFDPkWg=; b=JDppy8VF9Irao39PPHgk/YTpy7wQbVJKMM/vshTpo3I5+o5BZvzJvOHhoF180EYK/mvLUR DchdsGGC3rcaD1seufLf/g7uBwp3H0W01sSoe9hQ7C7DFFsdv/8inw7bjqsW8TD6K9fef/ Sma0AovEmjISO5qSNJSDYJHNN9Fcn9k= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1725612724; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=IzogC8JuQRtj+kiGfSeOCXmpLa3gvh93o14fVFDPkWg=; b=6jG5vXZT6yq3mZZyE0V2evrOPr1vy89l8hKTevfsKWau7UMtuyl+IMY6UHwk+sCGwF0t8v zyfXHi6Yxh9OPCCg== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 4C39A136A8; Fri, 6 Sep 2024 08:52:04 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id vEI+ErTC2mYQTgAAD6G6ig (envelope-from ); Fri, 06 Sep 2024 08:52:04 +0000 Message-ID: <572688a7-8719-4f94-a5cd-e726486c757d@suse.cz> Date: Fri, 6 Sep 2024 10:52:04 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v4] memcg: add charging of already allocated slab objects Content-Language: en-US To: Shakeel Butt , Yosry Ahmed Cc: Andrew Morton , Johannes Weiner , Michal Hocko , Roman Gushchin , Muchun Song , David Rientjes , Hyeonggon Yoo <42.hyeyoo@gmail.com>, Eric Dumazet , "David S . Miller" , Jakub Kicinski , Paolo Abeni , linux-mm@kvack.org, linux-kernel@vger.kernel.org, Meta kernel team , cgroups@vger.kernel.org, netdev@vger.kernel.org References: <20240905173422.1565480-1-shakeel.butt@linux.dev> From: Vlastimil Babka Autocrypt: addr=vbabka@suse.cz; keydata= xsFNBFZdmxYBEADsw/SiUSjB0dM+vSh95UkgcHjzEVBlby/Fg+g42O7LAEkCYXi/vvq31JTB KxRWDHX0R2tgpFDXHnzZcQywawu8eSq0LxzxFNYMvtB7sV1pxYwej2qx9B75qW2plBs+7+YB 87tMFA+u+L4Z5xAzIimfLD5EKC56kJ1CsXlM8S/LHcmdD9Ctkn3trYDNnat0eoAcfPIP2OZ+ 9oe9IF/R28zmh0ifLXyJQQz5ofdj4bPf8ecEW0rhcqHfTD8k4yK0xxt3xW+6Exqp9n9bydiy tcSAw/TahjW6yrA+6JhSBv1v2tIm+itQc073zjSX8OFL51qQVzRFr7H2UQG33lw2QrvHRXqD Ot7ViKam7v0Ho9wEWiQOOZlHItOOXFphWb2yq3nzrKe45oWoSgkxKb97MVsQ+q2SYjJRBBH4 8qKhphADYxkIP6yut/eaj9ImvRUZZRi0DTc8xfnvHGTjKbJzC2xpFcY0DQbZzuwsIZ8OPJCc LM4S7mT25NE5kUTG/TKQCk922vRdGVMoLA7dIQrgXnRXtyT61sg8PG4wcfOnuWf8577aXP1x 6mzw3/jh3F+oSBHb/GcLC7mvWreJifUL2gEdssGfXhGWBo6zLS3qhgtwjay0Jl+kza1lo+Cv BB2T79D4WGdDuVa4eOrQ02TxqGN7G0Biz5ZLRSFzQSQwLn8fbwARAQABzSBWbGFzdGltaWwg QmFia2EgPHZiYWJrYUBzdXNlLmN6PsLBlAQTAQoAPgIbAwULCQgHAwUVCgkICwUWAgMBAAIe AQIXgBYhBKlA1DSZLC6OmRA9UCJPp+fMgqZkBQJkBREIBQkRadznAAoJECJPp+fMgqZkNxIQ ALZRqwdUGzqL2aeSavbum/VF/+td+nZfuH0xeWiO2w8mG0+nPd5j9ujYeHcUP1edE7uQrjOC Gs9sm8+W1xYnbClMJTsXiAV88D2btFUdU1mCXURAL9wWZ8Jsmz5ZH2V6AUszvNezsS/VIT87 AmTtj31TLDGwdxaZTSYLwAOOOtyqafOEq+gJB30RxTRE3h3G1zpO7OM9K6ysLdAlwAGYWgJJ V4JqGsQ/lyEtxxFpUCjb5Pztp7cQxhlkil0oBYHkudiG8j1U3DG8iC6rnB4yJaLphKx57NuQ PIY0Bccg+r9gIQ4XeSK2PQhdXdy3UWBr913ZQ9AI2usid3s5vabo4iBvpJNFLgUmxFnr73SJ KsRh/2OBsg1XXF/wRQGBO9vRuJUAbnaIVcmGOUogdBVS9Sun/Sy4GNA++KtFZK95U7J417/J Hub2xV6Ehc7UGW6fIvIQmzJ3zaTEfuriU1P8ayfddrAgZb25JnOW7L1zdYL8rXiezOyYZ8Fm ZyXjzWdO0RpxcUEp6GsJr11Bc4F3aae9OZtwtLL/jxc7y6pUugB00PodgnQ6CMcfR/HjXlae h2VS3zl9+tQWHu6s1R58t5BuMS2FNA58wU/IazImc/ZQA+slDBfhRDGYlExjg19UXWe/gMcl De3P1kxYPgZdGE2eZpRLIbt+rYnqQKy8UxlszsBNBFsZNTUBCACfQfpSsWJZyi+SHoRdVyX5 J6rI7okc4+b571a7RXD5UhS9dlVRVVAtrU9ANSLqPTQKGVxHrqD39XSw8hxK61pw8p90pg4G /N3iuWEvyt+t0SxDDkClnGsDyRhlUyEWYFEoBrrCizbmahOUwqkJbNMfzj5Y7n7OIJOxNRkB IBOjPdF26dMP69BwePQao1M8Acrrex9sAHYjQGyVmReRjVEtv9iG4DoTsnIR3amKVk6si4Ea X/mrapJqSCcBUVYUFH8M7bsm4CSxier5ofy8jTEa/CfvkqpKThTMCQPNZKY7hke5qEq1CBk2 wxhX48ZrJEFf1v3NuV3OimgsF2odzieNABEBAAHCwXwEGAEKACYCGwwWIQSpQNQ0mSwujpkQ PVAiT6fnzIKmZAUCZAUSmwUJDK5EZgAKCRAiT6fnzIKmZOJGEACOKABgo9wJXsbWhGWYO7mD 8R8mUyJHqbvaz+yTLnvRwfe/VwafFfDMx5GYVYzMY9TWpA8psFTKTUIIQmx2scYsRBUwm5VI EurRWKqENcDRjyo+ol59j0FViYysjQQeobXBDDE31t5SBg++veI6tXfpco/UiKEsDswL1WAr tEAZaruo7254TyH+gydURl2wJuzo/aZ7Y7PpqaODbYv727Dvm5eX64HCyyAH0s6sOCyGF5/p eIhrOn24oBf67KtdAN3H9JoFNUVTYJc1VJU3R1JtVdgwEdr+NEciEfYl0O19VpLE/PZxP4wX PWnhf5WjdoNI1Xec+RcJ5p/pSel0jnvBX8L2cmniYnmI883NhtGZsEWj++wyKiS4NranDFlA HdDM3b4lUth1pTtABKQ1YuTvehj7EfoWD3bv9kuGZGPrAeFNiHPdOT7DaXKeHpW9homgtBxj 8aX/UkSvEGJKUEbFL9cVa5tzyialGkSiZJNkWgeHe+jEcfRT6pJZOJidSCdzvJpbdJmm+eED w9XOLH1IIWh7RURU7G1iOfEfmImFeC3cbbS73LQEFGe1urxvIH5K/7vX+FkNcr9ujwWuPE9b 1C2o4i/yZPLXIVy387EjA6GZMqvQUFuSTs/GeBcv0NjIQi8867H3uLjz+mQy63fAitsDwLmR EP+ylKVEKb0Q2A== In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspam-User: X-Stat-Signature: eae1f1yxtbwf18wtxnstcpkf5j9ua3mx X-Rspamd-Queue-Id: 2AE20C0015 X-Rspamd-Server: rspam11 X-HE-Tag: 1725612725-315230 X-HE-Meta: U2FsdGVkX1+uwvMHvBfYPVaiA3Q0aHC5YFoNKNz4+HGR7ZLfBU7EUTrrOYjgpnMxtzPbCiDXFuTgKIGyeAhPqfUhSGjo7i6w01C9RqwEpQ6NwdYjvq3PCcUqqkAkQAKESnMzmKMzHC9MGavYqvz2RSUFMnZtsrnR3dAa8kv1rCLnNspyRHq3BdzUY2NOG2SAokm+jUABLlqnBzYrK004q1yE2EcA2NTX+BJDn86bifOzxqrbzwJTsIEGT4v3Zpi4S/AK9zIu7krprZ2sdak+mvARLx57TQsphQ7rljwjMCF0uX5naanW9akWEEd09XsXq+pHnTa7hkDdrlXb8PQq7BqoTR+vpqzLOGPYPceq8pTWN+KLyou+y6T/VQZPJrOMvlX16xCV3eFH4rcCWRBN/LhJf+GW+lOzJRd9hC/O9NUcJVBD+5lOyLBRctcwgFCAEDbnnuwsP15IhANOKld6OhYz+hXYoRM8pFjbRPn6Lpf+BERok1a8NWkUhOVU3kqZyuaDFy1WLIdkw58H+dDtUoIP9rCD3g9VSc6ijaz4FU0Iwqf1eucRUez7AxNDwixnhbLAACU2s626KBby6oXdVvuvHuw5IB1A3WbMTeDskwQapfiTAWZnUSiUCReNrtZskAHJEX3VSLYlU1Z3VYHDy1RwczOy3f5D+Z/lyYYg4ckYqulWaOAdQPtma/w7W8GvL+Rb8AScEZe9GRChCggL13k1cVYmnG38I2GrTbDc072yL7LU011sw6Ie0minFfe/vyt+7xVrF5y62092p0NDvBP0XW71UUNP8mfIMC4T1+X1q5x7ngJI/owsLd0Ntn6bEvN6dFpPnmlFLUVio03FiEBy/E8B1JTUH/fwd5zR2+NgenvwNeQ0LEPIoKHo1WL/4ArrNWWidus1tVzrrkI1Gc6GxGQhlbHwGxZkr0Qsj+G5o8zfdXPmhQs5jK5qf2712YZ7wtlYMM6xyCcF4E6 33fb7pT9 8jhP7WnKQNd4yE/1uql6c4Tq0IEaLEu33ATAbBMqciizQcQH1pLvDB1tpFlxYE2g48qPoB9vI8fSPm3PkVOg6zulcURbu0WtxCNJRGDcMPQMkrbgAm5qFZbWq1guFh2y0ZkCN7686zu9c87rXkaTzbSyyMmDRWHyPr1BqWBt2lXUoZyZkJBk1nrQ/YOSD2siDu3K4u39/Pdkoom2fBOM5WIZRLhfTgyr5UM0zogE5CUnhZah+CKwENCyJKiNCLStaT33Ly9Nc7uPnHCn+pRk0TbfvImoJOODUIPf8JlWUryjeZKmwgLdD2pZDkXLR1fdafLTTYlpTNHme+/iaV5ujb5fxTpUresmVbuu3d5ntaYEJ9i2EjiVxPjARWl98ANVkJcuV X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 9/5/24 20:48, Shakeel Butt wrote: >> > --- >> > v3: https://lore.kernel.org/all/20240829175339.2424521-1-shakeel.butt@linux.dev/ >> > Changes since v3: >> > - Add kernel doc for kmem_cache_charge. >> > >> > v2: https://lore.kernel.org/all/20240827235228.1591842-1-shakeel.butt@linux.dev/ >> > Change since v2: >> > - Add handling of already charged large kmalloc objects. >> > - Move the normal kmalloc cache check into a function. >> > >> > v1: https://lore.kernel.org/all/20240826232908.4076417-1-shakeel.butt@linux.dev/ >> > Changes since v1: >> > - Correctly handle large allocations which bypass slab >> > - Rearrange code to avoid compilation errors for !CONFIG_MEMCG builds >> > >> > RFC: https://lore.kernel.org/all/20240824010139.1293051-1-shakeel.butt@linux.dev/ >> > Changes since the RFC: >> > - Added check for already charged slab objects. >> > - Added performance results from neper's tcp_crr >> > >> > >> > include/linux/slab.h | 20 ++++++++++++++ >> > mm/slab.h | 7 +++++ >> > mm/slub.c | 49 +++++++++++++++++++++++++++++++++ >> > net/ipv4/inet_connection_sock.c | 5 ++-- >> > 4 files changed, 79 insertions(+), 2 deletions(-) >> > >> > diff --git a/include/linux/slab.h b/include/linux/slab.h >> > index eb2bf4629157..68789c79a530 100644 >> > --- a/include/linux/slab.h >> > +++ b/include/linux/slab.h >> > @@ -547,6 +547,26 @@ void *kmem_cache_alloc_lru_noprof(struct kmem_cache *s, struct list_lru *lru, >> > gfp_t gfpflags) __assume_slab_alignment __malloc; >> > #define kmem_cache_alloc_lru(...) alloc_hooks(kmem_cache_alloc_lru_noprof(__VA_ARGS__)) >> > >> > +/** >> > + * kmem_cache_charge - memcg charge an already allocated slab memory >> > + * @objp: address of the slab object to memcg charge. >> > + * @gfpflags: describe the allocation context >> > + * >> > + * kmem_cache_charge is the normal method to charge a slab object to the current what is "normal method"? >> > + * memcg. The objp should be pointer returned by the slab allocator functions >> > + * like kmalloc or kmem_cache_alloc. The memcg charge behavior can be controller >> >> s/controller/controlled > > Thanks. Vlastimil please fix this when you pick this up. I felt it could be improved more, so ended up with this. Thoughts? /** * kmem_cache_charge - memcg charge an already allocated slab memory * @objp: address of the slab object to memcg charge * @gfpflags: describe the allocation context * * kmem_cache_charge allows charging a slab object to the current memcg, * primarily in cases where charging at allocation time might not be possible * because the target memcg is not known (i.e. softirq context) * * The objp should be pointer returned by the slab allocator functions like * kmalloc (with __GFP_ACCOUNT in flags) or kmem_cache_alloc. The memcg charge * behavior can be controlled through gfpflags parameter, which affects how the * necessary internal metadata can be allocated. Including __GFP_NOFAIL denotes * that overcharging is requested instead of failure, but is not applied for the * internal metadata allocation. * * There are several cases where it will return true even if the charging was * not done: * More specifically: * * 1. For !CONFIG_MEMCG or cgroup_disable=memory systems. * 2. Already charged slab objects. * 3. For slab objects from KMALLOC_NORMAL caches - allocated by kmalloc() * without __GFP_ACCOUNT * 4. Allocating internal metadata has failed * * Return: true if charge was successful otherwise false. */ >> > + >> > + /* Ignore KMALLOC_NORMAL cache to avoid circular dependency. */ >> >> Is it possible to point to the commit that has the explanation here? >> The one you pointed me to before? Otherwise it's not really obvious >> where the circular dependency comes from (at least to me). >> > > Not sure about the commit reference. We can add more text here. > Vlastimil, how much detail do you prefer? What about: /* * Ignore KMALLOC_NORMAL cache to avoid possible circular dependency * of slab_obj_exts being allocated from the same slab and thus the slab * becoming effectively unfreeable. */ > thanks, > Shakeel