From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3A73EC4332F for ; Thu, 29 Dec 2022 01:16:14 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id CE1B78E0002; Wed, 28 Dec 2022 20:16:13 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id C699C8E0001; Wed, 28 Dec 2022 20:16:13 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A96898E0002; Wed, 28 Dec 2022 20:16:13 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 969968E0001 for ; Wed, 28 Dec 2022 20:16:13 -0500 (EST) Received: from smtpin12.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 790E1A0957 for ; Thu, 29 Dec 2022 01:16:13 +0000 (UTC) X-FDA: 80293577826.12.C8FC0D6 Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by imf13.hostedemail.com (Postfix) with ESMTP id 0AA5320007 for ; Thu, 29 Dec 2022 01:16:09 +0000 (UTC) Authentication-Results: imf13.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=aL92hNEy; dmarc=pass (policy=none) header.from=intel.com; spf=pass (imf13.hostedemail.com: domain of fengwei.yin@intel.com designates 192.55.52.151 as permitted sender) smtp.mailfrom=fengwei.yin@intel.com; arc=reject ("signature check failed: fail, {[1] = sig:microsoft.com:reject}") ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1672276570; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=oAW6Xo/kzrNovOiD/3DkheMPJwNDxFbvYMfeGZdE88Y=; b=MJSl03sxxzBRKPAkYSK4qgmK6RF+zif1E6INVRf47pDMhjYByESVtqMxMHHBPV66WY6CwZ xf7IBB2MDt+jb9sR9fn7WVx8uf0w1+mw4NMOn39pf6pB/952n5bWipOCtnx8vaGnWuFaYq OSeV32IiF2cf3usTzw8B51FCRH1y4fc= ARC-Authentication-Results: i=2; imf13.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=aL92hNEy; dmarc=pass (policy=none) header.from=intel.com; spf=pass (imf13.hostedemail.com: domain of fengwei.yin@intel.com designates 192.55.52.151 as permitted sender) smtp.mailfrom=fengwei.yin@intel.com; arc=reject ("signature check failed: fail, {[1] = sig:microsoft.com:reject}") ARC-Seal: i=2; s=arc-20220608; d=hostedemail.com; t=1672276570; a=rsa-sha256; cv=fail; b=OxQ6JeBYKcKPoKjK2wyjcVLk2RQXKeFUKutFfErTFy4sq4lkUJm5HaAkiA7IZr5drzuMgH SeEBLpMQcRCq364F4JT6y+JXEbgQ/8zlLV9DdyaUPxXbOW+/xfgeo9TCjnJEpPoDg50Y8V JIiPBD4k1U6cx6dbo0LPFuN/NJMMh/0= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1672276570; x=1703812570; h=message-id:date:subject:to:cc:references:from: in-reply-to:content-transfer-encoding:mime-version; bh=nmCHN9hGK8cQ6kY1rkxn70N/9gDnOeKrxzg0fOx8iJk=; b=aL92hNEydP5a3RbEw69ZPRBTWkNH5/uQ8KgVPY7dLEhmXJQHW/FJ6vV2 b7/rfg1BAZjJVq9mjG9qrsrZZUzZ7PIkTSxRA3CCgv6rykNIMBD74Er9D 2kwvWokwZoXGMBvXhP1xBoHoZWJLFPyfAjG2lu1JTnYhq5wTJC0efJpME 8aExrKtWazjKefosnZP8RuGZiP8ga1NCr8mwRah4wsy44vU9EcwqD3qJn 4K9q57KZ952Ir/KeMsCHd4DQB0Ki5mrcjpGK5MIVbs4svRs4noUP2OX/s iESQQTfwMJarPjet+Bptp1oqPW9J22xpiykMCwm3SggJrZ7X+g1U6JoeV w==; X-IronPort-AV: E=McAfee;i="6500,9779,10574"; a="301325943" X-IronPort-AV: E=Sophos;i="5.96,282,1665471600"; d="scan'208";a="301325943" Received: from orsmga001.jf.intel.com ([10.7.209.18]) by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 28 Dec 2022 17:16:08 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10574"; a="685832862" X-IronPort-AV: E=Sophos;i="5.96,282,1665471600"; d="scan'208";a="685832862" Received: from orsmsx601.amr.corp.intel.com ([10.22.229.14]) by orsmga001.jf.intel.com with ESMTP; 28 Dec 2022 17:16:05 -0800 Received: from orsmsx611.amr.corp.intel.com (10.22.229.24) by ORSMSX601.amr.corp.intel.com (10.22.229.14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.16; Wed, 28 Dec 2022 17:16:04 -0800 Received: from orsmsx602.amr.corp.intel.com (10.22.229.15) by ORSMSX611.amr.corp.intel.com (10.22.229.24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.16; Wed, 28 Dec 2022 17:16:04 -0800 Received: from ORSEDG601.ED.cps.intel.com (10.7.248.6) by orsmsx602.amr.corp.intel.com (10.22.229.15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.16 via Frontend Transport; Wed, 28 Dec 2022 17:16:04 -0800 Received: from NAM10-MW2-obe.outbound.protection.outlook.com (104.47.55.105) by edgegateway.intel.com (134.134.137.102) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.16; Wed, 28 Dec 2022 17:16:04 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=hIEOk65aemn0mU34MBJwu3nqHKYVp4c4fzz2sCJtkWAWutseu8X4UmlP0rzAVNKQOoIHCtikO8g7eLtYv7G8LTBk2lKMxoV0om+h2PqcmdYNP5KFOSJ1YKkESeX9wd8Fpp9jdSFimM6DlXEXAMuTncWjGsv4WP3Bi5H6OLB2ib2aF3WjuFL0KScSnFvipfGXwLzHw1RQzs8+G0ICtUITW+3Fvtptyf2HS8gNusX9Alm3H3cjqV7G3Mw5tJB3SNXAuOtbFua5bPAKUDD3F5SQrkWJSLSH4xXODmN3vAUDO1X42bp0alxjQp5tcqUQMipWwNmPUebhd7yS7DYkGvUSYg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=oAW6Xo/kzrNovOiD/3DkheMPJwNDxFbvYMfeGZdE88Y=; b=MOj1V804oCv0wQp3BUTNP0igkxts+x2qweq9cL9lSFqG6YheQHPiqYsEN7f4kJ3NJfFeIQlQnZFYElyGbqbaqRqChkxwSFu4eTal5QgyHXM4FXxEf26VNfbBTXl9c9KqEkzMRmHgN4Et7+e0h/s6sg7004eMpdhysEgpj+IIM7qUezkjzKp33mLU1WMhakKpeKe36ZPRE3f4jL9n39sV+fENQBctb+/CXqmVYolby5CDEJ3SsXWuzefkxcH1/Q4dAUCUZaZIJNRhlb4TeOnIRxVLdirAAEkuoGQwdiluCXD7H652Chrg44A13qMkPHfTJzR2JJjdlrwgpWMtBXF3CA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from CO1PR11MB4820.namprd11.prod.outlook.com (2603:10b6:303:6f::8) by SJ0PR11MB4941.namprd11.prod.outlook.com (2603:10b6:a03:2d2::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5944.16; Thu, 29 Dec 2022 01:16:02 +0000 Received: from CO1PR11MB4820.namprd11.prod.outlook.com ([fe80::505b:18be:f1dd:104e]) by CO1PR11MB4820.namprd11.prod.outlook.com ([fe80::505b:18be:f1dd:104e%9]) with mapi id 15.20.5944.016; Thu, 29 Dec 2022 01:16:02 +0000 Message-ID: <57261dc9-e498-766f-e244-32b5e48b28b4@intel.com> Date: Thu, 29 Dec 2022 09:15:54 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Firefox/102.0 Thunderbird/102.6.1 Subject: Re: [RFC PATCH] mm/thp: check and bail out if page in deferred queue already Content-Language: en-US To: "Huang, Ying" CC: , , , , , , , , References: <20221223135207.2275317-1-fengwei.yin@intel.com> <87ilhwxox0.fsf@yhuang6-desk2.ccr.corp.intel.com> From: "Yin, Fengwei" In-Reply-To: <87ilhwxox0.fsf@yhuang6-desk2.ccr.corp.intel.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-ClientProxiedBy: SI2PR02CA0003.apcprd02.prod.outlook.com (2603:1096:4:194::13) To CO1PR11MB4820.namprd11.prod.outlook.com (2603:10b6:303:6f::8) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CO1PR11MB4820:EE_|SJ0PR11MB4941:EE_ X-MS-Office365-Filtering-Correlation-Id: c23fa848-a491-4650-a604-08dae93a400d X-LD-Processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: kCBev+DJl1+9Vx0H7H5smcZOTqPiP3S7DfqvZPB1nLLUBEyMZuDQ0juuhcZSFypigjqBwqMyrBoztnCRnTCCCqSK2lgHQrFsYfZ1wQPYQv49jypirNnRIte3wKNu36gS9jJ1pYboNmwDipwXgFQOsmNW9AFpsPJoNEedul+B3I9joBd6ueLTZ5cY9k9WnwzaLfirDgZmyD+axx+I8cEndjaL0zfuy7Bpm+VJolM4Mur7qHOZJehwCpqFeYh79go4d7sWKOdvisS3651OI70bymt1Rayily332kvcg8FPGZFKFOJ4pekvMlr5Xy3uYf/qdwi9BLIYwt7oBY/JQnR+5LoiKWQcsVMnFVpLsZDYYdGeU4GvTASBLF6t/U//Fa1IagUZC9bB3oyG6kc8LK04rUmxgWY72gCFF9CwkJLU8TBFzldRCW4HGtLNEFObzmjh8WtkAAiwHbYZ43rpiJCKv4fo8/F2Qta59ObP7/B2ASQHKKOtxqBT5T+Nq9GHHL0MC4Uk5f2cpAmlRW+tDNZv38BYgpL1yl+aQ7C8VFK/HblFb1zdexzsSvwWZYYH4sG5ORkXgo/WOGpC/MvySOESeIkiqYyHYiZrTOEhDx1SKy4XCjVWM9SXTYeKHErkIzy1oU/45q/gDefzeOR6LkKp/bpBdSxM/hMy2Wl4uY1108wPzRuMWPD3U0ZxAnR2OWgUNGZwH9QioyfYQ7eG8mEuJFFE26C8ylnEAU2ADCwADtM4inYQtqrN+BZxevWJUTYb X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:CO1PR11MB4820.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(376002)(396003)(366004)(346002)(39860400002)(136003)(451199015)(53546011)(2616005)(6506007)(26005)(186003)(6512007)(6486002)(966005)(478600001)(37006003)(316002)(86362001)(6666004)(2906002)(31696002)(6636002)(31686004)(82960400001)(36756003)(38100700002)(41300700001)(66476007)(66946007)(5660300002)(66556008)(6862004)(4326008)(83380400001)(8936002)(8676002)(43740500002)(45980500001);DIR:OUT;SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?aFlOOUdoSmJPVHBLdUYrWGZxTHpXeXBqYVZaRElRZWY0cWdBUHBvTzF1TDFt?= =?utf-8?B?Q2U4blhQSit2ckZsNFlURDdvWXQ4VC9ZZjNxRjJ6V1g5VXFjUkxpT21DMFhB?= =?utf-8?B?UHJuUGZNVUo4U3lQNEk3clF4eGJ3T3V4ajBYTGtvamVlUkx6SFoxU3N2QlJj?= =?utf-8?B?M0R0Y0JQRkRGaHFmc0hvY0libm91Z2JrK0FrSm9MY0ZIQzFwenlhMUUyekhV?= =?utf-8?B?YkQvZGZEUk1pYzlUZTcyeDVJZmtlTC9LRE0rcStXQkI3dXlUZ3VLT3VxMENK?= =?utf-8?B?ejNkZ0FwWGFtZjVBSE1MMGp1dmF4OUdKYTdwcG1RazF4SXlvSldJQU5lMndE?= =?utf-8?B?Nk8wQUljM2tkY0JhN2lWQVFiYjdmeG5pTFg0Sk94M0IyT1JoWjlKeG16MDhX?= =?utf-8?B?RTh5T0tQN3FiQTJ3MW1yampJTkFPSmgyOXBOVWVzWHFSQ21xYXBBOVBjZ3lF?= =?utf-8?B?S1VkcFczOGFMNTZPOUFRNS9zWjMrTXdEYmNYejRIOTRPbUFKSXRNRURqN25X?= =?utf-8?B?N1d6cUpyb0t0ZUFheVRjdE9qL25HcmNFWXdXQko4c05wTEVOeHBqY0xyZ1hv?= =?utf-8?B?YnBJOHR2NzAwTGxOV2VtZUpMTVNkaVNMR2NUUGhwc2hLRjR3VytWYzBBbElu?= =?utf-8?B?SStkL3J2QkYxTTdxbE9CM1ZYdG52d094Y0M0aUtnQXhoQk5MMHpxU0FacGpi?= =?utf-8?B?TGFWQldWVEREdU54dmdDWWp6NjgvaWZ5dGZ5ZERFTit3ZktXV1pDT0lBVlh1?= =?utf-8?B?LzZYNG1TTFJQNzhMM0V6N0RsZWdCZVNLUGlyeXE5dHArbW9ZMFhtMEFpWFh0?= =?utf-8?B?UjBqb0F0Nm1PZVF4cGpyb1JwR0hvek9yc0VkNFR5WFgzV2taWTRka0tiMFZK?= =?utf-8?B?ejZOUWlsRjNUa2lzL1RWUlhtd2dOSzNSZ1JYQXc4a0w3NVpyTTJSWlVCZ0pj?= =?utf-8?B?djdlV0ZvNkxwV2hhVGJWYTRXMndxcVFMbzZ1WUx0dlNKM1BrYnNjdXVhUXFX?= =?utf-8?B?YUdUbC8vODJLdTlqNmg2SlhURWk2K0J3Q3I2d2I3NTQvOUZsbHdoc2NIbjYz?= =?utf-8?B?ZHcvTkIxUzJZWnhuRGg5cy9GRElRam15bGZBVm5MT1B0bXlXaU9FRjllK2g3?= =?utf-8?B?RGIvYjlnNHU4RS9SMldtVkFnZFFYbHhYWkl4UmZDOWx5YkRpTUQxV0JwQ0Ns?= =?utf-8?B?a3JFejBjWkxDNHVyWmZ0c25sNVdubml6b3F5YU5RYysvdk9KZWxZRlZ3YktI?= =?utf-8?B?a1FzWi9qQjlFNk5ZY2tTSkRYV29WNE5IeHczYTMvWmpJOURKK1lJSDYwcWF6?= =?utf-8?B?M1NIek9SSG1WZXR4MlRsN042TzMzcGQvSGNsV0VGd0J6NDQrMi9GVHljZFZy?= =?utf-8?B?RDU5bUxZUWxyOEJua29RdTdpdVB2RWZibUpvNTlKUk42ZGFGTXlIdG0xdDdF?= =?utf-8?B?Qm5CRVNkcEVkaVc4bzgyTVU0NFpPZ2RRWVNVSExZY1BsUC90L1BYSklmWFkx?= =?utf-8?B?TmN1aEtaeVgrTkNIMk5TQTlPOTJ3ME5tcXc1ODlzdDFtRGEweWV4Z1R3NUFk?= =?utf-8?B?QnhPdGJzKzZGYjlhNHpRZzA1WE52Z0JvdndtNGdGNWZGaG9mM2JuMFIvdG1h?= =?utf-8?B?ZEhQOEFaYWcxakw5K3NzUVRLcVZUbjg5YlBxekxVcGdoMGN4WFRTWHlQV0JZ?= =?utf-8?B?Tks0VC9sVDZHdzNIcStvRzBmQVlJNFJqZnlmRUpNU0wwS3Qwd084Y0RBVW52?= =?utf-8?B?SkJNcUlGUHE0RUlZZnNtenZRMG5LcGhXdWxzcHVFKzlTdmM2TWpRNUIyb0N0?= =?utf-8?B?MEtIcHJWaExOZk03OFduSjJEMXpGMEFvN3FPaXJid205dU1nWE5XS0thN01x?= =?utf-8?B?d0ZCTGNqNWdzRDdJeFFjb2ZwUnYrWklTb3pMQmhVaDJDY3pCaUh2VWpuWm90?= =?utf-8?B?cjlGeC9aTFRVSW9LNTJCVkR4QU5CckczM3k1VHdDSVRLM0UyTkoyczhpMEhJ?= =?utf-8?B?ZXlsZFNtUmdWNHcxcWo3Vm5QWXpybUtnNkJLdmFLNVUvU0t0dEFNSlBQOXhK?= =?utf-8?B?T2tpQXk1OWZsbUdaQ3hORitLV0lLZWRsOTYwNFpNZmxzaVZPaFZDODg4bC94?= =?utf-8?Q?Hb3mT4/apEaCCSif4RzgrqoDg?= X-MS-Exchange-CrossTenant-Network-Message-Id: c23fa848-a491-4650-a604-08dae93a400d X-MS-Exchange-CrossTenant-AuthSource: CO1PR11MB4820.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 29 Dec 2022 01:16:01.9450 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 77QN7sWcw4POTSajA0tyHeSiyxk/zBuj29ksMDg4YRXp9PZ/umPtEglyi+Ysw2tqVQH8aS/4Gnl3gySpguO3Xg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR11MB4941 X-OriginatorOrg: intel.com X-Rspamd-Queue-Id: 0AA5320007 X-Rspamd-Server: rspam09 X-Rspam-User: X-Stat-Signature: 1s7rwkhgewbqtiabwo3w4pyonim6zgs7 X-HE-Tag: 1672276569-624191 X-HE-Meta: U2FsdGVkX1/Syly8RSDIk+5k0yoqNzKiqeyCwUElqyfvEN7awaLcgNUSmq+iyJtcxnYfo2HpTXJPXgAS3D2sMT2J45ePd4tgh0n6wFkeY/U5wfJvD4NhyPfNndn8836kuQYsCELAyyKsIkXrn+KjiBClFHYNNwKjg8JlMrGEEcHAdeawFzAPajPUM3dCmm5e7564jgrWM9rG7Nx9JfjMz6fEm4k19UXwPDKW34Ve8Ojv5AEOJ1nNIUfA1ew7JgViWRiQtsCo4m3zPUIdqQzpb/7nmVw233Kdd+5VmsuUyJGzWrPOj4b0Fj6S3aKBJZ/rCX9f8uOi5A2r1HHSysZKEY+qxe1j0mQwmLx4vorN476ito2+xDbqkiMoxDYJ8dZCL0+DvtUHXIlJ0Arx/4FJoftbjTFOUTCgCUNuwRzgWc3jEcKQ+zAOpGHqxCskH2fucY/QOXyGG84aOdS6ZtK90Kjdy8NdVdHgoUu9+XESavGEYaUnqMYiYabZStXPDP7EtCrS79temjiTqaX3idtK+6bLvj+OQ+PCfOeGGaPwI1GPhdnwFf7rRrhjAatkcZit0KDT1YERb+jw+DaW3IR/JLJmOI1ySX2Bgqvgw1hNjCLOTmllWIhlMybtjRXdNtgil8i3bU72Kh2wtuS/nmCXL+jJVzb6EGg6TP9AZ29YsDUj00sKKtWtVxnbgLEUxQ4+MIqpHTPhJHqCkGrZbm6vWvvOqJ6aIisdRzn2I33NmUvE6BjL/z2IBjfvPj4c4pjnA0uu0/WsWHSw8a9WeJ90oBf38Dupl0AIJYYZgLjr3e1MXV2tzxYhSfbPNikkw8dBXFyTymn0rLgdekqnQ1G5zdvmPO1reiZpPI0bTulqiopSGFrTKORmAzV/etWmv/vLBDO3jfsRNiCVOaXXqO4dCpnD2fzhmjOE X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 12/28/2022 10:06 AM, Huang, Ying wrote: > Yin Fengwei writes: > >> Kernel build regression with LLVM was reported here: >> https://lore.kernel.org/all/Y1GCYXGtEVZbcv%2F5@dev-arch.thelio-3990X/ >> with commit f35b5d7d676e ("mm: align larger anonymous mappings on THP >> boundaries"). And the commit f35b5d7d676e was reverted. >> >> It turned out the regression is related with madvise(MADV_DONTNEED) >> was used by ld.lld. But with none PMD_SIZE aligned parameter len. >> trace-bpfcc captured: >> 531607 531732 ld.lld do_madvise.part.0 start: 0x7feca9000000, len: 0x7fb000, behavior: 0x4 >> 531607 531793 ld.lld do_madvise.part.0 start: 0x7fec86a00000, len: 0x7fb000, behavior: 0x4 >> >> If the underneath physical page is THP, the madvise(MADV_DONTNNED) can >> trigger split_queue_lock contention raised significantly. perf showed >> following data: >> 14.85% 0.00% ld.lld [kernel.kallsyms] [k] >> entry_SYSCALL_64_after_hwframe >> 11.52% >> entry_SYSCALL_64_after_hwframe >> do_syscall_64 >> __x64_sys_madvise >> do_madvise.part.0 >> zap_page_range >> unmap_single_vma >> unmap_page_range >> page_remove_rmap >> deferred_split_huge_page >> __lock_text_start >> native_queued_spin_lock_slowpath >> >> If THP can't be removed from rmap as whole THP, partial THP will be >> removed from rmap by removing sub-pages from rmap. Even the THP >> head page is added to deferred queue already, the split_queue_lock >> will be acquired and check whether the THP head page is in the queue >> already. Thus, the contention of split_queue_lock is raised. >> >> Before acquire split_queue_lock, check and bail out early if the THP >> head page is in the queue already. The checking without holding >> split_queue_lock could race with deferred_split_scan, but it doesn't >> impact the correctness here. >> >> Test result of building kernel with ld.lld: >> commit 7b5a0b664ebe (parent commit of f35b5d7d676e): >> time -f "\t%E real,\t%U user,\t%S sys" make LD=ld.lld -skj96 allmodconfig all >> 6:07.99 real, 26367.77 user, 5063.35 sys >> >> commit f35b5d7d676e: >> time -f "\t%E real,\t%U user,\t%S sys" make LD=ld.lld -skj96 allmodconfig all >> 7:22.15 real, 26235.03 user, 12504.55 sys >> >> commit f35b5d7d676e with the fixing patch: >> time -f "\t%E real,\t%U user,\t%S sys" make LD=ld.lld -skj96 allmodconfig all >> 6:08.49 real, 26520.15 user, 5047.91 sys >> >> Signed-off-by: Yin Fengwei > > Thank you for fixing. > > Reviewed-by: "Huang, Ying" Thanks for reviewing the patch. Regards Yin, Fengwei