From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5471CC4321E for ; Sun, 27 Feb 2022 16:29:59 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 4B7808D0002; Sun, 27 Feb 2022 11:29:58 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 467BD8D0001; Sun, 27 Feb 2022 11:29:58 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 3579D8D0002; Sun, 27 Feb 2022 11:29:58 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (relay.hostedemail.com [64.99.140.25]) by kanga.kvack.org (Postfix) with ESMTP id 2762F8D0001 for ; Sun, 27 Feb 2022 11:29:58 -0500 (EST) Received: from smtpin03.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay11.hostedemail.com (Postfix) with ESMTP id BD43B80E53 for ; Sun, 27 Feb 2022 16:29:57 +0000 (UTC) X-FDA: 79189096434.03.E155664 Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) by imf21.hostedemail.com (Postfix) with ESMTP id ECB091C000C for ; Sun, 27 Feb 2022 16:29:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=desiato.20200630; h=Content-Transfer-Encoding:Content-Type :In-Reply-To:From:References:Cc:To:Subject:MIME-Version:Date:Message-ID: Sender:Reply-To:Content-ID:Content-Description; bh=OYI0DMvnPqa+60GAv7cFVpt7mnjohAntl6p3vksWtnQ=; b=DjcB7DVFVspRVXyu9GOKwXTCvJ PygxXcz+mHkNERbXGaHuaEQSQNGE07Sn6k1QKYNpfSGYgU/KVQ2DuhcSTSu9rx7whuoBbX5evQxrf jR+N49UQxf/Zc57YH1h3u4JyXE1En/66s32b2KQtbKaEfGrXqSlDQCaJtLcNrVoDOOsvhGFSFkli6 7iQ4ANmjmBVIi4BlaUOWE28JQf7KdPkcJrWAzY82WMUplla8k/Hm/G9Js0oALjht1Aa6TCjMgCkRp V5LYwfTiElkwJK0DxmSvatO1l25IZyC0F+mRyJrGXyY+CG4ZKk0zE7SvQTHVHA20o98KTKL8CEOuf 0k0RiJqQ==; Received: from [2601:1c0:6280:3f0::aa0b] by desiato.infradead.org with esmtpsa (Exim 4.94.2 #2 (Red Hat Linux)) id 1nOMQZ-00Db39-I2; Sun, 27 Feb 2022 16:29:43 +0000 Message-ID: <572369c5-85e4-75af-85f4-d150c25e75fd@infradead.org> Date: Sun, 27 Feb 2022 08:29:36 -0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.6.1 Subject: Re: [PATCH] mm/vmalloc.c: fix a comment Content-Language: en-US To: Yixuan Cao , akpm@linux-foundation.org Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org References: <20220227084544.4681-1-caoyixuan2019@email.szu.edu.cn> From: Randy Dunlap In-Reply-To: <20220227084544.4681-1-caoyixuan2019@email.szu.edu.cn> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: ECB091C000C X-Stat-Signature: k4r91ynida4kq6bdg99wixpeiepr6wrh X-Rspam-User: Authentication-Results: imf21.hostedemail.com; dkim=pass header.d=infradead.org header.s=desiato.20200630 header.b=DjcB7DVF; spf=none (imf21.hostedemail.com: domain of rdunlap@infradead.org has no SPF policy when checking 90.155.92.199) smtp.mailfrom=rdunlap@infradead.org; dmarc=none X-Rspamd-Server: rspam07 X-HE-Tag: 1645979396-275915 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 2/27/22 00:45, Yixuan Cao wrote: > Dear Sir/Madam, > > The sentence > "but the mempolcy want to alloc memory by interleaving" > should be rephrased with > "but the mempolicy wants to alloc memory by interleaving" > where "mempolicy" is a struct name. > > Thanks and best regards, > Yixuan Cao > > Signed-off-by: Yixuan Cao > --- > mm/vmalloc.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/mm/vmalloc.c b/mm/vmalloc.c > index b454cf1a261f..89d48d8eb20c 100644 > --- a/mm/vmalloc.c > +++ b/mm/vmalloc.c > @@ -2905,7 +2905,7 @@ vm_area_alloc_pages(gfp_t gfp, int nid, > /* memory allocation should consider mempolicy, we can't > * wrongly use nearest node when nid == NUMA_NO_NODE, > * otherwise memory may be allocated in only one node, > - * but mempolcy want to alloc memory by interleaving. > + * but mempolicy want to alloc memory by interleaving. s/want/wants/ as in your commentary above. > */ > if (IS_ENABLED(CONFIG_NUMA) && nid == NUMA_NO_NODE) > nr = alloc_pages_bulk_array_mempolicy(bulk_gfp, thanks. -- ~Randy