From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 083FBC77B7A for ; Wed, 7 Jun 2023 07:45:48 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 3C56A8E0002; Wed, 7 Jun 2023 03:45:48 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 375316B0074; Wed, 7 Jun 2023 03:45:48 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 23C958E0002; Wed, 7 Jun 2023 03:45:48 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 0FE206B0072 for ; Wed, 7 Jun 2023 03:45:48 -0400 (EDT) Received: from smtpin15.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id C9998140130 for ; Wed, 7 Jun 2023 07:45:47 +0000 (UTC) X-FDA: 80875167534.15.6D6781C Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) by imf13.hostedemail.com (Postfix) with ESMTP id ABDB920013 for ; Wed, 7 Jun 2023 07:45:45 +0000 (UTC) Authentication-Results: imf13.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=ZDkJ+wP8; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b="zyDAsG/S"; spf=pass (imf13.hostedemail.com: domain of vbabka@suse.cz designates 195.135.220.29 as permitted sender) smtp.mailfrom=vbabka@suse.cz; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1686123946; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=kuzBLDH+6vBS19qokiGMN61hDvOG3cixMFx4ZnGpwsY=; b=Fr6CiZZq8p1Akahb3epKeJqxqiT2kZ+j2qqQNXmHyc+88VheGmgJZUQRWQ3n0FkKtahozk bQY4gXJPbNp4ajEFNjCiOeKbMSsjt07ELGZ777W+zaAlHNNi/kFRLKpWhOyJ9Ew9m3mFre wjZGpYLEipfgPvXU4dMpdq5EZprla6k= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1686123946; a=rsa-sha256; cv=none; b=uOzmmtPXqwzIHTIiI+GAE1sNGttnImTCuOOOr1s6ataCERFFiE2HCRhpK5aEpsar0aLXWX n3Xm9FtNa8nOzPanUPTBd7AmSQNOld+8MxxJIQxv7D73TeWvOkxt4Rd/7+2MBT18sdcuVR XAjxFmIgEnf3GMaNRMoBqsQIhATe0dw= ARC-Authentication-Results: i=1; imf13.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=ZDkJ+wP8; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b="zyDAsG/S"; spf=pass (imf13.hostedemail.com: domain of vbabka@suse.cz designates 195.135.220.29 as permitted sender) smtp.mailfrom=vbabka@suse.cz; dmarc=none Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id D90C11FDA7; Wed, 7 Jun 2023 07:45:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1686123943; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=kuzBLDH+6vBS19qokiGMN61hDvOG3cixMFx4ZnGpwsY=; b=ZDkJ+wP8Mk1V/Gd6g8XOWPnH7eQTgy7RacOhnKeA+SsDIxenMOIUXFebEOuHd6KqQ427io LoBSLRjHgMr4kPdRG1+i/MFd9BGqm+aR/V7Hx4IG/9u48F2p+Lm6lsBKbjqhhGmlEiINZi R8q+PDmS/Ej5gskkjY+fqjtEXyedPgM= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1686123943; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=kuzBLDH+6vBS19qokiGMN61hDvOG3cixMFx4ZnGpwsY=; b=zyDAsG/SWmg9baJajNBw87o4keZirFobvvi8GI83urryWwLZAiL3l/gXexud90fOb/yXui zM0qgtsA2dzdZ3Ag== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id A983F13776; Wed, 7 Jun 2023 07:45:43 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id AqTkJ6c1gGRlKQAAMHmgww (envelope-from ); Wed, 07 Jun 2023 07:45:43 +0000 Message-ID: <571c997a-0f26-4076-f5c4-cf2aacd36e90@suse.cz> Date: Wed, 7 Jun 2023 09:46:23 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.11.0 Subject: Re: [PATCH] mm/mprotect: Fix do_mprotect_pkey() limit check To: "Liam R. Howlett" , Andrew Morton Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, Lorenzo Stoakes , Jeff Xu , stable@vger.kernel.org References: <20230606182912.586576-1-Liam.Howlett@oracle.com> Content-Language: en-US From: Vlastimil Babka In-Reply-To: <20230606182912.586576-1-Liam.Howlett@oracle.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: ABDB920013 X-Rspam-User: X-Stat-Signature: 4i18ss7fzazp9bm6nkybqy18a3qq7q3u X-Rspamd-Server: rspam03 X-HE-Tag: 1686123945-476331 X-HE-Meta: U2FsdGVkX1/7SmDMZvffZNms4mLkwBXPlpOT41ZuFZ36gKfif9FQ0rRfPRTbsyj+kmgfMBn6EsT7CWNMlghGI0wm32Zz6X0+vENh0g4/7w7dO2yXMr8FFlW4FtKA9gkcdUGWVwF3l91eYYQ9F+W8uKeB59741SvJRQiT39pMbu4JYMghIsGv8xXSBLYm21HUGOunpygCGljyWTMx8QzdqydzeYSEuCHRmUttGPMNWR9QBZXXi5nMVadQtytcsT0PLmyPKSkeSuRtYK3bfphzvPg7SVGz5bdyRpHiuq9x0yR0SJ0D0JLiBV5N0h6Xm3F1lnbXkSD3t0BLXJL+vdv9N0o1xRcMID6iiMn6XtLlsq6I3qQl9ZjSniizPHdj15xuSIRriZB40HLNdVl1FKhhm8vZEo8mB6Ocrcw44rOP8knys8sq+E9yaz/K2IiTAz+bTNPSGzus7yCgkFDbCSPRzY8Gl88fKzRyNy++SInepC79EWP/nq0SyUQacDHnTrlzvnaRfu9i4sB5pm3MOFEuoKfz6XNDCcXctDzllqGXJUW4uNmXHRvV4PIBdWImNYj0hWejnsKi2Iqeg9Jp49gdl5fdlW9WCwsMoJ8hYYABfKsU31kC1ikRiXhM20P07ZABiuQOoBk//MwL1V1oSejdITaKgBy2iVX+BMLg30UlPh/ImkahBN8DMDdLblc8FcvhFRJJOD1+sNvvA8wupZbwcGg6H0UrJif0dJq14Ra+jPNx6ZhQNM02NjPu5Jdlql3E3UijreG026VTxbU14zuYx0IlUOF17WeBO8bdRDTSpUrQxX9mbz3zvXF2D47h21G5rTVzd+VBdOAml/Px3aeA1VrvJl868F72zPp0UE4ROt30QM/D+qWzzxkdVHobij+G62sih4JDJVmPmDekzIQXqEBiRTRjK+kVHuhQ0WacxT0d8IBBUn1Luf1s4lBc5XcjPm2b5PBHXlRD3OOJ0nV p1UM4n6W WfSK3bxyhIvO4cD65a6BeVfVQStRFhE+QFXLOYaM+Nv5vMmwxJ1giGE5D0R9nbW9Q5MFVv3dW9EUfFe8njoQ7OzRzXnPLOr7TOZ/zvsCp8V9f8ml37+Sq8Jqo6MgNFkXuBykAspWySk0h465eJ1wdzakvEuL2T2omNcvjEIz1LucBDHiP4rmZpw42x4YP0ovoLEOlCELHAOAvOGhvS77Z+XsXowEvAXNy95YN28VmF5174cQmztkgBwvC4tDO64YybLauenktXoUkukDJbgTU7Abz9SM0GKCaLB81pfcEkV2Wuvh5+ShWXiFlUdBZ5QIl2f/EjLNN/4JkfRouhIYKZAsDst2FriFrX5TYQU8EwxnZIQcG1OuI7gYTE26GrgxDqRzlbjP8WV01RLGaLJuJu5nwEA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 6/6/23 20:29, Liam R. Howlett wrote: > The return of do_mprotect_pkey() can still be incorrectly returned as > success if there is a gap that spans to or beyond the end address passed > in. Update the check to ensure that the end address has indeed been > seen. > > Link: https://lore.kernel.org/all/CABi2SkXjN+5iFoBhxk71t3cmunTk-s=rB4T7qo0UQRh17s49PQ@mail.gmail.com/ > Fixes: 82f951340f25 ("mm/mprotect: fix do_mprotect_pkey() return on error") > Reported-by: Jeff Xu > Cc: > Signed-off-by: Liam R. Howlett Acked-by: Vlastimil Babka > --- > mm/mprotect.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/mm/mprotect.c b/mm/mprotect.c > index 92d3d3ca390a..c59e7561698c 100644 > --- a/mm/mprotect.c > +++ b/mm/mprotect.c > @@ -867,7 +867,7 @@ static int do_mprotect_pkey(unsigned long start, size_t len, > } > tlb_finish_mmu(&tlb); > > - if (!error && vma_iter_end(&vmi) < end) > + if (!error && tmp < end) > error = -ENOMEM; > > out: