From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id F0F6FC4345F for ; Mon, 29 Apr 2024 06:08:33 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 308A76B007B; Mon, 29 Apr 2024 02:08:33 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 2B9B76B0083; Mon, 29 Apr 2024 02:08:33 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 180886B0085; Mon, 29 Apr 2024 02:08:33 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id EF3086B007B for ; Mon, 29 Apr 2024 02:08:32 -0400 (EDT) Received: from smtpin25.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 62B4EC097E for ; Mon, 29 Apr 2024 06:08:32 +0000 (UTC) X-FDA: 82061540064.25.96DBB69 Received: from mail-ed1-f54.google.com (mail-ed1-f54.google.com [209.85.208.54]) by imf08.hostedemail.com (Postfix) with ESMTP id 78213160005 for ; Mon, 29 Apr 2024 06:08:30 +0000 (UTC) Authentication-Results: imf08.hostedemail.com; dkim=pass header.d=linaro.org header.s=google header.b=UX8wk+3n; spf=pass (imf08.hostedemail.com: domain of dan.carpenter@linaro.org designates 209.85.208.54 as permitted sender) smtp.mailfrom=dan.carpenter@linaro.org; dmarc=pass (policy=none) header.from=linaro.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1714370910; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=pvCfGDKq3NkKQAZVcl3gvcyNhlZM/4Uefp4v92bTZ8E=; b=L0aQ3Abir9cnHIdxKM0EcKR5dkaqvq41nmsEfbwQbDAppVOqlXZV/9dKNW5F9Lhm0VJbzq 0c4nlIYHu/JTScu6B50vZHWBMFIrACWk0EyeiGcuh6dag+DB5y6ukIjoGvWGUVGJ/kYky4 +p5TcAAunT9Fd12zJJsZVnU9SWQiVJ4= ARC-Authentication-Results: i=1; imf08.hostedemail.com; dkim=pass header.d=linaro.org header.s=google header.b=UX8wk+3n; spf=pass (imf08.hostedemail.com: domain of dan.carpenter@linaro.org designates 209.85.208.54 as permitted sender) smtp.mailfrom=dan.carpenter@linaro.org; dmarc=pass (policy=none) header.from=linaro.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1714370910; a=rsa-sha256; cv=none; b=zA9Ib2ag0Y1Mi5zWNLGSt/A0bQUq194yCYYOpIlOlrMfr0BZynot/6gDViwjJqJkFQxUry FZ4jUSru6Qc1IBf1MGU8cw+Vpt2f5k7EA8zOtS93LJD2PucAqGw26v+tZu1eoXVowMvATQ RoWZTDJOuUo6mS3DfCtLrkpSy9PuY04= Received: by mail-ed1-f54.google.com with SMTP id 4fb4d7f45d1cf-56e1baf0380so4963021a12.3 for ; Sun, 28 Apr 2024 23:08:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1714370909; x=1714975709; darn=kvack.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=pvCfGDKq3NkKQAZVcl3gvcyNhlZM/4Uefp4v92bTZ8E=; b=UX8wk+3n/6LxAQpTXwhEVbSQqUiS9hlqlY5mq64DIWxhCr1uB3lxQ1uALVbWCYnmNY HSGaldNmcGnycWqcJ5pnUcLNojxW1Xy2jrhS5rJCLp7mfh0iw0P0gCWZj2NcpB4a0EQ5 sboJ35tTxtos/lT87BXWwUvzeJ8iSk3DGg5vuI80y2636eXe6toJ4Ga/m0AMbOrJe22O mg3shj6RLNkfO7dmCRvBqfgApLZ928WLvnXAQ5M8jFamoX2pU+3P6vzTiaOX8VnEpB3J 3saX1QbKYXq2b8iTYERbtgTPOGsi1Q4AHoFsLvStAYkWbUQE4UadFqXT35DYGEEridY8 DGIA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1714370909; x=1714975709; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=pvCfGDKq3NkKQAZVcl3gvcyNhlZM/4Uefp4v92bTZ8E=; b=FBP15AO9ZfQO0vxAcMV+T6oAHTQ11f48vEu3DaUXE9s7TmigTf2VZEbLsNmsMaCqnY DEfJzB5P5hcQ8HDgqZdMp0z8xPbelfujPIVPbNNsSJlsLjpLNwei1HZkhgSmdMNwrdI+ d3ViOPiJOYt07kOiVBolxiw19qTpijNP1eYqk0J9ktVHL+Lahm4ZfcS7pOnMJDfxxi5G AiXR0R0hPuCFdorTfQrojh1ZTZ3NtrM7THpYhJZOLceld3KXqruz6aOlOOkp+/vpBq4a eFmxAO5y1lJOGvvwoD2ykPRygeDsvdnAYMqz/BS4zrjhZA9B/n2Aphx/4PZkrI+2s3B6 bZqw== X-Forwarded-Encrypted: i=1; AJvYcCXUDyjsRWvLCJ8vkQdMhtNGgkWeDFtOlkTzfNjh9eARRyFfB2FzvZTuiscBsNFTA6+PO4OOmoguOrKSenhkgA1iITw= X-Gm-Message-State: AOJu0Yx+85B/ZY/hOJyGOK3/U5WGri0CgR7Xmm8EfYIRElzRPvFgFEGi 0AOdPk6F3jA5h32Ew/aB6TIS2SmLVFclaRltWGrsg+PXhy6ZSCji1GHvG+7h9M0= X-Google-Smtp-Source: AGHT+IGXHWZJ0k9VgResxd/8nAAasZ5KzykP6pPgXMGjd/2HPcVWuqQtBjRpxFXW+yVkCtBfMc2gcA== X-Received: by 2002:a50:d496:0:b0:571:d380:95fd with SMTP id s22-20020a50d496000000b00571d38095fdmr5722874edi.28.1714370908456; Sun, 28 Apr 2024 23:08:28 -0700 (PDT) Received: from localhost ([102.222.70.76]) by smtp.gmail.com with ESMTPSA id v10-20020a056402184a00b005722cb1dd6fsm5920503edy.27.2024.04.28.23.08.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 28 Apr 2024 23:08:28 -0700 (PDT) Date: Mon, 29 Apr 2024 09:08:24 +0300 From: Dan Carpenter To: Matthew Wilcox Cc: Christoph Lameter , Peter Zijlstra , Pekka Enberg , David Rientjes , Joonsoo Kim , Andrew Morton , Vlastimil Babka , Roman Gushchin , Hyeonggon Yoo <42.hyeyoo@gmail.com>, linux-mm@kvack.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org, Bartosz Golaszewski Subject: Re: [PATCH] mm/slab: make __free(kfree) accept error pointers Message-ID: <571761df-fe50-49e8-8d56-65fbdec9a185@moroto.mountain> References: <285fee25-b447-47a1-9e00-3deb8f9af53e@moroto.mountain> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Stat-Signature: 3tn8jhsi3oneeh1q61pgbexfuyqphsk4 X-Rspam-User: X-Rspamd-Queue-Id: 78213160005 X-Rspamd-Server: rspam05 X-HE-Tag: 1714370910-463413 X-HE-Meta: U2FsdGVkX1+PKTf/6jBjAHHzb+4UjvxZXRNbmGQjFC4Z1DKUchTfszDYGUwX+NtRk8T9EEgn+V1A9ek+ZHNqOOjEb7rZ+YWAzIrJAFgssDhqNGkGDyxzAZb/Vp7wZQPgg84pGhg1DSlue1RdI0wNPV4mvh0MD6Gmh+sm6GXiyKdZReI/QSrYngf9wN9E0wCRLAq33E6BLcmoI8/bIKNVPRpavt1lMlESFpHYwsHoxzRar43pwCYtFRFy8Xt8W5vyZRx4uKAlmoBKJq5U4J2wD5ms6r9MzYBf/u+hW/vqf/bLPZHHMi4dWLN+qHQ4xF3uB1OouShMnviJOeYeLl0QfFThkx+7dOYSKH6BK4lIeJIo4p7rrsJ3FziEoU7lvg3xaGtqwS93YziluIdRUW17aykqDMs9YRz5GamL4xEFiCbUMLBHpH7gWtPLvMmm/0pXrE6s/QLrB7nNbROz++uupudE9FZm+PLPDUOfzZIoikFdt+J4kfbOo7CaNrCwYbRsZ9p1Srk+7tm78UuNWnNtbYSxmr1jftAfbCpi5x1BabEQF1ZDjWVqjrLi2azsAfo4Hre1GkOOyjYMeiJTguX+dGhObsGVTc450yBONC3DFxQtCUGJHXSpSO2QmWMAyJddeZjdiApOkutR41xS0JrHzGZ+yYrHsnVzXUS4IWssGo/ztfmO5WnaWg41Nbf9wYJ5oPvSloTHu8rjHWR7bHqj7mSuhne6v0mTZNzdWCKTDjd2YMch4QwylDoa8B/KsI0+oeAV3w/4UpNSNl2skVUglRMRCKF3oeSp3rbEVVqz8rkBruKTt0YxeKyHeqgGhQsrf+wLcKTwWoMNWQchaSixIbHvnSw5uThiDXFdMeQzQlHFLrNzAqZRtOA8ddhoPgcvsI3B2zNfdcw1jBySfFAw6f1P9ChGyp5jENA3TmNvxZpJu47ks0OZ/E5hcKqSmPmqUhQ/Rg1gIUqPgUu4Eo7 MauWGGvV CE+v6SyXvgKRXnIIsPQf2mNie2lZpq09XSg01k8Nhs/U6sI0h7CrXOwZI+YlAGEn7nz4hgZEr29xmhallPE5HdudOlmrvZFuzwCwsPxyb134NrUnIppCTVQWh+z8nCoyrKxeiqTUmFqbOi2521X3M7sgtNJhvP+4oPrFgs/REpzL68XhJaEKZXEagXY3WZ4qfEnMvm2UnhPy5txfJu9d1mn7HCsJ4eQvgLPjFyJ4Xx7z7p9STVkUCNh3JRX52QOjA5cUiJh6w8GcQRAK1t/741cZzsNYFH8gE2cCOHhfIuaeH+ZXBdMPv6AV+vn21UMp0yhx8fVJvTwjFTXOfjzVQakRLIBuoUl9zP/q0Tdv5llh2UrruIUdPYN/z0tP9fr2wY2xKsF5dPKmdb/IJWY0Mt6L8eEf53/2lQ04mP8YRgceXKio= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, Apr 29, 2024 at 04:03:07AM +0100, Matthew Wilcox wrote: > > diff --git a/include/linux/slab.h b/include/linux/slab.h > > index 4cc37ef22aae..5f5766219375 100644 > > --- a/include/linux/slab.h > > +++ b/include/linux/slab.h > > @@ -279,7 +279,7 @@ void kfree(const void *objp); > > void kfree_sensitive(const void *objp); > > size_t __ksize(const void *objp); > > > > -DEFINE_FREE(kfree, void *, if (_T) kfree(_T)) > > +DEFINE_FREE(kfree, void *, if (!IS_ERR_OR_NULL(_T)) kfree(_T)) > > Wait, why do we check 'if (_T)' at all? kfree() already handles NULL > pointers just fine. I wouldn't be averse to making it handle error > pointers either. > > > -DEFINE_FREE(kvfree, void *, if (_T) kvfree(_T)) > > +DEFINE_FREE(kvfree, void *, if (!IS_ERR_OR_NULL(_T)) kvfree(_T)) > > Ditto kvfree(). Fixing kfree() would fix both of these. I've always thought freeing pointers that have not been allocated is sloppy so I like that kfree() doesn't allow error pointers. We always catch it before it reaches production and that teaches people better habbits. Personally, I like how free_netdev() only accepts valid pointers. But I won't fight you on that if you want to change it. People have discussed this in the past, but no one has actually sent the patch. It would probably be merged. The __free() stuff is different because it's supposed to be transparent. Btw, I'm hoping we can officially declare small allocations as NOFAIL so then we can start doing allocations in the declaration block and remove the error checking and the cleanup. #define __ALLOC(p) p __free(kfree) = kmalloc(sizeof(*p), GFP_SMALL) #define __ZALLOC(p) p __free(kfree) = kzalloc(sizeof(*p), GFP_SMALL) struct foo *__ZALLOC(p); regards, dan carpenter