From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5E0AAC0218C for ; Mon, 27 Jan 2025 10:40:30 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id BB91C280149; Mon, 27 Jan 2025 05:40:29 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id B695D280148; Mon, 27 Jan 2025 05:40:29 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A09E6280149; Mon, 27 Jan 2025 05:40:29 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 80F99280148 for ; Mon, 27 Jan 2025 05:40:29 -0500 (EST) Received: from smtpin24.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 86EF8162194 for ; Mon, 27 Jan 2025 10:40:28 +0000 (UTC) X-FDA: 83052887736.24.05D580D Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.223.130]) by imf18.hostedemail.com (Postfix) with ESMTP id 5201D1C000D for ; Mon, 27 Jan 2025 10:40:26 +0000 (UTC) Authentication-Results: imf18.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=qdQSowRY; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=3OUz6SzW; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=RXvfxHwH; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=ZZ9f4YmZ; dmarc=none; spf=pass (imf18.hostedemail.com: domain of vbabka@suse.cz designates 195.135.223.130 as permitted sender) smtp.mailfrom=vbabka@suse.cz ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1737974426; a=rsa-sha256; cv=none; b=8UBm/iQ8sAju7kQ44LItx8RWxO0SDUafYJgHtbGfKjE+QTA5vICxAZ6b4z9aqmqokApijG AMGksFCTFArXTa05sMKGwmsfvmWW1TCJwuIgliKG6OtnK6yVqiA7WuR7MdL0bDJxsoAIur F6HYgDijiazqyyvZ9+C9/7YUtbOv9Ic= ARC-Authentication-Results: i=1; imf18.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=qdQSowRY; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=3OUz6SzW; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=RXvfxHwH; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=ZZ9f4YmZ; dmarc=none; spf=pass (imf18.hostedemail.com: domain of vbabka@suse.cz designates 195.135.223.130 as permitted sender) smtp.mailfrom=vbabka@suse.cz ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1737974426; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=YU1F1llbbg+pXtlmK1s6VMV6+ibR7cIqZshguKZDvio=; b=yODE/z15rT+lBsowNkA/WGDpMTUlJlL9Bn9cg1N1MHYiPEDRrMAroiF2nO2iO7Bzh4QD8g eT5wJP50Jog4GX+jepDCSJRFwB2ZP39AllAfHHC/R7bVjNMb+D9iuXRwUzr0OoYOVO/skg njANsTjaeIDXsL6nvQ8+utRiSxJ/uHQ= Received: from imap1.dmz-prg2.suse.org (unknown [10.150.64.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 036B521114; Mon, 27 Jan 2025 10:40:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1737974425; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=YU1F1llbbg+pXtlmK1s6VMV6+ibR7cIqZshguKZDvio=; b=qdQSowRY14Nd3zG0MSLPJlr7d3BOhhMrcwJ51LR3c5JxJnmo2jnBYtjjQ7OWey1oM8U+3F vVHnKrxfO1n1HUS9cUyEw8rUDOxRJdZCSWFX3eT0qSEmJRFuHhAECp/BcTcN9Ab9fx4wDQ 4pxDPynB/6qahX+AdTCku9a3W7K0Yjw= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1737974425; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=YU1F1llbbg+pXtlmK1s6VMV6+ibR7cIqZshguKZDvio=; b=3OUz6SzWqbR05jQjXobC1uXxpbhbA14Ht2ezIWsjRXqd8hT5EG2B/4U0o90nz1DtPz9nUS jbMw9M6FIkxQCpAg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1737974424; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=YU1F1llbbg+pXtlmK1s6VMV6+ibR7cIqZshguKZDvio=; b=RXvfxHwH3Ykmc4e9ojhA+GH8R4rLhJVzXTrTaksvfD3Cv1U3kdIG7i4OCpzvFDR5uZGvzd fWm7zHuXJFLM+Qnqi0buAjEoUL4QITGoiFGQA5C9ObNFcuIz2hG5hok7D9YQ8kfNDNergy ylUGsaE2nqLOwqF+Dpl9VVgeiAaQoMc= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1737974424; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=YU1F1llbbg+pXtlmK1s6VMV6+ibR7cIqZshguKZDvio=; b=ZZ9f4YmZLNkUaCw3dWuIapITRkcKZR+reTLkZofm2sfieKGgjC0CW5hDfueEU4hjKpm4kv s/MJA/t7VIfwwYDw== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id D9BF813715; Mon, 27 Jan 2025 10:40:23 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id ArvJNJdil2fuEQAAD6G6ig (envelope-from ); Mon, 27 Jan 2025 10:40:23 +0000 Message-ID: <5709c57c-1953-45b2-9a23-b0856b39bb02@suse.cz> Date: Mon, 27 Jan 2025 11:40:23 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 2/2] mm/compaction: expose a new param for proactive compaction Content-Language: en-US To: Pasha Tatashin , Michal Clapinski Cc: Andrew Morton , Nitin Gupta , Pasha Tatashin , linux-mm@kvack.org, linux-kernel@vger.kernel.org References: <20250124182140.2243862-1-mclapinski@google.com> <20250124182140.2243862-3-mclapinski@google.com> From: Vlastimil Babka In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Rspam-User: X-Rspamd-Server: rspam01 X-Rspamd-Queue-Id: 5201D1C000D X-Stat-Signature: yoayi4jskspskx97y1i155tyeta65uhu X-HE-Tag: 1737974426-671964 X-HE-Meta: U2FsdGVkX19UpPpIkOywOf+Xuj9F3BqOLiVoF8NmylO1E+v11cSG2tZI99m1d5Go0TlX+CBdNkFj/hk4o92AEtOyOBdBl60UhN8/g2jNm1wCt2Bt2KlMgoiYGn/7YR78JLl2zfP0kVg/A4h/QwprSMg0DBK+ZgVp5BlNMWJNgE4XJ34vEEUCVVsQe3UAZXrpVS+JrC2SyctAOIXdYB3twU0ucg36tJ/73PTKtSrqTKm80WLb0z5tWwQpxVt4Kv/Q/bQXEezCEnwZoBwNsGxrHg7giXzWlJFekr6WyadsH9l3X3/X2YG3E/h103CsVmrd5sVCg2/Frr/r5fzC7E/HqGp1HEOKQNHhXRl0VI6QHfyhMcy4w1gFlKQnyeuisLlTMSaG9QUirjlogCHrQBhzZpqj3QZAluYU6ZEhnlmqQRuGrPf33/k9tyQToY2BWuZ/TiZW1QmDPReSjoKAYyTOhj5YzosNV3Y4xJl5gYltldy0fCgMmKvXE/+g/PKVyjEAoBXM7ZFAk4HPyKk40lUnqSTbVVlpKBVivy9lJQq3XZPNkDIcqTr3GaUl5ovM418FV77lWbelPCLdWOHzGCvrc26nJUDKDiN97TDp7zD+1SBobwVCxJAMwhpauUTkSWCISTiGBAKIl6CMUFQW0781pv4UiQGzMjZaP3KNOkxdw3yX7dHfNkW4xcnA37NG8NWc8M3C0v4e/IVvF9q9QHHD+lpD2dn7p5I083IFyO6xNHO/+O2/grt1oSUc16iBQtYJG/ubd422Mq4gNw82qIwEtQuSQsYo1S4sZ1GXK4YxHCyGFCg6M/4QcN5GxNU8x9J7Wv5XdQ8QNqf3eaG6QT5vc13n1oBgtjva8gSgNCB3hBaxgJ6VKh6x8EPmCw6EJFaYgTdPtuETtDUErS2GVd/gdvTuQ++koXPIwvAMWEhoz9m0+Zt2fJM6MxCOSL0I6jir4AgRNTYrMClgrVE2vUd 4TuDwT9J 1RuYohSlIfJjMvOgToB34WAlKFG1isCzsldUBat0SIFkysOX8x9mhSoFi4pjxtbSF3ROS+sZMl+k/4o74MG5AncaD7ZWVzMTp7fQC36Z27JcNW6PMw6A5sTZofmbl+AdWEitX/0Kw2lnLQmTX18mV2Ow0+fMFbi2TGQ9CdpsF6hsPSDCHUm2Ej0vjolftLmlJWTgWux26FQVWjaC+HMXiif2ZkTtqJXE5gIKYAe3E1z1d0E51u7IzpNXq4eudW80nv4e2u7M6nndar+cmS5IjBW7DQUvGUH2om2rL5z9Hb0skKiBAY/sSqC3VQ3b9Q3gWO4g5MHV9cQZVSH/BCX+Y3cYVfw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.078432, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 1/25/25 17:20, Pasha Tatashin wrote: > Subject should be something like: > > mm/compaction: Make proactive compaction high watermark configurable via sysctl > > On Fri, Jan 24, 2025 at 1:21 PM Michal Clapinski wrote: >> >> Expose the diff between low and high watermark as a sysctl var. > > Please expand, for example: > > Currently, the difference between the low and high watermarks for > proactive compaction is hardcoded to 10. This hardcoded difference is > too large for free page reporting to work correctly. > > Add a new sysctl, `compaction_proactiveness_leeway`, to control the > difference between the low and high watermarks. Yeah, also please update Documentation/admin-guide/sysctl/vm.rst accordingly. Thanks, Vlastimil