From: Vlastimil Babka <vbabka@suse.cz>
To: Pasha Tatashin <pasha.tatashin@soleen.com>,
Michal Clapinski <mclapinski@google.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Nitin Gupta <nigupta@nvidia.com>,
Pasha Tatashin <tatashin@google.com>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] mm/compaction: expose a new param for proactive compaction
Date: Mon, 27 Jan 2025 11:40:23 +0100 [thread overview]
Message-ID: <5709c57c-1953-45b2-9a23-b0856b39bb02@suse.cz> (raw)
In-Reply-To: <CA+CK2bCncCgDFe=sUA=2WQLSDB7N69Gpv2upHJ5xJOA-Jb-Grw@mail.gmail.com>
On 1/25/25 17:20, Pasha Tatashin wrote:
> Subject should be something like:
>
> mm/compaction: Make proactive compaction high watermark configurable via sysctl
>
> On Fri, Jan 24, 2025 at 1:21 PM Michal Clapinski <mclapinski@google.com> wrote:
>>
>> Expose the diff between low and high watermark as a sysctl var.
>
> Please expand, for example:
>
> Currently, the difference between the low and high watermarks for
> proactive compaction is hardcoded to 10. This hardcoded difference is
> too large for free page reporting to work correctly.
>
> Add a new sysctl, `compaction_proactiveness_leeway`, to control the
> difference between the low and high watermarks.
Yeah, also please update Documentation/admin-guide/sysctl/vm.rst accordingly.
Thanks, Vlastimil
next prev parent reply other threads:[~2025-01-27 10:40 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-24 18:21 [PATCH 0/2] mm/compaction: allow more aggressive " Michal Clapinski
2025-01-24 18:21 ` [PATCH 1/2] mm/compaction: remove low watermark cap for " Michal Clapinski
2025-01-25 16:03 ` Pasha Tatashin
2025-01-27 10:38 ` Vlastimil Babka
2025-01-27 13:31 ` Michał Cłapiński
2025-01-27 14:13 ` Vlastimil Babka
2025-01-24 18:21 ` [PATCH 2/2] mm/compaction: expose a new param " Michal Clapinski
2025-01-25 16:20 ` Pasha Tatashin
2025-01-27 10:40 ` Vlastimil Babka [this message]
2025-01-27 10:36 ` [PATCH 0/2] mm/compaction: allow more aggressive " Vlastimil Babka
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5709c57c-1953-45b2-9a23-b0856b39bb02@suse.cz \
--to=vbabka@suse.cz \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mclapinski@google.com \
--cc=nigupta@nvidia.com \
--cc=pasha.tatashin@soleen.com \
--cc=tatashin@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox