From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5D528C433EF for ; Mon, 27 Jun 2022 19:47:02 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id D1DA18E0002; Mon, 27 Jun 2022 15:47:01 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id CCE698E0001; Mon, 27 Jun 2022 15:47:01 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B95A78E0002; Mon, 27 Jun 2022 15:47:01 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id AACC68E0001 for ; Mon, 27 Jun 2022 15:47:01 -0400 (EDT) Received: from smtpin18.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 75911208CD for ; Mon, 27 Jun 2022 19:47:01 +0000 (UTC) X-FDA: 79625049042.18.523E715 Received: from mail-ot1-f46.google.com (mail-ot1-f46.google.com [209.85.210.46]) by imf13.hostedemail.com (Postfix) with ESMTP id 9EA1E20025 for ; Mon, 27 Jun 2022 19:47:00 +0000 (UTC) Received: by mail-ot1-f46.google.com with SMTP id b23-20020a9d7557000000b00616c7999865so3662349otl.12 for ; Mon, 27 Jun 2022 12:47:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=google; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=sEyIMurSbUDEtnO4sXJJJqiGT9VfNu9mH5Y+RF1zXpM=; b=Q/XU92EvXKhdUFHYTfxhesbhCz0S+IitCXqbWL1lwG8PNxG+l+4SrGA2WOvu8Hdddc hxNASREKZON99TgF7gAIPDYD0ndh2+wavjuNnWpuUEeMootx4hkqjxKrR9TgklvfT9DF NCYJjTEFsfdWM9OZUdQ8BfTDKs6pNJBV7n3tU= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=sEyIMurSbUDEtnO4sXJJJqiGT9VfNu9mH5Y+RF1zXpM=; b=VrS04iGl0ogVw9ffCHQmQbS/NV0AzM0CggqmsGTcDxN2duHqtfScXpuFNIhNIifSV7 bU2F3Uj1ovdO5KGtJf34O1vh5mRE0QaVRqrNjCDPNloLqBcY5X7b7m3HVNnjMnEemHIb 8odF8AHIFDHJbpO+CXXM/r9uokksf6frvbYgCO3+jm2qG9nHLqZcVoX4lgeSsP/b6nsL ONiuxrGoQ+CifZ/Q+nh5hsHeMomJl837Nlfxeu41scm0ksDg+MFw9A+fahUc5Mzn3sWh oJm5CWGdZzfOlNTO1M1okMAT9o2mlMiAxyO57vBm0cL5OyukmKPGDoBP8zKdjjUkEH1H wwCQ== X-Gm-Message-State: AJIora+Yua18fvHxlC72OSezK7z6uM5nEkPrTd10pdrZHoHiYzlWaXfX fT4TCCOaI/FFe07eVJ/vMrRYJw== X-Google-Smtp-Source: AGRyM1te5Bj88UBGJhxBv7OUhUu6rYyaYCShv/RM1GHQuJnIgZVd2AIbqFEHx30R36IqvOP82OnZBg== X-Received: by 2002:a9d:76d0:0:b0:60b:53e5:6640 with SMTP id p16-20020a9d76d0000000b0060b53e56640mr6833397otl.241.1656359219758; Mon, 27 Jun 2022 12:46:59 -0700 (PDT) Received: from [192.168.1.128] ([38.15.45.1]) by smtp.gmail.com with ESMTPSA id h9-20020a056830400900b00616a19aac0bsm6693195ots.51.2022.06.27.12.46.59 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 27 Jun 2022 12:46:59 -0700 (PDT) Subject: Re: [PATCH v4] kselftests/damon: add support for cases where debugfs cannot be read To: SeongJae Park Cc: SeongJae Park , Gautam , shuah@kernel.org, damon@lists.linux.dev, linux-mm@kvack.org, linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org, Shuah Khan References: <20220627185704.58902-1-sj38.park@gmail.com> From: Shuah Khan Message-ID: <5708a2f6-4555-7bb3-4664-c33fe5b411b1@linuxfoundation.org> Date: Mon, 27 Jun 2022 13:46:58 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 MIME-Version: 1.0 In-Reply-To: <20220627185704.58902-1-sj38.park@gmail.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1656359220; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=sEyIMurSbUDEtnO4sXJJJqiGT9VfNu9mH5Y+RF1zXpM=; b=RaNOdXFpBDB8vqifqyYXIpQBfU72I8J2asw1cWNafErVuTjTQTIvVpaFmhkGc56MSLTljw bhc4fqWfyK/YjG4b4XXj2QMZUGc4HBp+E8Tjm7AItK4Zxis90aQB2j2yOy0gDVxa2t2A6o FkD2TYb5VmcMdObwXepGi/yhEZv1NPo= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1656359220; a=rsa-sha256; cv=none; b=h/jfEQ/pXLl59lIuUztVqjCxFjNjWdAhJBDtaWPtrUegBHplc9O3ReCEW3B8TyDFTpD/qU MESE3rizpz1HUeZAitKZDp9XC+U3eHzngqNcJ1PrUVXCWPJdNUgcdgxUq3e2bzEsmP6AeV n6OkbCu9SRMdFvcCGholF8JgCXesQl4= ARC-Authentication-Results: i=1; imf13.hostedemail.com; dkim=pass header.d=linuxfoundation.org header.s=google header.b="Q/XU92Ev"; spf=pass (imf13.hostedemail.com: domain of skhan@linuxfoundation.org designates 209.85.210.46 as permitted sender) smtp.mailfrom=skhan@linuxfoundation.org; dmarc=pass (policy=none) header.from=linuxfoundation.org X-Rspam-User: Authentication-Results: imf13.hostedemail.com; dkim=pass header.d=linuxfoundation.org header.s=google header.b="Q/XU92Ev"; spf=pass (imf13.hostedemail.com: domain of skhan@linuxfoundation.org designates 209.85.210.46 as permitted sender) smtp.mailfrom=skhan@linuxfoundation.org; dmarc=pass (policy=none) header.from=linuxfoundation.org X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: 9EA1E20025 X-Stat-Signature: sspssqd1paj1uttnr5emmqmnru79pyar X-HE-Tag: 1656359220-827991 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000034, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 6/27/22 12:57 PM, SeongJae Park wrote: > From: SeongJae Park > > Hi Shuah, > > On Mon, 27 Jun 2022 11:00:18 -0600 Shuah Khan wrote: > > [...] >>>> --- a/tools/testing/selftests/damon/_chk_dependency.sh >>>> +++ b/tools/testing/selftests/damon/_chk_dependency.sh >>>> @@ -26,3 +26,13 @@ do >>>> exit 1 >>>> fi >>>> done >>>> + >>>> +permission_error="Operation not permitted" >>>> +for f in attrs target_ids monitor_on >>>> +do >>>> + status=$( cat "$DBGFS/$f" 2>&1 ) >>>> + if [ "${status#*$permission_error}" != "$status" ]; then >>>> + echo "Permission for reading $DBGFS/$f denied; maybe secureboot enabled?" >> >> btw - does this run as a regular user or does it need root privilege? >> If so add a test for that and skip with a message. > > It needs the root permission, and does the check at the beginning[1]. > > [1] https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/tools/testing/selftests/damon/_chk_dependency.sh?h=v5.19-rc4#n9 > > Great. Thank you. I will pull this one in for linux-kselftest next for Linux 5.20-rc1 thanks, -- Shuah