From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3D6F1C7EE23 for ; Sun, 21 May 2023 23:56:42 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id B81F26B0074; Sun, 21 May 2023 19:56:41 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id B321F900003; Sun, 21 May 2023 19:56:41 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 9F9D5900002; Sun, 21 May 2023 19:56:41 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 9421C6B0074 for ; Sun, 21 May 2023 19:56:41 -0400 (EDT) Received: from smtpin16.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 60347C02E4 for ; Sun, 21 May 2023 23:56:41 +0000 (UTC) X-FDA: 80815924602.16.CBC9069 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf22.hostedemail.com (Postfix) with ESMTP id 9957AC0009 for ; Sun, 21 May 2023 23:56:39 +0000 (UTC) Authentication-Results: imf22.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=Z0UIsZmH; spf=pass (imf22.hostedemail.com: domain of dlemoal@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=dlemoal@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1684713399; a=rsa-sha256; cv=none; b=QmxMgmotUQ+cuvu2a7lnpD2KveDPni6DuYxORFSGB4yrBXzXok9m0oChJGRasM6BdSmXHa Gl5kukqmmaDTRER66M9i9T7Q3qu2strDWu5hVuBp+GNDv3W0Fx+BUxtK9FZOBQPy6VXg8+ +0JNSsGSevwTP9x9bQbtZQoE1oJuBh0= ARC-Authentication-Results: i=1; imf22.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=Z0UIsZmH; spf=pass (imf22.hostedemail.com: domain of dlemoal@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=dlemoal@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1684713399; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=hKSB8EoIIZdNDO3pwDZPENWgOr8qAdmee/t6mnJ6cuE=; b=La+D+CDsv8W7ERV4d78JIsA18CAIapTpgXtIjbilTAsrqHVHuBVD5GwCpYj965wpu3k0CD Ha2LehQc+OqU3kl/O1ZvxwpIdHngCth5feZFqktfC9v5VjE9+qJzV0UymgYyTbtWovnrJG wwmzxhSQ+Yn0K92gihODB3k08WGkuDo= Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 9796561866; Sun, 21 May 2023 23:56:38 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 611D9C433D2; Sun, 21 May 2023 23:56:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1684713398; bh=WK+H08Abjgxys0xDqd/U8tYXnOZJ3X8F5W55cIj1HCw=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=Z0UIsZmHFp90UQn/0ZDZSobLdQtjW4rPu1tqdDMNYQsGw8zH8/kGrQZAEyUH335qN jx+PcuHH194DZCYw13SBnxFHv8qR/dJGf6af0XZolQ4pY4NwGz561+BSCiSdq+NMfp pP9GaP2rqUcoup1eDTQaC0u9ku+LtvdS5oXq+YIcnSZNrqaJQPgnGcdSglE7zJQQJ1 mDglCPYJILcH8STc9acJkDdPcqcszqdqt1XtSzFpR3uZ4Vt/dLyxoG0U8QpJUgK6tJ zPiZ0smPzXHGDHdVfPjHk4iQopmGL94L8nywJnqwdSEEkEN2OyqqJI94LwhMmFDAGq dnU/Dyd7Whn7A== Message-ID: <5703f49d-177a-a810-6f1c-b32aa1abcde7@kernel.org> Date: Mon, 22 May 2023 08:56:34 +0900 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.10.0 Subject: Re: [PATCH 06/13] filemap: add a kiocb_invalidate_post_write helper Content-Language: en-US To: Christoph Hellwig , Matthew Wilcox Cc: Jens Axboe , Xiubo Li , Ilya Dryomov , Alexander Viro , Christian Brauner , Theodore Ts'o , Jaegeuk Kim , Chao Yu , Miklos Szeredi , Andreas Gruenbacher , "Darrick J. Wong" , Trond Myklebust , Anna Schumaker , Andrew Morton , linux-block@vger.kernel.org, ceph-devel@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-ext4@vger.kernel.org, "open list:F2FS FILE SYSTEM" , cluster-devel@redhat.com, linux-xfs@vger.kernel.org, linux-nfs@vger.kernel.org, linux-mm@kvack.org References: <20230519093521.133226-1-hch@lst.de> <20230519093521.133226-7-hch@lst.de> From: Damien Le Moal Organization: Western Digital Research In-Reply-To: <20230519093521.133226-7-hch@lst.de> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam08 X-Rspamd-Queue-Id: 9957AC0009 X-Stat-Signature: g5gfkaz63k7kncwmutyunttnjtz5by97 X-Rspam-User: X-HE-Tag: 1684713399-710782 X-HE-Meta: U2FsdGVkX18kzSyi6iVAHhAKqEOpY5O3dvJ+gcT6rp43Uy+uSDFeU7yhy8MPEci6yUrX4H5iluWdfORobJpydk0Q9LT4jK1tu/oIR2rsHszM3Byc9CF6rnTaELTTVwGf7jj/waQWq0DxwY3wUL9XC7p1JE1v4AuUXn3WuYnInM6y9zLOp1v4Dp1ftOKGkAGReNRt++ekBMmy8Ujt4ctrP+kJQ9tfHQvRfWeCGBi1ra6sLSvHJqXSGs5ACjbGuyUF3ak87YJvqaLCu8OTbEdj7nvJQlkuGsCA5EyEX5YNWFx90ipoeL/mH4Z4+XUj5If3YZe2S5H6xWYX1XRuktSz+P03ord4x+17U7bqFC4rH5HmvZTQEUOW7oNCbPOTYUlWkqcngCv1zxEyrg5yc3Mm46jntv164Irr98lRX2QeiPUPUtjlxgQXyS6GVPRz10vVv40pWsTp7tuZ5leTnJ3HlojatRSb2RChv0o04MIvotA9Czy1Oivg4dL7gFiCNRpP77MdCi18Ew5dpxB1XJx2wFYm2WxsIStQCoJ1KYoyGsWV61kBIam5dB7C4QEco0yzTDdrnwsZBxzRrELOcS+b4bQ97YZVEKtlb17padzgAsayvhlcwTtsiVsthpVzH5Ye6NWl0plYF1MWo0fZD2iFYA6s6Xpt/MmTZLJlNX4RR3NJBBDjqWNCOZWp96644wbqJN/itHKUxmgeb/+wSPl2p/y0gdsrxd0f4k7lnu65cfKzndWA1MnEOQbvEVrexPMNLea5KBCs3txmtmgFGRxQSo2KgUx1CcMLfpHIXxwrsx11CPHj5tZgXFrKVn5ZcqI8pcMxHcEeGOT78zqa34MtUuT7Pkr26BPViOrn6wg862XkFz4EsXzJhiikzSUvaiVBhrhzcmVUgybUi10aeaVty69BTbh7HWMm3UpbNW3gqpUfnGXyGkgn2tQ0mrvhZvxBE4YnjAB3GjrJBWMaYG8 A9qZelsm Sg46n9Y5h+rS4VK52WQPdyFy+RCMu/3i1KM5xK92eh0SSJWpPs1MDpPBJ6OBtUBCCFmzUOz60HvfGsVkDyfGmFBmbt1spzs1hj4knbn7ohKI3eH4zVbgUbErcFNSuhAiUI6fR+/uwv8qsljkReQdqDiwcB+hR7N1yF4oFxNFCh+DcNZJj2bY9uJrxicGEtz4m0aOsL4S5rgaXNoNBNKX0ybIWZr1txTx+k3B74iRnh8iGBCHV6mg7v1IcC4CjCNP1lGw8ygmkKIfmWvM7c4FhD9pl7/Nudm/ylOKcIOzh933WnPl7eyI7GQadJPVlMo59umkmAs7LRN9SRJHF/okNrcaVjtG4NnkxAKhXH7o9Q1uJQhf8sZ3Iey3iHvt1EFrGH5CcMZ/65jcf/QLILZqesBP2xzjqCMbu0Dgrbb54TYBNUzAoI1kSSa35a3VITqVmcHoo/IdM4/Qw78A= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 5/19/23 18:35, Christoph Hellwig wrote: > Add a helper to invalidate page cache after a dio write. > > Signed-off-by: Christoph Hellwig Nit: kiocb_invalidate_post_dio_write() may be a better name to be explicit about the fact that this is for DIOs only ? Otherwise looks ok to me. Reviewed-by: Damien Le Moal -- Damien Le Moal Western Digital Research