From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id B0429C02182 for ; Tue, 21 Jan 2025 08:13:36 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 275D66B007B; Tue, 21 Jan 2025 03:13:36 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 225696B0082; Tue, 21 Jan 2025 03:13:36 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 09F4D6B0083; Tue, 21 Jan 2025 03:13:36 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id DB4B56B007B for ; Tue, 21 Jan 2025 03:13:35 -0500 (EST) Received: from smtpin26.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 6807F1A07E2 for ; Tue, 21 Jan 2025 08:13:35 +0000 (UTC) X-FDA: 83030744790.26.0C72333 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf09.hostedemail.com (Postfix) with ESMTP id E0C1F140006 for ; Tue, 21 Jan 2025 08:13:32 +0000 (UTC) Authentication-Results: imf09.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=XUj6Dhi9; spf=pass (imf09.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1737447213; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=i+AUEwqQsOijWvy7OwVJMPI0MmBugw4RNkVQnFby7dE=; b=1UwCo581fbLT11HX3eWp8tv+GUg/W7WdCH8YxkFErApffg4bh/WRwwHWo9xLwWRrxOsYVF F/QDjXVQ+RV6LtJHPpEiZY4jPT0uNlVSBZgLifdo7oRvaHxooaO/TyBs6PUJapUt5siXkq SwkAHS3usiEs21HDO4iTQtI0oiLEbdM= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1737447213; a=rsa-sha256; cv=none; b=N5+R5wz10NTZqx3EJeOBedjNUKMjGDRwy/dm2Ezw3FDdGYRw4GVlHloYXPqM8/wPRsaLG8 CfDcptTMTivxebxU5X/32AMMmTqXmSy1k1H0JU8xB/fpPegVvlUo7ydKs8ZDB8F3FqVgBh N2xTRE/BI1Ysa13onWvoxikQA8wJKj0= ARC-Authentication-Results: i=1; imf09.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=XUj6Dhi9; spf=pass (imf09.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1737447212; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=i+AUEwqQsOijWvy7OwVJMPI0MmBugw4RNkVQnFby7dE=; b=XUj6Dhi9blfrvBhG39aaeUPhn8UoqG+ZN61emapugCr4K39+8Jaw1TEsfXdbXvADk5Ry0G HIrjoRAOT+YrHBKMcQ65IW/6zIqlTmMIcA39NXI6obon0Hudjz+1hT2+OYBXodrSmQO1w6 lR9pQycOXILMySpf+xuGfETIkfiiJo4= Received: from mail-wr1-f70.google.com (mail-wr1-f70.google.com [209.85.221.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-631-JZD8_tHFOQiQvJC8ER2WCw-1; Tue, 21 Jan 2025 03:13:30 -0500 X-MC-Unique: JZD8_tHFOQiQvJC8ER2WCw-1 X-Mimecast-MFC-AGG-ID: JZD8_tHFOQiQvJC8ER2WCw Received: by mail-wr1-f70.google.com with SMTP id ffacd0b85a97d-3862a49fbdaso2269969f8f.1 for ; Tue, 21 Jan 2025 00:13:30 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1737447209; x=1738052009; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:to:subject:user-agent:mime-version :date:message-id:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=i+AUEwqQsOijWvy7OwVJMPI0MmBugw4RNkVQnFby7dE=; b=rITRQ32yNs0iGIx/RkmAz5nS62f2NjBzk05vCRgukb7hA8Pk8WN4NhzFDGYoz4c/M1 VC9Cfp341qwy0veggPyxffhssCY0TXDE9PYrjhfnND/k/Y70Zk2M7fYHuXKiW5iT6K79 0QJklxs1yNnjAilY/HZRR1OG+5ys9V+U6git/nCMoEEha5GepKVj6Mj9lXX9SNvjT9Ii Mm50bFO6aMpgatnmgkvtKc0neBm85DbkwWaPPCiuHxR/dyPDYnOV29kas0iQ5QCjwX1T qefys3HXVyKMGMzd6zrn8cpNOIU+8N2R2JDumkpck9BsNEeCmgcfDcdaJ0C6HiAiQ5Lg dslQ== X-Forwarded-Encrypted: i=1; AJvYcCW65YB4nLiogZL633/ZVRLFcVEyMkcSyT6d+hz+aG7rH6shssGgoCganmFPptV86HWxNJ/kTcuIcg==@kvack.org X-Gm-Message-State: AOJu0Yx2k4jrqYnr1d0QYT7DwejIbzYgcpmHt8QgQDeOlgFTOXPpqDup Jox60Hu6G6tHK5Cy8r2oNd7wRqV8Tzl9aHggA6KLPQih7Xm0nOheCQwF9OeRWcO5t52H/1FZMXX DNOlqc+Vo6ihFkM87ZCSgZsAaTmALRFax48sXqSPGQcr+DMgsQRCmFL+u X-Gm-Gg: ASbGncuyQg2R67FgqO58opcpVbvmN7OC0tMUMwbmUEkRrGOv/2OoQmro8asV1kClG2D wg1hDnQMV+V8ZtT56EJXRdIRJHpCmdJ8AOvIaT3+V7s/ycDpsWn+/wLdKOubRzy6Tu/EYH0ofgj HlmBQJ1NjER9ksKr/yo6iJhreq6nN0xmaBFb5RttPTHj8H4CZblXH/MVyrEu3mIwGc2orq1XWBn dVUTAfjxb7TMpPAnULlf2SOKpffNNPX1BAiWVAQS8QVDl60f6Radfd2kXaawsmr9Q2Y7RlNOkl+ s6i+khV7N5aTgEx7uzcKuZOu0NFMW14egBFC4XK/SjTgpTIHNo5T0Jih3FgXog5L7lz/OFdZ855 NnD/Blnee2SqgXnhYvePBBg== X-Received: by 2002:a5d:6347:0:b0:386:36e7:f44f with SMTP id ffacd0b85a97d-38bf56627e4mr10351268f8f.18.1737447209446; Tue, 21 Jan 2025 00:13:29 -0800 (PST) X-Google-Smtp-Source: AGHT+IFt5AsUKWLpyL1oSxHm/OXYewnl+HIopEeDOxlqknwgVXpi1/8gt5dbdfvx4V/VgCo3+ajL8A== X-Received: by 2002:a5d:6347:0:b0:386:36e7:f44f with SMTP id ffacd0b85a97d-38bf56627e4mr10351244f8f.18.1737447209089; Tue, 21 Jan 2025 00:13:29 -0800 (PST) Received: from ?IPV6:2003:cb:c709:6200:16ba:af70:999d:6a1a? (p200300cbc709620016baaf70999d6a1a.dip0.t-ipconnect.de. [2003:cb:c709:6200:16ba:af70:999d:6a1a]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-38bf3214fbdsm12908147f8f.19.2025.01.21.00.13.26 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 21 Jan 2025 00:13:27 -0800 (PST) Message-ID: <56fe9ae8-e9bf-4627-a10a-ba1d3e84e8c8@redhat.com> Date: Tue, 21 Jan 2025 09:13:26 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2] mm: gup: fix infinite loop within __get_longterm_locked To: "zhaoyang.huang" , Andrew Morton , Alistair Popple , John Hubbard , linux-mm@kvack.org, linux-kernel@vger.kernel.org, Zhaoyang Huang , steve.kang@unisoc.com, aijun.sun@unisoc.com References: <20250121020159.3636477-1-zhaoyang.huang@unisoc.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <20250121020159.3636477-1-zhaoyang.huang@unisoc.com> X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: w1Z1O7KcdI2y3IMXDD5Z0C2m_-ShceX3-vIEQzrl5Yc_1737447209 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Stat-Signature: dkrm1gycstxyzchai9t5bwh4wggezxu9 X-Rspamd-Queue-Id: E0C1F140006 X-Rspam-User: X-Rspamd-Server: rspam06 X-HE-Tag: 1737447212-324973 X-HE-Meta: U2FsdGVkX1+QFFcnsbUNQvqVzjzBZ0z5RshtO/02QU/v90IKY9y8GPlT7nYfWLVC3gSBHb44Nm9LBGW4rOA8EN6lkCWuQ/gMLTXBopYheslmgGJBv7AOWcNw2l+ED8X3AEOJVD/OpQGrq09xrTJGN5QaERmYRY/dArkpgNF6bbZZGTZoX8BA3IYFD3QbhtFmnNHmhg2GGofuzNtDt9FyrlTN8J+3OlJAeg1gwWBAy+sOU/lLC/5dnl082lE+jwM+Kvge5BTQrnCdkFThuKlF1EodIS8oVxbAQ+5vWZgGVC7o5vntm3JriwDticN8K5Es9nGLckh4QDlpsLtuI6EXJvZ3AqwawHjVe27uJ6c8VYQrGzu1vL+ut8diISo+m0HyxjgxUygTv2r4Vip5yT5RNYoUdJ3dWR1jTL0wcr0RFIapNaOAG2PChSW6sZ3H2aQ/SOy1azZjcipf+9NPBtR6MgtnRNifFGBYug55mrgzHrdosNVtY0Ow2+o8QD3skk7jmktUIFVu/srnh7LU4LorRDQ8JL5CtSM/Q4itduabj1T3/eJQeIBdVCVCvM4yH0ax5iOVrNVL9xUEgC3N4WJcVJjvp/fqFgB1CDXayMhmyn5DA6kNIigKoETstW6xr6RXvZdqYD4D9mPJMuGGyzLc1V0hrupWI+o11AaGZCD+0eB05hKl90JEtanMQF7A9z95S2kaEJtqXJLI4jAl9XEl1Jtr0e2+3t7K6usFR5v4fA2UQqyBppkbt8ZMDzTHo1/M48RgcHwlHIz1j9E0oF2olaiIPfs5jM7wuJOxRhKoG8u/8pcLqnNcld1kuueu5CZSa2sKdebm4mvyIWMVjqVZufC7X49kwxmoqvYPs18y28b5JB/TnXhCq1c3veE7ODmiUp9zRVlhK6TAjcE+f+QrXnV++QdjGSTtozy/ELs6rRt1tujJZdG89G/0Z9Q4wQV+rLm/TQgVmUiddmZnETQ qvat/bSk f/tBPSNlMR1XcvslTTPZWKMaOzQ6YTtlCzKF4V17U+3D9E00ugxbp9ulUkyygo1BtdNYqctzKPGqJieEk3fIuEh2a6M50pyY7K0n3+cqXohtykDck25uudyrTMMDafcczE+KIeH0TuiKiR5pGUGhceI+gg4ysdsLkTIg/ebI/XbXnC5uv4AII8EbaRyyqKv3Cww6Aj2Pb/cBS8AHZauixiraAxR3AImZf+IUCvLmLljHv0BUH0Pa9l2DkvdDkmq/69uP2IotCyK99QS44Oa5khMMEM0ljntfAyPIjkqJDJAjKYMSHjZKmRAzRU5VrV+mh3PGO4D0zOH9Y5hzF+8HioLTOt8HxB59LiAfKP0QTXy9MzIjDvWT/b7+4XYSgz+UUfbRSsSqCD5NqUezuTvGMIEccWSx0K9fgpTo8ApFFF/E6Jzu17F9RahAIB9y8wnCyZWcaMQRG1XY5pGMhsaNYRxpUBZ/+Mq75VnAl8gPNrF6xJH4hbJ5zDr1yqKye6xWEU8Jz57G5VvbEsZA5IgBjY6gnJ8U9RznTGNr8CsidwhEW/hgURrW21M+U3ilUdECjyZSxS/fVyiebSNWDAUua+/rMsw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 21.01.25 03:01, zhaoyang.huang wrote: > From: Zhaoyang Huang > > We can run into an infinite loop in __get_longterm_locked() when > collect_longterm_unpinnable_folios() finds only folios that are isolated > from the LRU or were never added to the LRU. This can happen when all > folios to be pinned are never added to the LRU, for example when > vm_ops->fault allocated pages using cma_alloc() and never added them to > the LRU. > > We incorrectly update the "collected" variable even if nothing was > collected. Fix it by incrementing "collected" only when we isolated a > folio and added it to the list of folios to migrate. Last sentence now has to be "Fix it by simply taking a look at the list in the single caller, to see if anything was added.". > > Fixes: 67e139b02d99 ("mm/gup.c: refactor check_and_migrate_movable_pages()") > > Reviewed-by: John Hubbard > Suggested-by: David Hildenbrand > Signed-off-by: Zhaoyang Huang > --- > v2: judge if there are unpinnable pages via list_empty and update commit > message > --- > --- > mm/gup.c | 14 ++++---------- > 1 file changed, 4 insertions(+), 10 deletions(-) > > diff --git a/mm/gup.c b/mm/gup.c > index 3b75e631f369..37951fba929a 100644 > --- a/mm/gup.c > +++ b/mm/gup.c > @@ -2323,11 +2323,11 @@ static void pofs_unpin(struct pages_or_folios *pofs) > /* > * Returns the number of collected folios. Return value is always >= 0. > */ > -static unsigned long collect_longterm_unpinnable_folios( > +static void collect_longterm_unpinnable_folios( > struct list_head *movable_folio_list, > struct pages_or_folios *pofs) > { > - unsigned long i, collected = 0; > + unsigned long i; Nit: "reverse christmas tree" parameter format wants this to come after the "drain_allow" variable now. > struct folio *prev_folio = NULL; > bool drain_allow = true; > > @@ -2341,8 +2341,6 @@ static unsigned long collect_longterm_unpinnable_folios( > if (folio_is_longterm_pinnable(folio)) > continue; > > - collected++; > - > if (folio_is_device_coherent(folio)) > continue; > > @@ -2364,8 +2362,6 @@ static unsigned long collect_longterm_unpinnable_folios( > NR_ISOLATED_ANON + folio_is_file_lru(folio), > folio_nr_pages(folio)); > } > - > - return collected; > } > > /* > @@ -2442,11 +2438,9 @@ static long > check_and_migrate_movable_pages_or_folios(struct pages_or_folios *pofs) > { > LIST_HEAD(movable_folio_list); > - unsigned long collected; > > - collected = collect_longterm_unpinnable_folios(&movable_folio_list, > - pofs); > - if (!collected) > + collect_longterm_unpinnable_folios(&movable_folio_list, pofs); > + if (list_empty(&movable_folio_list)) > return 0; > > return migrate_longterm_unpinnable_folios(&movable_folio_list, pofs); Nice, exactly what I just recommended as reply to #1 after waking up :) Reviewed-by: David Hildenbrand -- Cheers, David / dhildenb