From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9BC11C433EF for ; Mon, 20 Sep 2021 14:37:58 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 17AA660F6B for ; Mon, 20 Sep 2021 14:37:58 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 17AA660F6B Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=huawei.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kvack.org Received: by kanga.kvack.org (Postfix) id A54B26B006C; Mon, 20 Sep 2021 10:37:57 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id A03A16B0072; Mon, 20 Sep 2021 10:37:57 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 8F2A3900002; Mon, 20 Sep 2021 10:37:57 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0250.hostedemail.com [216.40.44.250]) by kanga.kvack.org (Postfix) with ESMTP id 81AC06B006C for ; Mon, 20 Sep 2021 10:37:57 -0400 (EDT) Received: from smtpin30.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id 432D4180AD820 for ; Mon, 20 Sep 2021 14:37:57 +0000 (UTC) X-FDA: 78608206194.30.3CCD71C Received: from frasgout.his.huawei.com (frasgout.his.huawei.com [185.176.79.56]) by imf06.hostedemail.com (Postfix) with ESMTP id C18A6801AB01 for ; Mon, 20 Sep 2021 14:37:56 +0000 (UTC) Received: from fraeml739-chm.china.huawei.com (unknown [172.18.147.206]) by frasgout.his.huawei.com (SkyGuard) with ESMTP id 4HCnCj0h4qz67jtv; Mon, 20 Sep 2021 22:35:29 +0800 (CST) Received: from lhreml724-chm.china.huawei.com (10.201.108.75) by fraeml739-chm.china.huawei.com (10.206.15.220) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.8; Mon, 20 Sep 2021 16:37:54 +0200 Received: from [10.47.88.85] (10.47.88.85) by lhreml724-chm.china.huawei.com (10.201.108.75) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.8; Mon, 20 Sep 2021 15:37:53 +0100 Subject: Re: [RFC PATCH] Introducing lockless cache built on top of slab allocator To: Matthew Wilcox , Hyeonggon Yoo <42.hyeyoo@gmail.com> CC: Christoph Lameter , David Rientjes , Joonsoo Kim , Andrew Morton , Vlastimil Babka , , , Jens Axboe References: <20210919164239.49905-1-42.hyeyoo@gmail.com> <20210920010938.GA3108@kvm.asia-northeast3-a.c.our-ratio-313919.internal> From: John Garry Message-ID: <56f30136-23ce-dd73-705c-4e1326768c9d@huawei.com> Date: Mon, 20 Sep 2021 15:41:16 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.12.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="utf-8"; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [10.47.88.85] X-ClientProxiedBy: lhreml729-chm.china.huawei.com (10.201.108.80) To lhreml724-chm.china.huawei.com (10.201.108.75) X-CFilter-Loop: Reflected X-Stat-Signature: xz1q7rcitoymra1qeza8ymiax6ojcx3z Authentication-Results: imf06.hostedemail.com; dkim=none; dmarc=pass (policy=none) header.from=huawei.com; spf=pass (imf06.hostedemail.com: domain of john.garry@huawei.com designates 185.176.79.56 as permitted sender) smtp.mailfrom=john.garry@huawei.com X-Rspamd-Server: rspam03 X-Rspamd-Queue-Id: C18A6801AB01 X-HE-Tag: 1632148676-647721 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 20/09/2021 02:53, Matthew Wilcox wrote: > On Mon, Sep 20, 2021 at 01:09:38AM +0000, Hyeonggon Yoo wrote: >> Hello Matthew, Thanks to give me a comment! I appreciate it. >> >> On Sun, Sep 19, 2021 at 08:17:44PM +0100, Matthew Wilcox wrote: >>> On Sun, Sep 19, 2021 at 04:42:39PM +0000, Hyeonggon Yoo wrote: >>>> It is just simple proof of concept, and not ready for submission yet. >>>> There can be wrong code (like wrong gfp flags, or wrong error handling, >>>> etc) it is just simple proof of concept. I want comment from you. >>> >>> Have you read: >>> >>> https://www.usenix.org/legacy/event/usenix01/full_papers/bonwick/bonwick_html/ >>> The relevant part of that paper is section 3, magazines. We should have >>> low and high water marks for number of objects >> In case unknown, jfyi there is an implementation of this in drivers/iommu/iova.c Thanks, John >> I haven't read that before, but after reading it seems not different from >> SLAB's percpu queuing. >> >>> and we should allocate >>> from / free to the slab allocator in batches. Slab has bulk alloc/free >>> APIs already. >>>