From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4C5F8C4332F for ; Fri, 9 Dec 2022 15:18:21 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 84F7B8E0003; Fri, 9 Dec 2022 10:18:20 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 800508E0001; Fri, 9 Dec 2022 10:18:20 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 6A0AC8E0003; Fri, 9 Dec 2022 10:18:20 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 580708E0001 for ; Fri, 9 Dec 2022 10:18:20 -0500 (EST) Received: from smtpin05.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 1D807161260 for ; Fri, 9 Dec 2022 15:18:20 +0000 (UTC) X-FDA: 80223123960.05.D2C2B82 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf01.hostedemail.com (Postfix) with ESMTP id 096164001A for ; Fri, 9 Dec 2022 15:18:16 +0000 (UTC) Authentication-Results: imf01.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=gzUkA6GJ; spf=pass (imf01.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1670599097; a=rsa-sha256; cv=none; b=Njfw3B8fjl9kiD3VcYfdU6Fd1clOZNeAgtFa1vuuIV5ddkupCo9l92uVcMRMa8PhcQxIZi LYtEqKt3SqJM/ZBFolBUBbFLZBcNQ5zaMZrOPXdrLfqPo2Jw6Gn23jpJKEn5p48KcXJ+vu JNhkG2sQJLlJQfBg3Zj/wI9PT/aWWeQ= ARC-Authentication-Results: i=1; imf01.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=gzUkA6GJ; spf=pass (imf01.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1670599097; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=0eu2Sx7RzvtaeptKcICpgSODE9eJn6k0GSRJ1eb03QI=; b=ZaSXX2pUyjjpwVkDffluGuCIyaf1xyNZaQnn7B1WPuNpyzgqjcLf9nrgAglK5gLH66g/La k+KnWND5atEv43lUVCY+gxvCzZnfP2sJELxW89uXAiWlXWY2oLh/0FJueDVIkCkxA7X48S K9LnOqw1NTBv1ih6MKyR41A6V+jYzY0= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1670599096; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=0eu2Sx7RzvtaeptKcICpgSODE9eJn6k0GSRJ1eb03QI=; b=gzUkA6GJmHWD63Sdq2o1sIuLNxbjGcddopkkmcw11m00ychjzP7D1GYHUFTcVdjTIMLcK7 eafB4D+UoyagYiMqmggcUj1hNGMx/k0LbQpSf4FiZGH5jQw+2n/j7QGkXjPef6Nlo3BTb3 jYfdheoSlry6hooPXpSfQUl5nHEHjDk= Received: from mail-wr1-f69.google.com (mail-wr1-f69.google.com [209.85.221.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-39-gVt68mUUOZWtCGqCcyS5LA-1; Fri, 09 Dec 2022 10:18:14 -0500 X-MC-Unique: gVt68mUUOZWtCGqCcyS5LA-1 Received: by mail-wr1-f69.google.com with SMTP id e19-20020adfa453000000b0024209415034so1049106wra.18 for ; Fri, 09 Dec 2022 07:18:14 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:subject:organization:from :references:cc:to:content-language:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=0eu2Sx7RzvtaeptKcICpgSODE9eJn6k0GSRJ1eb03QI=; b=mR5zfifVVqTGvtb8JARyaSt4putch/Wz0RnA6hFi69uVROYSCOBGA4PzM6dBYbAVFY 6anyGfnvahjmFz/pOaslcrp6ae+OmqBNvMa4jM6p0zZzp+3MpKCKjsJ61Ccp7A8aXngZ wljlylbSQioJLR6s8TxTXSwkKxil9kgbAe9wbuU5+h24sX2SuV2AJmwbkFr7lyKyKlfG hcl6GOIJrY9L8YS84jwE9u7dyMj5FkAWx3JQDbykJSppxpnjrio1AeBk4rOZfYfYoDdq stgurN8xtIC14r0h0qpx3WgKQxS95UPP6WwtaZstTcxCrNbm860lL7KiDSXfTeGQKy53 yRCA== X-Gm-Message-State: ANoB5pnX2f1RnJ7ivRyzelNNMAmdMr+1OS7ufdTSp8EiSKChNcFj6HIO Q9uSdsC+q+GdPHNrN26MurwMGJ9a64WqUyPoA9TZDqOhu4vARqKtFLJsp5/fnU/brKdxKLL0PtP FPlvq2AxtS0c= X-Received: by 2002:adf:f944:0:b0:236:d8ef:9efd with SMTP id q4-20020adff944000000b00236d8ef9efdmr3935389wrr.11.1670599093465; Fri, 09 Dec 2022 07:18:13 -0800 (PST) X-Google-Smtp-Source: AA0mqf4KARRhY+Z5zQK6Yh9EJ5fVMlhw8pIH4mFjrrpb1FJnV8S84Jfmj9JV23bFZ0mT1TsAq+pj4A== X-Received: by 2002:adf:f944:0:b0:236:d8ef:9efd with SMTP id q4-20020adff944000000b00236d8ef9efdmr3935374wrr.11.1670599093112; Fri, 09 Dec 2022 07:18:13 -0800 (PST) Received: from ?IPV6:2003:cb:c702:2e00:b9ea:114c:a3f5:327e? (p200300cbc7022e00b9ea114ca3f5327e.dip0.t-ipconnect.de. [2003:cb:c702:2e00:b9ea:114c:a3f5:327e]) by smtp.gmail.com with ESMTPSA id ay2-20020a5d6f02000000b002366e3f1497sm1709649wrb.6.2022.12.09.07.18.11 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 09 Dec 2022 07:18:12 -0800 (PST) Message-ID: <56eecd5e-9f1a-0171-0e4f-934e3e6b495a@redhat.com> Date: Fri, 9 Dec 2022 16:18:11 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.5.0 To: Peter Xu Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, Muchun Song , John Hubbard , Andrea Arcangeli , James Houghton , Jann Horn , Rik van Riel , Miaohe Lin , Andrew Morton , Mike Kravetz , Nadav Amit References: <20221207203034.650899-1-peterx@redhat.com> <20221207203034.650899-9-peterx@redhat.com> <72a62bf5-7633-f35f-75fd-0222fd0ab49f@redhat.com> From: David Hildenbrand Organization: Red Hat Subject: Re: [PATCH v2 08/10] mm/hugetlb: Make walk_hugetlb_range() safe to pmd unshare In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspam-User: X-Rspamd-Queue-Id: 096164001A X-Rspamd-Server: rspam01 X-Stat-Signature: ht7d4kygas5wyqym3zzhuad49i37q9z6 X-HE-Tag: 1670599096-302034 X-HE-Meta: U2FsdGVkX19oBLoEZULJ9HeH998QcC0WFrm08tfFDY8kF3lBBXxHjyd/TQHxiJ4tQ62qlIScLiGR4G08I9K6QtEvTbrcW6pm8KGsbXqxqRoRpx4cOoevZ8icpkfJtoVc5hFgcZCSYt7fJ7SJ8Q1XLKAHnPCbGBIcO0cULTvMjfVqyFzAAX+5z8Sese85SocyREeB6OuhRU6yIVIy7WeCb0aljjS++LsFPTfzXZZIkogt+ziKEbadtKlkC/6AUdHKrzDqNXTXi9E+V0ECeZI3B1O359VsUAe+dbGmkaKoq2J04zul7ad345thrQLWXbHn8OdMewO/Zl7GE5SzSriAu9RlZ7tMQgErpwdHNyLR8dLGAM4S2RvstPBu4jXa7j9mBf5AThiXRHNCJy0MCDuzLesbAjFFWeCMVhq2zWKcKEUVHQNRlVchysd46SQeB5BhMIde6E6Z8tOQxRajnY1QhO8JECneiod9OdH+DdbuMpeyIMMjRmRA0WzjAXIUti0F3I8ZPGc249T+AdNPi2x8nvLCeRN6BEgq4pSXGfGuks55+x4BQSmDA1U+h1t9d8M4zwPqwxhDyG3xxswmhYyUBJ0jwQ7RvFb3YhxnVACFu8/ylkvr5T+fmTJbgKOrEzz2cxjDjBRnQefH2IW8s6SBOzIWZLkDIYiWBqsQCpg+qlI6gEFT2Ye69YR0Qqflng8rdpyHsWrRzYQOxusGiGD+Y/QujdXPw594SyPwFUkGMqP42SmHoAnwVa7VFTuRPbTWbObyAjBa6xNnsn3eq/XjpyFzG2L/WWCepMhZ63czlltaNEFguJJm8rj+iKqqVy44nROF/ASQo/z1WBbDRdYEaHGS9K+8kEfYLF54Vaj5tdieAicBOXU9r/wKcHONe0sdbO8FYn3ag+It33UBjJRvZ6cCYbFOfLI4THl87bxao9kWxL9hldoYxBECKL8RpQwOQCpP15i41a9r2bVd+g/ 2801mMEC NlHGi4xjdtVFpDT+H6iDg73+hrPCmODSP0u7lAsa35Bp/heoNcgWwzxltz0LFPxaeAYfjYgyflLCIZGYIjj0FsegvulG+FT4R1r/hUk/DR4nVf8eJkHOoGIpOQQssLzDLqgfgv6qB4R1F6Zxdi71Erl/QkYgAjHv3k199jU4TNrSjZcrTJ6LmferUISR4vb40ka9OzIfOmBeeckageFRZTcvIKZcJe9tAi5bQTpqX208124eRSfiXYDRbFp+r2aG5m9BxTFA7EIAirqk= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 09.12.22 15:39, Peter Xu wrote: > On Fri, Dec 09, 2022 at 11:24:55AM +0100, David Hildenbrand wrote: >> For such cases, it would be good to have any evidence that it really helps. > > I don't know much on the s390 path, but if a process has a large hugetlb > vma, even MADV_DONTNEED will be blocked for whatever long time if there's > another process or thread scanning pagemap for this vma. > > Would this justify a bit? I get your point. But that raises the question if we should voluntarily drop the VMA lock already in the caller every now and then on such large VMAs and maybe move even the cond_resched() into the common page walker, if you get what I mean? On a preemtible kernel you could reschedule just before you drop the lock and call cond_resched() ... hmm No strong opinion here, it just looked a bit weird to optimize for a cond_resched() if we might just reschedule either way even without the cond_resched(). -- Thanks, David / dhildenb