From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8D019C00528 for ; Thu, 27 Jul 2023 08:55:48 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id DFB5A6B0078; Thu, 27 Jul 2023 04:55:47 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id D847E6B007D; Thu, 27 Jul 2023 04:55:47 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id BFDE08D0001; Thu, 27 Jul 2023 04:55:47 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id ACC536B0078 for ; Thu, 27 Jul 2023 04:55:47 -0400 (EDT) Received: from smtpin18.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 4FB92120514 for ; Thu, 27 Jul 2023 08:55:47 +0000 (UTC) X-FDA: 81056783934.18.284DC88 Received: from mail-pf1-f169.google.com (mail-pf1-f169.google.com [209.85.210.169]) by imf14.hostedemail.com (Postfix) with ESMTP id 5349D10001C for ; Thu, 27 Jul 2023 08:55:43 +0000 (UTC) Authentication-Results: imf14.hostedemail.com; dkim=pass header.d=bytedance.com header.s=google header.b=Umb+YV+a; dmarc=pass (policy=quarantine) header.from=bytedance.com; spf=pass (imf14.hostedemail.com: domain of zhengqi.arch@bytedance.com designates 209.85.210.169 as permitted sender) smtp.mailfrom=zhengqi.arch@bytedance.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1690448145; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=WiPjRg1/kjwO6K5zl232SDHPqYtmZOtFvHbsJXMq+7g=; b=uZkJ1PMWLi5hVTTk7OddESY63XmeKtOPsBTLC/1pwQTaPPlOwSfvtHYelc5qiPvkrt2KnV 3M3Q0PyJG0Y8bhrHQJzuX8p6Og+Ih4QW07FPXChSxbqpnsMiuQFX1JIhHhSlgBCl9krGwo IK12m3nh0c8DxP7YOrPcJ5zu/SyhMPI= ARC-Authentication-Results: i=1; imf14.hostedemail.com; dkim=pass header.d=bytedance.com header.s=google header.b=Umb+YV+a; dmarc=pass (policy=quarantine) header.from=bytedance.com; spf=pass (imf14.hostedemail.com: domain of zhengqi.arch@bytedance.com designates 209.85.210.169 as permitted sender) smtp.mailfrom=zhengqi.arch@bytedance.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1690448145; a=rsa-sha256; cv=none; b=PDlLnY7Z0bAbwCjxHicu4xVuOWe0XXesXs2Gwg9EiTPCgkoP5THnLrEUG1LoWVehQnKJyD 6xD3lx8IiT16gdxYSnF6Fu/N2rVgLumS6Ois5W4KPMxFLclFN1q3xp59Ma28+bxNuaV1xL ywvjIt2VIBzeV4Z3V0/iQ+PX+nmf5AM= Received: by mail-pf1-f169.google.com with SMTP id d2e1a72fcca58-6748a616e17so192443b3a.1 for ; Thu, 27 Jul 2023 01:55:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bytedance.com; s=google; t=1690448142; x=1691052942; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=WiPjRg1/kjwO6K5zl232SDHPqYtmZOtFvHbsJXMq+7g=; b=Umb+YV+a9lWFhAL8II9iFkMStUOOBYcco6VfVBA99lXKZrqzVwUjfYjnKm4Dm0LFjT qdoJauj14z5/Q/ALZNZe4hty9eUQzFUzAPUNYhh89WT1GQpVMRyZmNBBpLKeWi1ZbclH LZhMvQeV3S/E/ICy+9O5ITOO1Phn4D+1/k/6DGPG+fLuYZVwP+5BQnq4IpnQhN9xTXZe rfTcvD1n0zxeVBrWB1YcR+3kK3++SSPnDRJs7hwNhsakSHiwU6PBsTieOJN2pDWuMDWg xnIMDcCLv5tsUy7qwBc5TOF+eIq3rIHBy6gcXooMjKSZ0a9wuV4u6V1UPp0vjKeCWB6q aakQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1690448142; x=1691052942; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=WiPjRg1/kjwO6K5zl232SDHPqYtmZOtFvHbsJXMq+7g=; b=DyMb2EVJYxcXrk1oezxDmTAJ3Y2AFqKCycVy0EX2ss23t9baeeww/26SgZQRhpEaK1 7WaOZ0fDO8MtQQ8YuLtgKzRNJhkj8GmIqUdVZn6fTruslbBh4JsQ3IsGCapTXiK9H+5W 4uL5hAxLbJfofxOmG+x2tHxCoJSskxuOke3gkqmjy1Nn/9BqPi7/k/+HKYgUFOXQl4si 1UKCyFJZWRml3fo5mwlbcuKggcabGFwy5OH+uch6d+znAAOZeXH2CZqjyasd1rqaJzh0 MIylK7WyEqS7S3kVfI4vLKUaWhrTStSSCwDK3ZDS8rdIdmVAFodjOkpyzz6q4tgn9zMv GYVw== X-Gm-Message-State: ABy/qLY7mRnqwMZAuKr6/y++CXE3u6fbjB1O9TMit6+7ne7v0qt2rBP+ gfnQBOOQ5IGUrgRo5oqDAaMIvw== X-Google-Smtp-Source: APBJJlGwmdjot/rbtwF9nTotnOmqaOAtVmCVUqRrFxhkDx7eGx5gFUYRsJSjv9frk6zdjI0egP1lkA== X-Received: by 2002:a17:902:e891:b0:1b3:d4bb:3515 with SMTP id w17-20020a170902e89100b001b3d4bb3515mr5854967plg.0.1690448141745; Thu, 27 Jul 2023 01:55:41 -0700 (PDT) Received: from [10.70.252.135] ([203.208.167.147]) by smtp.gmail.com with ESMTPSA id iy15-20020a170903130f00b001bbb1eec92esm1023927plb.281.2023.07.27.01.55.30 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 27 Jul 2023 01:55:41 -0700 (PDT) Message-ID: <56ee1d92-28ee-81cb-9c41-6ca7ea6556b0@bytedance.com> Date: Thu, 27 Jul 2023 16:55:27 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.12.0 Subject: Re: [PATCH v3 28/49] dm zoned: dynamically allocate the dm-zoned-meta shrinker Content-Language: en-US To: Damien Le Moal Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, x86@kernel.org, kvm@vger.kernel.org, xen-devel@lists.xenproject.org, linux-erofs@lists.ozlabs.org, linux-f2fs-devel@lists.sourceforge.net, cluster-devel@redhat.com, linux-nfs@vger.kernel.org, linux-mtd@lists.infradead.org, rcu@vger.kernel.org, netdev@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-arm-msm@vger.kernel.org, dm-devel@redhat.com, linux-raid@vger.kernel.org, linux-bcache@vger.kernel.org, virtualization@lists.linux-foundation.org, linux-fsdevel@vger.kernel.org, linux-ext4@vger.kernel.org, linux-xfs@vger.kernel.org, linux-btrfs@vger.kernel.org, Muchun Song , akpm@linux-foundation.org, david@fromorbit.com, tkhai@ya.ru, vbabka@suse.cz, roman.gushchin@linux.dev, djwong@kernel.org, brauner@kernel.org, paulmck@kernel.org, tytso@mit.edu, steven.price@arm.com, cel@kernel.org, senozhatsky@chromium.org, yujie.liu@intel.com, gregkh@linuxfoundation.org, muchun.song@linux.dev References: <20230727080502.77895-1-zhengqi.arch@bytedance.com> <20230727080502.77895-29-zhengqi.arch@bytedance.com> From: Qi Zheng In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 5349D10001C X-Rspam-User: X-Rspamd-Server: rspam04 X-Stat-Signature: 89ygg8koqrmehncjomud58m3r14wsztw X-HE-Tag: 1690448143-711058 X-HE-Meta: U2FsdGVkX185pnB5OLIl/7JTLh5ECtGDQiLfB26JVTH7hKzhnOinzAid+T3NgwtbVVAI2Tdlu/tKBxf8xJP9jWr6X7qrSt1TEQiZXdF4QVBnSxheMyfnBVmFS5qY3ZZPD84o4Q5fuaISPPiUH5LhFYilWomPtJS0XOFo+sHMnIEgx5CSYBBt6wOv3Ob59AyUPwDNYgEikSdccV+koIJPIIEshhdKD+rAz95qf1pevqi+cP+2eISGuIe2DVC4ZutAoW0EWwn3Egz2H4ykeKRQrtexVZUl+Q6G5hIV9XaIJyXUfUJGwAhIAN0EsejgjCelMtGjd50Ll5l6iFt7WSDPlNxn8L6Xo4WfOHyXCeqZhW8gnSB1yj/nZftk8ZzpjyT/fqnY7nBzPRF1hdZic5J/13KU3bZTkS15hGIVz3kf4xU+TdodJ8jVT9wPGbMXN+qVSmmeYIs3/wZu020rQJHF+9c7ZvK9IP6DK1m0750i/4njsCX6FsDnu/vAIhPBDQ2WDq4zIHm42FxoJ0n0hvjszWTnCKJF+9t2HlXDfuNzOP1s0O3XCk6R1x6E5lDgAqtM23D10Pp/ilsfKOERpQOypFaaxhWiydrnAfRwQbpq/RDeJUFKmUKGMWxqNa+aZ00Q+t7MDr5uYKIPsNU1wFS/rpz3IJxEcGiZIwXxnPsz6iahjeOhhN8CpG1/9jOB0N0aYez/sv7rBHDdLjRVETtghyJTGNgYujxnos4UvqftHZy4BOb9KWe3PwbSlXR1MxFOea0QK+veUXlmU/VdnhzQ+LhGYPkQ1bi5q/9t2FHsMkU4MpYxhFxgBfnxrGufDwv9CCDJa7FXXmMilZHUPPIVdVt0cjVNIgZFV/iFxcUM4DKlJHXCOZmmCAEmtama+bOX8/Ac+rfPT2OfhQJZic+htYUGingvhnZTdUbfngwxTtHPkv/7ftIwL9fhtwcd8JnXF3GngsShcog62g4qTxq vidhyfoI 4F/rx7B8LVgu8fQgrkeQJ28s5fccjN3PG/Ati0+RGnvHP0xmGkhZKK6iD4revjOmIEthyX8yNwFiUXN+wL6fLPpWnuLXSzO2eX7cwd6hSy47NGO5zw1lw7+el2tsct/qVL9Yd/zURvTj2i8c/gvwIIQ4W91Id8XYG79gGNimuHr0wIbCy7isPpuPJe9yIeiz08t6LZbK82KKZC//fQ7/PH0blnZxKCGh53ouh6GYpU7hP5LMCieTauk2sRBs9+gCYCeEe8krQy2XxS4Rj/GjchRdkSumsdfQP55bQutzAEMbwZRysydkBqARp1oVC1NntJpiCqYubp5+FPg31qTLk1Jt2O0P+7xrVOjkS72RUxuuhOwhJmzAdHxETRVLHiy+veVWhUl4OymN3+FUr1op/zznJg7GuMQZ1x7Qv9Z695PYky4s= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Hi, On 2023/7/27 16:30, Damien Le Moal wrote: > On 7/27/23 17:04, Qi Zheng wrote: >> In preparation for implementing lockless slab shrink, use new APIs to >> dynamically allocate the dm-zoned-meta shrinker, so that it can be freed >> asynchronously using kfree_rcu(). Then it doesn't need to wait for RCU >> read-side critical section when releasing the struct dmz_metadata. >> >> Signed-off-by: Qi Zheng >> Reviewed-by: Muchun Song >> --- >> drivers/md/dm-zoned-metadata.c | 28 ++++++++++++++++------------ >> 1 file changed, 16 insertions(+), 12 deletions(-) >> >> diff --git a/drivers/md/dm-zoned-metadata.c b/drivers/md/dm-zoned-metadata.c >> index 9d3cca8e3dc9..0bcb26a43578 100644 >> --- a/drivers/md/dm-zoned-metadata.c >> +++ b/drivers/md/dm-zoned-metadata.c >> @@ -187,7 +187,7 @@ struct dmz_metadata { >> struct rb_root mblk_rbtree; >> struct list_head mblk_lru_list; >> struct list_head mblk_dirty_list; >> - struct shrinker mblk_shrinker; >> + struct shrinker *mblk_shrinker; >> >> /* Zone allocation management */ >> struct mutex map_lock; >> @@ -615,7 +615,7 @@ static unsigned long dmz_shrink_mblock_cache(struct dmz_metadata *zmd, >> static unsigned long dmz_mblock_shrinker_count(struct shrinker *shrink, >> struct shrink_control *sc) >> { >> - struct dmz_metadata *zmd = container_of(shrink, struct dmz_metadata, mblk_shrinker); >> + struct dmz_metadata *zmd = shrink->private_data; >> >> return atomic_read(&zmd->nr_mblks); >> } >> @@ -626,7 +626,7 @@ static unsigned long dmz_mblock_shrinker_count(struct shrinker *shrink, >> static unsigned long dmz_mblock_shrinker_scan(struct shrinker *shrink, >> struct shrink_control *sc) >> { >> - struct dmz_metadata *zmd = container_of(shrink, struct dmz_metadata, mblk_shrinker); >> + struct dmz_metadata *zmd = shrink->private_data; >> unsigned long count; >> >> spin_lock(&zmd->mblk_lock); >> @@ -2936,19 +2936,23 @@ int dmz_ctr_metadata(struct dmz_dev *dev, int num_dev, >> */ >> zmd->min_nr_mblks = 2 + zmd->nr_map_blocks + zmd->zone_nr_bitmap_blocks * 16; >> zmd->max_nr_mblks = zmd->min_nr_mblks + 512; >> - zmd->mblk_shrinker.count_objects = dmz_mblock_shrinker_count; >> - zmd->mblk_shrinker.scan_objects = dmz_mblock_shrinker_scan; >> - zmd->mblk_shrinker.seeks = DEFAULT_SEEKS; >> >> /* Metadata cache shrinker */ >> - ret = register_shrinker(&zmd->mblk_shrinker, "dm-zoned-meta:(%u:%u)", >> - MAJOR(dev->bdev->bd_dev), >> - MINOR(dev->bdev->bd_dev)); >> - if (ret) { >> - dmz_zmd_err(zmd, "Register metadata cache shrinker failed"); >> + zmd->mblk_shrinker = shrinker_alloc(0, "dm-zoned-meta:(%u:%u)", >> + MAJOR(dev->bdev->bd_dev), >> + MINOR(dev->bdev->bd_dev)); >> + if (!zmd->mblk_shrinker) { >> + dmz_zmd_err(zmd, "Allocate metadata cache shrinker failed"); > > ret is not set here, so dmz_ctr_metadata() will return success. You need to add: > ret = -ENOMEM; > or something. Indeed, will fix. >> goto err; >> } >> >> + zmd->mblk_shrinker->count_objects = dmz_mblock_shrinker_count; >> + zmd->mblk_shrinker->scan_objects = dmz_mblock_shrinker_scan; >> + zmd->mblk_shrinker->seeks = DEFAULT_SEEKS; >> + zmd->mblk_shrinker->private_data = zmd; >> + >> + shrinker_register(zmd->mblk_shrinker); > > I fail to see how this new shrinker API is better... Why isn't there a > shrinker_alloc_and_register() function ? That would avoid adding all this code > all over the place as the new API call would be very similar to the current > shrinker_register() call with static allocation. In some registration scenarios, memory needs to be allocated in advance. So we continue to use the previous prealloc/register_prepared() algorithm. The shrinker_alloc_and_register() is just a helper function that combines the two, and this increases the number of APIs that shrinker exposes to the outside, so I choose not to add this helper. Thanks, Qi > >> + >> dmz_zmd_info(zmd, "DM-Zoned metadata version %d", zmd->sb_version); >> for (i = 0; i < zmd->nr_devs; i++) >> dmz_print_dev(zmd, i); >> @@ -2995,7 +2999,7 @@ int dmz_ctr_metadata(struct dmz_dev *dev, int num_dev, >> */ >> void dmz_dtr_metadata(struct dmz_metadata *zmd) >> { >> - unregister_shrinker(&zmd->mblk_shrinker); >> + shrinker_free(zmd->mblk_shrinker); >> dmz_cleanup_metadata(zmd); >> kfree(zmd); >> } >