From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4B2FBC54E4A for ; Thu, 7 Mar 2024 23:33:00 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 989416B02DD; Thu, 7 Mar 2024 18:32:59 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 93A0C6B02DE; Thu, 7 Mar 2024 18:32:59 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 7DAA16B02DF; Thu, 7 Mar 2024 18:32:59 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 6DF936B02DD for ; Thu, 7 Mar 2024 18:32:59 -0500 (EST) Received: from smtpin14.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id E9A89C0C95 for ; Thu, 7 Mar 2024 23:32:58 +0000 (UTC) X-FDA: 81871845636.14.C652391 Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.21]) by imf13.hostedemail.com (Postfix) with ESMTP id 44B642000B for ; Thu, 7 Mar 2024 23:32:56 +0000 (UTC) Authentication-Results: imf13.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=WtH7Yaju; dmarc=pass (policy=none) header.from=intel.com; spf=pass (imf13.hostedemail.com: domain of dave.hansen@intel.com designates 198.175.65.21 as permitted sender) smtp.mailfrom=dave.hansen@intel.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1709854377; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=orF+Y6MVULpvTwTR0kycuhppErBSc05oAiIlRgNyDI8=; b=SfzxxDJSDCh96Fc2qRa+MHN+GzKEHGukBnNjkPI4GSazzmOWs5afVSSFmh2zVPK7l9vb5P a2WcY3ryZBYR47gTwH2I0KB+NVnvpARnY69AVscNfr+hCKjq2zUG+LjnVl5ZBnTqxTkZLO Cya/26N4tlVaSuzLbx0uOgVicKgmb/g= ARC-Authentication-Results: i=1; imf13.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=WtH7Yaju; dmarc=pass (policy=none) header.from=intel.com; spf=pass (imf13.hostedemail.com: domain of dave.hansen@intel.com designates 198.175.65.21 as permitted sender) smtp.mailfrom=dave.hansen@intel.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1709854377; a=rsa-sha256; cv=none; b=xL6tDK6IgMOdKp4Gyaz84dXYraiqG8bcxZetdUQw6nImvb5TFCJVnuG72XLKKbJ6PCdr7m nF1qYrsORuhBN9KtQdZmDHJeP2YX1Av3rP42EHc+wtP0AAKik3bvVZSCkXz1y0oCo+CJbE rr5kE0H7hmCYajWL94BdxLCB3XxYceY= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1709854377; x=1741390377; h=message-id:date:mime-version:subject:to:cc:references: from:in-reply-to:content-transfer-encoding; bh=wH1fAGWkx3PuU6bIlC2l6H2WIIxDNfblOEri3RuZAOs=; b=WtH7Yajug9Lx9+sY8TKXOHrJ6ZWe4OPd3gFunM/vI21nNSH+Fex2IE22 RyRGrSV8ugv8jtMq41FTLOhLGPgXd5AwaFSka2s0cTLJMTHtQ/z2RMskA 9ruVDMJRt6jjxk6AJL0zv3WksHJ2UM3t/TRYJqywWnowYgcUoOEVJ1Fbw zC73qGd7ilIkXTxnJJFqWx6E1IDq/iUmBCmb/+OzcZHyoN4AyrBS3Y/iM cF3iwpzB8nZxllXRwtR3uMXE6B2RCLndCFgMzdZ59MW3rB96yZmVXH2DX /p9RFsxho/nU4LU4RLsFUOEUNGLnc+u+tAshJJYCFUw3KnvMzYj35n+yF Q==; X-IronPort-AV: E=McAfee;i="6600,9927,11006"; a="4486042" X-IronPort-AV: E=Sophos;i="6.07,107,1708416000"; d="scan'208";a="4486042" Received: from fmviesa008.fm.intel.com ([10.60.135.148]) by orvoesa113.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 07 Mar 2024 15:32:55 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.07,107,1708416000"; d="scan'208";a="10373761" Received: from yuqiangu-mobl.amr.corp.intel.com (HELO [10.209.57.176]) ([10.209.57.176]) by fmviesa008-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 07 Mar 2024 15:32:54 -0800 Message-ID: <56ea29c2-8545-4689-a418-eb7784613650@intel.com> Date: Thu, 7 Mar 2024 15:32:53 -0800 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [RFC PATCH 1/3] x86/mm: fix LAM cr3 mask inconsistency during context switch Content-Language: en-US To: Yosry Ahmed Cc: Andrew Morton , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Peter Zijlstra , Andy Lutomirski , "Kirill A. Shutemov" , x86@kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org References: <20240307133916.3782068-1-yosryahmed@google.com> <20240307133916.3782068-2-yosryahmed@google.com> From: Dave Hansen Autocrypt: addr=dave.hansen@intel.com; keydata= xsFNBE6HMP0BEADIMA3XYkQfF3dwHlj58Yjsc4E5y5G67cfbt8dvaUq2fx1lR0K9h1bOI6fC oAiUXvGAOxPDsB/P6UEOISPpLl5IuYsSwAeZGkdQ5g6m1xq7AlDJQZddhr/1DC/nMVa/2BoY 2UnKuZuSBu7lgOE193+7Uks3416N2hTkyKUSNkduyoZ9F5twiBhxPJwPtn/wnch6n5RsoXsb ygOEDxLEsSk/7eyFycjE+btUtAWZtx+HseyaGfqkZK0Z9bT1lsaHecmB203xShwCPT49Blxz VOab8668QpaEOdLGhtvrVYVK7x4skyT3nGWcgDCl5/Vp3TWA4K+IofwvXzX2ON/Mj7aQwf5W iC+3nWC7q0uxKwwsddJ0Nu+dpA/UORQWa1NiAftEoSpk5+nUUi0WE+5DRm0H+TXKBWMGNCFn c6+EKg5zQaa8KqymHcOrSXNPmzJuXvDQ8uj2J8XuzCZfK4uy1+YdIr0yyEMI7mdh4KX50LO1 pmowEqDh7dLShTOif/7UtQYrzYq9cPnjU2ZW4qd5Qz2joSGTG9eCXLz5PRe5SqHxv6ljk8mb ApNuY7bOXO/A7T2j5RwXIlcmssqIjBcxsRRoIbpCwWWGjkYjzYCjgsNFL6rt4OL11OUF37wL QcTl7fbCGv53KfKPdYD5hcbguLKi/aCccJK18ZwNjFhqr4MliQARAQABzUVEYXZpZCBDaHJp c3RvcGhlciBIYW5zZW4gKEludGVsIFdvcmsgQWRkcmVzcykgPGRhdmUuaGFuc2VuQGludGVs LmNvbT7CwXgEEwECACIFAlQ+9J0CGwMGCwkIBwMCBhUIAgkKCwQWAgMBAh4BAheAAAoJEGg1 lTBwyZKwLZUP/0dnbhDc229u2u6WtK1s1cSd9WsflGXGagkR6liJ4um3XCfYWDHvIdkHYC1t MNcVHFBwmQkawxsYvgO8kXT3SaFZe4ISfB4K4CL2qp4JO+nJdlFUbZI7cz/Td9z8nHjMcWYF IQuTsWOLs/LBMTs+ANumibtw6UkiGVD3dfHJAOPNApjVr+M0P/lVmTeP8w0uVcd2syiaU5jB aht9CYATn+ytFGWZnBEEQFnqcibIaOrmoBLu2b3fKJEd8Jp7NHDSIdrvrMjYynmc6sZKUqH2 I1qOevaa8jUg7wlLJAWGfIqnu85kkqrVOkbNbk4TPub7VOqA6qG5GCNEIv6ZY7HLYd/vAkVY E8Plzq/NwLAuOWxvGrOl7OPuwVeR4hBDfcrNb990MFPpjGgACzAZyjdmYoMu8j3/MAEW4P0z F5+EYJAOZ+z212y1pchNNauehORXgjrNKsZwxwKpPY9qb84E3O9KYpwfATsqOoQ6tTgr+1BR CCwP712H+E9U5HJ0iibN/CDZFVPL1bRerHziuwuQuvE0qWg0+0SChFe9oq0KAwEkVs6ZDMB2 P16MieEEQ6StQRlvy2YBv80L1TMl3T90Bo1UUn6ARXEpcbFE0/aORH/jEXcRteb+vuik5UGY 5TsyLYdPur3TXm7XDBdmmyQVJjnJKYK9AQxj95KlXLVO38lczsFNBFRjzmoBEACyAxbvUEhd GDGNg0JhDdezyTdN8C9BFsdxyTLnSH31NRiyp1QtuxvcqGZjb2trDVuCbIzRrgMZLVgo3upr MIOx1CXEgmn23Zhh0EpdVHM8IKx9Z7V0r+rrpRWFE8/wQZngKYVi49PGoZj50ZEifEJ5qn/H Nsp2+Y+bTUjDdgWMATg9DiFMyv8fvoqgNsNyrrZTnSgoLzdxr89FGHZCoSoAK8gfgFHuO54B lI8QOfPDG9WDPJ66HCodjTlBEr/Cwq6GruxS5i2Y33YVqxvFvDa1tUtl+iJ2SWKS9kCai2DR 3BwVONJEYSDQaven/EHMlY1q8Vln3lGPsS11vSUK3QcNJjmrgYxH5KsVsf6PNRj9mp8Z1kIG qjRx08+nnyStWC0gZH6NrYyS9rpqH3j+hA2WcI7De51L4Rv9pFwzp161mvtc6eC/GxaiUGuH BNAVP0PY0fqvIC68p3rLIAW3f97uv4ce2RSQ7LbsPsimOeCo/5vgS6YQsj83E+AipPr09Caj 0hloj+hFoqiticNpmsxdWKoOsV0PftcQvBCCYuhKbZV9s5hjt9qn8CE86A5g5KqDf83Fxqm/ vXKgHNFHE5zgXGZnrmaf6resQzbvJHO0Fb0CcIohzrpPaL3YepcLDoCCgElGMGQjdCcSQ+Ci FCRl0Bvyj1YZUql+ZkptgGjikQARAQABwsFfBBgBAgAJBQJUY85qAhsMAAoJEGg1lTBwyZKw l4IQAIKHs/9po4spZDFyfDjunimEhVHqlUt7ggR1Hsl/tkvTSze8pI1P6dGp2XW6AnH1iayn yRcoyT0ZJ+Zmm4xAH1zqKjWplzqdb/dO28qk0bPso8+1oPO8oDhLm1+tY+cOvufXkBTm+whm +AyNTjaCRt6aSMnA/QHVGSJ8grrTJCoACVNhnXg/R0g90g8iV8Q+IBZyDkG0tBThaDdw1B2l asInUTeb9EiVfL/Zjdg5VWiF9LL7iS+9hTeVdR09vThQ/DhVbCNxVk+DtyBHsjOKifrVsYep WpRGBIAu3bK8eXtyvrw1igWTNs2wazJ71+0z2jMzbclKAyRHKU9JdN6Hkkgr2nPb561yjcB8 sIq1pFXKyO+nKy6SZYxOvHxCcjk2fkw6UmPU6/j/nQlj2lfOAgNVKuDLothIxzi8pndB8Jju KktE5HJqUUMXePkAYIxEQ0mMc8Po7tuXdejgPMwgP7x65xtfEqI0RuzbUioFltsp1jUaRwQZ MTsCeQDdjpgHsj+P2ZDeEKCbma4m6Ez/YWs4+zDm1X8uZDkZcfQlD9NldbKDJEXLIjYWo1PH hYepSffIWPyvBMBTW2W5FRjJ4vLRrJSUoEfJuPQ3vW9Y73foyo/qFoURHO48AinGPZ7PC7TF vUaNOTjKedrqHkaOcqB185ahG2had0xnFsDPlx5y In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 44B642000B X-Rspam-User: X-Rspamd-Server: rspam02 X-Stat-Signature: 41yz9h8qntjmuh656gx9feae1xxhm4n8 X-HE-Tag: 1709854376-66264 X-HE-Meta: U2FsdGVkX18an9IA1YQojQeqGo4499Muq6OuVSzQosCbMLs/2Zd4ZBGfSCjEJ33AyvwdG17csF27Etj8wM3uy9G/MysPsfKzaf6vND9CShi977o7ZZFQxK618IGRIc/F2hbvEU26CXk6hVs1zEa6wn1mwtvZRt+ZRR354gdG23R8wVcTs+EvtiQ2nMELxKpmWQdhVBwm4bCo/Fryh0PcNl+UcyKXpLLUNV2Uc5Uq6aUwHxq/8OU0/o9pJGqIQyrZCBrRUI9s4UcDXQwGE7JaBc6dMvavdprWl0XuvEmq1vJ+55Y1uHi2Zia+XejEp1t5xysrM1iWDODBXy5ZdAeAqRnkwuam4WObwhiP50TsRIpsQTqavJLBWW4QDWJHhLR1Ovq+cBtEB1JWJgiWSbSnxVu0l04EMkXvKzbUkW4XxmO1a3583dcE7Pnz5x/xfK0Zf3hmWheK5xoewKoKrdgfjhY3Z4btEs+7nOtxvQJ0UcKSyBJuJfvIARw0ggbH/fGGS2b9malAnvUX+8X3sYOtt48Z+x9alLkOf4fFGIRdfhTA6PaFxjKVNc4r8Lhux7lTSmkUPg6eV8Pce3vAgh11TebcGIyc5LVgg6E414TtHOsersc0fZUL1ft0V9jzpw70XFpk9lOTK+7qiHBjRKP6mf5NDdq2evQF3AaTWuaFZHO7uLZFEIiZ/73esQ4+nMeM4DX9XLdK0//t01qDsPlCZPX3KbEdLZlIM+OZHtApSzZAEa1floCSujFjKkqnImLzwLKhQtJyhLDsMPK2Y4mdJpQrnnXpN0aL0wNdx/Twm/KWXJJvXc+BgLNzLQoL3PTRSptP9XEtn5CpkPa3cM5HnFW6Hwis86u+6y7qFquufyzda0f+M84qf6IYijCCbiQ1 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 3/7/24 15:21, Yosry Ahmed wrote: >>> The "set_" naming bugs me in both of the sites that get modified here. >>> I'd be with a new name that fits better, if we can think of one. >> Is it because it's not clear we are updating cpu_tlbstate (in which case >> I think update_cpu_tlbstate_lam() is an improvement), or is it because >> the function returns a value now? That's part of it. >> If the latter we can put "return" in the name somewhere, or keep >> the function void and pass in an output parameter. No, adding a "_return" won't make it better. > Or we can avoid returning a value from the helper and avoid passing an > mm. The callers would be more verbose, they'll have to call > mm_lam_cr3_mask() and mm_untag_mask() and pass the results into the > helper (set_tlbstate_lam_mode() or update_cpu_tlbstate_lam()). Another > advantage of this is that we can move the READ_ONCE to > switch_mm_irqs_off() and keep the comment here. One thing I don't like about set_tlbstate_lam_mode() is that it's not obvious that it's writing to "cpu_tlbstate" and its right smack in the middle of a bunch of other writers to the same thing. But I'm also not sure that open-coding it at its three call sites makes things better overall. I honestly don't have any brilliant suggestions.