From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id D2A3FC25B75 for ; Fri, 31 May 2024 10:57:31 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 5625A6B0095; Fri, 31 May 2024 06:57:31 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 511A26B009A; Fri, 31 May 2024 06:57:31 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 3B2196B009B; Fri, 31 May 2024 06:57:31 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 19F206B0095 for ; Fri, 31 May 2024 06:57:31 -0400 (EDT) Received: from smtpin10.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id C8CED1A1370 for ; Fri, 31 May 2024 10:57:30 +0000 (UTC) X-FDA: 82178389860.10.272D414 Received: from HK2PR02CU002.outbound.protection.outlook.com (mail-eastasiaazon11010001.outbound.protection.outlook.com [52.101.128.1]) by imf19.hostedemail.com (Postfix) with ESMTP id 6D5E91A0005 for ; Fri, 31 May 2024 10:57:27 +0000 (UTC) Authentication-Results: imf19.hostedemail.com; dkim=pass header.d=oppo.com header.s=selector1 header.b=B94VJ5n6; arc=pass ("microsoft.com:s=arcselector9901:i=1"); spf=pass (imf19.hostedemail.com: domain of hailong.liu@oppo.com designates 52.101.128.1 as permitted sender) smtp.mailfrom=hailong.liu@oppo.com; dmarc=pass (policy=quarantine) header.from=oppo.com ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1717153047; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=h9rBxc/rCfszobnzgFFRX5iG/79t2sVMqpsOyA9DVDg=; b=MmIkmp430T3mkalCByxjLD7n1GnS9YZ3cbIw45Vo18Tfw6VxEy1RmOqwzvpW3LWQdCC2RF uovY0syzs/oZGUVTf1y5gbyT9nXx5xhSTbE0DVvd9lH1AZWkHGmUyvpl5NyXLg7t14OW1L fX1gBmSuvRbYDeGSeOpnqLU3yoHtjnc= ARC-Authentication-Results: i=2; imf19.hostedemail.com; dkim=pass header.d=oppo.com header.s=selector1 header.b=B94VJ5n6; arc=pass ("microsoft.com:s=arcselector9901:i=1"); spf=pass (imf19.hostedemail.com: domain of hailong.liu@oppo.com designates 52.101.128.1 as permitted sender) smtp.mailfrom=hailong.liu@oppo.com; dmarc=pass (policy=quarantine) header.from=oppo.com ARC-Seal: i=2; s=arc-20220608; d=hostedemail.com; t=1717153047; a=rsa-sha256; cv=pass; b=gMzZJKFWU+jaGdocj8zf2Ub9set+g09yikQiwQlCLlZL2jPhl8pYeqe2fwrM7A8BFqn4Mj ESL/Nxe5nJOqIY0DLs7jUrgYiTzC0zL51Qyp6ky/f6/e4coo9htRVY91U/8KnTxAfAMPnc WKx3J6kyFq+8/jxKRrHcvBjO/i/8rEE= ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=iCVb9vatzac5sMtRiZWCRsHRxWmI5xsIVpU9Yc1V6YacTKth4ZJIWTEIe9TrTLyy3aaaPkh6/4STxc+m8EvbcDZYD03tDuKdZ08UF9wdJjZyDySsQRvCPmnt+SAQq2C3zRW6b+IWlN6LagUkUjt/8fmNMDq+lUboUiqnOk35lYEgfpdSPaX3I2gL45s5UBUMkBUgoqg1XxBNBd4b7zlEpXuOHqrX/IoHUjHGK13ndTvlX+UrRreklUYg97LcraMz/G3EQPxWfM2HSGgb4jH1P+YWjkXfmv0BxDbUQFpMhkXtpUUl9ms8TLvHmYnwifbLhtxs7/dmRxDIuOVInQjexw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=h9rBxc/rCfszobnzgFFRX5iG/79t2sVMqpsOyA9DVDg=; b=G9Qaq2puJbKg1TU856ZPGUNp/h2W+PEv6sV9BXJICAQU7BBVm5VMiCoTmw3bnfEqB2HhVL2+nfYlZhWM9QnElR0d4N2VInzpe7/EotwerDVZOPbLe1P3KeOAuYKniZNRq8tb2aIB00Oj5UjC3ZsjnFQHHd7wi29cMZq3cuAxDGuSl6nyZBFJmNwSydRtkQaNfYSuQQqYgoQLmKN04XKUzqEVZw355+4T4/xlaURLsAtCzBYy5Gx50561sX9R9Mh3g9iqaKpbO3JimWXCOfydyUkV4JplOWFEDHINh8KdbgTd7xbctj/eOAqx/nAgqfTJzlvJIxNkcSGipnv4+i9/DA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 58.252.5.68) smtp.rcpttodomain=sina.com smtp.mailfrom=oppo.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=oppo.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oppo.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=h9rBxc/rCfszobnzgFFRX5iG/79t2sVMqpsOyA9DVDg=; b=B94VJ5n6rzD3geHy4+Z0RL795oDSSr70d/R0qDWY6FcIP3YkfiAPeYhe8HU5p88JJ5tjIWSI/9CzTwV/H2nC4DsCaspmJGRlXzIi771OBHsFK/HLjdL8fjZzderiSLIUbalxZ9Dr4rArJKR2IH8DT952B7hZ0tHJfWNZ3UOkapg= Received: from SG2PR02CA0089.apcprd02.prod.outlook.com (2603:1096:4:90::29) by TYSPR02MB7418.apcprd02.prod.outlook.com (2603:1096:405:37::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7611.22; Fri, 31 May 2024 10:57:22 +0000 Received: from SG1PEPF000082E2.apcprd02.prod.outlook.com (2603:1096:4:90:cafe::45) by SG2PR02CA0089.outlook.office365.com (2603:1096:4:90::29) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7633.23 via Frontend Transport; Fri, 31 May 2024 10:57:22 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 58.252.5.68) smtp.mailfrom=oppo.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=oppo.com; Received-SPF: Pass (protection.outlook.com: domain of oppo.com designates 58.252.5.68 as permitted sender) receiver=protection.outlook.com; client-ip=58.252.5.68; helo=mail.oppo.com; pr=C Received: from mail.oppo.com (58.252.5.68) by SG1PEPF000082E2.mail.protection.outlook.com (10.167.240.5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.7633.15 via Frontend Transport; Fri, 31 May 2024 10:57:20 +0000 Received: from [127.0.0.1] (172.16.40.118) by mailappw31.adc.com (172.16.56.198) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39; Fri, 31 May 2024 18:57:20 +0800 Message-ID: <56e5606e-6dcb-4c34-a3b0-143a29b021f7@oppo.com> Date: Fri, 31 May 2024 18:57:14 +0800 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCHv3] mm: fix incorrect vbq reference in purge_fragmented_block To: Hillf Danton , Uladzislau Rezki CC: "zhaoyang . huang" , Andrew Morton , Thomas Gleixner , , References: <20240531104425.3262-1-hdanton@sina.com> Content-Language: en-US From: Hailong Liu In-Reply-To: <20240531104425.3262-1-hdanton@sina.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-Originating-IP: [172.16.40.118] X-ClientProxiedBy: mailappw31.adc.com (172.16.56.198) To mailappw31.adc.com (172.16.56.198) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SG1PEPF000082E2:EE_|TYSPR02MB7418:EE_ X-MS-Office365-Filtering-Correlation-Id: ce37baf5-2246-4c8f-f597-08dc81607204 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230031|376005|82310400017|36860700004|1800799015; X-Microsoft-Antispam-Message-Info: =?utf-8?B?U3pNWFA3NWJTWmtxOTR4Qm5IeFU4cXp5eVZQTXdZdGluYXI0Uy9IdjdoYzdL?= =?utf-8?B?RVFjNlNwNCtGaURXK2NtWFRwODVxeHZaNmQwZmk2R25tbVV2OHZjeUFQNUlI?= =?utf-8?B?aDcvd3RqWmlxM1BhejAzajhwNGRMWFkvakhlT2xuUUFCSHpDU05mOTdZTm1j?= =?utf-8?B?TjRtUHRQWTJNYnN2Z1pXVEtBZ2ZiZDRHdHdERlRMUVFpbU5LNndPeWZQTDZt?= =?utf-8?B?cTNPU09UdENOMmtWUUpCR05lNjJhaGx6RjNITzYvaXFxeHBtNFZNeElYVTJV?= =?utf-8?B?YU5md3Rwc2ZieUdJVitnaXBsMEFjTEYwcDdaU0VUR0dqbGx0Z0Y4SXZ2ZEhI?= =?utf-8?B?c3JwQWMzWkpDRHBSN0RiTzQ1OUhidEhpL04vR3Q5MjdJUkU0a3ZiWTlJL0Ra?= =?utf-8?B?TUUxajdXVTVNbWRIQ1htYmlycHhFNnlCSGRlWDduS3RSTGpldUlKYk51OFpp?= =?utf-8?B?Y1lOemlJM0VuQVZVRnJ5cWtFcnF1enlnaDR1SnJWZHdyV1VhbE9lWVp3d3BU?= =?utf-8?B?V05uS2VNYjRCTVRWT3dNYWdBWFZCclp0bnd3WVUxdkxDalViRHRVLzc5Z1Z0?= =?utf-8?B?dytsTGREc0dNbVc3Q2l0Um1seHlNVi9tV0haeWo0eUxJWnNwK1poVHB5VnVw?= =?utf-8?B?WWNWMnhQL2E4OWYrVjhGNXpXVFZzdXRCM3NJT3gvMmladGVxWGtqZlhXVFhq?= =?utf-8?B?VmR4TS9Ualo0OHExNkw1Zm9IL0REU2NPNGNsSTRHdmdNek5CemkxbUMyMDBj?= =?utf-8?B?R2Q2b3BmN1hXZXVXRTdRSWdqZm8vTnZ5dzRoR3BlZVlJZUhQK0pyUUxkcnF4?= =?utf-8?B?VTVSZ2xtNS9tYUIydkpBMm1sRkZSRlZXRE5tcGdTSXRMUE54aG95dlF1clJR?= =?utf-8?B?S245eTJ2TFROUUVDYk9aTjAzSFJuQ2ZVK0ZSM2JFSVgwR3MxSDh6T04xSS9i?= =?utf-8?B?VXFRL2c5S0FEQjdHZXNVVDJJRnp5emZMS0RaMGU5UUh1c3ZqSFB5R3lhZysw?= =?utf-8?B?bEhmNTk5RVp1WU93djVqK25USHI1TTRubzFRbVlCWWdBd3pLcVlUQkd4Sllw?= =?utf-8?B?TVpMMmlyUXFkS0tyRHg3cHVNanlBM2JtdThsbnpMYldTbnkzQ2R6T2prL1Bs?= =?utf-8?B?Vmg4dUVmTzAxdjJWeUk1UFhPK0V1QitOSk92RWZRc25FOUNZRDZidisxNE0z?= =?utf-8?B?bVROOEVMNngzOWpJdlhKSkwwUU9RVGZ0UnJtME5KTlZ4SFZXcjQ1TnZlTXU3?= =?utf-8?B?d1RBdzJMc3B1dEIrWXFEbWVweExnaTZDMEVtalRNS0hPZUxCNldpeERkVHJL?= =?utf-8?B?SWJ3N09seENOS0RORE1OWGFjN2xVWko3eTltaHM2SEhvcnlaRXBjajlhK1Fw?= =?utf-8?B?d0E1TnRVOERWQ08zME51bC9KNkpxRE1VK3diUGlpNy9CU1BKL3NsNWEza3NS?= =?utf-8?B?cFpUUkpQSFJtV1p2NjJmNnpVZDNNSE5mQThsN0JqcFI2Z0NCYWFLNEhManRD?= =?utf-8?B?Tk5Lbi91SzRlcWpieTJxOFRtZ1psQ2ozVDlXbVpqbnRYMng4RkRReTJXZE5y?= =?utf-8?B?UXIwK09CaWl5Z1FjdTVuUDBocjdYOW9hczBQK2hJNUdiY09CR1dESkxhQ05Z?= =?utf-8?B?SzhlSmRUYklna2J4REQ2MVlaQUd2d0lqOFNyTjZzYnloMEFGOHBORFZhL0M5?= =?utf-8?B?MzViTlNxS1VqakhRanhpOEVWSHFPM0ZhSmNZVS9XQWV3TlBvdmRmYzVnQVp3?= =?utf-8?B?cXF3U3lHWThmMm54UmJwdThwZHd3SUNGYk1kRjkrL2kvMkQwcEtLeEN0Vllj?= =?utf-8?B?RGRJci9PSUZHNWpWUGVNS25TWXFDQldTK1ZFYnRWT1hnOGtxcFlSazFjbjFz?= =?utf-8?Q?/lCCTZMWJgcFG?= X-Forefront-Antispam-Report: CIP:58.252.5.68;CTRY:CN;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:mail.oppo.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230031)(376005)(82310400017)(36860700004)(1800799015);DIR:OUT;SFP:1101; X-OriginatorOrg: oppo.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 31 May 2024 10:57:20.8288 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: ce37baf5-2246-4c8f-f597-08dc81607204 X-MS-Exchange-CrossTenant-Id: f1905eb1-c353-41c5-9516-62b4a54b5ee6 X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f1905eb1-c353-41c5-9516-62b4a54b5ee6;Ip=[58.252.5.68];Helo=[mail.oppo.com] X-MS-Exchange-CrossTenant-AuthSource: SG1PEPF000082E2.apcprd02.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: TYSPR02MB7418 X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: 6D5E91A0005 X-Stat-Signature: 1ff5fd8y155qmzth61kkbrpxepw3cgzh X-Rspam-User: X-HE-Tag: 1717153047-553453 X-HE-Meta: U2FsdGVkX19Z6dC/BwF59hEks3NCsS6T5T1oDMdHX2qJJaas5JwiKvJcrFpAp+TUNy61U4jNsmTyz0tDt9LmMMoMZrwy2NgyCRaJMOnjGpvCqMBm0v/qIQMxWRLuXiwE/fPj35E4Gz+hq6DOjbcEBgUKnqoDfcDu9O/o2nK6UKAedCz90Z41bCaXmRJsm2RyK9V9yw3Zc+A1kgkoKJxL4RQm2Cr3h9tA0ZMph581NRLIH2t7h77McNATH0sHXJXczmjdyqYJtktHRBfR+a4ZrOh4yjdTZ29F4CDM06jCjQcedhZ3qE3hhGVx+CuYxo3N2SUPf2SzkIu6VsiP3EeFAgonuMyIESgdjceqsgPJLmEc/3+AssA76EjqCxWIjkVY9EmReTFwp3Xj+80HUngSI+gBceLy4aUpAlU9cere3OIS3fhumKj/JyTCx8DjcH93lDQSdKL4xv6vIrpxVbSsFob2Pp1EAekJH7SvNWUHrZbb2mQiNNbsZmuUxO3Tdf5qOW+8/NJC2pzZizbJf1im+/zsYlCQQ0jBo4lLLZU1LEZyLBsujKBFjtlXtioVhw7xUTHqhEyE0y7VpyK5USMF52xKE8leVSlKOg4uA6tO82mjU81EWxpqlWIxJEn/SHs0XFdI/uNZqBj6t6yk2s0krfi1EwlrWTQKtskOqSekzDrOpn5zwNJLIWne63O6QYFCvPCHGPUQiKw1ctO/gb44I+thxZL+4wdZ4sxeEExcU21eSulF16nIMTKoPF/swVJb2SSFYHCGYDhbe2j/08RgFTupKSSE1fPz2hAYlKxizLqaOjB8jsDXo5rK1E83w0ipm4RpVAmPCfC7/2FItVbEAacbtbon/0i1DbYRmk+c3cpem44XXOEUvO930LFN58yy8kYW+DIiuG8EZKJ6onX0dzmZGyw7aOOAx2PSksgLL4D0fMU0KtIWXnUM9q40q/ZBvzaj5j3bV2aLDB0Vl7U EIylF3jX QBe/zvOdY02vWDWKrvX8zcGQvru7+C52v5qBBAYgvXpMG/4bVR56Cb2l4VNKR1aDHZEoBRgUQa7RE+kWHbfTTWYQAwG30xImMpdJ4Q5hgfBxL6stSvAxyZgXg9RkUWR0mF889s0775XLFWZ6aOuECczmfuIQNr0nzV15qOvmF7v4tGQL0uO1lt/xkmXCKrCASjzJIBatXMBdz4loXppHyeMDIE5PfjYZEkXhPuCQ8edLmnounMxzIja/oTo2HKG+bgM30O4BIO03sXuCLo96ZSR+JT3I+HvP+7K+yj3SzJfL9VoRe/20fYLzj979mX89REPpaUa7aynBaYfsdQzNsfImkbqVo8rtFSZM0kk6dJ/wuB4OOqzpPpsWUKr/C4p5ngr+a/nCtHKNjQESGhITivmW8UWJGoEgDHTBx3JGupJONtY6mMLCcmoT7cN4ipgFVEdBiKBfyhOSVkt8QsWzBR+O4XlojIUqxj2aQ5uM1XRL1nKjZ+dm3rNQx34OKCb/9nNeZkEiAXRzaWc/wz29b/TNFdQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 5/31/2024 6:44 PM, Hillf Danton wrote: > On Fri, 31. May 10:04, Uladzislau Rezki wrote: >> On Fri, May 31, 2024 at 11:05:20AM +0800, zhaoyang.huang wrote: >>> From: Zhaoyang Huang >>> >>> vmalloc area runs out in our ARM64 system during an erofs test as >>> vm_map_ram failed[1]. By following the debug log, we find that >>> vm_map_ram()->vb_alloc() will allocate new vb->va which corresponding >>> to 4MB vmalloc area as list_for_each_entry_rcu returns immediately >>> when vbq->free->next points to vbq->free. That is to say, 65536 times >>> of page fault after the list's broken will run out of the whole >>> vmalloc area. This should be introduced by one vbq->free->next point to >>> vbq->free which makes list_for_each_entry_rcu can not iterate the list >>> and find the BUG. >>> >>> [1] >>> PID: 1 TASK: ffffff80802b4e00 CPU: 6 COMMAND: "init" >>> #0 [ffffffc08006afe0] __switch_to at ffffffc08111d5cc >>> #1 [ffffffc08006b040] __schedule at ffffffc08111dde0 >>> #2 [ffffffc08006b0a0] schedule at ffffffc08111e294 >>> #3 [ffffffc08006b0d0] schedule_preempt_disabled at ffffffc08111e3f0 >>> #4 [ffffffc08006b140] __mutex_lock at ffffffc08112068c >>> #5 [ffffffc08006b180] __mutex_lock_slowpath at ffffffc08111f8f8 >>> #6 [ffffffc08006b1a0] mutex_lock at ffffffc08111f834 >>> #7 [ffffffc08006b1d0] reclaim_and_purge_vmap_areas at ffffffc0803ebc3c >>> #8 [ffffffc08006b290] alloc_vmap_area at ffffffc0803e83fc >>> #9 [ffffffc08006b300] vm_map_ram at ffffffc0803e78c0 >>> >>> Fixes: fc1e0d980037 ("mm/vmalloc: prevent stale TLBs in fully utilized blocks") >>> >>> Suggested-by: Hailong.Liu >>> Signed-off-by: Zhaoyang Huang >>> >> Is a problem related to run out of vmalloc space _only_ or it is a problem >> with broken list? From the commit message it is hard to follow the reason. >> >> Could you please post a full trace or panic? > > What they proposed looks correct IIUC > > --- l/mm/vmalloc.c > +++ v/mm/vmalloc.c > @@ -2067,7 +2067,7 @@ static void *new_vmap_block(unsigned int > return ERR_PTR(err); > } > > - vbq = raw_cpu_ptr(&vmap_block_queue); > + vbq = container_of(xa, struct vmap_block_queue, vmap_blocks); IMO, this violates the percpu principle, why not use vmap_block_queues[NR_CPUS]? > spin_lock(&vbq->lock); > list_add_tail_rcu(&vb->free_list, &vbq->free); > spin_unlock(&vbq->lock);