From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.0 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 44BF3C433E1 for ; Thu, 27 Aug 2020 09:52:03 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 03489207CD for ; Thu, 27 Aug 2020 09:52:02 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 03489207CD Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 935DA6B0006; Thu, 27 Aug 2020 05:52:02 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 8E5B16B0007; Thu, 27 Aug 2020 05:52:02 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 7FD2B8E0003; Thu, 27 Aug 2020 05:52:02 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0236.hostedemail.com [216.40.44.236]) by kanga.kvack.org (Postfix) with ESMTP id 6B28C6B0006 for ; Thu, 27 Aug 2020 05:52:02 -0400 (EDT) Received: from smtpin13.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id 28CF7A2D4 for ; Thu, 27 Aug 2020 09:52:02 +0000 (UTC) X-FDA: 77195882484.13.nerve24_3b1785a2706c Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin13.hostedemail.com (Postfix) with ESMTP id E9C6018140B67 for ; Thu, 27 Aug 2020 09:52:01 +0000 (UTC) X-HE-Tag: nerve24_3b1785a2706c X-Filterd-Recvd-Size: 3354 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by imf49.hostedemail.com (Postfix) with ESMTP for ; Thu, 27 Aug 2020 09:52:01 +0000 (UTC) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id A53D7101E; Thu, 27 Aug 2020 02:52:00 -0700 (PDT) Received: from [192.168.1.190] (unknown [172.31.20.19]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 7C99F3F66B; Thu, 27 Aug 2020 02:51:58 -0700 (PDT) Subject: Re: [PATCH 19/35] kasan: don't allow SW_TAGS with ARM64_MTE To: Catalin Marinas , Andrey Konovalov Cc: Dmitry Vyukov , kasan-dev@googlegroups.com, Andrey Ryabinin , Alexander Potapenko , Marco Elver , Evgenii Stepanov , Elena Petrova , Branislav Rankov , Kevin Brodsky , Will Deacon , Andrew Morton , linux-arm-kernel@lists.infradead.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org References: <5185661d553238884613a432cf1d71b1480a23ba.1597425745.git.andreyknvl@google.com> <20200827080442.GA29264@gaia> From: Vincenzo Frascino Message-ID: <56ba1b14-36af-31ea-116b-23300525398d@arm.com> Date: Thu, 27 Aug 2020 10:54:11 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <20200827080442.GA29264@gaia> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: E9C6018140B67 X-Spamd-Result: default: False [0.00 / 100.00] X-Rspamd-Server: rspam04 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Hi Andrey, On 8/27/20 9:04 AM, Catalin Marinas wrote: > On Fri, Aug 14, 2020 at 07:27:01PM +0200, Andrey Konovalov wrote: >> Software tag-based KASAN provides its own tag checking machinery that >> can conflict with MTE. Don't allow enabling software tag-based KASAN >> when MTE is enabled. >> >> Signed-off-by: Andrey Konovalov >> --- >> lib/Kconfig.kasan | 1 + >> 1 file changed, 1 insertion(+) >> >> diff --git a/lib/Kconfig.kasan b/lib/Kconfig.kasan >> index b4cf6c519d71..e500c18cbe79 100644 >> --- a/lib/Kconfig.kasan >> +++ b/lib/Kconfig.kasan >> @@ -69,6 +69,7 @@ config KASAN_GENERIC >> config KASAN_SW_TAGS >> bool "Software tag-based mode" >> depends on HAVE_ARCH_KASAN_SW_TAGS && CC_HAS_KASAN_SW_TAGS >> + depends on !ARM64_MTE > > I think that's better as: > > diff --git a/arch/arm64/Kconfig b/arch/arm64/Kconfig > index 10cf81d70657..736c32bd8905 100644 > --- a/arch/arm64/Kconfig > +++ b/arch/arm64/Kconfig > @@ -131,7 +131,7 @@ config ARM64 > select HAVE_ARCH_JUMP_LABEL > select HAVE_ARCH_JUMP_LABEL_RELATIVE > select HAVE_ARCH_KASAN if !(ARM64_16K_PAGES && ARM64_VA_BITS_48) > - select HAVE_ARCH_KASAN_SW_TAGS if HAVE_ARCH_KASAN > + select HAVE_ARCH_KASAN_SW_TAGS if HAVE_ARCH_KASAN && !ARM64_MTE > select HAVE_ARCH_KGDB > select HAVE_ARCH_MMAP_RND_BITS > select HAVE_ARCH_MMAP_RND_COMPAT_BITS if COMPAT > I agree with Catalin here, "select HAVE_ARCH_KASAN_SW_TAGS if HAVE_ARCH_KASAN && !ARM64_MTE" should be sufficient. -- Regards, Vincenzo