From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3474DE77188 for ; Tue, 14 Jan 2025 16:54:08 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id B641B6B0095; Tue, 14 Jan 2025 11:54:07 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id B14876B0096; Tue, 14 Jan 2025 11:54:07 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 9B4C46B0098; Tue, 14 Jan 2025 11:54:07 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 7D5D66B0095 for ; Tue, 14 Jan 2025 11:54:07 -0500 (EST) Received: from smtpin06.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 2D384160B6F for ; Tue, 14 Jan 2025 16:54:07 +0000 (UTC) X-FDA: 83006654934.06.9B0A79E Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf15.hostedemail.com (Postfix) with ESMTP id 96286A0005 for ; Tue, 14 Jan 2025 16:54:04 +0000 (UTC) Authentication-Results: imf15.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=UiMBMMfr; spf=pass (imf15.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1736873644; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=056ZHJ91+HDRI4BQYHeDGeZYL/iE09ANEtZFdy1HhhA=; b=UVQKCRiNxyr9DbuSmvXI3pJw99sj8mnY45qwE1Nzh8eZMq6m4KBOzNCabRwAfXPlBOJI9s DUwstCxwY7ok2lDODJwfVWQ6NbA3k+XQbePPDoHfkj7ON2WdcURGaUJiw4g4jA2WHi8Q2e Ec/tIUJd0WyEarP0BYStDDsHqZL0ZQM= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1736873644; a=rsa-sha256; cv=none; b=V2LuqcSuj1Ygz48l+XATJ3Dv8/kNhmcyzvXlmbwVDtpA4DRBO8H5y19onCQaBEidKzXk9F mk9PHEdKRXEzo5ovNkHGfPXKghfZg4kJlxZykt41t/r14MWpvsbFk0r3d0jFKAe//hRy2w xZT6DfgjgKFUq0HoPjTOsy0GUp/Of0M= ARC-Authentication-Results: i=1; imf15.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=UiMBMMfr; spf=pass (imf15.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1736873643; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=056ZHJ91+HDRI4BQYHeDGeZYL/iE09ANEtZFdy1HhhA=; b=UiMBMMfrWK0BoPMcG/g0jak6b9UjLBD7qZoKWVCE6G0Um2FUnX5u7Wy0YYsMuy3QsznHgx ds/hFHQGg1WL5eFSTwYomqGPxuHAidFpr6PjdaC5PuEuqW1NYmO/6+FyA5f3T/XhbulvEv exZ3MxKdiAiC0EEHZFks2NIT4LT46Ck= Received: from mail-wr1-f69.google.com (mail-wr1-f69.google.com [209.85.221.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-256-fQRB9NviNvGnVXl-pvgxsQ-1; Tue, 14 Jan 2025 11:54:02 -0500 X-MC-Unique: fQRB9NviNvGnVXl-pvgxsQ-1 X-Mimecast-MFC-AGG-ID: fQRB9NviNvGnVXl-pvgxsQ Received: by mail-wr1-f69.google.com with SMTP id ffacd0b85a97d-388d1f6f3b2so2603877f8f.0 for ; Tue, 14 Jan 2025 08:54:02 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1736873641; x=1737478441; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=056ZHJ91+HDRI4BQYHeDGeZYL/iE09ANEtZFdy1HhhA=; b=WYMgHodPADcnx0NpZetTl7cmFLDHD2syTYUm+mUfnrqGK/Wf3GJsErWSl9j1GhwWoj RxEcKfnt2IzIHV0B383CH79t/yc90p3u2OsOiMJzQDpFtfXYp/Q6XWlW/9WwLtFKP10P Tr9Telmz4UEgbTqij3c4UQwOyZca185N7+VgfNxSfYz6llZcSEsGS7DNwbfUhlFSvWV4 TIxBbd/rNo8e0rttJ1l73J1/3+yGnjU8UIWLCh1jJUOaLX6Qk+IaR12YxaWVgq0tBD6z NnnKjmmuqPDkdZFL/kcxRPwoj8W6ZmEXWs3mJiODnlZZVZl4rE7KgZnEsFInPHIIgIsw FiiQ== X-Gm-Message-State: AOJu0YxSnVtmQrXVGkQqeNVINEra2C+3P7WgQXC5AVc/5HiTKoIDgYgj Kl7msHz1pHgSUIcZ0HyJOM1US8TIKkW25NIUpzHdlNpmQddgKFAGMvE1GVfpoSdk4kJ1aaQRpHQ e0b7LTBHQ3mrQ7Phkja43UGxsnG/4fIvACw4iEqMCg2kkRpKtAi2A/KW3xNQ= X-Gm-Gg: ASbGnctdzbc+mkapXbIbpV8NjzYyUfw6X6OviDQ8+K0CjmsVD/GYB8DgYu2aUJU2j/j OW1eCLmoGHm/SwPn4uy8naL4T8W+xjHyg8jR+JaHnaBo0JW/ianqBrGUDC2+H51VbM+RPpKMcYH YSIHUHHRuLTnnTBVtlopqr3LDpzTYYTS8fY/gDGBGG9OxFYcrL54+SvwMQeZlkidNSpCTU0hhnd dWx+a5TjLvewN/NyuszsdMCW4nLIltS1P5G5CYmaLPiW5dr7BsbFrBUnORFiLDAIQfNxjNc7kFj dzFWX5j2eg0K2fovQJukEbf1CincSPKw3qzePKAs6iTMMYE+Tw6yRGN0Iqftu0KWPNWapuXDgp+ shsraGrj5 X-Received: by 2002:a5d:5985:0:b0:38a:2798:c3e0 with SMTP id ffacd0b85a97d-38a87358f3bmr22039210f8f.54.1736873641193; Tue, 14 Jan 2025 08:54:01 -0800 (PST) X-Google-Smtp-Source: AGHT+IHszYQ25Q8gOYLXiUeL3WQw5fG7HtbGIoBScqOz9la2MvGnmSzFJ80J/RseI4NGCCdbYcB6Eg== X-Received: by 2002:a5d:5985:0:b0:38a:2798:c3e0 with SMTP id ffacd0b85a97d-38a87358f3bmr22039192f8f.54.1736873640840; Tue, 14 Jan 2025 08:54:00 -0800 (PST) Received: from ?IPV6:2003:cb:c738:3100:8133:26cf:7877:94aa? (p200300cbc7383100813326cf787794aa.dip0.t-ipconnect.de. [2003:cb:c738:3100:8133:26cf:7877:94aa]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-436e9d26a7bsm187883795e9.0.2025.01.14.08.53.59 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 14 Jan 2025 08:54:00 -0800 (PST) Message-ID: <56a1657c-d60f-4cdc-88a7-826ad977890f@redhat.com> Date: Tue, 14 Jan 2025 17:53:58 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v4 4/4] selftests/mm: virtual_address_range: Avoid reading from VM_IO mappings To: =?UTF-8?Q?Thomas_Wei=C3=9Fschuh?= , Andrew Morton , Shuah Khan , Dev Jain , Thomas Gleixner , Anshuman Khandual Cc: linux-mm@kvack.org, linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org, kernel test robot References: <20250114-virtual_address_range-tests-v4-0-6fd7269934a5@linutronix.de> <20250114-virtual_address_range-tests-v4-4-6fd7269934a5@linutronix.de> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <20250114-virtual_address_range-tests-v4-4-6fd7269934a5@linutronix.de> X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: FyY3_bvcOXHrKJSyhPoWFkLR35Y6vmoA_WWtHBvizJg_1736873641 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Rspamd-Server: rspam10 X-Rspamd-Queue-Id: 96286A0005 X-Stat-Signature: spgibgjqt1hb6q861e3z1zq1hsunukci X-Rspam-User: X-HE-Tag: 1736873644-329254 X-HE-Meta: U2FsdGVkX1/b9thiQ2aiJbqIjxU0AF7Oi/qGDNrEmFY7MZAcjBmX3QeA+GC74hGa8BP/hd8v3WYWXvqHPI7lVa2VaF99sQc3yhaLXcvWBiQ8/rf/zkyYdqKn5lx1qyt0p7ddKcC4pw7Ru9R+MO2lJWWQpBU2ctyN2cocxgLj6svbK7EC3VR5ekXEPVViQRVxt4VJ9YXzBJFB2OisJ7xig1lEbGFNXdPt1eIVmm4ld4cLFdUhVDhs4tnpivEnooqTAB2caZ/FLybPddN3f32Qpwf1UtnyYGmxgld3YKYv2TZag2wEwqFEpmNf2HvTjW4ul3H2BDBorqXtRf06WGJ8Mq8vqddAMZhQifvfBno/rS9r+aqmLsSzd6u4cAp81Cc2HbMwV1OazEgQQIXYYsE0Tg6aPeVGAXahHDvBcgsEGnFONMcWv940JRjRGk5z4D8Ffb0WSX34Y0G7ynJEa9+95SbOKdTlSUjm+nS5z5Pd6BfUvyb8cFOv+QF8vD5pUQYJjQ2hvhP97pyU+KGNybdtnVMaYqFBZuuBZE11TickJOJUwepotdXeeTMAbYVSjKQCuwvZxDA3lkpZFWbqnv7Bj4r5U3WmpbgnscUBddKwB7WfIozmwfWpBD48avEt31WYviiscrTtYmF5aZzVbAXuNNAibbp6/Q5Bg5K3/UvMLesak8iwpO8vD8Hy0+dtEAxWPQ5oDN4vdDV3tFr6vmhkr5P3pV1Cabe+OegwDWPnrmFvBjUBCyia4rm3HxBcPYc0ozIR8X8z/d3oOJ7oaCRrhXEafqf6uGFjDGA+r0H5M89bSBywQtd38R1pixFSO8Bi67HytRqL82+NLtv6QO5FpOYKH3S9rqi/x057yrHCZzKs3pGbPui64uz3Q/j3+4TeddQ0KhR/MsoWEYiwUGIfCPfSHMoGahnCs7GUx04eUIXr2SKtSvMNIIaxFEl9SzyiSGrXjrutfsRqON5Z8wb zgxgQ3Bz 7fGfqPagG+sjpdlB2Ys4sFobNL/uDrkNH46otDgcy5yf5n+a2LhmCOpMskeRN09MH77fKkNNzDKi2K7DeGcDfRiBmCYIDx3nmpCCdp2RuwAOYufJoqaPis5wBOem/bKj4XUq6FXTXrqg2o4Um7Z2XBtj64/hYlkOBy7bGXxmCF14Gv8cLuZ4CLzyy4K467Lqp4W9jEnXNbjz3EbCa3MX1joO8jJSYoeKhkCbV7R+LLxoAT0eZO3WLl+Oy15f0dCU/u1C67XxqPgug5c8uUvnZsm1skRgWHuY0fteiYJsjzpgml/1jz0HMQq81kLrUycrN9y/dnqyku1v15a0aijyQrpPF1k0S/zjFCSjqnOzp+iXU27yWVNRDcsPszmVW49OHKZAHroNFfS1J0bmA6biC9D3v+xq2GXUL6+885SsMldkvQhqsNtvmaDuPjiEuxjofLoNgo1JsqL3379KO2vsvKjBPTGhzWAMNidsfEoUgqnKbt3ce/fEL1paJw80+L9na+xvYQ+PR93erld9GdUZiA/otri5gYvn1AEcq X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 14.01.25 17:06, Thomas Weißschuh wrote: > The virtual_address_range selftest reads from the start of each mapping > listed in /proc/self/maps. > However not all mappings are valid to be arbitrarily accessed. > > For example the vvar data used for virtual clocks on x86 [vvar_vclock] > can only be accessed if 1) the kernel configuration enables virtual > clocks and 2) the hypervisor provided the data for it. > Only the VDSO itself has the necessary information to know this. > Since commit e93d2521b27f ("x86/vdso: Split virtual clock pages into dedicated mapping") > the virtual clock data was split out into its own mapping, leading > to EFAULT from read() during the validation. > > Check for the VM_IO flag as a proxy. > It is present for the VVAR mappings and MMIO ranges can be dangerous to > access arbitrarily. > > Reported-by: kernel test robot > Closes: https://lore.kernel.org/oe-lkp/202412271148.2656e485-lkp@intel.com > Fixes: e93d2521b27f ("x86/vdso: Split virtual clock pages into dedicated mapping") > Fixes: 010409649885 ("selftests/mm: confirm VA exhaustion without reliance on correctness of mmap()") > Suggested-by: David Hildenbrand > Link: https://lore.kernel.org/lkml/e97c2a5d-c815-4936-a767-ac42a3220a90@redhat.com/ > Signed-off-by: Thomas Weißschuh Acked-by: David Hildenbrand Unfortunately, vsyscall doesn't seem to set VM_IO, it only has VmFlags: ex Which is rather weird. So we cannot remove that special-casing right now, -- Cheers, David / dhildenb