From: Vlastimil Babka <vbabka@suse.cz>
To: Lucas Stach <l.stach@pengutronix.de>,
Joonsoo Kim <js1304@gmail.com>,
linux-mm@kvack.org, Andrew Morton <akpm@linux-foundation.org>
Cc: linux-kernel@vger.kernel.org, kernel@pengutronix.de,
patchwork-lst@pengutronix.de
Subject: Re: [PATCH] mm/page_isolation: fix tracepoint to mirror check function behavior
Date: Thu, 24 Mar 2016 16:52:18 +0100 [thread overview]
Message-ID: <56F40D32.1000507@suse.cz> (raw)
In-Reply-To: <56F40CEE.9080201@suse.cz>
On 03/24/2016 04:51 PM, Vlastimil Babka wrote:
> On 03/17/2016 06:40 PM, Lucas Stach wrote:
>> Page isolation has not failed if the fin pfn extends beyond the end pfn
>> and test_pages_isolated checks this correctly. Fix the tracepoint to
>> report the same result as the actual check function.
>
> Right.
>
>> Signed-off-by: Lucas Stach <l.stach@pengutronix.de>
>
> Acked-by: Vlastimil Babka <vbabka@suse.cz>
Note you didn't have Andrew in To/Cc.
>> ---
>> include/trace/events/page_isolation.h | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/include/trace/events/page_isolation.h b/include/trace/events/page_isolation.h
>> index 6fb644029c80..8738a78e6bf4 100644
>> --- a/include/trace/events/page_isolation.h
>> +++ b/include/trace/events/page_isolation.h
>> @@ -29,7 +29,7 @@ TRACE_EVENT(test_pages_isolated,
>>
>> TP_printk("start_pfn=0x%lx end_pfn=0x%lx fin_pfn=0x%lx ret=%s",
>> __entry->start_pfn, __entry->end_pfn, __entry->fin_pfn,
>> - __entry->end_pfn == __entry->fin_pfn ? "success" : "fail")
>> + __entry->end_pfn <= __entry->fin_pfn ? "success" : "fail")
>> );
>>
>> #endif /* _TRACE_PAGE_ISOLATION_H */
>>
>
> --
> To unsubscribe, send a message with 'unsubscribe linux-mm' in
> the body to majordomo@kvack.org. For more info on Linux MM,
> see: http://www.linux-mm.org/ .
> Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
>
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
prev parent reply other threads:[~2016-03-24 15:52 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-17 17:40 Lucas Stach
2016-03-24 15:51 ` Vlastimil Babka
2016-03-24 15:52 ` Vlastimil Babka [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56F40D32.1000507@suse.cz \
--to=vbabka@suse.cz \
--cc=akpm@linux-foundation.org \
--cc=js1304@gmail.com \
--cc=kernel@pengutronix.de \
--cc=l.stach@pengutronix.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=patchwork-lst@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox