From: Joel Fernandes <joelaf@lab126.com>
To: Andi Kleen <ak@linux.intel.com>
Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, tj@kernel.org,
linux-rt-users@vger.kernel.org, Nick Piggin <npiggin@suse.de>
Subject: Re: [RFC] high preempt off latency in vfree path
Date: Wed, 23 Mar 2016 12:03:49 -0700 [thread overview]
Message-ID: <56F2E895.7080003@lab126.com> (raw)
In-Reply-To: <20160323024402.GA27856@tassilo.jf.intel.com>
On 03/22/16 19:44, Andi Kleen wrote:
>> (1)
>> One is we reduce the number of lazy_max_pages (right now its around 32MB per core worth of pages).
>>
>> diff --git a/mm/vmalloc.c b/mm/vmalloc.c
>> index aa3891e..2720f4f 100644
>> --- a/mm/vmalloc.c
>> +++ b/mm/vmalloc.c
>> @@ -564,7 +564,7 @@ static unsigned long lazy_max_pages(void)
>>
>> log = fls(num_online_cpus());
>>
>> - return log * (32UL * 1024 * 1024 / PAGE_SIZE);
>> + return log * (8UL * 1024 * 1024 / PAGE_SIZE);
>> }
>
> This seems like the right fix to me. Perhaps even make it somewhat smaller.
>
> Even on larger systems it's probably fine because they have a lot more
> cores/threads these days, so it will be still sufficiently large.
>
Thanks Andi. I'll post a patch then.
Regards,
Joel
> -Andi
>
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
prev parent reply other threads:[~2016-03-23 19:04 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-23 1:43 Joel Fernandes
2016-03-23 2:44 ` Andi Kleen
2016-03-23 19:03 ` Joel Fernandes [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56F2E895.7080003@lab126.com \
--to=joelaf@lab126.com \
--cc=ak@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-rt-users@vger.kernel.org \
--cc=npiggin@suse.de \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox