From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f54.google.com (mail-wm0-f54.google.com [74.125.82.54]) by kanga.kvack.org (Postfix) with ESMTP id CA27B828F2 for ; Wed, 2 Mar 2016 09:17:39 -0500 (EST) Received: by mail-wm0-f54.google.com with SMTP id n186so87891406wmn.1 for ; Wed, 02 Mar 2016 06:17:39 -0800 (PST) Received: from mx2.suse.de (mx2.suse.de. [195.135.220.15]) by mx.google.com with ESMTPS id km6si43324671wjc.1.2016.03.02.06.17.38 for (version=TLS1 cipher=AES128-SHA bits=128/128); Wed, 02 Mar 2016 06:17:38 -0800 (PST) Subject: Re: [PATCH mmotm] mm, sl[au]b: print gfp_flags as strings in slab_out_of_memory() References: <1456859312-26207-1-git-send-email-vbabka@suse.cz> From: Vlastimil Babka Message-ID: <56D6F5FE.6050709@suse.cz> Date: Wed, 2 Mar 2016 15:17:34 +0100 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: owner-linux-mm@kvack.org List-ID: To: David Rientjes Cc: Andrew Morton , linux-mm@kvack.org, linux-kernel@vger.kernel.org, Christoph Lameter , Pekka Enberg , Joonsoo Kim On 03/01/2016 11:41 PM, David Rientjes wrote: > On Tue, 1 Mar 2016, Vlastimil Babka wrote: > >> We can now print gfp_flags more human-readable. Make use of this in >> slab_out_of_memory() for SLUB and SLAB. Also convert the SLAB variant it to >> pr_warn() along the way. >> >> Signed-off-by: Vlastimil Babka >> Cc: Christoph Lameter >> Cc: Pekka Enberg >> Cc: David Rientjes >> Cc: Joonsoo Kim > > Acked-by: David Rientjes Thanks. > Although I've always been curious about the usefulness of these out of > memory calls in the first place. They are obviously for debugging, but > have they actually helped to diagnose anything? Uh no idea, maybe other SL*B maintainers have more experience. But what did prompt me to write this patch is that I've recently have actually seen the output of those in some (presumably linux-mm) thread. -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org