From: Vlastimil Babka <vbabka@suse.cz>
To: Stephen Rothwell <sfr@canb.auug.org.au>
Cc: kbuild test robot <fengguang.wu@intel.com>,
Heiko Carstens <heiko.carstens@de.ibm.com>,
Martin Schwidefsky <schwidefsky@de.ibm.com>,
kbuild-all@01.org, linux-s390@vger.kernel.org,
Andrew Morton <akpm@linux-foundation.org>,
"linux-mm@kvack.org" <linux-mm@kvack.org>,
Peter Zijlstra <peterz@infradead.org>
Subject: Re: [linux-next:master 1875/2100] include/linux/jump_label.h:122:2: error: implicit declaration of function 'atomic_read'
Date: Fri, 29 Jan 2016 12:25:17 +0100 [thread overview]
Message-ID: <56AB4C1D.5090801@suse.cz> (raw)
In-Reply-To: <20160129215335.1a049964@canb.auug.org.au>
On 01/29/2016 11:53 AM, Stephen Rothwell wrote:
> Hi Vlastimil,
>
> On Fri, 29 Jan 2016 11:28:59 +0100 Vlastimil Babka <vbabka@suse.cz> wrote:
>> > include/linux/jump_label.h: In function 'static_key_count':
>> >>> include/linux/jump_label.h:122:2: error: implicit declaration of function 'atomic_read' [-Werror=implicit-function-declaration]
>> > return atomic_read(&key->enabled);
>>
>> Sigh.
>>
>> I don't get it, there's "#include <linux/atomic.h>" in jump_label.h right before
>> it gets used. So, what implicit declaration?
>
> But we are in the process of reading linux/atomic.h already, and the
> #include in jump_label.h will just not read it then (because of the
> include guards) so the body of linux/atomic.h has not yet been read
> when we process static_key_count(). i.e. we have a circular inclusion.
Oh, of course, doh. Thanks.
Please replace the -fix with this patch. Sorry again.
----8<----
next prev parent reply other threads:[~2016-01-29 11:25 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <201601291512.vqk4lpvV%fengguang.wu@intel.com>
2016-01-29 10:28 ` Vlastimil Babka
2016-01-29 10:53 ` Stephen Rothwell
2016-01-29 11:25 ` Vlastimil Babka [this message]
2016-01-31 20:52 ` Stephen Rothwell
2016-01-29 11:05 ` Heiko Carstens
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56AB4C1D.5090801@suse.cz \
--to=vbabka@suse.cz \
--cc=akpm@linux-foundation.org \
--cc=fengguang.wu@intel.com \
--cc=heiko.carstens@de.ibm.com \
--cc=kbuild-all@01.org \
--cc=linux-mm@kvack.org \
--cc=linux-s390@vger.kernel.org \
--cc=peterz@infradead.org \
--cc=schwidefsky@de.ibm.com \
--cc=sfr@canb.auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox