From: Tomi Valkeinen <tomi.valkeinen@ti.com>
To: Dan Williams <dan.j.williams@intel.com>, dri-devel@lists.freedesktop.org
Cc: Dave Hansen <dave@sr71.net>, David Airlie <airlied@linux.ie>,
linux-kernel@vger.kernel.org, Julian Margetson <runaway@candw.ms>,
linux-mm@kvack.org, akpm@linux-foundation.org
Subject: Re: [PATCH] mm: fix pfn_t to page conversion in vm_insert_mixed
Date: Wed, 27 Jan 2016 09:06:37 +0200 [thread overview]
Message-ID: <56A86C7D.6080708@ti.com> (raw)
In-Reply-To: <20160126183751.9072.22772.stgit@dwillia2-desk3.amr.corp.intel.com>
[-- Attachment #1: Type: text/plain, Size: 565 bytes --]
On 26/01/16 20:37, Dan Williams wrote:
> pfn_t_to_page() honors the flags in the pfn_t value to determine if a
> pfn is backed by a page. However, vm_insert_mixed() was originally
> written to use pfn_valid() to make this determination. To restore the
> old/correct behavior, ignore the pfn_t flags in the !pfn_t_devmap() case
> and fallback to trusting pfn_valid().
>
> Fixes: 01c8f1c44b83 ("mm, dax, gpu: convert vm_insert_mixed to pfn_t")
Thanks, this fixes the crash with omapdrm.
Tested-by: Tomi Valkeinen <tomi.valkeinen@ti.com>
Tomi
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
prev parent reply other threads:[~2016-01-27 7:06 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-26 18:37 Dan Williams
2016-01-26 19:46 ` Julian Margetson
2016-01-26 20:34 ` Dan Williams
2016-01-26 20:49 ` Julian Margetson
2016-01-27 7:06 ` Tomi Valkeinen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56A86C7D.6080708@ti.com \
--to=tomi.valkeinen@ti.com \
--cc=airlied@linux.ie \
--cc=akpm@linux-foundation.org \
--cc=dan.j.williams@intel.com \
--cc=dave@sr71.net \
--cc=dri-devel@lists.freedesktop.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=runaway@candw.ms \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox