From: "Shi, Yang" <yang.shi@linaro.org>
To: akpm@linux-foundation.org, rostedt@goodmis.org, mingo@redhat.com
Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org,
linaro-kernel@lists.linaro.org,
"David S. Miller" <davem@davemloft.net>,
sparclinux@vger.kernel.org
Subject: Re: [PATCH v5 7/7] sparc64: mm/gup: add gup trace points
Date: Wed, 13 Jan 2016 10:13:08 -0800 [thread overview]
Message-ID: <569693B4.6060305@linaro.org> (raw)
In-Reply-To: <1449696151-4195-8-git-send-email-yang.shi@linaro.org>
Hi David,
Any comment on this one? The tracing part review has been done.
Thanks,
Yang
On 12/9/2015 1:22 PM, Yang Shi wrote:
> Cc: "David S. Miller" <davem@davemloft.net>
> Cc: sparclinux@vger.kernel.org
> Signed-off-by: Yang Shi <yang.shi@linaro.org>
> ---
> arch/sparc/mm/gup.c | 6 ++++++
> 1 file changed, 6 insertions(+)
>
> diff --git a/arch/sparc/mm/gup.c b/arch/sparc/mm/gup.c
> index 2e5c4fc..5a06c34 100644
> --- a/arch/sparc/mm/gup.c
> +++ b/arch/sparc/mm/gup.c
> @@ -12,6 +12,8 @@
> #include <linux/rwsem.h>
> #include <asm/pgtable.h>
>
> +#include <trace/events/gup.h>
> +
> /*
> * The performance critical leaf functions are made noinline otherwise gcc
> * inlines everything into a single function which results in too much
> @@ -174,6 +176,8 @@ int __get_user_pages_fast(unsigned long start, int nr_pages, int write,
> len = (unsigned long) nr_pages << PAGE_SHIFT;
> end = start + len;
>
> + trace_gup_get_user_pages_fast(start, nr_pages);
> +
> local_irq_save(flags);
> pgdp = pgd_offset(mm, addr);
> do {
> @@ -236,6 +240,8 @@ int get_user_pages_fast(unsigned long start, int nr_pages, int write,
>
> local_irq_enable();
>
> + trace_gup_get_user_pages_fast(start, nr_pages);
> +
> VM_BUG_ON(nr != (end - start) >> PAGE_SHIFT);
> return nr;
>
>
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2016-01-13 18:13 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-09 21:22 [RFC V5] Add gup trace points support Yang Shi
2015-12-09 21:22 ` [PATCH v5 1/7] trace/events: Add gup trace events Yang Shi
2015-12-09 21:22 ` [PATCH v5 2/7] mm/gup: add gup trace points Yang Shi
2015-12-09 21:22 ` [PATCH v5 3/7] x86: " Yang Shi
2016-01-13 18:11 ` Shi, Yang
2015-12-09 21:22 ` [PATCH v5 4/7] mips: " Yang Shi
2015-12-09 21:22 ` [PATCH v5 5/7] s390: " Yang Shi
2016-01-13 18:12 ` Shi, Yang
2016-01-14 7:45 ` Heiko Carstens
2015-12-09 21:22 ` [PATCH v5 6/7] sh: " Yang Shi
2015-12-09 21:22 ` [PATCH v5 7/7] sparc64: " Yang Shi
2016-01-13 18:13 ` Shi, Yang [this message]
2016-01-13 20:21 ` David Miller
2016-01-13 20:44 ` Steven Rostedt
2016-01-12 20:00 ` [RFC V5] Add gup trace points support Shi, Yang
2016-01-12 20:10 ` Steven Rostedt
2016-01-13 18:14 ` Shi, Yang
2016-01-14 14:40 ` Steven Rostedt
2016-02-08 23:15 ` Shi, Yang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=569693B4.6060305@linaro.org \
--to=yang.shi@linaro.org \
--cc=akpm@linux-foundation.org \
--cc=davem@davemloft.net \
--cc=linaro-kernel@lists.linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mingo@redhat.com \
--cc=rostedt@goodmis.org \
--cc=sparclinux@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox