From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ob0-f178.google.com (mail-ob0-f178.google.com [209.85.214.178]) by kanga.kvack.org (Postfix) with ESMTP id 3310D828DF for ; Tue, 12 Jan 2016 23:55:05 -0500 (EST) Received: by mail-ob0-f178.google.com with SMTP id vt7so46009867obb.1 for ; Tue, 12 Jan 2016 20:55:05 -0800 (PST) Received: from heian.cn.fujitsu.com ([59.151.112.132]) by mx.google.com with ESMTP id r19si15340854obt.65.2016.01.12.20.55.03 for ; Tue, 12 Jan 2016 20:55:04 -0800 (PST) Message-ID: <5695D8E2.6040908@cn.fujitsu.com> Date: Wed, 13 Jan 2016 12:56:02 +0800 From: Tang Chen MIME-Version: 1.0 Subject: Re: [PATCH 1/5] x86, memhp, numa: Online memory-less nodes at boot time. References: <1452140425-16577-1-git-send-email-tangchen@cn.fujitsu.com> <1452140425-16577-2-git-send-email-tangchen@cn.fujitsu.com> <20160108182808.GZ1898@mtj.duckdns.org> In-Reply-To: <20160108182808.GZ1898@mtj.duckdns.org> Content-Type: text/plain; charset="ISO-8859-1"; format=flowed Content-Transfer-Encoding: 7bit Sender: owner-linux-mm@kvack.org List-ID: To: Tejun Heo Cc: cl@linux.com, jiang.liu@linux.intel.com, mika.j.penttila@gmail.com, mingo@redhat.com, akpm@linux-foundation.org, rjw@rjwysocki.net, hpa@zytor.com, yasu.isimatu@gmail.com, isimatu.yasuaki@jp.fujitsu.com, kamezawa.hiroyu@jp.fujitsu.com, izumi.taku@jp.fujitsu.com, gongzhaogang@inspur.com, x86@kernel.org, linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, tangchen@cn.fujitsu.com Hi tj, On 01/09/2016 02:28 AM, Tejun Heo wrote: > Hello, > > On Thu, Jan 07, 2016 at 12:20:21PM +0800, Tang Chen wrote: >> +static void __init init_memory_less_node(int nid) >> { >> + unsigned long zones_size[MAX_NR_ZONES] = {0}; >> + unsigned long zholes_size[MAX_NR_ZONES] = {0}; > It doesn't cause any functional difference but it's a bit weird to use > {0} because it explicitly says to initialize the first element to 0 > when the whole array needs to be cleared. Wouldnt { } make more sense? Yes. Will fix them. > >> diff --git a/include/linux/mmzone.h b/include/linux/mmzone.h >> index e23a9e7..9c4d4d5 100644 >> --- a/include/linux/mmzone.h >> +++ b/include/linux/mmzone.h >> @@ -736,6 +736,7 @@ static inline bool is_dev_zone(const struct zone *zone) >> >> extern struct mutex zonelists_mutex; >> void build_all_zonelists(pg_data_t *pgdat, struct zone *zone); >> +void build_zonelists(pg_data_t *pgdat); > This isn't used in this patch. Contamination? Sorry, I tried to build zone lists here. But it totally unnecessary and led to some problems. I forgot to remove them when I fixed the problems. Will remove them. Thx. > > Thanks. > -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org