From: Lorenzo Stoakes <lorenzo.stoakes@oracle.com>
To: Mark Brown <broonie@kernel.org>
Cc: wang lian <lianux.mm@gmail.com>,
akpm@linux-foundation.org, ziy@nvidia.com, david@redhat.com,
sj@kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org,
linux-kselftest@vger.kernel.org, shuah@kernel.org,
Liam.Howlett@oracle.com, brauner@kernel.org,
gkwang@linx-info.com, jannh@google.com, p1ucky0923@gmail.com,
ryncsn@gmail.com, vbabka@suse.cz, zijing.zhang@proton.me
Subject: Re: [PATCH v4] selftests/mm: add process_madvise() tests
Date: Fri, 11 Jul 2025 09:53:10 +0100 [thread overview]
Message-ID: <569270da-8827-4a3c-84db-91f715ef5c22@lucifer.local> (raw)
In-Reply-To: <aHDHQzzbtgCh6Ox3@finisterre.sirena.org.uk>
On Fri, Jul 11, 2025 at 09:11:47AM +0100, Mark Brown wrote:
> On Thu, Jul 10, 2025 at 05:57:23PM +0100, Lorenzo Stoakes wrote:
> > On Thu, Jul 10, 2025 at 07:22:49PM +0800, wang lian wrote:
>
> > > +#include <linux/pidfd.h>
>
> > However, the pidfd tests already have a stub in so you can alternatively
> > use:
>
> > #include "../pidfd/pidfd.h"
>
> > As is done in guard-regions.c.
>
> One thing to watch out for with peering into the private header files of
> other selftests is that it's a routine source of build and sometimes
> runtime failures, people have a tendency to update one selftest without
> thinking that other selftests might be peering at their code. The cross
> tree aspect can make it painful to deal with the resulting issues.
I take it from the lack of reported issues this hasn't happened in reality.
next prev parent reply other threads:[~2025-07-11 8:53 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-10 11:22 wang lian
2025-07-10 13:42 ` Mark Brown
2025-07-10 16:21 ` Zi Yan
2025-07-11 8:05 ` Mark Brown
2025-07-11 12:19 ` [PATCH v3] " wang lian
2025-07-10 16:57 ` [PATCH v4] " Lorenzo Stoakes
2025-07-11 8:11 ` Mark Brown
2025-07-11 8:53 ` Lorenzo Stoakes [this message]
2025-07-11 9:29 ` Mark Brown
2025-07-11 11:16 ` wang lian
2025-07-11 11:33 ` Lorenzo Stoakes
2025-07-11 12:02 ` wang lian
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=569270da-8827-4a3c-84db-91f715ef5c22@lucifer.local \
--to=lorenzo.stoakes@oracle.com \
--cc=Liam.Howlett@oracle.com \
--cc=akpm@linux-foundation.org \
--cc=brauner@kernel.org \
--cc=broonie@kernel.org \
--cc=david@redhat.com \
--cc=gkwang@linx-info.com \
--cc=jannh@google.com \
--cc=lianux.mm@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=p1ucky0923@gmail.com \
--cc=ryncsn@gmail.com \
--cc=shuah@kernel.org \
--cc=sj@kernel.org \
--cc=vbabka@suse.cz \
--cc=zijing.zhang@proton.me \
--cc=ziy@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox