From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 60B0CC77B7F for ; Mon, 23 Jun 2025 14:28:06 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 070A76B00C1; Mon, 23 Jun 2025 10:28:06 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 021506B00C3; Mon, 23 Jun 2025 10:28:05 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E2B7C6B00C4; Mon, 23 Jun 2025 10:28:05 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id D1AE96B00C1 for ; Mon, 23 Jun 2025 10:28:05 -0400 (EDT) Received: from smtpin01.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 816071D6D0D for ; Mon, 23 Jun 2025 14:28:05 +0000 (UTC) X-FDA: 83586894930.01.7875F93 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.223.130]) by imf08.hostedemail.com (Postfix) with ESMTP id 03702160008 for ; Mon, 23 Jun 2025 14:28:02 +0000 (UTC) Authentication-Results: imf08.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=x3hlEMs7; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=oI968zJQ; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=JYsVXf0I; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=heS3N+pq; spf=pass (imf08.hostedemail.com: domain of vbabka@suse.cz designates 195.135.223.130 as permitted sender) smtp.mailfrom=vbabka@suse.cz; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1750688883; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=E5iEM9QDpyRDgX//nNw/KJ2WQ1r0Cs8xwFNmlzPnDVo=; b=Wy96w55duxH1qjlnUjBzeEqlHa+Gsb9bBEBgF/UAwwdNkg8uAY4+zTGoqS1u7uCWRDnrfa 8nUwVe4XXMwtabFSTTHsnyunmrzqHGg8OEksdZVd2YV/v3a3AtmpVqNSCCeRjFznH8cuTp D1DkxRiwHFdC1wbqrmTD3WpuLHCxruI= ARC-Authentication-Results: i=1; imf08.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=x3hlEMs7; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=oI968zJQ; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=JYsVXf0I; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=heS3N+pq; spf=pass (imf08.hostedemail.com: domain of vbabka@suse.cz designates 195.135.223.130 as permitted sender) smtp.mailfrom=vbabka@suse.cz; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1750688883; a=rsa-sha256; cv=none; b=A0hC6E2t1TfIPLn8xMYFSsjLw43Cb5GPDhY9zQmpbvWAiwDEHsd73xOMWkdAq+MnG5XiRW 9M2ZvRPgOFW7nkPPTGWGHTkWVBmvGhEe+OKW/LL0JHGEGLf9PLcxxF+38I0Fhb+aJBfBzQ BpY7y1RsxmmDujzt8CFC3IrD+Y+d7Mc= Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id D2F812116B; Mon, 23 Jun 2025 14:28:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1750688881; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=E5iEM9QDpyRDgX//nNw/KJ2WQ1r0Cs8xwFNmlzPnDVo=; b=x3hlEMs7Qeam81RvadgdyX74sjneiRIuSoLTV8Zh7tHYVzOvvJPLpOmq456wZDs+K3lZwf rhD5eDuzFJqLXL8TTTkzwLMQYDbwkURrobYjrXkQjk5qoqNRQN7o9v7FCFXFiiLQEXdHgK yF+RP4OJ3PLvV9aqyZyIqyYRh0jxvgg= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1750688881; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=E5iEM9QDpyRDgX//nNw/KJ2WQ1r0Cs8xwFNmlzPnDVo=; b=oI968zJQbRFY0zQwCT3VKqq9pG9i7OW2SURAfo5/ulY0hNG5ungqeZtZJpHZEnP3hy9ULG 3Q2MpRA+ZzDyF5Cg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1750688880; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=E5iEM9QDpyRDgX//nNw/KJ2WQ1r0Cs8xwFNmlzPnDVo=; b=JYsVXf0It5vYCvQpCLT+/NBQkTuOiMRZH5Nxnrt9kAEfJj896Q80TeZ6vB9GyOpVfhylwH 5h8l6ifIWvzu8BSangwlhivu9ZBtwaSjKSJDSQNCpCIC9CMHY8KF5FCh+ENHIYSFf6g8IE yGk7jFjXBhCmCtDZJzxA9VYcv/6T2rk= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1750688880; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=E5iEM9QDpyRDgX//nNw/KJ2WQ1r0Cs8xwFNmlzPnDVo=; b=heS3N+pqYQB4nibgzso7aVZDikqAsmk3Towm7IX/mP8/6BiMXv7VjWEh4V/acQ4IMpjsKw 8RUrlCwPQZgvY9Ag== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id A0FA313485; Mon, 23 Jun 2025 14:28:00 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id +0kAJ3BkWWioZAAAD6G6ig (envelope-from ); Mon, 23 Jun 2025 14:28:00 +0000 Message-ID: <568cba54-dd42-45e9-be0f-53569811f2e9@suse.cz> Date: Mon, 23 Jun 2025 16:28:00 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH V2] fs: export anon_inode_make_secure_inode() and fix secretmem LSM bypass Content-Language: en-US From: Vlastimil Babka To: Shivank Garg , David Hildenbrand , akpm@linux-foundation.org, brauner@kernel.org, paul@paul-moore.com, rppt@kernel.org, viro@zeniv.linux.org.uk Cc: seanjc@google.com, willy@infradead.org, pbonzini@redhat.com, tabba@google.com, afranji@google.com, ackerleytng@google.com, jack@suse.cz, hch@infradead.org, cgzones@googlemail.com, ira.weiny@intel.com, roypat@amazon.co.uk, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, linux-security-module@vger.kernel.org References: <20250620070328.803704-3-shivankg@amd.com> <3114d54f-ed7c-4c68-9d32-53ce04175556@amd.com> <39f95eb9-c494-4967-8d4d-9768200637f4@suse.cz> Autocrypt: addr=vbabka@suse.cz; keydata= xsFNBFZdmxYBEADsw/SiUSjB0dM+vSh95UkgcHjzEVBlby/Fg+g42O7LAEkCYXi/vvq31JTB KxRWDHX0R2tgpFDXHnzZcQywawu8eSq0LxzxFNYMvtB7sV1pxYwej2qx9B75qW2plBs+7+YB 87tMFA+u+L4Z5xAzIimfLD5EKC56kJ1CsXlM8S/LHcmdD9Ctkn3trYDNnat0eoAcfPIP2OZ+ 9oe9IF/R28zmh0ifLXyJQQz5ofdj4bPf8ecEW0rhcqHfTD8k4yK0xxt3xW+6Exqp9n9bydiy tcSAw/TahjW6yrA+6JhSBv1v2tIm+itQc073zjSX8OFL51qQVzRFr7H2UQG33lw2QrvHRXqD Ot7ViKam7v0Ho9wEWiQOOZlHItOOXFphWb2yq3nzrKe45oWoSgkxKb97MVsQ+q2SYjJRBBH4 8qKhphADYxkIP6yut/eaj9ImvRUZZRi0DTc8xfnvHGTjKbJzC2xpFcY0DQbZzuwsIZ8OPJCc LM4S7mT25NE5kUTG/TKQCk922vRdGVMoLA7dIQrgXnRXtyT61sg8PG4wcfOnuWf8577aXP1x 6mzw3/jh3F+oSBHb/GcLC7mvWreJifUL2gEdssGfXhGWBo6zLS3qhgtwjay0Jl+kza1lo+Cv BB2T79D4WGdDuVa4eOrQ02TxqGN7G0Biz5ZLRSFzQSQwLn8fbwARAQABzSBWbGFzdGltaWwg QmFia2EgPHZiYWJrYUBzdXNlLmN6PsLBlAQTAQoAPgIbAwULCQgHAwUVCgkICwUWAgMBAAIe AQIXgBYhBKlA1DSZLC6OmRA9UCJPp+fMgqZkBQJnyBr8BQka0IFQAAoJECJPp+fMgqZkqmMQ AIbGN95ptUMUvo6aAdhxaOCHXp1DfIBuIOK/zpx8ylY4pOwu3GRe4dQ8u4XS9gaZ96Gj4bC+ jwWcSmn+TjtKW3rH1dRKopvC07tSJIGGVyw7ieV/5cbFffA8NL0ILowzVg8w1ipnz1VTkWDr 2zcfslxJsJ6vhXw5/npcY0ldeC1E8f6UUoa4eyoskd70vO0wOAoGd02ZkJoox3F5ODM0kjHu Y97VLOa3GG66lh+ZEelVZEujHfKceCw9G3PMvEzyLFbXvSOigZQMdKzQ8D/OChwqig8wFBmV QCPS4yDdmZP3oeDHRjJ9jvMUKoYODiNKsl2F+xXwyRM2qoKRqFlhCn4usVd1+wmv9iLV8nPs 2Db1ZIa49fJet3Sk3PN4bV1rAPuWvtbuTBN39Q/6MgkLTYHb84HyFKw14Rqe5YorrBLbF3rl M51Dpf6Egu1yTJDHCTEwePWug4XI11FT8lK0LNnHNpbhTCYRjX73iWOnFraJNcURld1jL1nV r/LRD+/e2gNtSTPK0Qkon6HcOBZnxRoqtazTU6YQRmGlT0v+rukj/cn5sToYibWLn+RoV1CE Qj6tApOiHBkpEsCzHGu+iDQ1WT0Idtdynst738f/uCeCMkdRu4WMZjteQaqvARFwCy3P/jpK uvzMtves5HvZw33ZwOtMCgbpce00DaET4y/UzsBNBFsZNTUBCACfQfpSsWJZyi+SHoRdVyX5 J6rI7okc4+b571a7RXD5UhS9dlVRVVAtrU9ANSLqPTQKGVxHrqD39XSw8hxK61pw8p90pg4G /N3iuWEvyt+t0SxDDkClnGsDyRhlUyEWYFEoBrrCizbmahOUwqkJbNMfzj5Y7n7OIJOxNRkB IBOjPdF26dMP69BwePQao1M8Acrrex9sAHYjQGyVmReRjVEtv9iG4DoTsnIR3amKVk6si4Ea X/mrapJqSCcBUVYUFH8M7bsm4CSxier5ofy8jTEa/CfvkqpKThTMCQPNZKY7hke5qEq1CBk2 wxhX48ZrJEFf1v3NuV3OimgsF2odzieNABEBAAHCwXwEGAEKACYCGwwWIQSpQNQ0mSwujpkQ PVAiT6fnzIKmZAUCZ8gcVAUJFhTonwAKCRAiT6fnzIKmZLY8D/9uo3Ut9yi2YCuASWxr7QQZ lJCViArjymbxYB5NdOeC50/0gnhK4pgdHlE2MdwF6o34x7TPFGpjNFvycZqccSQPJ/gibwNA zx3q9vJT4Vw+YbiyS53iSBLXMweeVV1Jd9IjAoL+EqB0cbxoFXvnjkvP1foiiF5r73jCd4PR rD+GoX5BZ7AZmFYmuJYBm28STM2NA6LhT0X+2su16f/HtummENKcMwom0hNu3MBNPUOrujtW khQrWcJNAAsy4yMoJ2Lw51T/5X5Hc7jQ9da9fyqu+phqlVtn70qpPvgWy4HRhr25fCAEXZDp xG4RNmTm+pqorHOqhBkI7wA7P/nyPo7ZEc3L+ZkQ37u0nlOyrjbNUniPGxPxv1imVq8IyycG AN5FaFxtiELK22gvudghLJaDiRBhn8/AhXc642/Z/yIpizE2xG4KU4AXzb6C+o7LX/WmmsWP Ly6jamSg6tvrdo4/e87lUedEqCtrp2o1xpn5zongf6cQkaLZKQcBQnPmgHO5OG8+50u88D9I rywqgzTUhHFKKF6/9L/lYtrNcHU8Z6Y4Ju/MLUiNYkmtrGIMnkjKCiRqlRrZE/v5YFHbayRD dJKXobXTtCBYpLJM4ZYRpGZXne/FAtWNe4KbNJJqxMvrTOrnIatPj8NhBVI0RSJRsbilh6TE m6M14QORSWTLRg== In-Reply-To: <39f95eb9-c494-4967-8d4d-9768200637f4@suse.cz> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspamd-Action: no action X-Rspam-User: X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: 03702160008 X-Stat-Signature: h48jgmfjsmitp7m9m5u8m57ab61js5n5 X-HE-Tag: 1750688882-736477 X-HE-Meta: U2FsdGVkX1/m/hQ6DwuujwSoEmiPrunk3LTFpxE130DXBlpm67+xdp+7ftC5uuWeXR6gOu6CpoBt0xoo26IsrKo0VEX7mCV74A0aN6OoRTbN3t6DmxIJfHidF8FY6bt6JmXXvKUi0Un+aCvFcm9+ddoaCthLn62ePYc/X7VlY57H/04JAtXj4JFidxcYJjcvFgL8GiI1mr7gdXVTIMc9HFk4gl+m5JpbDxLQnGkjdmaFezX8bfKiDVMm4omQ+6yj1bZyrHP94r6Rj8vw+V4UvWlOYYOdFhLUwg5LZMvrBDf2ZPSqlQMHN+kCQJ4oXMrlRtZTH6IL5ewRKTqgy0SAAJJwmI94HQL/cf56eWu5NV+JFZZkV1s4XT4a6COSjBOex4yIPHeGf8MD5oxltYWtYVvi63KwyL7/bNt+qOQNnOSgKRO3kyOqGz/KBKjvYvZ/azb7HUJ5Cvfq5J/c50oGfA0fg0mhOyyrcT5KXy7E/V24kIzYeZgnQUJ7qX804wftpRJ1XYKH4lSmFk4zeZ0BXtDSobG6Xne951fqUgR+qxTtH0drZ5kdR+XWY/ViBHiYVecRuYM80EY7iPlQXAo67VrC05iMyfi43rQNc2TvzHySFVNhe7k4/IBXxgQP/qjNkHKdnovbIlmXyCOWKH8aRKmRhXiGhFoYG8dXWBzcNek3+xTwlomxOr6Ax7c/JmPp7siAySweTM6RSiptqntyMzxtVyYq9lcMSZ8GLpkk9tYIq2+Uq/7kN8JStilKevdDgIjgWZoKNs8DGSGvfjT3+D6r87VBSTw0uXkJL6CqtQbWsijNFeRKxrndGLrIHOjmMKcHJxonZBrGjIHYMDI127ScnLBRVwdnIsL810UzW8RhfFzbE4YLLQqwxKhgE8Jdoox6ill8m9WgL3B16w61V1ydOYJ53wr3ItPht2k7oX1+J9wR7hXOCAPLm8pVj1Oa6kUXa8fd4UzqFFL0bAh DWiD0AkZ bYq5Hm41e2HSqNMt6WW0WS7yCWNcoXQ5751IWklPxRg6Y4q/boEJ2sxjACRaa4beoIrMJyEvcdT6Km8SKWsHgqFdlcJsFX6HNt5Yk/Lcvx32h6PEK1DhR+bvn+no3/Oq+B17iwYacUYYhaH4SSDOTieaE4JvB8GLM+KjFyVbtHdJilqHBaiOSJQ8gKmalzGjVWvYMaEb5+ErE2GkXgvTKYkRm60oghco4mLRLYnqX+vCGGuirGrMn5rvqs5Z/WNt2K46NWbAqk/JKOcLZ/9PRRDkb+iqhKi3+BFGSJ/2ftk8zAoPYaR6tEwUs/WwsY3SqvOkN+jmIb3i3gK+IjziSw007Pw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 6/23/25 16:13, Vlastimil Babka wrote: > On 6/23/25 16:08, Shivank Garg wrote: >> >> >>> >>> In general, LGTM, but I think the actual fix should be separated from exporting it for guest_memfd purposes? >>> >>> Also makes backporting easier, when EXPORT_SYMBOL_GPL_FOR_MODULES does not exist yet ... >>> >> I agree. I did not think about backporting conflicts when sending the patch. >> >> Christian, I can send it as 2 separate patches to make it easier? > > The proper way is to send the fix without the export, and then add the > export only when adding its user. Note: AFAIU either way the new user would be depending on a patch in a vfs tree (maybe scheduled for an 6.16 rc and not the next merge window?) if that's an issue for the development. >> Thanks, >> Shivank >