From: Vlastimil Babka <vbabka@suse.cz>
To: Shivank Garg <shivankg@amd.com>,
David Hildenbrand <david@redhat.com>,
akpm@linux-foundation.org, brauner@kernel.org,
paul@paul-moore.com, rppt@kernel.org, viro@zeniv.linux.org.uk
Cc: seanjc@google.com, willy@infradead.org, pbonzini@redhat.com,
tabba@google.com, afranji@google.com, ackerleytng@google.com,
jack@suse.cz, hch@infradead.org, cgzones@googlemail.com,
ira.weiny@intel.com, roypat@amazon.co.uk,
linux-fsdevel@vger.kernel.org, linux-mm@kvack.org,
linux-kernel@vger.kernel.org,
linux-security-module@vger.kernel.org
Subject: Re: [PATCH V2] fs: export anon_inode_make_secure_inode() and fix secretmem LSM bypass
Date: Mon, 23 Jun 2025 16:28:00 +0200 [thread overview]
Message-ID: <568cba54-dd42-45e9-be0f-53569811f2e9@suse.cz> (raw)
In-Reply-To: <39f95eb9-c494-4967-8d4d-9768200637f4@suse.cz>
On 6/23/25 16:13, Vlastimil Babka wrote:
> On 6/23/25 16:08, Shivank Garg wrote:
>>
>>
>>>
>>> In general, LGTM, but I think the actual fix should be separated from exporting it for guest_memfd purposes?
>>>
>>> Also makes backporting easier, when EXPORT_SYMBOL_GPL_FOR_MODULES does not exist yet ...
>>>
>> I agree. I did not think about backporting conflicts when sending the patch.
>>
>> Christian, I can send it as 2 separate patches to make it easier?
>
> The proper way is to send the fix without the export, and then add the
> export only when adding its user.
Note: AFAIU either way the new user would be depending on a patch in a vfs
tree (maybe scheduled for an 6.16 rc and not the next merge window?) if
that's an issue for the development.
>> Thanks,
>> Shivank
>
next prev parent reply other threads:[~2025-06-23 14:28 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-20 7:03 Shivank Garg
2025-06-20 8:31 ` Mike Rapoport
2025-06-23 10:41 ` Christian Brauner
2025-06-23 13:51 ` David Hildenbrand
2025-06-23 14:08 ` Shivank Garg
2025-06-23 14:13 ` Vlastimil Babka
2025-06-23 14:28 ` Vlastimil Babka [this message]
2025-06-26 19:46 ` Shivank Garg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=568cba54-dd42-45e9-be0f-53569811f2e9@suse.cz \
--to=vbabka@suse.cz \
--cc=ackerleytng@google.com \
--cc=afranji@google.com \
--cc=akpm@linux-foundation.org \
--cc=brauner@kernel.org \
--cc=cgzones@googlemail.com \
--cc=david@redhat.com \
--cc=hch@infradead.org \
--cc=ira.weiny@intel.com \
--cc=jack@suse.cz \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-security-module@vger.kernel.org \
--cc=paul@paul-moore.com \
--cc=pbonzini@redhat.com \
--cc=roypat@amazon.co.uk \
--cc=rppt@kernel.org \
--cc=seanjc@google.com \
--cc=shivankg@amd.com \
--cc=tabba@google.com \
--cc=viro@zeniv.linux.org.uk \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox